86775 2012-05-17 14:19:36 -0700 Floor y coordinate in Chromium's GraphicsContext::drawLineForText to avoid anti-aliasing 2012-05-24 10:24:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85555 1 leviw leviw eae eric oldest_to_newest 626976 0 leviw 2012-05-17 14:19:36 -0700 Currently we take floats but always paint at whole y coordinates. This patch will preserve that behavior with the sub-pixel conversion. Otherwise, some underlines and strike-throughs end up midway between two pixels. 626983 1 142556 leviw 2012-05-17 14:26:35 -0700 Created attachment 142556 Patch 626985 2 142556 eric 2012-05-17 14:28:18 -0700 Comment on attachment 142556 Patch Does Skia floor the X for us? I'm confused? 627216 3 leviw 2012-05-17 18:54:14 -0700 (In reply to comment #2) > (From update of attachment 142556 [details]) > Does Skia floor the X for us? I'm confused? I'm going to add a comment. We always draw these lines horizontally. Sub-pixel x values are normal and acceptable. 632916 4 leviw 2012-05-24 10:23:55 -0700 Forgot to comment... landed in r117528 <http://trac.webkit.org/changeset/117528> 142556 2012-05-17 14:26:35 -0700 2012-05-24 10:24:04 -0700 Patch patch text/plain 1708 leviw ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZjVkOGIyLi5iNzgxYmNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDUtMTcgIExldmkgV2VpbnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIEZsb29yIHkgY29vcmRpbmF0ZSBpbiBDaHJvbWl1bSdzIEdyYXBoaWNzQ29udGV4dDo6 ZHJhd0xpbmVGb3JUZXh0IHRvIGF2b2lkIGFudGktYWxpYXNpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2Nzc1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVzcGl0ZSBvcGVyYXRpbmcgaW4gZmxvYXRz LCB3ZSBhbHdheXMgd2FudCB0byBkcmF3IGxpbmVzIGZvciB0ZXh0IGFsaWduZWQgdG8gcGl4ZWwg Ym91bmRhcmllcy4KKyAgICAgICAgVGhlcmUgYXJlIHNpbWlsYXIgZnVuY3Rpb25zIHRvIGRvIHRo aXMgaW4gb3RoZXIgcGxhdGZvcm1zLCBidXQgdG8gZ2V0IHByb3BlciByZXN1bHRzLCB3ZSBvbmx5 CisgICAgICAgIG5lZWQgdG8gZmxvb3IgdGhlIHkgdmFsdWUuCisKKyAgICAgICAgTm8gdGVzdHMu IE5vIGNoYW5nZSBpbiBiZWhhdmlvciBwcmlvciB0byBzdWItcGl4ZWwgY2hhbmdlLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6ZHJhd0xpbmVGb3JUZXh0KToKKwogMjAx Mi0wNS0xNyAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUuY29tPgogCiAgICAgICAgIElu c2VydCBzb3VyY2UgZmlsZSBhbmQgbGluZSBudW1iZXIgZm9yIHY4IGZ1bmN0aW9uIGNhbGxzIGlu dG8gdHJhY2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAKaW5kZXggY2U0NGYwYy4uZjkzMTlh YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFw aGljc0NvbnRleHRTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCkBAIC02MjksNyArNjI5LDcgQEAgdm9pZCBH cmFwaGljc0NvbnRleHQ6OmRyYXdMaW5lRm9yVGV4dChjb25zdCBGbG9hdFBvaW50JiBwdCwKICAg ICBpbnQgdGhpY2tuZXNzID0gU2tNYXgzMihzdGF0aWNfY2FzdDxpbnQ+KHN0cm9rZVRoaWNrbmVz cygpKSwgMSk7CiAgICAgU2tSZWN0IHI7CiAgICAgci5mTGVmdCA9IFdlYkNvcmVGbG9hdFRvU2tT Y2FsYXIocHQueCgpKTsKLSAgICByLmZUb3AgPSBXZWJDb3JlRmxvYXRUb1NrU2NhbGFyKHB0Lnko KSk7CisgICAgci5mVG9wID0gV2ViQ29yZUZsb2F0VG9Ta1NjYWxhcihmbG9vcmYocHQueSgpKSk7 CiAgICAgci5mUmlnaHQgPSByLmZMZWZ0ICsgV2ViQ29yZUZsb2F0VG9Ta1NjYWxhcih3aWR0aCk7 CiAgICAgci5mQm90dG9tID0gci5mVG9wICsgU2tJbnRUb1NjYWxhcih0aGlja25lc3MpOwogCg==