86708 2012-05-16 22:58:46 -0700 Add an assertion to make sure that visited node is not active insertion point. 2012-05-17 20:24:03 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hayato hayato dglazkov dominicc morrita shinyak tasak webkit.review.bot oldest_to_newest 626281 0 hayato 2012-05-16 22:58:46 -0700 Now InsertionPoint has isActive() member function. https://bugs.webkit.org/show_bug.cgi?id=82010 We can add an assertion to ComposedShadowTreeWalker using that function. 626283 1 142418 hayato 2012-05-16 23:04:37 -0700 Created attachment 142418 add an assertion 626420 2 142418 eric 2012-05-17 03:28:39 -0700 Comment on attachment 142418 add an assertion ok. 626434 3 142418 webkit.review.bot 2012-05-17 04:07:02 -0700 Comment on attachment 142418 add an assertion Rejecting attachment 142418 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12724121 627223 4 142610 hayato 2012-05-17 19:16:18 -0700 Created attachment 142610 Patch for landing 627285 5 142610 webkit.review.bot 2012-05-17 20:23:59 -0700 Comment on attachment 142610 Patch for landing Clearing flags on attachment: 142610 Committed r117534: <http://trac.webkit.org/changeset/117534> 627286 6 webkit.review.bot 2012-05-17 20:24:03 -0700 All reviewed patches have been landed. Closing bug. 142418 2012-05-16 23:04:37 -0700 2012-05-17 19:16:12 -0700 add an assertion bug-86708-20120517150435.patch text/plain 1890 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjExODA2YTJiNTU1MDcy YWEzZmM2NjA3NzI4YmVmM2EzZWI3M2ZiNi4uMzdiMmUxMTAxNWJlZTMyMTYyMjYwZDBmOTgzNjg2 M2ZiYjYzNWM3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTE2ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBbU2hhZG93IERPTV0gQWRk IGFuIGFzc2VydGlvbiB0byBtYWtlIHN1cmUgYSB2aXNpdGVkIG5vZGUgaXMgbm90IGFuIGFjdGl2 ZSBpbnNlcnRpb24gcG9pbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NjcwOAorCisgICAgICAgIFNpbmNlIEluc2VydGlvblBvaW50IG5vdyBoYXMg aXNBY3RpdmUoKSBtZW1iZXIgZnVuY3Rpb24sCisgICAgICAgIHdlIGNhbiBhZGQgYW4gYXNzZXJ0 aW9uIHRvIENvbXBvc2VkU2hhZG93VHJlZVdhbGtlcjo6YXNzZXJ0UHJlY29uZGl0aW9uKCkKKyAg ICAgICAgdXNpbmcgdGhhdCBmdW5jdGlvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGNo YW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGRvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxr ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBvc2VkU2hhZG93VHJlZVdhbGtlcjo6YXNzZXJ0 UHJlY29uZGl0aW9uKToKKwogMjAxMi0wNS0xNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3 LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjExNzA1 MC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxr ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxrZXIuaAppbmRl eCA5NzY2YzFhMzY1MDE5MDA4OGI5NGRhMmE0NDBjMjA2MjZkMGQ0YTkyLi45ZjY3NmY5NzJjNmNm MDE1ZWVmZjA4M2VlOTg0Zjc5ZDAyNmQzN2MwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k b20vQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0Nv bXBvc2VkU2hhZG93VHJlZVdhbGtlci5oCkBAIC0yNyw2ICsyNyw3IEBACiAjaWZuZGVmIENvbXBv c2VkU2hhZG93VHJlZVdhbGtlcl9oCiAjZGVmaW5lIENvbXBvc2VkU2hhZG93VHJlZVdhbGtlcl9o CiAKKyNpbmNsdWRlICJJbnNlcnRpb25Qb2ludC5oIgogI2luY2x1ZGUgIlNoYWRvd1Jvb3QuaCIK IAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNzgsOSArNzksNyBAQCBwcml2YXRlOgogICAgICAg ICAgICAgQVNTRVJUKCFtX25vZGUtPmlzU2hhZG93Um9vdCgpKTsKICAgICAgICAgZWxzZQogICAg ICAgICAgICAgQVNTRVJUKCFtX25vZGUtPmlzU2hhZG93Um9vdCgpIHx8IHRvU2hhZG93Um9vdCht X25vZGUpLT5pc1lvdW5nZXN0KCkpOwotICAgICAgICAvLyBGSVhNRTogQWRkIGFuIGFzc2VydGlv biBvbmNlIEluc2VydGlvblBvaW50IGhhdmUgaXNBY3RpdmUoKSBmdW5jdGlvbi4KLSAgICAgICAg Ly8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyMDEwCi0gICAgICAg IC8vIEFTU0VSVCghaXNJbnNlcnRpb25Qb2ludChtX25vZGUpIHx8ICF0b0luc2VydGlvblBvaW50 KG5vZGUpLT5pc0FjdGl2ZSgpKTsKKyAgICAgICAgQVNTRVJUKCFpc0luc2VydGlvblBvaW50KG1f bm9kZSkgfHwgIXRvSW5zZXJ0aW9uUG9pbnQobV9ub2RlKS0+aXNBY3RpdmUoKSk7CiAjZW5kaWYK ICAgICB9CiAK 142610 2012-05-17 19:16:18 -0700 2012-05-17 20:23:59 -0700 Patch for landing bug-86708-20120518111617.patch text/plain 1948 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjRjMmEzM2ZkZGM1MmJi N2YzMDdkNGYzMDkyNWU1Y2MwODk2ZTQxMS4uYjkxNmUyZmI4YmJkODVlMTBhNWFjNjljN2I1NzQw MWEzYzc2Y2IxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA1LTE2ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBbU2hhZG93IERPTV0gQWRk IGFuIGFzc2VydGlvbiB0byBtYWtlIHN1cmUgYSB2aXNpdGVkIG5vZGUgaXMgbm90IGFuIGFjdGl2 ZSBpbnNlcnRpb24gcG9pbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NjcwOAorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgorCisg ICAgICAgIFNpbmNlIEluc2VydGlvblBvaW50IG5vdyBoYXMgaXNBY3RpdmUoKSBtZW1iZXIgZnVu Y3Rpb24sCisgICAgICAgIHdlIGNhbiBhZGQgYW4gYXNzZXJ0aW9uIHRvIENvbXBvc2VkU2hhZG93 VHJlZVdhbGtlcjo6YXNzZXJ0UHJlY29uZGl0aW9uKCkKKyAgICAgICAgdXNpbmcgdGhhdCBmdW5j dGlvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKwor ICAgICAgICAqIGRvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxrZXIuaDoKKyAgICAgICAgKFdlYkNv cmU6OkNvbXBvc2VkU2hhZG93VHJlZVdhbGtlcjo6YXNzZXJ0UHJlY29uZGl0aW9uKToKKwogMjAx Mi0wNS0xNyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBjcmVhdGUgU291cmNlRnJhbWVzIHdpdGggY29udGVudCBwcm92aWRl cnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29tcG9zZWRTaGFkb3dUcmVlV2Fs a2VyLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ29tcG9zZWRTaGFkb3dUcmVlV2Fsa2VyLmgKaW5k ZXggMWE5ZDJhOTNjNjM2NjMzYTllM2YyNDIwMWI1MGM0ZTA5M2FmN2I5NC4uODMxYjgyYzY5N2Yz NzU2OTViYzY3ZWU4ODIyNWJiMDMxMmU2Yzk2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZG9tL0NvbXBvc2VkU2hhZG93VHJlZVdhbGtlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9D b21wb3NlZFNoYWRvd1RyZWVXYWxrZXIuaApAQCAtMjcsNiArMjcsNyBAQAogI2lmbmRlZiBDb21w b3NlZFNoYWRvd1RyZWVXYWxrZXJfaAogI2RlZmluZSBDb21wb3NlZFNoYWRvd1RyZWVXYWxrZXJf aAogCisjaW5jbHVkZSAiSW5zZXJ0aW9uUG9pbnQuaCIKICNpbmNsdWRlICJTaGFkb3dSb290Lmgi CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTgwLDkgKzgxLDcgQEAgcHJpdmF0ZToKICAgICAg ICAgICAgIEFTU0VSVCghbV9ub2RlLT5pc1NoYWRvd1Jvb3QoKSk7CiAgICAgICAgIGVsc2UKICAg ICAgICAgICAgIEFTU0VSVCghbV9ub2RlLT5pc1NoYWRvd1Jvb3QoKSB8fCB0b1NoYWRvd1Jvb3Qo bV9ub2RlKS0+aXNZb3VuZ2VzdCgpKTsKLSAgICAgICAgLy8gRklYTUU6IEFkZCBhbiBhc3NlcnRp b24gb25jZSBJbnNlcnRpb25Qb2ludCBoYXZlIGlzQWN0aXZlKCkgZnVuY3Rpb24uCi0gICAgICAg IC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjAxMAotICAgICAg ICAvLyBBU1NFUlQoIWlzSW5zZXJ0aW9uUG9pbnQobV9ub2RlKSB8fCAhdG9JbnNlcnRpb25Qb2lu dChub2RlKS0+aXNBY3RpdmUoKSk7CisgICAgICAgIEFTU0VSVCghaXNJbnNlcnRpb25Qb2ludCht X25vZGUpIHx8ICF0b0luc2VydGlvblBvaW50KG1fbm9kZSktPmlzQWN0aXZlKCkpOwogI2VuZGlm CiAgICAgfQogCg==