86693 2012-05-16 18:26:16 -0700 Fix rounding in paintSelection 2012-05-17 13:57:00 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85555 1 eae eae eric leviw webkit.review.bot oldest_to_newest 626103 0 eae 2012-05-16 18:26:16 -0700 Fix rounding to device pixels in paintSelection to avoid selection gaps once we turn on subpixel layout. 626121 1 142389 eae 2012-05-16 18:37:05 -0700 Created attachment 142389 Patch 626857 2 142389 eric 2012-05-17 12:36:01 -0700 Comment on attachment 142389 Patch Looks reasonable to me. 626935 3 142389 webkit.review.bot 2012-05-17 13:56:56 -0700 Comment on attachment 142389 Patch Clearing flags on attachment: 142389 Committed r117491: <http://trac.webkit.org/changeset/117491> 626936 4 webkit.review.bot 2012-05-17 13:57:00 -0700 All reviewed patches have been landed. Closing bug. 142389 2012-05-16 18:37:05 -0700 2012-05-17 13:56:56 -0700 Patch bug-86693-20120516183704.patch text/plain 7229 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNzM3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDEyLTA1LTE2ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggcm91bmRpbmcgaW4gcGFp bnRTZWxlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg2NjkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQnJlYWsgb3V0IHJvdW5kaW5nIGxvZ2ljIGZyb20gSW5saW5lVGV4dEJveDo6cGFpbnRTZWxl Y3Rpb24gaW50byBzZXBhcmF0ZQorICAgICAgICBmdW5jdGlvbiBhbmQgdXNlIGl0IGZvciBhbGwg dGhlIEVsbGlwc2lzQm94IHBhaW50U2VsZWN0aW9uIGltcGxlbWVudGF0aW9uCisgICAgICAgIGFu ZCBzZWxlY3Rpb24gZ2FwIGNhbGN1bGF0aW9uLiBUaGlzIGVuc3VyZXMgdGhhdCBzZWxlY3Rpb25z IGFyZSBwYWludGVkCisgICAgICAgIHdpdGhvdXQgZ2FwcyBhbmQgb3ZlcmxhcHMgb25jZSB3ZSB0 dXJuIG9uIHN1YnBpeGVsIGxheW91dC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQg YnkgZXhpc3RpbmcgdGVzdHMgaW4gZWRpdGluZy9zZWxlY3Rpb24gYW5kCisgICAgICAgIGVkaXRp bmcvc3R5bGUuCisKKyAgICAgICAgKiByZW5kZXJpbmcvRWxsaXBzaXNCb3guY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RWxsaXBzaXNCb3g6OnBhaW50U2VsZWN0aW9uKToKKyAgICAgICAgKiByZW5k ZXJpbmcvSW5saW5lVGV4dEJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjphbGlnblNlbGVjdGlv blJlY3RUb0RldmljZVBpeGVscyk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNv cmU6OklubGluZVRleHRCb3g6OnBhaW50U2VsZWN0aW9uKToKKyAgICAgICAgKiByZW5kZXJpbmcv SW5saW5lVGV4dEJveC5oOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpsb2dpY2Fs TGVmdFNlbGVjdGlvbkdhcCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6bG9naWNh bFJpZ2h0U2VsZWN0aW9uR2FwKToKKwogMjAxMi0wNS0xNiAgS2VudGFybyBIYXJhICA8aGFyYWtl bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBQYXNzIElzb2xhdGUgdG8gY29udmVydEV2 ZW50VGFyZ2V0VG9WOE9iamVjdCgpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRWxs aXBzaXNCb3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9FbGxp cHNpc0JveC5jcHAJKHJldmlzaW9uIDExNzM0OCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9FbGxpcHNpc0JveC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzLDYgKzIzLDcgQEAKICNpbmNs dWRlICJEb2N1bWVudC5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUg IkhpdFRlc3RSZXN1bHQuaCIKKyNpbmNsdWRlICJJbmxpbmVUZXh0Qm94LmgiCiAjaW5jbHVkZSAi UGFpbnRJbmZvLmgiCiAjaW5jbHVkZSAiUmVuZGVyQmxvY2suaCIKICNpbmNsdWRlICJSb290SW5s aW5lQm94LmgiCkBAIC05NiwxMCArOTcsMTEgQEAgdm9pZCBFbGxpcHNpc0JveDo6cGFpbnRTZWxl Y3Rpb24oR3JhcGhpYwogICAgIEdyYXBoaWNzQ29udGV4dFN0YXRlU2F2ZXIgc3RhdGVTYXZlcigq Y29udGV4dCk7CiAgICAgTGF5b3V0VW5pdCB0b3AgPSByb290KCktPnNlbGVjdGlvblRvcCgpOwog ICAgIExheW91dFVuaXQgaCA9IHJvb3QoKS0+c2VsZWN0aW9uSGVpZ2h0KCk7Ci0gICAgLy8gRklY TUU6IFdlJ2xsIG5lZWQgdG8gYXBwbHkgdGhlIGNvcnJlY3QgY2xpcCByb3VuZGluZyBoZXJlOiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjM2NTYKLSAgICBjb250ZXh0 LT5jbGlwKEludFJlY3QoeCgpICsgcGFpbnRPZmZzZXQueCgpLCB0b3AgKyBwYWludE9mZnNldC55 KCksIG1fbG9naWNhbFdpZHRoLCBoKSk7CisgICAgTGF5b3V0UmVjdCBjbGlwUmVjdCh4KCkgKyBw YWludE9mZnNldC54KCksIHRvcCArIHBhaW50T2Zmc2V0LnkoKSwgbV9sb2dpY2FsV2lkdGgsIGgp OworICAgIGFsaWduU2VsZWN0aW9uUmVjdFRvRGV2aWNlUGl4ZWxzKGNsaXBSZWN0KTsKKyAgICBj b250ZXh0LT5jbGlwKGNsaXBSZWN0KTsKICAgICAvLyBGSVhNRTogV2h5IGlzIHRoaXMgYWx3YXlz IExUUj8gRml4IGJ5IHBhc3NpbmcgY29ycmVjdCB0ZXh0IHJ1biBmbGFncyBiZWxvdy4KLSAgICBj b250ZXh0LT5kcmF3SGlnaGxpZ2h0Rm9yVGV4dChmb250LCBSZW5kZXJCbG9jazo6Y29uc3RydWN0 VGV4dFJ1bihyZW5kZXJlcigpLCBmb250LCBtX3N0ciwgc3R5bGUsIFRleHRSdW46OkFsbG93VHJh aWxpbmdFeHBhbnNpb24pLCBJbnRQb2ludCh4KCkgKyBwYWludE9mZnNldC54KCksIHkoKSArIHBh aW50T2Zmc2V0LnkoKSArIHRvcCksIGgsIGMsIHN0eWxlLT5jb2xvclNwYWNlKCkpOworICAgIGNv bnRleHQtPmRyYXdIaWdobGlnaHRGb3JUZXh0KGZvbnQsIFJlbmRlckJsb2NrOjpjb25zdHJ1Y3RU ZXh0UnVuKHJlbmRlcmVyKCksIGZvbnQsIG1fc3RyLCBzdHlsZSwgVGV4dFJ1bjo6QWxsb3dUcmFp bGluZ0V4cGFuc2lvbiksIHJvdW5kZWRJbnRQb2ludChMYXlvdXRQb2ludCh4KCkgKyBwYWludE9m ZnNldC54KCksIHkoKSArIHBhaW50T2Zmc2V0LnkoKSArIHRvcCkpLCBoLCBjLCBzdHlsZS0+Y29s b3JTcGFjZSgpKTsKIH0KIAogYm9vbCBFbGxpcHNpc0JveDo6bm9kZUF0UG9pbnQoY29uc3QgSGl0 VGVzdFJlcXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RSZXN1bHQmIHJlc3VsdCwgY29uc3QgTGF5b3V0 UG9pbnQmIHBvaW50SW5Db250YWluZXIsIGNvbnN0IExheW91dFBvaW50JiBhY2N1bXVsYXRlZE9m ZnNldCwgTGF5b3V0VW5pdCBsaW5lVG9wLCBMYXlvdXRVbml0IGxpbmVCb3R0b20pCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCShyZXZpc2lvbiAxMTcz NDgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTgwNyw2ICs4MDcsMjIgQEAgdm9pZCBJbmxpbmVUZXh0Qm94OjpzZWxlY3Rp b25TdGFydEVuZChpbgogICAgIGVQb3MgPSBtaW4oZW5kUG9zIC0gbV9zdGFydCwgKGludCltX2xl bik7CiB9CiAKK3ZvaWQgYWxpZ25TZWxlY3Rpb25SZWN0VG9EZXZpY2VQaXhlbHMoTGF5b3V0UmVj dCYgcmVjdCkKK3sKKyAgICBMYXlvdXRVbml0IG1heFggPSBmbG9vclRvSW50KHJlY3QubWF4WCgp KTsKKyAgICByZWN0LnNldFgoZmxvb3JUb0ludChyZWN0LngoKSkpOworICAgIHJlY3Quc2V0V2lk dGgobWF4WCAtIHJlY3QueCgpKTsKK30KKworI2lmICFFTkFCTEUoU1VCUElYRUxfTEFZT1VUKQor dm9pZCBhbGlnblNlbGVjdGlvblJlY3RUb0RldmljZVBpeGVscyhGbG9hdFJlY3QmIHJlY3QpCit7 CisgICAgZmxvYXQgbWF4WCA9IGZsb29yZihyZWN0Lm1heFgoKSk7CisgICAgcmVjdC5zZXRYKGZs b29yZihyZWN0LngoKSkpOworICAgIHJlY3Quc2V0V2lkdGgocm91bmRmKG1heFggLSByZWN0Lngo KSkpOworfQorI2VuZGlmCisKIHZvaWQgSW5saW5lVGV4dEJveDo6cGFpbnRTZWxlY3Rpb24oR3Jh cGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBGbG9hdFBvaW50JiBib3hPcmlnaW4sIFJlbmRl clN0eWxlKiBzdHlsZSwgY29uc3QgRm9udCYgZm9udCwgQ29sb3IgdGV4dENvbG9yKQogewogICAg IGlmIChjb250ZXh0LT5wYWludGluZ0Rpc2FibGVkKCkpCkBAIC04NDQsMTUgKzg2MCwxOCBAQCB2 b2lkIElubGluZVRleHRCb3g6OnBhaW50U2VsZWN0aW9uKEdyYXBoCiAgICAgTGF5b3V0VW5pdCBz ZWxlY3Rpb25Cb3R0b20gPSByb290KCktPnNlbGVjdGlvbkJvdHRvbSgpOwogICAgIExheW91dFVu aXQgc2VsZWN0aW9uVG9wID0gcm9vdCgpLT5zZWxlY3Rpb25Ub3BBZGp1c3RlZEZvclByZWNlZGlu Z0Jsb2NrKCk7CiAKLSAgICBpbnQgZGVsdGFZID0gcmVuZGVyZXIoKS0+c3R5bGUoKS0+aXNGbGlw cGVkTGluZXNXcml0aW5nTW9kZSgpID8gc2VsZWN0aW9uQm90dG9tIC0gbG9naWNhbEJvdHRvbSgp IDogbG9naWNhbFRvcCgpIC0gc2VsZWN0aW9uVG9wOwotICAgIGludCBzZWxIZWlnaHQgPSBtYXg8 TGF5b3V0VW5pdD4oMCwgc2VsZWN0aW9uQm90dG9tIC0gc2VsZWN0aW9uVG9wKTsKKyAgICBMYXlv dXRVbml0IGRlbHRhWSA9IHJlbmRlcmVyKCktPnN0eWxlKCktPmlzRmxpcHBlZExpbmVzV3JpdGlu Z01vZGUoKSA/IHNlbGVjdGlvbkJvdHRvbSAtIGxvZ2ljYWxCb3R0b20oKSA6IGxvZ2ljYWxUb3Ao KSAtIHNlbGVjdGlvblRvcDsKKyAgICBMYXlvdXRVbml0IHNlbEhlaWdodCA9IG1heDxMYXlvdXRV bml0PigwLCBzZWxlY3Rpb25Cb3R0b20gLSBzZWxlY3Rpb25Ub3ApOwogCisjaWYgRU5BQkxFKFNV QlBJWEVMX0xBWU9VVCkKKyAgICBMYXlvdXRQb2ludCBsb2NhbE9yaWdpbihib3hPcmlnaW4ueCgp LCBib3hPcmlnaW4ueSgpIC0gZGVsdGFZKTsKKyAgICBMYXlvdXRSZWN0IGNsaXBSZWN0KGxvY2Fs T3JpZ2luLCBMYXlvdXRTaXplKG1fbG9naWNhbFdpZHRoLCBzZWxIZWlnaHQpKTsKKyAgICBhbGln blNlbGVjdGlvblJlY3RUb0RldmljZVBpeGVscyhjbGlwUmVjdCk7CisjZWxzZQogICAgIEZsb2F0 UG9pbnQgbG9jYWxPcmlnaW4oYm94T3JpZ2luLngoKSwgYm94T3JpZ2luLnkoKSAtIGRlbHRhWSk7 Ci0KICAgICBGbG9hdFJlY3QgY2xpcFJlY3QobG9jYWxPcmlnaW4sIEZsb2F0U2l6ZShtX2xvZ2lj YWxXaWR0aCwgc2VsSGVpZ2h0KSk7Ci0gICAgZmxvYXQgbWF4WCA9IGZsb29yZihjbGlwUmVjdC5t YXhYKCkpOwotICAgIGNsaXBSZWN0LnNldFgoZmxvb3JmKGNsaXBSZWN0LngoKSkpOwotICAgIGNs aXBSZWN0LnNldFdpZHRoKG1heFggLSBjbGlwUmVjdC54KCkpOworICAgIGFsaWduU2VsZWN0aW9u UmVjdFRvRGV2aWNlUGl4ZWxzKGNsaXBSZWN0KTsKKyNlbmRpZgogICAgIGNvbnRleHQtPmNsaXAo Y2xpcFJlY3QpOwogCiAgICAgY29udGV4dC0+ZHJhd0hpZ2hsaWdodEZvclRleHQoZm9udCwgdGV4 dFJ1biwgbG9jYWxPcmlnaW4sIHNlbEhlaWdodCwgYywgc3R5bGUtPmNvbG9yU3BhY2UoKSwgc1Bv cywgZVBvcyk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmgJ KHJldmlzaW9uIDExNzM0OCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0 Qm94LmgJKHdvcmtpbmcgY29weSkKQEAgLTIxMyw2ICsyMTMsMTEgQEAgaW5saW5lIFJlbmRlclRl eHQqIElubGluZVRleHRCb3g6OnRleHRSZQogICAgIHJldHVybiB0b1JlbmRlclRleHQocmVuZGVy ZXIoKSk7CiB9CiAKK3ZvaWQgYWxpZ25TZWxlY3Rpb25SZWN0VG9EZXZpY2VQaXhlbHMoTGF5b3V0 UmVjdCYpOworI2lmICFFTkFCTEUoU1VCUElYRUxfTEFZT1VUKQordm9pZCBhbGlnblNlbGVjdGlv blJlY3RUb0RldmljZVBpeGVscyhGbG9hdFJlY3QmKTsKKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBJbmxpbmVUZXh0Qm94X2gKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gMTE3MzQ4KQorKysgU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzI5 NSw2ICszMjk1LDcgQEAgTGF5b3V0UmVjdCBSZW5kZXJCbG9jazo6bG9naWNhbExlZnRTZWxlYwog ICAgICAgICByZXR1cm4gTGF5b3V0UmVjdCgpOwogCiAgICAgTGF5b3V0UmVjdCBnYXBSZWN0ID0g cm9vdEJsb2NrLT5sb2dpY2FsUmVjdFRvUGh5c2ljYWxSZWN0KHJvb3RCbG9ja1BoeXNpY2FsUG9z aXRpb24sIExheW91dFJlY3Qocm9vdEJsb2NrTG9naWNhbExlZnQsIHJvb3RCbG9ja0xvZ2ljYWxU b3AsIHJvb3RCbG9ja0xvZ2ljYWxXaWR0aCwgbG9naWNhbEhlaWdodCkpOworICAgIGFsaWduU2Vs ZWN0aW9uUmVjdFRvRGV2aWNlUGl4ZWxzKGdhcFJlY3QpOwogICAgIGlmIChwYWludEluZm8pCiAg ICAgICAgIHBhaW50SW5mby0+Y29udGV4dC0+ZmlsbFJlY3QoZ2FwUmVjdCwgc2VsT2JqLT5zZWxl Y3Rpb25CYWNrZ3JvdW5kQ29sb3IoKSwgc2VsT2JqLT5zdHlsZSgpLT5jb2xvclNwYWNlKCkpOwog ICAgIHJldHVybiBnYXBSZWN0OwpAQCAtMzMxMSw2ICszMzEyLDcgQEAgTGF5b3V0UmVjdCBSZW5k ZXJCbG9jazo6bG9naWNhbFJpZ2h0U2VsZQogICAgICAgICByZXR1cm4gTGF5b3V0UmVjdCgpOwog CiAgICAgTGF5b3V0UmVjdCBnYXBSZWN0ID0gcm9vdEJsb2NrLT5sb2dpY2FsUmVjdFRvUGh5c2lj YWxSZWN0KHJvb3RCbG9ja1BoeXNpY2FsUG9zaXRpb24sIExheW91dFJlY3Qocm9vdEJsb2NrTG9n aWNhbExlZnQsIHJvb3RCbG9ja0xvZ2ljYWxUb3AsIHJvb3RCbG9ja0xvZ2ljYWxXaWR0aCwgbG9n aWNhbEhlaWdodCkpOworICAgIGFsaWduU2VsZWN0aW9uUmVjdFRvRGV2aWNlUGl4ZWxzKGdhcFJl Y3QpOwogICAgIGlmIChwYWludEluZm8pCiAgICAgICAgIHBhaW50SW5mby0+Y29udGV4dC0+Zmls bFJlY3QoZ2FwUmVjdCwgc2VsT2JqLT5zZWxlY3Rpb25CYWNrZ3JvdW5kQ29sb3IoKSwgc2VsT2Jq LT5zdHlsZSgpLT5jb2xvclNwYWNlKCkpOwogICAgIHJldHVybiBnYXBSZWN0Owo=