86570 2012-05-15 21:46:35 -0700 [V8] Pass Isolate to remaining toV8() 2012-05-16 19:20:29 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 624957 0 haraken 2012-05-15 21:46:35 -0700 The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to toV8(). I've landed a bunch of patches to pass Isolate to toV8(), and this would be the last patch for passing Isolate to toV8(). 624962 1 142144 haraken 2012-05-15 21:49:47 -0700 Created attachment 142144 Patch 626151 2 142144 webkit.review.bot 2012-05-16 19:20:25 -0700 Comment on attachment 142144 Patch Clearing flags on attachment: 142144 Committed r117381: <http://trac.webkit.org/changeset/117381> 626152 3 webkit.review.bot 2012-05-16 19:20:29 -0700 All reviewed patches have been landed. Closing bug. 142144 2012-05-15 21:49:47 -0700 2012-05-16 19:20:25 -0700 Patch bug-86570-20120516134945.patch text/plain 3677 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY0ZWUzMjgxZTUzZTU3 MzNkODg5MDBhYzQ1NDk4Nzc4Njk0NzYzZC4uNWEyZDVlMzFhOTM1YWI2NmU5MTBkNTRiMjUyZTQ3 OTBmN2Y5MDEyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTA1LTE1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFBhc3MgSXNv bGF0ZSB0byByZW1haW5pbmcgdG9WOCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04NjU3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBvYmplY3RpdmUgaXMgdG8gcGFzcyBJc29sYXRlIGFyb3VuZCBp biBWOCBiaW5kaW5ncy4KKyAgICAgICAgVGhpcyBwYXRjaCBwYXNzZXMgSXNvbGF0ZSB0byB0b1Y4 KCkuIEkndmUgbGFuZGVkIGEgYnVuY2ggb2YKKyAgICAgICAgcGF0Y2hlcyB0byBwYXNzIElzb2xh dGUgdG8gdG9WOCgpLCBhbmQgdGhpcyB3b3VsZCBiZSB0aGUgbGFzdAorICAgICAgICBwYXRjaCBm b3IgcGFzc2luZyBJc29sYXRlIHRvIHRvVjgoKS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hh bmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTENv bGxlY3Rpb25DdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0TmFtZWRJdGVtcyk6Cisg ICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SURCQW55Q3VzdG9tLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OnRvVjgpOgorCisyMDEyLTA1LTE1ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNo cm9taXVtLm9yZz4KKwogICAgICAgICBVbnJldmlld2VkLiBSZWJhc2VsaW5lZCBydW4tYmluZGlu Z3MtdGVzdHMgcmVzdWx0cy4KIAogICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9K U0Zsb2F0NjRBcnJheS5jcHA6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9jdXN0b20vVjhIVE1MQ29sbGVjdGlvbkN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhIVE1MQ29sbGVjdGlvbkN1c3RvbS5jcHAKaW5kZXggZDI0MTZlOGVi MzBmOWNlNDI4NmVmMzUzOGMwN2JkYzkyMjI3MjY3Yi4uMmYxZWE1NGU4ZTI2ZTljNjNjM2EyMjY4 M2VlMjMzOWFjMzY3NDZlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4SFRNTENvbGxlY3Rpb25DdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxDb2xsZWN0aW9uQ3VzdG9tLmNwcApAQCAtNTUsNyArNTUs NyBAQCBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGdldE5hbWVkSXRlbXMoSFRNTENvbGxl Y3Rpb24qIGNvbGxlY3Rpb24sIEF0b21pY1N0cgogICAgICAgICByZXR1cm4gdG9WOChuYW1lZEl0 ZW1zLmF0KDApLnJlbGVhc2UoKSwgaXNvbGF0ZSk7CiAKICAgICBpZiAoY29sbGVjdGlvbi0+dHlw ZSgpID09IEZvcm1Db250cm9scykKLSAgICAgICAgcmV0dXJuIHRvVjgoY29sbGVjdGlvbi0+YmFz ZSgpLT5yYWRpb05vZGVMaXN0KG5hbWUpLmdldCgpKTsKKyAgICAgICAgcmV0dXJuIHRvVjgoY29s bGVjdGlvbi0+YmFzZSgpLT5yYWRpb05vZGVMaXN0KG5hbWUpLmdldCgpLCBpc29sYXRlKTsKIAog ICAgIHJldHVybiB0b1Y4KFY4TmFtZWROb2Rlc0NvbGxlY3Rpb246OmNyZWF0ZShuYW1lZEl0ZW1z KSwgaXNvbGF0ZSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9j dXN0b20vVjhJREJBbnlDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4SURCQW55Q3VzdG9tLmNwcAppbmRleCAxNzMzZWM4YmNkYTNhNDdlM2ZiMGZhNGZhY2Y1 OTBjNjZjYWJjYWRiLi4xNDM0MDU0MzA1NzczMjc5N2NhODFlODJiYzhjOGIxNzlmNDZhNzIzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhJREJBbnlDdXN0 b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOElEQkFueUN1 c3RvbS5jcHAKQEAgLTU1LDIzICs1NSwyMyBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdG9WOChJ REJBbnkqIGltcGwsIHY4OjpJc29sYXRlKiBpc29sYXRlKQogICAgIGNhc2UgSURCQW55OjpOdWxs VHlwZToKICAgICAgICAgcmV0dXJuIHY4OjpOdWxsKCk7CiAgICAgY2FzZSBJREJBbnk6OkRPTVN0 cmluZ0xpc3RUeXBlOgotICAgICAgICByZXR1cm4gdG9WOChpbXBsLT5kb21TdHJpbmdMaXN0KCkp OworICAgICAgICByZXR1cm4gdG9WOChpbXBsLT5kb21TdHJpbmdMaXN0KCksIGlzb2xhdGUpOwog ICAgIGNhc2UgSURCQW55OjpJREJDdXJzb3JUeXBlOgotICAgICAgICByZXR1cm4gdG9WOChpbXBs LT5pZGJDdXJzb3IoKSk7CisgICAgICAgIHJldHVybiB0b1Y4KGltcGwtPmlkYkN1cnNvcigpLCBp c29sYXRlKTsKICAgICBjYXNlIElEQkFueTo6SURCQ3Vyc29yV2l0aFZhbHVlVHlwZToKLSAgICAg ICAgcmV0dXJuIHRvVjgoaW1wbC0+aWRiQ3Vyc29yV2l0aFZhbHVlKCkpOworICAgICAgICByZXR1 cm4gdG9WOChpbXBsLT5pZGJDdXJzb3JXaXRoVmFsdWUoKSwgaXNvbGF0ZSk7CiAgICAgY2FzZSBJ REJBbnk6OklEQkRhdGFiYXNlVHlwZToKLSAgICAgICAgcmV0dXJuIHRvVjgoaW1wbC0+aWRiRGF0 YWJhc2UoKSk7CisgICAgICAgIHJldHVybiB0b1Y4KGltcGwtPmlkYkRhdGFiYXNlKCksIGlzb2xh dGUpOwogICAgIGNhc2UgSURCQW55OjpJREJGYWN0b3J5VHlwZToKLSAgICAgICAgcmV0dXJuIHRv VjgoaW1wbC0+aWRiRmFjdG9yeSgpKTsKKyAgICAgICAgcmV0dXJuIHRvVjgoaW1wbC0+aWRiRmFj dG9yeSgpLCBpc29sYXRlKTsKICAgICBjYXNlIElEQkFueTo6SURCSW5kZXhUeXBlOgotICAgICAg ICByZXR1cm4gdG9WOChpbXBsLT5pZGJJbmRleCgpKTsKKyAgICAgICAgcmV0dXJuIHRvVjgoaW1w bC0+aWRiSW5kZXgoKSwgaXNvbGF0ZSk7CiAgICAgY2FzZSBJREJBbnk6OklEQktleVR5cGU6Ci0g ICAgICAgIHJldHVybiB0b1Y4KGltcGwtPmlkYktleSgpKTsKKyAgICAgICAgcmV0dXJuIHRvVjgo aW1wbC0+aWRiS2V5KCksIGlzb2xhdGUpOwogICAgIGNhc2UgSURCQW55OjpJREJPYmplY3RTdG9y ZVR5cGU6Ci0gICAgICAgIHJldHVybiB0b1Y4KGltcGwtPmlkYk9iamVjdFN0b3JlKCkpOworICAg ICAgICByZXR1cm4gdG9WOChpbXBsLT5pZGJPYmplY3RTdG9yZSgpLCBpc29sYXRlKTsKICAgICBj YXNlIElEQkFueTo6SURCVHJhbnNhY3Rpb25UeXBlOgotICAgICAgICByZXR1cm4gdG9WOChpbXBs LT5pZGJUcmFuc2FjdGlvbigpKTsKKyAgICAgICAgcmV0dXJuIHRvVjgoaW1wbC0+aWRiVHJhbnNh Y3Rpb24oKSwgaXNvbGF0ZSk7CiAgICAgY2FzZSBJREJBbnk6OlNlcmlhbGl6ZWRTY3JpcHRWYWx1 ZVR5cGU6CiAgICAgICAgIHJldHVybiBpbXBsLT5zZXJpYWxpemVkU2NyaXB0VmFsdWUoKS0+ZGVz ZXJpYWxpemUoMCwgaXNvbGF0ZSk7CiAgICAgfQo=