86566 2012-05-15 21:06:27 -0700 [V8] Pass Isolate to convertEventTargetToV8Object() 2012-05-16 18:18:52 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 624932 0 haraken 2012-05-15 21:06:27 -0700 The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to convertEventTargetToV8Object(). 624945 1 142140 haraken 2012-05-15 21:20:55 -0700 Created attachment 142140 Patch 625468 2 142140 japhet 2012-05-16 08:33:30 -0700 Comment on attachment 142140 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142140&action=review > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3830 > - return "V8DOMWrapper::convertEventTargetToV8Object($value)"; > + return "V8DOMWrapper::convertEventTargetToV8Object($value, $getIsolate)"; Does this need a bindings/scripts/test change? 626048 3 142140 haraken 2012-05-16 17:17:53 -0700 Comment on attachment 142140 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142140&action=review >> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3830 >> + return "V8DOMWrapper::convertEventTargetToV8Object($value, $getIsolate)"; > > Does this need a bindings/scripts/test change? No change. 626096 4 142140 webkit.review.bot 2012-05-16 18:18:48 -0700 Comment on attachment 142140 Patch Clearing flags on attachment: 142140 Committed r117374: <http://trac.webkit.org/changeset/117374> 626097 5 webkit.review.bot 2012-05-16 18:18:52 -0700 All reviewed patches have been landed. Closing bug. 142140 2012-05-15 21:20:55 -0700 2012-05-16 18:18:48 -0700 Patch bug-86566-20120516132053.patch text/plain 4029 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTY0ZWUzMjgxZTUzZTU3 MzNkODg5MDBhYzQ1NDk4Nzc4Njk0NzYzZC4uMmY3MmRkYzA2ZWQ4Mjk1NzVhODRlYWUxYWQyNTE5 MzE4YzYwMTQ2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDEyLTA1LTE1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFBhc3MgSXNv bGF0ZSB0byBjb252ZXJ0RXZlbnRUYXJnZXRUb1Y4T2JqZWN0KCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NTY2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG9iamVjdGl2ZSBpcyB0byBwYXNzIElz b2xhdGUgYXJvdW5kIGluIFY4IGJpbmRpbmdzLgorICAgICAgICBUaGlzIHBhdGNoIHBhc3NlcyBJ c29sYXRlIHRvIGNvbnZlcnRFdmVudFRhcmdldFRvVjhPYmplY3QoKS4KKyAgICAgICAgSSBtYWRl IHRoZSAnaXNvbGF0ZScgYXJndW1lbnQgb3B0aW9uYWwsIHNpbmNlCisgICAgICAgIGNvbnZlcnRF dmVudFRhcmdldFRvVjhPYmplY3QoKSBjYW4gYmUgY2FsbGVkIGZyb20gdGhlIFdlYkNvcmUgY29u dGV4dC4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAg ICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAgICAgIChOYXRp dmVUb0pTVmFsdWUpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NV3JhcHBlcjo6Y29udmVy dEV2ZW50VGFyZ2V0VG9WOE9iamVjdCk6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFw cGVyLmg6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdyYXBwZXI6OmNvbnZlcnRFdmVudFRhcmdl dFRvVjhPYmplY3QpOgorICAgICAgICAoVjhET01XcmFwcGVyKToKKworMjAxMi0wNS0xNSAgS2Vu dGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgVW5yZXZpZXdlZC4g UmViYXNlbGluZWQgcnVuLWJpbmRpbmdzLXRlc3RzIHJlc3VsdHMuCiAKICAgICAgICAgKiBiaW5k aW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNGbG9hdDY0QXJyYXkuY3BwOgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0gYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCA3MDJhYjQ0 MGM1NmZlM2U3ZjdlMTI1OGU3ZTFkYTIyZjFkMzRiNTRlLi4zOTE0MjAwZjczZDdjOTc4ODI4NzM0 YmMwODI4ZDdlMGViNjIzZDhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMzgyNyw3ICszODI3LDcgQEAgc3ViIE5hdGl2 ZVRvSlNWYWx1ZQogICAgIH0KIAogICAgIGlmICgkdHlwZSBlcSAiRXZlbnRUYXJnZXQiKSB7Ci0g ICAgICAgIHJldHVybiAiVjhET01XcmFwcGVyOjpjb252ZXJ0RXZlbnRUYXJnZXRUb1Y4T2JqZWN0 KCR2YWx1ZSkiOworICAgICAgICByZXR1cm4gIlY4RE9NV3JhcHBlcjo6Y29udmVydEV2ZW50VGFy Z2V0VG9WOE9iamVjdCgkdmFsdWUsICRnZXRJc29sYXRlKSI7CiAgICAgfQogCiAgICAgaWYgKCR0 eXBlIGVxICJFdmVudExpc3RlbmVyIikgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 RE9NV3JhcHBlci5jcHAKaW5kZXggMGFkNGUyMjE0NjNmNTRlN2VlZjEwOWM4M2RkNzBmZjcwZTE2 MmU2Mi4uMmNkNzlhOTcyOTllN2I2NDA0OTI1M2ViNDY4NjlhNTAyMDU2YzA0YiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCkBAIC0yNTMsMTAgKzI1Mywx MCBAQCBib29sIFY4RE9NV3JhcHBlcjo6aXNXcmFwcGVyT2ZUeXBlKHY4OjpIYW5kbGU8djg6OlZh bHVlPiB2YWx1ZSwgV3JhcHBlclR5cGVJbmZvKgogCiAjZGVmaW5lIFRSWV9UT19XUkFQX1dJVEhf SU5URVJGQUNFKGludGVyZmFjZU5hbWUpIFwKICAgICBpZiAoZXZlbnROYW1lcygpLmludGVyZmFj ZUZvciMjaW50ZXJmYWNlTmFtZSA9PSBkZXNpcmVkSW50ZXJmYWNlKSBcCi0gICAgICAgIHJldHVy biB0b1Y4KHN0YXRpY19jYXN0PGludGVyZmFjZU5hbWUqPih0YXJnZXQpKTsKKyAgICAgICAgcmV0 dXJuIHRvVjgoc3RhdGljX2Nhc3Q8aW50ZXJmYWNlTmFtZSo+KHRhcmdldCksIGlzb2xhdGUpOwog CiAvLyBBIEpTIG9iamVjdCBvZiB0eXBlIEV2ZW50VGFyZ2V0IGlzIGxpbWl0ZWQgdG8gYSBzbWFs bCBudW1iZXIgb2YgcG9zc2libGUgY2xhc3Nlcy4KLXY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOERP TVdyYXBwZXI6OmNvbnZlcnRFdmVudFRhcmdldFRvVjhPYmplY3QoRXZlbnRUYXJnZXQqIHRhcmdl dCkKK3Y4OjpIYW5kbGU8djg6OlZhbHVlPiBWOERPTVdyYXBwZXI6OmNvbnZlcnRFdmVudFRhcmdl dFRvVjhPYmplY3QoRXZlbnRUYXJnZXQqIHRhcmdldCwgdjg6Oklzb2xhdGUqIGlzb2xhdGUpCiB7 CiAgICAgaWYgKCF0YXJnZXQpCiAgICAgICAgIHJldHVybiB2ODo6TnVsbCgpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmggYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaAppbmRleCBiM2M5ZmY5ZDcyYzNkZjgwNTJk NzZhZWE3YWEwZTU5MjM0NTM2NGVhLi43MDU5ZjUxYjhjMWVmZGY0NzUyMjczNTJiZTg2ZDlhMzI1 YzU3OWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBw ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaApAQCAt ODYsMTIgKzg2LDEyIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICBzdGF0aWMgV3Jh cHBlclR5cGVJbmZvKiBkb21XcmFwcGVyVHlwZSh2ODo6SGFuZGxlPHY4OjpPYmplY3Q+KTsKIAot ICAgICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGNvbnZlcnRFdmVudFRhcmdldFRv VjhPYmplY3QoUGFzc1JlZlB0cjxFdmVudFRhcmdldD4gZXZlbnRUYXJnZXQpCisgICAgICAgIHN0 YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gY29udmVydEV2ZW50VGFyZ2V0VG9WOE9iamVjdChQ YXNzUmVmUHRyPEV2ZW50VGFyZ2V0PiBldmVudFRhcmdldCwgdjg6Oklzb2xhdGUqIGlzb2xhdGUg PSAwKQogICAgICAgICB7Ci0gICAgICAgICAgICByZXR1cm4gY29udmVydEV2ZW50VGFyZ2V0VG9W OE9iamVjdChldmVudFRhcmdldC5nZXQoKSk7CisgICAgICAgICAgICByZXR1cm4gY29udmVydEV2 ZW50VGFyZ2V0VG9WOE9iamVjdChldmVudFRhcmdldC5nZXQoKSwgaXNvbGF0ZSk7CiAgICAgICAg IH0KIAotICAgICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGNvbnZlcnRFdmVudFRh cmdldFRvVjhPYmplY3QoRXZlbnRUYXJnZXQqKTsKKyAgICAgICAgc3RhdGljIHY4OjpIYW5kbGU8 djg6OlZhbHVlPiBjb252ZXJ0RXZlbnRUYXJnZXRUb1Y4T2JqZWN0KEV2ZW50VGFyZ2V0Kiwgdjg6 Oklzb2xhdGUqID0gMCk7CiAKICAgICAgICAgc3RhdGljIFBhc3NSZWZQdHI8RXZlbnRMaXN0ZW5l cj4gZ2V0RXZlbnRMaXN0ZW5lcih2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWx1ZSwgYm9vbCBpc0F0 dHJpYnV0ZSwgTGlzdGVuZXJMb29rdXBUeXBlIGxvb2t1cCk7CiAK