86558 2012-05-15 20:03:21 -0700 [V8] Pass Isolate to createV8HTMLWrapper() and createV8SVGWrapper() 2012-05-16 17:45:30 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 624898 0 haraken 2012-05-15 20:03:21 -0700 The objective is to pass Isolate around in V8 bindings. In this bug, we pass Isolate to createV8HTMLWrapper() and createV8SVGWrapper(). 624900 1 142133 haraken 2012-05-15 20:08:27 -0700 Created attachment 142133 Patch 626073 2 142133 webkit.review.bot 2012-05-16 17:45:25 -0700 Comment on attachment 142133 Patch Clearing flags on attachment: 142133 Committed r117371: <http://trac.webkit.org/changeset/117371> 626074 3 webkit.review.bot 2012-05-16 17:45:30 -0700 All reviewed patches have been landed. Closing bug. 142133 2012-05-15 20:08:27 -0700 2012-05-16 17:45:25 -0700 Patch bug-86558-20120516120826.patch text/plain 7063 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGY2ZWMxZTlkYzkyMTYx MzRhOTJmYWYzZDRmNDJhYjM0ZWM5NDcyMy4uZjIxZjBlOTI2NmYzYjcyZWU2ZGRlMTA2MjkwNDhl NmI3YzRiMGY3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTA1LTE1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFBhc3MgSXNv bGF0ZSB0byBjcmVhdGVWOEhUTUxXcmFwcGVyKCkgYW5kIGNyZWF0ZVY4U1ZHV3JhcHBlcigpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjU1OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBvYmplY3Rp dmUgaXMgdG8gcGFzcyBJc29sYXRlIGFyb3VuZCBpbiBWOCBiaW5kaW5ncy4KKyAgICAgICAgVGhp cyBwYXRjaCBwYXNzZXMgSXNvbGF0ZSB0byBjcmVhdGVWOEhUTUxXcmFwcGVyKCkgYW5kIGNyZWF0 ZVY4U1ZHV3JhcHBlcigpLgorCisgICAgICAgIEJhc2ljYWxseSAnaXNvbGF0ZScgaGFzIGJlZW4g aW1wbGVtZW50ZWQgYXMgdGhlIGxhc3QgYXJndW1lbnQKKyAgICAgICAgYnV0IGJlZm9yZSAnZm9y Y2VOZXdPYmplY3QnIGFyZ3VtZW50LCBiZWNhdXNlICdmb3JjZU5ld09iamVjdCcgaXMgYW4gb3B0 aW9uYWwKKyAgICAgICAgYXJndW1lbnQgYW5kIG9taXR0ZWQgaW4gbW9zdCBjYXNlcy4gRHVlIHRv IHRoZSBjb252ZW50aW9uLAorICAgICAgICB0aGlzIHBhdGNoIHB1dHMgJ2lzb2xhdGUnIGJlZm9y ZSAnZm9yY2VOZXdPYmplY3QnLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVo YXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRWxlbWVudEN1c3Rv bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b1Y4KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9j dXN0b20vVjhTVkdFbGVtZW50Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRvVjgpOgor ICAgICAgICAqIGRvbS9tYWtlX25hbWVzLnBsOgorICAgICAgICAocHJpbnRXcmFwcGVyRnVuY3Rp b25zKToKKyAgICAgICAgKHByaW50V3JhcHBlckZhY3RvcnlDcHBGaWxlKToKKyAgICAgICAgKHBy aW50V3JhcHBlckZhY3RvcnlIZWFkZXJGaWxlKToKKwogMjAxMi0wNS0xNSAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUGFzcyBBdHRyaWJ1dGUgYnkgY29uc3Qg cmVmZXJlbmNlIGFzIG11Y2ggYXMgcG9zc2libGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRWxlbWVudEN1c3RvbS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRWxlbWVudEN1c3RvbS5jcHAKaW5kZXggZGVh MTdlYzhjYzI2OWFkYWI2YTM2MzNjZWQ0ODY3YWMyMjk0N2Y4MC4uMTkyODYxMjRmMTQ2ODM1Y2Fh NmJjMzQ2ZTI4NDZkMjUxNDE4OTNiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvY3VzdG9tL1Y4SFRNTEVsZW1lbnRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxFbGVtZW50Q3VzdG9tLmNwcApAQCAtNTcsNyArNTcs NyBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdG9WOChIVE1MRWxlbWVudCogaW1wbCwgdjg6Oklz b2xhdGUqIGlzb2xhdGUsIGJvb2wgZm9yY2VOZQogewogICAgIGlmICghaW1wbCkKICAgICAgICAg cmV0dXJuIHY4OjpOdWxsKCk7Ci0gICAgcmV0dXJuIGNyZWF0ZVY4SFRNTFdyYXBwZXIoaW1wbCwg Zm9yY2VOZXdPYmplY3QpOworICAgIHJldHVybiBjcmVhdGVWOEhUTUxXcmFwcGVyKGltcGwsIGlz b2xhdGUsIGZvcmNlTmV3T2JqZWN0KTsKIH0KIAogI2lmIEVOQUJMRShNSUNST0RBVEEpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhTVkdFbGVtZW50Q3Vz dG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFNWR0VsZW1lbnRD dXN0b20uY3BwCmluZGV4IGZjY2U0NWE4NzRjYTFjMWZlODgwNzQ0ZmJjYzc3ZDUwYzY4ZGI4NTQu LmI0NDQzYzE4YTE0OTNhZDgxZjEzMmYwMzIxNDAwOWUxZmU3YWM3OTggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFNWR0VsZW1lbnRDdXN0b20uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFNWR0VsZW1lbnRDdXN0b20u Y3BwCkBAIC00MSw3ICs0MSw3IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB0b1Y4KFNWR0VsZW1l bnQqIGltcGwsIHY4OjpJc29sYXRlKiBpc29sYXRlLCBib29sIGZvcmNlTmV3CiB7CiAgICAgaWYg KCFpbXBsKQogICAgICAgICByZXR1cm4gdjg6Ok51bGwoKTsKLSAgICByZXR1cm4gY3JlYXRlVjhT VkdXcmFwcGVyKGltcGwsIGZvcmNlTmV3T2JqZWN0KTsKKyAgICByZXR1cm4gY3JlYXRlVjhTVkdX cmFwcGVyKGltcGwsIGlzb2xhdGUsIGZvcmNlTmV3T2JqZWN0KTsKIH0KIAogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL21ha2VfbmFtZXMucGwg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vbWFrZV9uYW1lcy5wbAppbmRleCA4YWIzM2Q1NWVkZDI3NWIw ZDFiZDcyZGRiNTRiYjdmZjcyY2MzMWQ5Li5hNmRjNjIzZTlhYzZkMTAwNWMzZDQ4YTg2MzI3Y2Ez NzJmOGM5ZWJmIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vbWFrZV9uYW1lcy5wbAor KysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vbWFrZV9uYW1lcy5wbApAQCAtMTAzNSwxMiArMTAzNSwx MiBAQCBFTkQKICAgICAgICAgfSBlbHNpZiAoJHdyYXBwZXJGYWN0b3J5VHlwZSBlcSAiVjgiKSB7 CiAgICAgICAgICAgICBpZiAoJGVuYWJsZWRUYWdzeyR0YWdOYW1lfXt3cmFwcGVyT25seUlmTWVk aWFJc0F2YWlsYWJsZX0pIHsKICAgICAgICAgICAgICAgICBwcmludCBGIDw8RU5ECi1zdGF0aWMg djg6OkhhbmRsZTx2ODo6VmFsdWU+IGNyZWF0ZSR7SlNJbnRlcmZhY2VOYW1lfVdyYXBwZXIoJHBh cmFtZXRlcnN7bmFtZXNwYWNlfUVsZW1lbnQqIGVsZW1lbnQpCitzdGF0aWMgdjg6OkhhbmRsZTx2 ODo6VmFsdWU+IGNyZWF0ZSR7SlNJbnRlcmZhY2VOYW1lfVdyYXBwZXIoJHBhcmFtZXRlcnN7bmFt ZXNwYWNlfUVsZW1lbnQqIGVsZW1lbnQsIHY4OjpJc29sYXRlKiBpc29sYXRlKQogewogICAgIFNl dHRpbmdzKiBzZXR0aW5ncyA9IGVsZW1lbnQtPmRvY3VtZW50KCktPnNldHRpbmdzKCk7CiAgICAg aWYgKCFNZWRpYVBsYXllcjo6aXNBdmFpbGFibGUoKSB8fCAoc2V0dGluZ3MgJiYgIXNldHRpbmdz LT5pc01lZGlhRW5hYmxlZCgpKSkKLSAgICAgICAgcmV0dXJuIFY4JHBhcmFtZXRlcnN7bmFtZXNw YWNlfUVsZW1lbnQ6OndyYXAoZWxlbWVudCk7Ci0gICAgcmV0dXJuIHRvVjgoc3RhdGljX2Nhc3Q8 JHtKU0ludGVyZmFjZU5hbWV9Kj4oZWxlbWVudCkpOworICAgICAgICByZXR1cm4gVjgkcGFyYW1l dGVyc3tuYW1lc3BhY2V9RWxlbWVudDo6d3JhcChlbGVtZW50LCBpc29sYXRlKTsKKyAgICByZXR1 cm4gdG9WOChzdGF0aWNfY2FzdDwke0pTSW50ZXJmYWNlTmFtZX0qPihlbGVtZW50KSwgaXNvbGF0 ZSk7CiB9CiAKIEVORApAQCAtMTA0OCwyOCArMTA0OCwyOCBAQCBFTkQKICAgICAgICAgICAgIH0g ZWxzaWYgKCRlbmFibGVkVGFnc3skdGFnTmFtZX17cnVudGltZUNvbmRpdGlvbmFsfSkgewogICAg ICAgICAgICAgICAgIG15ICRydW50aW1lQ29uZGl0aW9uYWwgPSAkZW5hYmxlZFRhZ3N7JHRhZ05h bWV9e3J1bnRpbWVDb25kaXRpb25hbH07CiAgICAgICAgICAgICAgICAgcHJpbnQgRiA8PEVORAot c3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjcmVhdGUke0pTSW50ZXJmYWNlTmFtZX1XcmFw cGVyKCRwYXJhbWV0ZXJze25hbWVzcGFjZX1FbGVtZW50KiBlbGVtZW50KQorc3RhdGljIHY4OjpI YW5kbGU8djg6OlZhbHVlPiBjcmVhdGUke0pTSW50ZXJmYWNlTmFtZX1XcmFwcGVyKCRwYXJhbWV0 ZXJze25hbWVzcGFjZX1FbGVtZW50KiBlbGVtZW50LCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsK ICAgICBpZiAoIVJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OiR7cnVudGltZUNvbmRpdGlvbmFsfUVu YWJsZWQoKSkKLSAgICAgICAgcmV0dXJuIFY4JHBhcmFtZXRlcnN7ZmFsbGJhY2tJbnRlcmZhY2VO YW1lfTo6d3JhcCh0byRwYXJhbWV0ZXJze2ZhbGxiYWNrSW50ZXJmYWNlTmFtZX0oZWxlbWVudCkp OwotICAgIHJldHVybiB0b1Y4KHN0YXRpY19jYXN0PCR7SlNJbnRlcmZhY2VOYW1lfSo+KGVsZW1l bnQpKTsKKyAgICAgICAgcmV0dXJuIFY4JHBhcmFtZXRlcnN7ZmFsbGJhY2tJbnRlcmZhY2VOYW1l fTo6d3JhcCh0byRwYXJhbWV0ZXJze2ZhbGxiYWNrSW50ZXJmYWNlTmFtZX0oZWxlbWVudCksIGlz b2xhdGUpOworICAgIHJldHVybiB0b1Y4KHN0YXRpY19jYXN0PCR7SlNJbnRlcmZhY2VOYW1lfSo+ KGVsZW1lbnQpLCBpc29sYXRlKTsKIH0KIEVORAogOwogICAgICAgICAgICAgfSBlbHNpZiAoJHtK U0ludGVyZmFjZU5hbWV9IGVxICJIVE1MRWxlbWVudCIpIHsKICAgICAgICAgICAgICAgICBwcmlu dCBGIDw8RU5ECi1zdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGNyZWF0ZSR7SlNJbnRlcmZh Y2VOYW1lfVdyYXBwZXIoJHBhcmFtZXRlcnN7bmFtZXNwYWNlfUVsZW1lbnQqIGVsZW1lbnQpCitz dGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGNyZWF0ZSR7SlNJbnRlcmZhY2VOYW1lfVdyYXBw ZXIoJHBhcmFtZXRlcnN7bmFtZXNwYWNlfUVsZW1lbnQqIGVsZW1lbnQsIHY4OjpJc29sYXRlKiBp c29sYXRlKQogewotICAgIHJldHVybiBWOCRwYXJhbWV0ZXJze25hbWVzcGFjZX1FbGVtZW50Ojp3 cmFwKGVsZW1lbnQpOworICAgIHJldHVybiBWOCRwYXJhbWV0ZXJze25hbWVzcGFjZX1FbGVtZW50 Ojp3cmFwKGVsZW1lbnQsIGlzb2xhdGUpOwogfQogCiBFTkQKIDsKICAgICAgICAgICAgICB9IGVs c2UgewogICAgICAgICAgICAgcHJpbnQgRiA8PEVORAotc3RhdGljIHY4OjpIYW5kbGU8djg6OlZh bHVlPiBjcmVhdGUke0pTSW50ZXJmYWNlTmFtZX1XcmFwcGVyKCRwYXJhbWV0ZXJze25hbWVzcGFj ZX1FbGVtZW50KiBlbGVtZW50KQorc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjcmVhdGUk e0pTSW50ZXJmYWNlTmFtZX1XcmFwcGVyKCRwYXJhbWV0ZXJze25hbWVzcGFjZX1FbGVtZW50KiBl bGVtZW50LCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKLSAgICByZXR1cm4gdG9WOChzdGF0aWNf Y2FzdDwke0pTSW50ZXJmYWNlTmFtZX0qPihlbGVtZW50KSk7CisgICAgcmV0dXJuIHRvVjgoc3Rh dGljX2Nhc3Q8JHtKU0ludGVyZmFjZU5hbWV9Kj4oZWxlbWVudCksIGlzb2xhdGUpOwogfQogCiAK QEAgLTExNTEsNyArMTE1MSw3IEBAIEVORAogOwogICAgIH0gZWxzaWYgKCR3cmFwcGVyRmFjdG9y eVR5cGUgZXEgIlY4IikgewogICAgICAgICBwcmludCBGIDw8RU5ECi10eXBlZGVmIHY4OjpIYW5k bGU8djg6OlZhbHVlPiAoKkNyZWF0ZSRwYXJhbWV0ZXJze25hbWVzcGFjZX1FbGVtZW50V3JhcHBl ckZ1bmN0aW9uKSgkcGFyYW1ldGVyc3tuYW1lc3BhY2V9RWxlbWVudCopOwordHlwZWRlZiB2ODo6 SGFuZGxlPHY4OjpWYWx1ZT4gKCpDcmVhdGUkcGFyYW1ldGVyc3tuYW1lc3BhY2V9RWxlbWVudFdy YXBwZXJGdW5jdGlvbikoJHBhcmFtZXRlcnN7bmFtZXNwYWNlfUVsZW1lbnQqLCB2ODo6SXNvbGF0 ZSopOwogCiBFTkQKIDsKQEAgLTExNzAsNyArMTE3MCw3IEBAIEVORAogOwogICAgIH0gZWxzaWYg KCR3cmFwcGVyRmFjdG9yeVR5cGUgZXEgIlY4IikgewogICAgICAgICBwcmludCBGIDw8RU5ECi12 ODo6SGFuZGxlPHY4OjpWYWx1ZT4gY3JlYXRlVjgkcGFyYW1ldGVyc3tuYW1lc3BhY2V9V3JhcHBl cigkcGFyYW1ldGVyc3tuYW1lc3BhY2V9RWxlbWVudCogZWxlbWVudCwgYm9vbCBmb3JjZU5ld09i amVjdCkKK3Y4OjpIYW5kbGU8djg6OlZhbHVlPiBjcmVhdGVWOCRwYXJhbWV0ZXJze25hbWVzcGFj ZX1XcmFwcGVyKCRwYXJhbWV0ZXJze25hbWVzcGFjZX1FbGVtZW50KiBlbGVtZW50LCB2ODo6SXNv bGF0ZSogaXNvbGF0ZSwgYm9vbCBmb3JjZU5ld09iamVjdCkKIHsKICAgICB0eXBlZGVmIEhhc2hN YXA8V1RGOjpBdG9taWNTdHJpbmdJbXBsKiwgQ3JlYXRlJHBhcmFtZXRlcnN7bmFtZXNwYWNlfUVs ZW1lbnRXcmFwcGVyRnVuY3Rpb24+IEZ1bmN0aW9uTWFwOwogICAgIERFRklORV9TVEFUSUNfTE9D QUwoRnVuY3Rpb25NYXAsIG1hcCwgKCkpOwpAQCAtMTIxMSw3ICsxMjExLDcgQEAgRU5ECiA7CiAg ICAgfSBlbHNpZiAoJHdyYXBwZXJGYWN0b3J5VHlwZSBlcSAiVjgiKSB7CiAgICAgICAgIHByaW50 IEYgPDxFTkQKLSAgICAgICAgcmV0dXJuIGNyZWF0ZVdyYXBwZXJGdW5jdGlvbihlbGVtZW50KTsK KyAgICAgICAgcmV0dXJuIGNyZWF0ZVdyYXBwZXJGdW5jdGlvbihlbGVtZW50LCBpc29sYXRlKTsK ICAgICByZXR1cm4gVjgkcGFyYW1ldGVyc3tmYWxsYmFja0ludGVyZmFjZU5hbWV9Ojp3cmFwKHRv JHBhcmFtZXRlcnN7ZmFsbGJhY2tJbnRlcmZhY2VOYW1lfShlbGVtZW50KSwgMCwgZm9yY2VOZXdP YmplY3QpOwogRU5ECiA7CkBAIC0xMjcyLDcgKzEyNzIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKICAgICBjbGFzcyAkcGFyYW1ldGVyc3tuYW1lc3BhY2V9RWxlbWVudDsKIAotICAgIHY4OjpI YW5kbGU8djg6OlZhbHVlPiBjcmVhdGVWOCRwYXJhbWV0ZXJze25hbWVzcGFjZX1XcmFwcGVyKCRw YXJhbWV0ZXJze25hbWVzcGFjZX1FbGVtZW50KiwgYm9vbCk7CisgICAgdjg6OkhhbmRsZTx2ODo6 VmFsdWU+IGNyZWF0ZVY4JHBhcmFtZXRlcnN7bmFtZXNwYWNlfVdyYXBwZXIoJHBhcmFtZXRlcnN7 bmFtZXNwYWNlfUVsZW1lbnQqLCB2ODo6SXNvbGF0ZSosIGJvb2wpOwogfQogRU5ECiA7Cg==