86315 2012-05-13 02:14:16 -0700 Styles are not recalculated when the seamless attribute is dynamically added/removed 2012-05-15 02:47:47 -0700 1 1 1 Unclassified WebKit Frames 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 45950 1 pimvdb eric eric jamesr jchaffraix kling koivisto ojan webkit.review.bot oldest_to_newest 622482 0 pimvdb 2012-05-13 02:14:16 -0700 Scenario: A main page with a seamless iframe and an iframe page. The main page has CSS "color: red" applied to "body". Both the main page and the iframe page have text, which initially is both colored red (as expected). Problems: When the seamless attribute is removed, the iframe page should lose its inherited color style. So, the iframe page should get black text, but it stays red. Using the inspector to select an element on the parent page (e.g. the html element) *does* make the text color to be updated to black. Also (without the attribute removed), when the main web page gets another color set such as blue, then the main web page gets blue text but the iframe page stays red. The inspector trick does not seem to work here. I believe this is a bug because the HTML5 spec says: "The attribute can be set or removed dynamically, with the rendering updating in tandem." I'll try to attach a test case, but it's tricky because there are two HTML files involved (main page and parent page). 622483 1 141601 pimvdb 2012-05-13 02:14:55 -0700 Created attachment 141601 Test case - main page 622484 2 141602 pimvdb 2012-05-13 02:15:24 -0700 Created attachment 141602 Test case - iframe page 623449 3 eric 2012-05-14 16:47:19 -0700 This sounds like two (great) bugs. I'm working on bug #1 now. We'll have to split this bug into two to solve both. 623483 4 eric 2012-05-14 17:23:25 -0700 Bug #2 is not actually a bug in the code, but a bug in your test. :) The body { } selector is inherited by the child iframe, so even though you change the color on the outer body, it will not be changed on the inner body, since a more specific selector applies. :) 623494 5 141826 eric 2012-05-14 17:31:55 -0700 Created attachment 141826 Patch 623495 6 eric 2012-05-14 17:34:12 -0700 Thank you for the great bug! I look forward to many more. :) The layout changes for seamless should land in the next couple days, at which point it should begin being actually useful. :) Right now we have only landed the style inheritance, stylesheet inheritance, and navigational changes. The dynamic sizing/layout code will be in my next patch. 623511 7 eric 2012-05-14 17:45:34 -0700 I've heard that Antti and Kling are perhaps familiar with the world of style as well. :) 623536 8 141826 kling 2012-05-14 18:18:56 -0700 Comment on attachment 141826 Patch Looks fabulous, r=me 623619 9 141826 webkit.review.bot 2012-05-14 21:35:47 -0700 Comment on attachment 141826 Patch Clearing flags on attachment: 141826 Committed r117026: <http://trac.webkit.org/changeset/117026> 623620 10 webkit.review.bot 2012-05-14 21:35:52 -0700 All reviewed patches have been landed. Closing bug. 623848 11 pimvdb 2012-05-15 02:47:47 -0700 Whoops, bug #2 is indeed my own fault. Sorry about that. Thanks for the very quick response and patch. 141601 2012-05-13 02:14:55 -0700 2012-05-13 02:14:55 -0700 Test case - main page seamless_iframe_main.html text/html 507 pimvdb PCFkb2N0eXBlIGh0bWw+DQo8aHRtbD4NCiAgPGhlYWQ+DQogICAgPHRpdGxlPm1haW48L3RpdGxl Pg0KDQogICAgPHN0eWxlPg0KICAgICAgYm9keSB7DQogICAgICAgIGNvbG9yOiByZWQ7DQogICAg ICB9DQogICAgPC9zdHlsZT4NCiAgPC9oZWFkPg0KDQogIDxib2R5Pg0KICAgIDxhIGhyZWY9IiMi IG9uY2xpY2s9ImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdpZnJhbWUnKS5yZW1vdmVBdHRyaWJ1 dGUoJ3NlYW1sZXNzJyk7Ij5SZW1vdmUgc2VhbWxlc3MgYXR0cmlidXRlPC9hPg0KICAgIDxhIGhy ZWY9IiMiIG9uY2xpY2s9ImRvY3VtZW50LmJvZHkuc3R5bGUuY29sb3IgPSAnYmx1ZSc7Ij5DaGFu Z2UgbWFpbiBwYWdlIHN0eWxlPC9hPg0KICAgIDxicj4NCiAgICB0ZXh0IG9uIG1haW4gcGFnZQ0K ICAgIDxicj4NCiAgICA8aWZyYW1lIHNlYW1sZXNzIGlkPSJpZnJhbWUiIHNyYz0ic2VhbWxlc3Nf aWZyYW1lX2lmcmFtZS5odG1sIj48L2lmcmFtZT4NCiAgPC9ib2R5Pg0KPC9odG1sPg0K 141602 2012-05-13 02:15:24 -0700 2012-05-13 02:15:24 -0700 Test case - iframe page seamless_iframe_iframe.html text/html 130 pimvdb PCFkb2N0eXBlIGh0bWw+DQo8aHRtbD4NCiAgPGhlYWQ+DQogICAgPHRpdGxlPmlmcmFtZTwvdGl0 bGU+DQogIDwvaGVhZD4NCg0KICA8Ym9keT4NCiAgICB0ZXh0IG9uIGlmcmFtZSBwYWdlDQogIDwv Ym9keT4NCjwvaHRtbD4NCg== 141826 2012-05-14 17:31:55 -0700 2012-05-14 21:35:46 -0700 Patch bug-86315-20120514173153.patch text/plain 5807 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2M4MDQ5MDgxNzkxNWVl Mzg0YWVjNjI2OGIwNWNkNTU2NWQyNjZkNC4uMmM3OGVmZGZhN2U5Y2ZjNDEyN2M0ODRiZjRkYTYz ZDNjZTY4MjAyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA1LTE0ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBTdHlsZXMgYXJlIG5vdCByZWNh bGN1bGF0ZWQgd2hlbiB0aGUgc2VhbWxlc3MgYXR0cmlidXRlIGlzIGR5bmFtaWNhbGx5IGFkZGVk L3JlbW92ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg2MzE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q292ZXJlZCBieSBmYXN0L2ZyYW1lcy9zZWFtbGVzcy9zZWFtbGVzcy1jc3MtY2FzY2FkZS5odG1s LgorCisgICAgICAgICogaHRtbC9IVE1MSUZyYW1lRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpIVE1MSUZyYW1lRWxlbWVudDo6aXNQcmVzZW50YXRpb25BdHRyaWJ1dGUpOgorICAgICAg ICAgLSBNYWtlIHNlYW1sZXNzIGEgcHJlc2VudGF0aW9uYWwgYXR0cmlidXRlLCB3aGljaCBtZWFu cyBzdHlsZSBvbiB0aGUgPGlmcmFtZT4gd2lsbAorICAgICAgICAgICBiZSBmb3JjZWQgdG8gcmVj YWxjdWxhdGUgd2hlbiBpdCBjaGFuZ2VzLiAgVGhpcyBpcyBjb3JyZWN0LCBidXQgbm90IG9ic2Vy dmFibGUKKyAgICAgICAgICAgdW50aWwgdGhlIGxheW91dCBjaGFuZ2VzIGFyZSBsYW5kZWQgKGFz IHRoZW4gdGhlIGlmcmFtZSBzaG91bGQgY29ycmVjdGx5IHJldmVydCB0byBub3QKKyAgICAgICAg ICAgYmVpbmcgc2l6ZWQgdG8gZml0IGl0cyBjb250ZW50IGlmIHNlYW1sZXNzIGlzIHJlbW92ZWQp LgorICAgICAgICAoV2ViQ29yZTo6SFRNTElGcmFtZUVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKToK KyAgICAgICAgIC0gV2hlbiB0aGUgc2VhbWxlc3MgYXR0cmlidXRlIGlzIGFkZGVkIG9yIHJlbW92 ZSwgZm9yY2UgdGhlIGNvbnRlbnQgZG9jdW1lbnQgdG8gcmVjYWxjCisgICAgICAgICAgIGl0cyBz dHlsZSByZXNvbHZlciwgd2hpY2ggd2lsbCByZWZyZXNoIHRoZSBsaXN0IG9mIGluaGVyaXRlZCBz dHlsZXNoZWV0cyBmcm9tIHRoZQorICAgICAgICAgICBwYXJlbnQuICBUaGlzIGRvZXNuJ3QgbmVl ZCB0byBoYXBwZW4gc3luY2hyb25vdXNseS4gIFdoZW4gdGhlIGxheW91dCBjaGFuZ2VzIGxhbmQK KyAgICAgICAgICAgdGhlIGNvbnRlbnQgZG9jdW1lbnQgd2lsbCBhY3R1YWxseSBjYXVzZSB0aGF0 IHJlY2FsYyB0byByZWRpcmVjdCB0byB0aGUgcGFyZW50IGRvY3VtZW50CisgICAgICAgICAgIGlu IHRoZSBzZWFtbGVzcyBjYXNlIGFueXdheSwgYnV0IGl0J3MgbW9yZSBjb3JyZWN0IHRvIGFzayB0 aGUgY29udGVudCBkb2N1bWVudCBkaXJlY3RseS4KKwogMjAxMi0wNS0xNCAgVGFrYXNoaSBTYWth bW90byAgPHRhc2FrQGdvb2dsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggaW4gV2ViQ29yZTo6UmVu ZGVyT2JqZWN0OjpyZXBhaW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJ RnJhbWVFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElGcmFtZUVsZW1lbnQu Y3BwCmluZGV4IGM3ZTE1N2U3MzQwZDFjYjYyOTBhNzcyZjkyNmQxNDMxY2M3YmE0MzEuLjA0Mjgz OGQ1MTQ3MWRjOGNmYmQyMWU5NTVmNDI3MWI0YWFhMDNjZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTElGcmFtZUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTElGcmFtZUVsZW1lbnQuY3BwCkBAIC01MSw3ICs1MSw3IEBAIFBhc3NSZWZQdHI8SFRN TElGcmFtZUVsZW1lbnQ+IEhUTUxJRnJhbWVFbGVtZW50OjpjcmVhdGUoY29uc3QgUXVhbGlmaWVk TmFtZSYgdGFnCiAKIGJvb2wgSFRNTElGcmFtZUVsZW1lbnQ6OmlzUHJlc2VudGF0aW9uQXR0cmli dXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIG5hbWUpIGNvbnN0CiB7Ci0gICAgaWYgKG5hbWUgPT0g d2lkdGhBdHRyIHx8IG5hbWUgPT0gaGVpZ2h0QXR0ciB8fCBuYW1lID09IGFsaWduQXR0ciB8fCBu YW1lID09IGZyYW1lYm9yZGVyQXR0cikKKyAgICBpZiAobmFtZSA9PSB3aWR0aEF0dHIgfHwgbmFt ZSA9PSBoZWlnaHRBdHRyIHx8IG5hbWUgPT0gYWxpZ25BdHRyIHx8IG5hbWUgPT0gZnJhbWVib3Jk ZXJBdHRyIHx8IG5hbWUgPT0gc2VhbWxlc3NBdHRyKQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICByZXR1cm4gSFRNTEZyYW1lRWxlbWVudEJhc2U6OmlzUHJlc2VudGF0aW9uQXR0cmlidXRlKG5h bWUpOwogfQpAQCAtODcsNyArODcsMTEgQEAgdm9pZCBIVE1MSUZyYW1lRWxlbWVudDo6cGFyc2VB dHRyaWJ1dGUoQXR0cmlidXRlKiBhdHRyKQogICAgICAgICBtX25hbWUgPSBuZXdOYW1lOwogICAg IH0gZWxzZSBpZiAoYXR0ci0+bmFtZSgpID09IHNhbmRib3hBdHRyKQogICAgICAgICBzZXRTYW5k Ym94RmxhZ3MoYXR0ci0+aXNOdWxsKCkgPyBTYW5kYm94Tm9uZSA6IFNlY3VyaXR5Q29udGV4dDo6 cGFyc2VTYW5kYm94UG9saWN5KGF0dHItPnZhbHVlKCkpKTsKLSAgICBlbHNlCisgICAgZWxzZSBp ZiAoYXR0ci0+bmFtZSgpID09IHNlYW1sZXNzQXR0cikgeworICAgICAgICAvLyBJZiB3ZSdyZSBh ZGRpbmcgb3IgcmVtb3ZpbmcgdGhlIHNlYW1sZXNzIGF0dHJpYnV0ZSwgd2UgbmVlZCB0byBmb3Jj ZSB0aGUgY29udGVudCBkb2N1bWVudCB0byByZWNhbGN1bGF0ZSBpdHMgU3R5bGVSZXNvbHZlci4K KyAgICAgICAgaWYgKGNvbnRlbnREb2N1bWVudCgpKQorICAgICAgICAgICAgY29udGVudERvY3Vt ZW50KCktPnN0eWxlUmVzb2x2ZXJDaGFuZ2VkKERlZmVyUmVjYWxjU3R5bGUpOworICAgIH0gZWxz ZQogICAgICAgICBIVE1MRnJhbWVFbGVtZW50QmFzZTo6cGFyc2VBdHRyaWJ1dGUoYXR0cik7CiB9 CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCA2NjFlNWQ1MjFjOGMxZTU0NTdmZTMwYmUzN2MxN2Y0Yjc1YTFkNGJlLi5hY2Vj YmNiMmVjYzk2Y2U4YzE3NjkyZWJlNjdkNGJiMzc0ZjU5MTRmIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDUtMTQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IFN0eWxlcyBhcmUgbm90IHJlY2FsY3VsYXRlZCB3aGVuIHRoZSBzZWFtbGVzcyBhdHRyaWJ1dGUg aXMgZHluYW1pY2FsbHkgYWRkZWQvcmVtb3ZlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYzMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgYSBzdWJ0ZXN0IHRvIGNvdmVyIHRoaXMgY2FzZS4KKwor ICAgICAgICAqIGZhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWNzcy1jYXNjYWRlLWV4cGVj dGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2ZyYW1lcy9zZWFtbGVzcy9zZWFtbGVzcy1jc3MtY2Fz Y2FkZS5odG1sOgorCiAyMDEyLTA1LTE0ICBUYWthc2hpIFNha2Ftb3RvICA8dGFzYWtAZ29vZ2xl LmNvbT4KIAogICAgICAgICBDcmFzaCBpbiBXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OnJlcGFpbnQK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWNz cy1jYXNjYWRlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NlYW1sZXNz L3NlYW1sZXNzLWNzcy1jYXNjYWRlLWV4cGVjdGVkLnR4dAppbmRleCAxZmNlNDA2NDRlZDY1ZTAy YjkxYjg2MDliOTcwY2Q5Mjg2ZDUyODEyLi40ZmEwNjFmYTViMDEyYTI4MDQ3YTg2ZGNlMWI3NDY1 N2FlNGU2NGNlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9zZWFtbGVzcy9z ZWFtbGVzcy1jc3MtY2FzY2FkZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9m cmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3MtY3NzLWNhc2NhZGUtZXhwZWN0ZWQudHh0CkBAIC01LDQg KzUsNyBAQCBQQVNTIHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKHRocmVlKS5jb2xvciBpcyAicmdi KDI1NSwgMjU1LCAyNTUpIgogUEFTUyB3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShyb290RWxlbWVu dCkuY29sb3IgaXMgInJnYigyNTUsIDE2NSwgMCkiCiBQQVNTIHdpbmRvdy5nZXRDb21wdXRlZFN0 eWxlKHJvb3RFbGVtZW50KS5jb2xvciBpcyAicmdiKDEsIDIsIDMpIgogUEFTUyB3aW5kb3cuZ2V0 Q29tcHV0ZWRTdHlsZShvbmUpLmNvbG9yIGlzICJyZ2IoMywgMiwgMSkiCitQQVNTIHdpbmRvdy5n ZXRDb21wdXRlZFN0eWxlKG9uZSkuY29sb3IgaXMgInJnYigwLCAwLCAwKSIKK1BBU1Mgd2luZG93 LmdldENvbXB1dGVkU3R5bGUodHdvKS5jb2xvciBpcyAicmdiKDEyOCwgMCwgMTI4KSIKK1BBU1Mg d2luZG93LmdldENvbXB1dGVkU3R5bGUodGhyZWUpLmNvbG9yIGlzICJyZ2IoMCwgMCwgMCkiCiAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWNz cy1jYXNjYWRlLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9zZWFtbGVzcy9zZWFtbGVz cy1jc3MtY2FzY2FkZS5odG1sCmluZGV4IGFiNmE5NTdjNGEzNmUyMjlhMjY4N2Q5MmRiZGFmZjRl MTdkNjZlZWUuLmM1MDliYjE3ZjhhNTM2ZDJjNjdiMjdlZWU3NmEwZjcwZDFmYzI5MmQgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3NlYW1sZXNzL3NlYW1sZXNzLWNzcy1jYXNj YWRlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxlc3Mt Y3NzLWNhc2NhZGUuaHRtbApAQCAtNDIsNSArNDIsMTEgQEAgd2luZG93Lm9ubG9hZCA9IGZ1bmN0 aW9uICgpIHsKICAgICBkb2N1bWVudC5oZWFkLmFwcGVuZENoaWxkKHN0eWxlU2hlZXQpOwogICAg IC8vICNvbmUncyBzdHlsZSBpcyBvbmx5IHNwZWNpZmllZCBieSB0aGlzIHBhcmVudCwgc28gYWRk aW5nIGEgbGF0ZXIgc2hlZXQgc2hvdWxkIG92ZXJyaWRlIHRoZSBjb2xvciBhbmQgdXBkYXRlIHRo ZSBjaGlsZCBmcmFtZS4KICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoIndpbmRvdy5nZXRDb21w dXRlZFN0eWxlKG9uZSkuY29sb3IiLCAicmdiKDMsIDIsIDEpIik7CisKKyAgICAvLyBUZXN0IHRo YXQgcmVtb3ZpbmcgdGhlIHNlYW1sZXNzIGF0dHJpYnV0ZSByZWNhbGN1bGF0ZXMgdGhlIGNoaWxk J3Mgc3R5bGUuCisgICAgd2luZG93LmlmcmFtZS5yZW1vdmVBdHRyaWJ1dGUoInNlYW1sZXNzIik7 CisgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJ3aW5kb3cuZ2V0Q29tcHV0ZWRTdHlsZShvbmUp LmNvbG9yIiwgInJnYigwLCAwLCAwKSIpOyAvLyBibGFjaywgZGVmYXVsdC4KKyAgICBzaG91bGRC ZUVxdWFsVG9TdHJpbmcoIndpbmRvdy5nZXRDb21wdXRlZFN0eWxlKHR3bykuY29sb3IiLCAicmdi KDEyOCwgMCwgMTI4KSIpOyAvLyBwdXJwbGUsIHNlbGVjdG9yIGluIGNoaWxkLgorICAgIHNob3Vs ZEJlRXF1YWxUb1N0cmluZygid2luZG93LmdldENvbXB1dGVkU3R5bGUodGhyZWUpLmNvbG9yIiwg InJnYigwLCAwLCAwKSIpOyAvLyBibGFjaywgZGVmYXVsdC4KIH0KIDwvc2NyaXB0Pgo=