86200 2012-05-11 05:44:11 -0700 [EFL] fast/events/arrow-keys-on-body.html does not pass 2012-05-22 11:17:14 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 85503 0 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 621523 0 mikhail.pozdnyakov 2012-05-11 05:44:11 -0700 fast/events/arrow-keys-on-body.html wrong test result, keypress should not be emitted. 621550 1 mikhail.pozdnyakov 2012-05-11 06:07:56 -0700 Keypress event should be raised by noncharacter keys. 621561 2 141397 mikhail.pozdnyakov 2012-05-11 06:25:34 -0700 Created attachment 141397 Fix. Non-characters keys have empty text value. This patch should be applied after bug85503 is landed, as bug85503 fixes windowsKeyMap population. 621588 3 rakuco 2012-05-11 06:47:33 -0700 LGTM. 622612 4 141397 gyuyoung.kim 2012-05-13 19:18:58 -0700 Comment on attachment 141397 Fix. Looks fine too. 625364 5 141397 webkit.review.bot 2012-05-16 06:50:40 -0700 Comment on attachment 141397 Fix. Rejecting attachment 141397 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: fset -113 lines). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/efl/EflKeyboardUtilities.cpp Hunk #1 succeeded at 202 (offset 12 lines). Hunk #2 FAILED at 215. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/efl/EflKeyboardUtilities.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12703792 625372 6 142247 mikhail.pozdnyakov 2012-05-16 06:59:01 -0700 Created attachment 142247 to be landed. 625403 7 142247 rakuco 2012-05-16 07:26:33 -0700 Comment on attachment 142247 to be landed. Hmm. Can you check if your change is still needed after r117218? 625421 8 mikhail.pozdnyakov 2012-05-16 07:39:57 -0700 (In reply to comment #7) > (From update of attachment 142247 [details]) > Hmm. Can you check if your change is still needed after r117218? I guess might make sense, r117218 is touching EventSender which is part of DRT. Changes in this bug are part of core where I think the values still should be checked. 625446 9 rakuco 2012-05-16 08:13:09 -0700 (In reply to comment #8) > (In reply to comment #7) > > Hmm. Can you check if your change is still needed after r117218? > > I guess might make sense, r117218 is touching EventSender which is part of DRT. > Changes in this bug are part of core where I think the values still should be checked. r117218 completely solves the problem when the code path is reached via DRT, right? Then it would be good to check if this is something that can happen via normal user interaction as well, that is, check how ecore_evas initializes the event structure passed to evas -- I can't remember how it initializes the string member off the top of my head. 625622 10 mikhail.pozdnyakov 2012-05-16 10:40:40 -0700 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > Hmm. Can you check if your change is still needed after r117218? > > > > I guess might make sense, r117218 is touching EventSender which is part of DRT. > > Changes in this bug are part of core where I think the values still should be checked. > > r117218 completely solves the problem when the code path is reached via DRT, right? Then it would be good to check if this is something that can happen via normal user interaction as well, that is, check how ecore_evas initializes the event structure passed to evas -- I can't remember how it initializes the string member off the top of my head. from http://docs.enlightenment.org/auto/evas/group__Evas__Event__Feeding__Group.html : void evas_event_feed_key_down (Evas * e, const char * keyname, const char * key, const char * string, const char * compose, unsigned int timestamp, const void * data ) Key down event feed. Parameters: e The canvas to thaw out keyname Name of the key key The key pressed. string A String compose The compose string timestamp Timestamp of the mouse up event data Data for canvas. The situations like evas_event_feed_key_down(evas, "Left", "Left", "some garbage that will turn up in webkit PlatformKeyboardEvent", 0, 0, 0); are quite possible. 627457 11 mikhail.pozdnyakov 2012-05-18 01:20:35 -0700 > The situations like > > evas_event_feed_key_down(evas, "Left", "Left", "some garbage that will turn up in webkit PlatformKeyboardEvent", 0, 0, 0); > > are quite possible. And this will lead to appearance of unneeded Keypress events. 627680 12 rakuco 2012-05-18 07:31:26 -0700 We have discussed this on IRC, and agreed to only unskip the test that is already passing. I've done so in <http://trac.webkit.org/changeset/117591>. The rationale is that right now ecore and evas do not have a cross-backend way of representing keys (like what's present in gdk and Qt), and the current implementation in EflKeyboardUtilities.cpp is only expected to work with the ecore_x xlib backend. We therefore do not expect people to do what was cited in comment #11, and so we have decided not to fix what is not broken. 627681 13 rakuco 2012-05-18 07:32:15 -0700 Closing for now -- if we do find some problem in the future, we can revisit this patch. 141397 2012-05-11 06:25:34 -0700 2012-05-16 06:59:01 -0700 Fix. bug86200 text/plain 2927 mikhail.pozdnyakov Y29tbWl0IGFjZmY4YmViODVkNTk5Zjc0OTQ3MjI4YjFiZWY3ZjY4NmIxMjMzNTEKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg RnJpIE1heSAxMSAxNjoxOTo1NiAyMDEyICswMzAwCgogICAgYnVnODYyMDAKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmQx MWJkNi4uZmZhZWEwNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA1LTExICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtF RkxdIGZhc3QvZXZlbnRzL2Fycm93LWtleXMtb24tYm9keS5odG1sIGRvZXMgbm90IHBhc3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2MjAwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9l ZmwvU2tpcHBlZDogdW5za2lwcGVkIGZhc3QvZXZlbnRzL2Fycm93LWtleXMtb24tYm9keS5odG1s LgorCiAyMDEyLTA1LTEwICBKaWFuIExpICA8amlhbmxpQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkIGNocm9taXVtIGdhcmRlbmluZy4gVXBkYXRlZCBmYWlsZWQgdGVzdHMuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2VmbC9Ta2lwcGVkCmluZGV4IDhkOTU5M2YuLmYzNTI4ZWIgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2VmbC9Ta2lwcGVkCkBAIC04NzcsOSArODc3LDYgQEAgZmFzdC9kb20vV2luZG93L3dpbmRv dy1yZXNpemUuaHRtbAogIyBCVUc6IHdpbmRvdyBoYXMgd3JvbmcgcGl4ZWwgYW5kIGNvbG9yIGRl cHRoCiBmYXN0L2RvbS9XaW5kb3cvd2luZG93LXNjcmVlbi1wcm9wZXJ0aWVzLmh0bWwKIAotIyBC VUc6IHdyb25nIHRlc3QgcmVzdWx0LCBrZXlwcmVzcyBzaG91bGQgbm90IGJlIGVtaXR0ZWQKLWZh c3QvZXZlbnRzL2Fycm93LWtleXMtb24tYm9keS5odG1sCi0KICMgQlVHOiB3cm9uZyB0ZXN0IHJl c3VsdCwgd2luZG93IHNob3VsZCBub3QgaGF2ZSBiZWVuIHNjcm9sbGVkCiBmYXN0L2V2ZW50cy9h dHRlbXB0LXNjcm9sbC13aXRoLW5vLXNjcm9sbGJhcnMuaHRtbAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmY2 ODRjYy4uMmFjZTVlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTExICBN aWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAg ICAgIFtFRkxdIGZhc3QvZXZlbnRzL2Fycm93LWtleXMtb24tYm9keS5odG1sIGRvZXMgbm90IHBh c3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2MjAw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm9uY2hh cmFjdGVyIGtleXMgcmV0dXJuIGVtcHR5IHRleHQgdmFsdWUuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9lZmwvRWZsS2V5Ym9hcmRVdGlsaXRpZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNDaGFy YWN0ZXJLZXkpOiBhdXggZnVuY3Rpb24KKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2Vi Q29yZTo6c2luZ2xlQ2hhcmFjdGVyU3RyaW5nKToKKwogMjAxMi0wNS0xMCAgWXVyeSBTZW1pa2hh dHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBoZWFw IHNuYXBzaG90IGNvbXBhcmlzb24gdmlldyBpcyBicm9rZW4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9FZmxLZXlib2FyZFV0aWxpdGllcy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9lZmwvRWZsS2V5Ym9hcmRVdGlsaXRpZXMuY3BwCmluZGV4IDllOGViMTAu LjljOWZhZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9FZmxLZXli b2FyZFV0aWxpdGllcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0VmbEtl eWJvYXJkVXRpbGl0aWVzLmNwcApAQCAtMTkwLDYgKzE5MCwxMiBAQCBzdGF0aWMgdm9pZCBjcmVh dGVXaW5kb3dzS2V5TWFwKCkKICAgICB9CiB9CiAKK3N0YXRpYyBpbmxpbmUgYm9vbCBpc0NoYXJh Y3RlcktleShjb25zdCBTdHJpbmcmIGtleU5hbWUpCit7CisgICAgY29uc3QgaW50IGtleUNvZGUg PSB3aW5kb3dzS2V5Q29kZUZvckV2YXNLZXlOYW1lKGtleU5hbWUpOworICAgIHJldHVybiAoVktf MCA8PSBrZXlDb2RlICYmIGtleUNvZGUgPD0gVktfOSkgfHwgKFZLX0EgPD0ga2V5Q29kZSAmJiBr ZXlDb2RlIDw9IFZLX1opOworfQorCiBTdHJpbmcga2V5SWRlbnRpZmllckZvckV2YXNLZXlOYW1l KGNvbnN0IFN0cmluZyYga2V5TmFtZSkKIHsKICAgICBpZiAoa2V5TWFwKCkuaXNFbXB0eSgpKQpA QCAtMjA5LDYgKzIxNSw5IEBAIFN0cmluZyBzaW5nbGVDaGFyYWN0ZXJTdHJpbmcoY29uc3QgU3Ry aW5nJiBrZXlOYW1lKQogICAgICAgICByZXR1cm4gU3RyaW5nKCJceDgiKTsKICAgICBpZiAoa2V5 TmFtZSA9PSAiVGFiIikKICAgICAgICAgcmV0dXJuIFN0cmluZygiXHQiKTsKKyAgICBpZiAoIWlz Q2hhcmFjdGVyS2V5KGtleU5hbWUpKQorICAgICAgICByZXR1cm4gU3RyaW5nKCk7CisKICAgICBy ZXR1cm4ga2V5TmFtZTsKIH0KIAo= 142247 2012-05-16 06:59:01 -0700 2012-05-18 07:31:47 -0700 to be landed. bug86200_v2 text/plain 3057 mikhail.pozdnyakov Y29tbWl0IDE0MjI3ZDRjZTM4Y2I5MmQxMTRhMTY3MjM1MDY5ZTExNTY1NzIzYWIKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg RnJpIE1heSAxMSAxNjoxOTo1NiAyMDEyICswMzAwCgogICAgYnVnODYyMDAKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmNl NWRlYS4uMjcyNjliMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA1LTExICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtF RkxdIGZhc3QvZXZlbnRzL2Fycm93LWtleXMtb24tYm9keS5odG1sIGRvZXMgbm90IHBhc3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2MjAwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhIFNpbHZhLgorCisgICAgICAgICogcGxh dGZvcm0vZWZsL1NraXBwZWQ6IHVuc2tpcHBlZCBmYXN0L2V2ZW50cy9hcnJvdy1rZXlzLW9uLWJv ZHkuaHRtbC4KKwogMjAxMi0wNS0xNiAgRG9taW5payBSw7Z0dHNjaGVzICA8ZG9taW5pay5yb3R0 c2NoZXNAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW0RSVF0gR2FyZGVuaW5nIGZhaWx1cmVz IGFmdGVyIHIxMTcxMjMgYW5kIHIxMTcyMDUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2VmbC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKaW5kZXgg YmI1Mjg4Mi4uZWFlMDJhMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Nr aXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKQEAgLTc3Nyw5ICs3 NzcsNiBAQCBmYXN0L2RvbS9XaW5kb3cvd2luZG93LXJlc2l6ZS5odG1sCiAjIEJVRzogd2luZG93 IGhhcyB3cm9uZyBwaXhlbCBhbmQgY29sb3IgZGVwdGgKIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ct c2NyZWVuLXByb3BlcnRpZXMuaHRtbAogCi0jIEJVRzogd3JvbmcgdGVzdCByZXN1bHQsIGtleXBy ZXNzIHNob3VsZCBub3QgYmUgZW1pdHRlZAotZmFzdC9ldmVudHMvYXJyb3cta2V5cy1vbi1ib2R5 Lmh0bWwKLQogIyBCVUc6IHdyb25nIHRlc3QgcmVzdWx0LCB3aW5kb3cgc2hvdWxkIG5vdCBoYXZl IGJlZW4gc2Nyb2xsZWQKIGZhc3QvZXZlbnRzL2F0dGVtcHQtc2Nyb2xsLXdpdGgtbm8tc2Nyb2xs YmFycy5odG1sCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmOTVkZmRlLi43NDBjNDA3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDUtMTEgIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwu cG96ZG55YWtvdkBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gZmFzdC9ldmVudHMvYXJyb3ct a2V5cy1vbi1ib2R5Lmh0bWwgZG9lcyBub3QgcGFzcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYyMDAKKworICAgICAgICBSZXZpZXdlZCBieSBHdXN0 YXZvIE5vcm9uaGEgU2lsdmEuCisKKyAgICAgICAgTm9uY2hhcmFjdGVyIGtleXMgcmV0dXJuIGVt cHR5IHRleHQgdmFsdWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvRWZsS2V5Ym9hcmRVdGls aXRpZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNDaGFyYWN0ZXJLZXkpOiBhdXggZnVuY3Rp b24KKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6c2luZ2xlQ2hhcmFjdGVy U3RyaW5nKToKKwogMjAxMi0wNS0xNiAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pk bnlha292QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6 IGZpZ3VyZXMsIGxldHRlcnMgYW5kIHByaW50c2NyZWVuIGtleSBoYW5kbGluZwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0VmbEtleWJvYXJkVXRpbGl0aWVzLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9FZmxLZXlib2FyZFV0aWxpdGllcy5jcHAKaW5k ZXggNThjMDU4Zi4uNzJiYmM5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v ZWZsL0VmbEtleWJvYXJkVXRpbGl0aWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9lZmwvRWZsS2V5Ym9hcmRVdGlsaXRpZXMuY3BwCkBAIC0yMDIsNiArMjAyLDEyIEBAIHN0YXRp YyB2b2lkIGNyZWF0ZVdpbmRvd3NLZXlNYXAoKQogICAgIH0KIH0KIAorc3RhdGljIGlubGluZSBi b29sIGlzQ2hhcmFjdGVyS2V5KGNvbnN0IFN0cmluZyYga2V5TmFtZSkKK3sKKyAgICBjb25zdCBp bnQga2V5Q29kZSA9IHdpbmRvd3NLZXlDb2RlRm9yRXZhc0tleU5hbWUoa2V5TmFtZSk7CisgICAg cmV0dXJuIChWS18wIDw9IGtleUNvZGUgJiYga2V5Q29kZSA8PSBWS185KSB8fCAoVktfQSA8PSBr ZXlDb2RlICYmIGtleUNvZGUgPD0gVktfWik7Cit9CisKIFN0cmluZyBrZXlJZGVudGlmaWVyRm9y RXZhc0tleU5hbWUoY29uc3QgU3RyaW5nJiBrZXlOYW1lKQogewogICAgIGlmIChrZXlNYXAoKS5p c0VtcHR5KCkpCkBAIC0yMjEsOCArMjI3LDExIEBAIFN0cmluZyBzaW5nbGVDaGFyYWN0ZXJTdHJp bmcoY29uc3QgU3RyaW5nJiBrZXlOYW1lKQogICAgICAgICByZXR1cm4gU3RyaW5nKCJceDgiKTsK ICAgICBpZiAoa2V5TmFtZSA9PSAiVGFiIikKICAgICAgICAgcmV0dXJuIFN0cmluZygiXHQiKTsK LSAgICBpZiAoa2V5TmFtZSA9PSAiUHJpbnQiKQotICAgICAgICByZXR1cm4gU3RyaW5nKCIiKTsK KworICAgIGlmICghaXNDaGFyYWN0ZXJLZXkoa2V5TmFtZSkpCisgICAgICAgIHJldHVybiBTdHJp bmcoKTsKKworCiAgICAgcmV0dXJuIGtleU5hbWU7CiB9CiAK