86083 2012-05-10 04:05:47 -0700 TouchAdjustment doesn't correct for scroll-offsets 2012-05-10 09:17:16 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85101 1 allan.jensen allan.jensen tdanderson webkit.review.bot oldest_to_newest 620447 0 allan.jensen 2012-05-10 04:05:47 -0700 The two functions EventHandler::bestClickableNodeForTouchPoint and EventHandler::bestZoomableAreaForTouchPoint does not correctly adjust for scroll-offset. Scroll-offset is only taking into account for calculating distance, but not in hit-testing or in returned adjusted values. This is in case corrected in Internals to make the test-cases work, but it should be done generally. 620451 1 141139 allan.jensen 2012-05-10 04:08:49 -0700 Created attachment 141139 Patch 620585 2 tdanderson 2012-05-10 08:02:35 -0700 I just uploaded a revised patch for https://bugs.webkit.org/show_bug.cgi?id=85101, which takes the scroll offset/frame issues into account for chromium. But in light of this bug, I will have to re-revise. 620622 3 141139 webkit.review.bot 2012-05-10 09:17:11 -0700 Comment on attachment 141139 Patch Clearing flags on attachment: 141139 Committed r116650: <http://trac.webkit.org/changeset/116650> 620623 4 webkit.review.bot 2012-05-10 09:17:16 -0700 All reviewed patches have been landed. Closing bug. 141139 2012-05-10 04:08:49 -0700 2012-05-10 09:17:11 -0700 Patch bug-86083-20120510130853.patch text/plain 4552 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODA2MDFkZTQwYmJkMjUw MWVmM2ZiMTk2YWEyOGU2Y2FjZTcyY2Q0Mi4uYWMyNjY2NmFlMGRkOTljODgzMzkyMGU3NzMwYTg2 NTUzNjk4YzkxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTA1LTEwICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgogCisgICAgICAgIFRv dWNoQWRqdXN0bWVudCBkb2Vzbid0IGNvcnJlY3QgZm9yIHNjcm9sbC1vZmZzZXRzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYwODMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHJlYWR5IHRlc3RlZCBi eTogdG91Y2hhZGp1c3RtZW50L3Njcm9sbC1kZWxlZ2F0aW9uCisKKyAgICAgICAgKiBwYWdlL0V2 ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmJlc3RDbGlj a2FibGVOb2RlRm9yVG91Y2hQb2ludCk6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6 OmJlc3Rab29tYWJsZUFyZWFGb3JUb3VjaFBvaW50KToKKyAgICAgICAgKiBwYWdlL1RvdWNoQWRq dXN0bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUb3VjaEFkanVzdG1lbnQ6OmZpbmROb2Rl V2l0aExvd2VzdERpc3RhbmNlTWV0cmljKToKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFscy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbHM6OmJlc3Rab29tYWJsZUFyZWFGb3JUb3Vj aFBvaW50KToKKworMjAxMi0wNS0xMCAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVu c2VuQG5va2lhLmNvbT4KKwogICAgICAgICBGcmFjdGlvbmFsVW5pdCBtaW5vciBtYXRoIGJ1Z3MK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2MDY1CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAppbmRleCAyOTBlNThmM2EwNTc0ZWMxNWNk Y2MzZDFjMzY5ZTRhMzcxMWUxOTNjLi4wMDE2MzRkOWRjOTMyMDE0ZTFmMmZhMjYyZDFiZGUxMThl OWJmMGU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCkBAIC0yNDc4LDcgKzI0 NzgsOCBAQCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZVNjcm9sbENvcmUoY29uc3Qg UGxhdGZvcm1HZXN0dXJlRXZlbnQmIGdlc3R1cmVFdgogYm9vbCBFdmVudEhhbmRsZXI6OmJlc3RD bGlja2FibGVOb2RlRm9yVG91Y2hQb2ludChjb25zdCBJbnRQb2ludCYgdG91Y2hDZW50ZXIsIGNv bnN0IEludFNpemUmIHRvdWNoUmFkaXVzLCBJbnRQb2ludCYgdGFyZ2V0UG9pbnQsIE5vZGUqJiB0 YXJnZXROb2RlKQogewogICAgIEhpdFRlc3RSZXF1ZXN0OjpIaXRUZXN0UmVxdWVzdFR5cGUgaGl0 VHlwZSA9IEhpdFRlc3RSZXF1ZXN0OjpSZWFkT25seSB8IEhpdFRlc3RSZXF1ZXN0OjpBY3RpdmU7 Ci0gICAgSGl0VGVzdFJlc3VsdCByZXN1bHQgPSBoaXRUZXN0UmVzdWx0QXRQb2ludCh0b3VjaENl bnRlciwgLyphbGxvd1NoYWRvd0NvbnRlbnQqLyBmYWxzZSwgLyppZ25vcmVDbGlwcGluZyovIGZh bHNlLCBEb250SGl0VGVzdFNjcm9sbGJhcnMsIGhpdFR5cGUsIHRvdWNoUmFkaXVzKTsKKyAgICBJ bnRQb2ludCBoaXRUZXN0UG9pbnQgPSBtX2ZyYW1lLT52aWV3KCktPndpbmRvd1RvQ29udGVudHMo dG91Y2hDZW50ZXIpOworICAgIEhpdFRlc3RSZXN1bHQgcmVzdWx0ID0gaGl0VGVzdFJlc3VsdEF0 UG9pbnQoaGl0VGVzdFBvaW50LCAvKmFsbG93U2hhZG93Q29udGVudCovIGZhbHNlLCAvKmlnbm9y ZUNsaXBwaW5nKi8gZmFsc2UsIERvbnRIaXRUZXN0U2Nyb2xsYmFycywgaGl0VHlwZSwgdG91Y2hS YWRpdXMpOwogCiAgICAgSW50UmVjdCB0b3VjaFJlY3QgPSByZXN1bHQucmVjdEZvclBvaW50KHRv dWNoQ2VudGVyKTsKICAgICBSZWZQdHI8U3RhdGljSGFzaFNldE5vZGVMaXN0PiBub2RlTGlzdCA9 IFN0YXRpY0hhc2hTZXROb2RlTGlzdDo6YWRvcHQocmVzdWx0LnJlY3RCYXNlZFRlc3RSZXN1bHQo KSk7CkBAIC0yNDg4LDcgKzI0ODksOCBAQCBib29sIEV2ZW50SGFuZGxlcjo6YmVzdENsaWNrYWJs ZU5vZGVGb3JUb3VjaFBvaW50KGNvbnN0IEludFBvaW50JiB0b3VjaENlbnRlciwgYwogYm9vbCBF dmVudEhhbmRsZXI6OmJlc3Rab29tYWJsZUFyZWFGb3JUb3VjaFBvaW50KGNvbnN0IEludFBvaW50 JiB0b3VjaENlbnRlciwgY29uc3QgSW50U2l6ZSYgdG91Y2hSYWRpdXMsIEludFJlY3QmIHRhcmdl dEFyZWEsIE5vZGUqJiB0YXJnZXROb2RlKQogewogICAgIEhpdFRlc3RSZXF1ZXN0OjpIaXRUZXN0 UmVxdWVzdFR5cGUgaGl0VHlwZSA9IEhpdFRlc3RSZXF1ZXN0OjpSZWFkT25seSB8IEhpdFRlc3RS ZXF1ZXN0OjpBY3RpdmU7Ci0gICAgSGl0VGVzdFJlc3VsdCByZXN1bHQgPSBoaXRUZXN0UmVzdWx0 QXRQb2ludCh0b3VjaENlbnRlciwgLyphbGxvd1NoYWRvd0NvbnRlbnQqLyBmYWxzZSwgLyppZ25v cmVDbGlwcGluZyovIGZhbHNlLCBEb250SGl0VGVzdFNjcm9sbGJhcnMsIGhpdFR5cGUsIHRvdWNo UmFkaXVzKTsKKyAgICBJbnRQb2ludCBoaXRUZXN0UG9pbnQgPSBtX2ZyYW1lLT52aWV3KCktPndp bmRvd1RvQ29udGVudHModG91Y2hDZW50ZXIpOworICAgIEhpdFRlc3RSZXN1bHQgcmVzdWx0ID0g aGl0VGVzdFJlc3VsdEF0UG9pbnQoaGl0VGVzdFBvaW50LCAvKmFsbG93U2hhZG93Q29udGVudCov IGZhbHNlLCAvKmlnbm9yZUNsaXBwaW5nKi8gZmFsc2UsIERvbnRIaXRUZXN0U2Nyb2xsYmFycywg aGl0VHlwZSwgdG91Y2hSYWRpdXMpOwogCiAgICAgSW50UmVjdCB0b3VjaFJlY3QgPSByZXN1bHQu cmVjdEZvclBvaW50KHRvdWNoQ2VudGVyKTsKICAgICBSZWZQdHI8U3RhdGljSGFzaFNldE5vZGVM aXN0PiBub2RlTGlzdCA9IFN0YXRpY0hhc2hTZXROb2RlTGlzdDo6YWRvcHQocmVzdWx0LnJlY3RC YXNlZFRlc3RSZXN1bHQoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1RvdWNo QWRqdXN0bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1RvdWNoQWRqdXN0bWVudC5jcHAK aW5kZXggNWExYmYyYmIwNmU0ZjJkYTk4OWQ4MTQ4OGJmMmZiMzI0ZTk1NTExNS4uNTg3MDAzYjJm NDExZTMwNDhlY2YwYjljYzc3NWVlMzJjYjIwN2FiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9Ub3VjaEFkanVzdG1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVG91 Y2hBZGp1c3RtZW50LmNwcApAQCAtMjY1LDYgKzI2NSwxMCBAQCBib29sIGZpbmROb2RlV2l0aExv d2VzdERpc3RhbmNlTWV0cmljKE5vZGUqJiB0YXJnZXROb2RlLCBJbnRQb2ludCYgdGFyZ2V0UG9p bnQsCiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CisgICAgaWYgKHRhcmdldE5vZGUp IHsKKyAgICAgICAgdGFyZ2V0QXJlYSA9IHRhcmdldE5vZGUtPmRvY3VtZW50KCktPnZpZXcoKS0+ Y29udGVudHNUb1dpbmRvdyh0YXJnZXRBcmVhKTsKKyAgICAgICAgdGFyZ2V0UG9pbnQgPSB0YXJn ZXROb2RlLT5kb2N1bWVudCgpLT52aWV3KCktPmNvbnRlbnRzVG9XaW5kb3codGFyZ2V0UG9pbnQp OworICAgIH0KIAogICAgIHJldHVybiAodGFyZ2V0Tm9kZSk7CiB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L0ludGVybmFscy5jcHAKaW5kZXggNzc0MjAzMjU1YzBjOWM3ZGJiM2JjMmFjNmNhMGY5MzM0ZWJm OWMyMS4uN2RjY2VhMzA5NjNkOTg4YjE5NjRiOGNiNDQzNmZjODliZGEyY2I3MiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcApAQCAtNzc0LDggKzc3NCw2IEBAIFBhc3NSZWZQdHI8 Q2xpZW50UmVjdD4gSW50ZXJuYWxzOjpiZXN0Wm9vbWFibGVBcmVhRm9yVG91Y2hQb2ludChsb25n IHgsIGxvbmcgeSwKICAgICBOb2RlKiB0YXJnZXROb2RlOwogICAgIEludFJlY3Qgem9vbWFibGVB cmVhOwogICAgIGRvY3VtZW50LT5mcmFtZSgpLT5ldmVudEhhbmRsZXIoKS0+YmVzdFpvb21hYmxl QXJlYUZvclRvdWNoUG9pbnQocG9pbnQsIHJhZGl1cywgem9vbWFibGVBcmVhLCB0YXJnZXROb2Rl KTsKLSAgICBpZiAodGFyZ2V0Tm9kZSkKLSAgICAgICAgem9vbWFibGVBcmVhID0gdGFyZ2V0Tm9k ZS0+ZG9jdW1lbnQoKS0+dmlldygpLT5jb250ZW50c1RvV2luZG93KHpvb21hYmxlQXJlYSk7CiAK ICAgICByZXR1cm4gQ2xpZW50UmVjdDo6Y3JlYXRlKHpvb21hYmxlQXJlYSk7CiB9Cg==