85988 2012-05-09 05:45:04 -0700 MediaStream API: SessionDescription::addCandidate should not crash for malformed input 2012-05-09 08:55:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 80589 1 tommyw tommyw abarth eric.carlson feature-media-reviews ojan webkit.review.bot oldest_to_newest 619421 0 tommyw 2012-05-09 05:45:04 -0700 Sending null would crash the browser. Added safeguards in both the bindings and the native code. 619422 1 140928 tommyw 2012-05-09 05:50:00 -0700 Created attachment 140928 Patch 619487 2 140928 abarth 2012-05-09 08:02:59 -0700 Comment on attachment 140928 Patch I support not crashing. :) 619530 3 140928 webkit.review.bot 2012-05-09 08:55:16 -0700 Comment on attachment 140928 Patch Clearing flags on attachment: 140928 Committed r116530: <http://trac.webkit.org/changeset/116530> 619531 4 webkit.review.bot 2012-05-09 08:55:21 -0700 All reviewed patches have been landed. Closing bug. 140928 2012-05-09 05:50:00 -0700 2012-05-09 08:55:15 -0700 Patch bug-85988-20120509144958.patch text/plain 6659 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2NTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQxZjQ2OTBmYzI3OTg3 NzU3MDE5NmMxNDgwZGY1ZGVlZWRlNzg3My4uZmQ4ODg1MjVmYzMzZmRhOWUwMDYwNzk3NGY4ZGJl NTczNzRkNWJhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTA5ICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogU2Vzc2lvbkRlc2NyaXB0aW9uOjphZGRDYW5kaWRhdGUgc2hvdWxkIG5vdCBjcmFzaCBm b3IgbWFsZm9ybWVkIGlucHV0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NTk4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFNlbmRpbmcgbnVsbCB3b3VsZCBjcmFzaCB0aGUgYnJvd3Nlci4gQWRkZWQgc2Fm ZWd1YXJkcyBpbiBib3RoIHRoZSBiaW5kaW5ncyBhbmQgdGhlIG5hdGl2ZSBjb2RlLgorCisgICAg ICAgIFRlc3Q6IGZhc3QvbWVkaWFzdHJlYW0vU2Vzc2lvbkRlc2NyaXB0aW9uLmh0bWwKKworICAg ICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vU2Vzc2lvbkRlc2NyaXB0aW9uLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlNlc3Npb25EZXNjcmlwdGlvbjo6YWRkQ2FuZGlkYXRlKToKKyAgICAgICAg KiBNb2R1bGVzL21lZGlhc3RyZWFtL1Nlc3Npb25EZXNjcmlwdGlvbi5oOgorICAgICAgICAoU2Vz c2lvbkRlc2NyaXB0aW9uKToKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL1Nlc3Npb25E ZXNjcmlwdGlvbi5pZGw6CisKIDIwMTItMDUtMDkgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2luQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dW0Zvcm1zXSBIVE1MT3B0aW9uc0NvbGxl Y3Rpb24gZG9lc24ndCBoYXZlIGluZGV4ZWQgcHJvcGVydGllcyBvbiBwcm9wZXJ0eSBlbnVtZXJh dGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9TZXNz aW9uRGVzY3JpcHRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9T ZXNzaW9uRGVzY3JpcHRpb24uY3BwCmluZGV4IDk4MjcwN2E5ZjdmNTBmZTlhZjY2ZWZmNjE4NzFk ZTZjZDMwODYzOGMuLjFiMmQ2NGExZmEwYWQ0ZDIyZWRjZjhmNTRkYTk3OTg5NzUzYjRmMDggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vU2Vzc2lvbkRlc2Ny aXB0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1Nlc3Np b25EZXNjcmlwdGlvbi5jcHAKQEAgLTM0LDYgKzM0LDcgQEAKIAogI2luY2x1ZGUgIlNlc3Npb25E ZXNjcmlwdGlvbi5oIgogCisjaW5jbHVkZSAiRXhjZXB0aW9uQ29kZS5oIgogI2luY2x1ZGUgIklj ZUNhbmRpZGF0ZS5oIgogI2luY2x1ZGUgIkljZUNhbmRpZGF0ZURlc2NyaXB0b3IuaCIKICNpbmNs dWRlICJNZWRpYVN0cmVhbUNlbnRlci5oIgpAQCAtNjEsOCArNjIsMTMgQEAgU2Vzc2lvbkRlc2Ny aXB0aW9uOjp+U2Vzc2lvbkRlc2NyaXB0aW9uKCkKIHsKIH0KIAotdm9pZCBTZXNzaW9uRGVzY3Jp cHRpb246OmFkZENhbmRpZGF0ZShQYXNzUmVmUHRyPEljZUNhbmRpZGF0ZT4gY2FuZGlkYXRlKQor dm9pZCBTZXNzaW9uRGVzY3JpcHRpb246OmFkZENhbmRpZGF0ZShQYXNzUmVmUHRyPEljZUNhbmRp ZGF0ZT4gY2FuZGlkYXRlLCBFeGNlcHRpb25Db2RlJiBlYykKIHsKKyAgICBpZiAoIWNhbmRpZGF0 ZSkgeworICAgICAgICBlYyA9IFRZUEVfTUlTTUFUQ0hfRVJSOworICAgICAgICByZXR1cm47Cisg ICAgfQorCiAgICAgbV9kZXNjcmlwdG9yLT5hZGRDYW5kaWRhdGUoY2FuZGlkYXRlLT5kZXNjcmlw dG9yKCkpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3Ry ZWFtL1Nlc3Npb25EZXNjcmlwdGlvbi5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0 cmVhbS9TZXNzaW9uRGVzY3JpcHRpb24uaAppbmRleCA2YTUxOTAxZjBiZTBmOTVmMmFjNzJjYzU1 MDNjYTc3MGIxZDY1Zjk5Li4wMTE1ODUzNzY1Mzg3YzEwMzY2YjdkMjliYWFhOGE2ZjYwZTA2NDI5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1Nlc3Npb25E ZXNjcmlwdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vU2Vz c2lvbkRlc2NyaXB0aW9uLmgKQEAgLTMzLDYgKzMzLDcgQEAKIAogI2lmIEVOQUJMRShNRURJQV9T VFJFQU0pCiAKKyNpbmNsdWRlICJFeGNlcHRpb25CYXNlLmgiCiAjaW5jbHVkZSA8d3RmL1Bhc3NS ZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0 L1dURlN0cmluZy5oPgpAQCAtNDgsNyArNDksNyBAQCBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NS ZWZQdHI8U2Vzc2lvbkRlc2NyaXB0aW9uPiBjcmVhdGUoUGFzc1JlZlB0cjxTZXNzaW9uRGVzY3Jp cHRpb25EZXNjcmlwdG9yPik7CiAgICAgdmlydHVhbCB+U2Vzc2lvbkRlc2NyaXB0aW9uKCk7CiAK LSAgICB2b2lkIGFkZENhbmRpZGF0ZShQYXNzUmVmUHRyPEljZUNhbmRpZGF0ZT4pOworICAgIHZv aWQgYWRkQ2FuZGlkYXRlKFBhc3NSZWZQdHI8SWNlQ2FuZGlkYXRlPiwgRXhjZXB0aW9uQ29kZSYp OwogICAgIFN0cmluZyB0b1NkcCgpOwogCiAgICAgU2Vzc2lvbkRlc2NyaXB0aW9uRGVzY3JpcHRv ciogZGVzY3JpcHRvcigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9TZXNzaW9uRGVzY3JpcHRpb24uaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYXN0cmVhbS9TZXNzaW9uRGVzY3JpcHRpb24uaWRsCmluZGV4IDM1Nzc1YmU0YjI0ODE1YTlh YzcwOWEzMzA1OWViMjUzMDllYmM1NjAuLmQ0YWZlZGFkOWY3Yzc2MDc1MmQ0NDNiYzc0ODRiNzU1 NTg0MDYwMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0v U2Vzc2lvbkRlc2NyaXB0aW9uLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c3RyZWFtL1Nlc3Npb25EZXNjcmlwdGlvbi5pZGwKQEAgLTM0LDcgKzM0LDggQEAgbW9kdWxlIHAy cCB7CiAgICAgICAgIENvbmRpdGlvbmFsPU1FRElBX1NUUkVBTSwKICAgICAgICAgQ29uc3RydWN0 b3IoaW4gRE9NU3RyaW5nIHNkcCkKICAgICBdIFNlc3Npb25EZXNjcmlwdGlvbiB7Ci0gICAgICAg IHZvaWQgYWRkQ2FuZGlkYXRlKGluIEljZUNhbmRpZGF0ZSBjYW5kaWRhdGUpOworICAgICAgICBb U3RyaWN0VHlwZUNoZWNraW5nXSB2b2lkIGFkZENhbmRpZGF0ZShpbiBJY2VDYW5kaWRhdGUgY2Fu ZGlkYXRlKQorICAgICAgICAgICAgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAKICAgICAgICAgRE9N U3RyaW5nIHRvU2RwKCk7CiAgICAgfTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmNTZiNWNmODcwMzljMGQ1MTQ2NzExODMw ZTY1YTM1MTdkMmQwZDgwLi5lOWM4M2FkYmVhOGJhMGVkZDU5MTBiZDczYjYzMWMwOGM5ZDFmN2E0 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDUtMDkgIFRvbW15IFdpZGVuZmx5Y2h0ICA8 dG9tbXl3QGdvb2dsZS5jb20+CisKKyAgICAgICAgTWVkaWFTdHJlYW0gQVBJOiBTZXNzaW9uRGVz Y3JpcHRpb246OmFkZENhbmRpZGF0ZSBzaG91bGQgbm90IGNyYXNoIGZvciBtYWxmb3JtZWQgaW5w dXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1OTg4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0 L21lZGlhc3RyZWFtL1Nlc3Npb25EZXNjcmlwdGlvbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvbWVkaWFzdHJlYW0vU2Vzc2lvbkRlc2NyaXB0aW9uLmh0bWw6IEFkZGVkLgor CiAyMDEyLTA1LTA5ICBTdWRhcnNhbmEgTmFnaW5lbmkgIDxzdWRhcnNhbmEubmFnaW5lbmlAbGlu dXguaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW0RSVF0gQWRkIGJhc2VsaW5lcyBmb3IgbmV3 IENTUyBjYXNlcyBhZnRlciByMTE2NDM4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L21l ZGlhc3RyZWFtL1Nlc3Npb25EZXNjcmlwdGlvbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9m YXN0L21lZGlhc3RyZWFtL1Nlc3Npb25EZXNjcmlwdGlvbi1leHBlY3RlZC50eHQKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uNzVkMGY0ODRlZDM3YTJlMjIyZmE3NTdkYzc1ODljNTNjY2VlYTI3NQotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vU2Vzc2lvbkRlc2NyaXB0aW9uLWV4 cGVjdGVkLnR4dApAQCAtMCwwICsxLDE2IEBACitUZXN0cyB0aGUgSlNFUCBTZXNzaW9uRGVzY3Jp cHRpb24uCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVz c2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHNlc3Npb25EZXNj cmlwdGlvbiA9IG5ldyBTZXNzaW9uRGVzY3JpcHRpb24oJycpOyBkaWQgbm90IHRocm93IGV4Y2Vw dGlvbi4KK1BBU1Mgc2Vzc2lvbkRlc2NyaXB0aW9uLmFkZENhbmRpZGF0ZSgpIHRocmV3IGV4Y2Vw dGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzLgorUEFTUyBzZXNzaW9uRGVzY3Jp cHRpb24uYWRkQ2FuZGlkYXRlKG51bGwpIHRocmV3IGV4Y2VwdGlvbiBFcnJvcjogVFlQRV9NSVNN QVRDSF9FUlI6IERPTSBFeGNlcHRpb24gMTcuCitQQVNTIHNlc3Npb25EZXNjcmlwdGlvbi5hZGRD YW5kaWRhdGUodW5kZWZpbmVkKSB0aHJldyBleGNlcHRpb24gRXJyb3I6IFRZUEVfTUlTTUFUQ0hf RVJSOiBET00gRXhjZXB0aW9uIDE3LgorUEFTUyBzZXNzaW9uRGVzY3JpcHRpb24uYWRkQ2FuZGlk YXRlKDQyKSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBUeXBlIGVycm9yLgorUEFTUyBpY2VD YW5kaWRhdGUgPSBuZXcgSWNlQ2FuZGlkYXRlKCcnLCAnJyk7IGRpZCBub3QgdGhyb3cgZXhjZXB0 aW9uLgorUEFTUyBzZXNzaW9uRGVzY3JpcHRpb24uYWRkQ2FuZGlkYXRlKGljZUNhbmRpZGF0ZSkg ZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVl CisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0 cmVhbS9TZXNzaW9uRGVzY3JpcHRpb24uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJl YW0vU2Vzc2lvbkRlc2NyaXB0aW9uLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOGJkMmE3MDMyMzBkOGNmOTNi YTE5ZjExYTAzODcyNzRkMjcxZTFlNgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvbWVkaWFzdHJlYW0vU2Vzc2lvbkRlc2NyaXB0aW9uLmh0bWwKQEAgLTAsMCArMSwyNyBAQAor PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8 aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRl c3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUu anMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4K KzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJUZXN0cyB0 aGUgSlNFUCBTZXNzaW9uRGVzY3JpcHRpb24uIik7CisKK3Nlc3Npb25EZXNjcmlwdGlvbiA9IG51 bGw7CitzaG91bGROb3RUaHJvdygic2Vzc2lvbkRlc2NyaXB0aW9uID0gbmV3IFNlc3Npb25EZXNj cmlwdGlvbignJyk7Iik7CitzaG91bGRUaHJvdygic2Vzc2lvbkRlc2NyaXB0aW9uLmFkZENhbmRp ZGF0ZSgpIik7CitzaG91bGRUaHJvdygic2Vzc2lvbkRlc2NyaXB0aW9uLmFkZENhbmRpZGF0ZShu dWxsKSIpOworc2hvdWxkVGhyb3coInNlc3Npb25EZXNjcmlwdGlvbi5hZGRDYW5kaWRhdGUodW5k ZWZpbmVkKSIpOworc2hvdWxkVGhyb3coInNlc3Npb25EZXNjcmlwdGlvbi5hZGRDYW5kaWRhdGUo NDIpIik7CitpY2VDYW5kaWRhdGUgPSBudWxsOworc2hvdWxkTm90VGhyb3coImljZUNhbmRpZGF0 ZSA9IG5ldyBJY2VDYW5kaWRhdGUoJycsICcnKTsiKTsKK3Nob3VsZE5vdFRocm93KCJzZXNzaW9u RGVzY3JpcHRpb24uYWRkQ2FuZGlkYXRlKGljZUNhbmRpZGF0ZSkiKTsKKword2luZG93LmpzVGVz dElzQXN5bmMgPSBmYWxzZTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNl cy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=