85879 2012-05-08 02:58:38 -0700 [EFL] fast/frames/frame-crash-with-page-cache.html is crashing 2012-05-17 00:29:22 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tmpsantos mikhail.pozdnyakov cdumez d-r gyuyoung.kim lucas.de.marchi mikhail.pozdnyakov rakuco webkit.review.bot oldest_to_newest 618451 0 tmpsantos 2012-05-08 02:58:38 -0700 Test started to crash after bug 85620 was landed. 619372 1 tmpsantos 2012-05-09 04:31:47 -0700 *** Bug 85981 has been marked as a duplicate of this bug. *** 619380 2 tmpsantos 2012-05-09 04:42:51 -0700 Bug 85608 has nothing to do with the crash. If you revert it, it will crash anyway. Although we should investigate if closeRemainingWindowsWhenComplete() really needs to be checked before cleaning the extra views. 619383 3 tmpsantos 2012-05-09 04:51:56 -0700 (In reply to comment #2) > Bug 85608 has nothing to do with the crash. If you revert it, it will crash anyway. Although we should investigate if closeRemainingWindowsWhenComplete() really needs to be checked before cleaning the extra views. Not really, it was set to True. So even verifying the flag, the test would still crash. 619764 4 mikhail.pozdnyakov 2012-05-09 13:10:26 -0700 Backtrace: 1480 ASSERT(!m_frame->document() || !m_frame->document()->inPageCache()); (gdb) bt #0 0xb404af53 in WebCore::FrameLoader::stopAllLoaders (this=0xae7db1cc, clearProvisionalItemPolicy=WebCore::ShouldClearProvisionalItem) at /usr/share/WebKit/Source/WebCore/loader/FrameLoader.cpp:1480 #1 0xb404e41c in WebCore::FrameLoader::detachFromParent (this=0xae7db1cc) at /usr/share/WebKit/Source/WebCore/loader/FrameLoader.cpp:2325 #2 0xb1e333f0 in _ewk_frame_smart_del (ewkFrame=0xaf3d30c0) at /usr/share/WebKit/Source/WebKit/efl/ewk/ewk_frame.cpp:232 #3 0xb7e03e00 in evas_object_smart_del (obj=0xaf3d30c0) at evas_object_smart.c:747 #4 0xb7df7435 in evas_object_del (obj=0xaf3d30c0) at evas_object_main.c:437 #5 0xb7e02770 in _evas_object_smart_members_all_del (obj=0xaf3ceed8) at evas_object_smart.c:299 #6 0xb7e044e8 in evas_object_smart_clipped_smart_del (obj=0xaf3ceed8) at evas_object_smart_clipped.c:79 #7 0xb1e33448 in _ewk_frame_smart_del (ewkFrame=0xaf3ceed8) at /usr/share/WebKit/Source/WebKit/efl/ewk/ewk_frame.cpp:242 #8 0xb7e03e00 in evas_object_smart_del (obj=0xaf3ceed8) at evas_object_smart.c:747 #9 0xb7df7435 in evas_object_del (obj=0xaf3ceed8) at evas_object_main.c:437 #10 0xb7e02770 in _evas_object_smart_members_all_del (obj=0xaf3ce7e8) at evas_object_smart.c:299 #11 0xb7e044e8 in evas_object_smart_clipped_smart_del (obj=0xaf3ce7e8) at evas_object_smart_clipped.c:79 #12 0xb1e54f76 in _ewk_view_smart_del (ewkView=0xaf3ce7e8) at /usr/share/WebKit/Source/WebKit/efl/ewk/ewk_view.cpp:896 #13 0xb7e03e00 in evas_object_smart_del (obj=0xaf3ce7e8) at evas_object_smart.c:747 #14 0xb7df7435 in evas_object_del (obj=0xaf3ce7e8) at evas_object_main.c:437 #15 0x0809fc1c in DumpRenderTreeChrome::clearExtraViews (this=0x8161638) at /usr/share/WebKit/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:174 #16 0x0809d4c8 in runTest (cTestPathOrURL=0xbffff4c1 "LayoutTests/fast/frames/frame-c 619774 5 mikhail.pozdnyakov 2012-05-09 13:23:03 -0700 Crash is lead by ewk_frame freeing functions. loader()->detachFromParent() should be applied only for the main frame, not for each frame as traverses trough the frame tree. loader()->cancelAndClear() resets frame's document which is not appropriate for the cached frame, not needed because detachFromParent makes clean up already. 619777 6 mikhail.pozdnyakov 2012-05-09 13:24:26 -0700 (In reply to comment #5) > Crash is lead by ewk_frame freeing functions. loader()->detachFromParent() and loader()->cancelAndClear() are invoked from _ewk_frame_smart_del() 619782 7 141005 mikhail.pozdnyakov 2012-05-09 13:27:06 -0700 Created attachment 141005 preliminary patch 620374 8 141005 gyuyoung.kim 2012-05-10 01:32:10 -0700 Comment on attachment 141005 preliminary patch View in context: https://bugs.webkit.org/attachment.cgi?id=141005&action=review Looks fine overall except for variable name. > Source/WebKit/efl/ewk/ewk_frame.cpp:232 > + EWK_FRAME_SD_GET(ewk_view_frame_main_get(smartData->view), msd); Please use full name for variable. For example, mainSmartData instead of msd ? 620397 9 141114 mikhail.pozdnyakov 2012-05-10 02:24:52 -0700 Created attachment 141114 patch 620399 10 mikhail.pozdnyakov 2012-05-10 02:26:57 -0700 (In reply to comment #8) > (From update of attachment 141005 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141005&action=review > > Looks fine overall except for variable name. > > > Source/WebKit/efl/ewk/ewk_frame.cpp:232 > > + EWK_FRAME_SD_GET(ewk_view_frame_main_get(smartData->view), msd); > > Please use full name for variable. For example, mainSmartData instead of msd ? Thanks for taking a look! Fixed. 620405 11 141114 gyuyoung.kim 2012-05-10 02:37:00 -0700 Comment on attachment 141114 patch Looks good to me. 626110 12 141114 webkit.review.bot 2012-05-16 18:28:58 -0700 Comment on attachment 141114 patch Rejecting attachment 141114 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ests/platform/efl/test_expectations.txt Hunk #1 FAILED at 398. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/efl/test_expectations.txt.rej patching file Source/WebKit/efl/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/efl/ewk/ewk_frame.cpp Hunk #1 succeeded at 233 (offset 4 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Noam Rosen..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12709612 626301 13 142421 mikhail.pozdnyakov 2012-05-16 23:40:48 -0700 Created attachment 142421 to be landed. 626334 14 142421 webkit.review.bot 2012-05-17 00:29:16 -0700 Comment on attachment 142421 to be landed. Clearing flags on attachment: 142421 Committed r117409: <http://trac.webkit.org/changeset/117409> 626335 15 webkit.review.bot 2012-05-17 00:29:22 -0700 All reviewed patches have been landed. Closing bug. 141005 2012-05-09 13:27:06 -0700 2012-05-10 02:24:52 -0700 preliminary patch bug85879 text/plain 1838 mikhail.pozdnyakov Y29tbWl0IGIyY2YzMTk3ZTQyMjI2OWMwNDFjYTE1OWM1OWQ2NzhiZTVmNmMwYjQKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg V2VkIE1heSA5IDIzOjA3OjEwIDIwMTIgKzAzMDAKCiAgICBidWc4NTg3OQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxv ZwppbmRleCA3NzY3MTViLi5kNjBiZDY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDUtMDkgIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBp bnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gZmFzdC9mcmFtZXMvZnJhbWUtY3Jhc2gtd2l0aC1w YWdlLWNhY2hlLmh0bWwgaXMgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg1ODc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgX2V3a19mcmFtZV9zbWFydF9kZWwoKSBpcyBjb25zaWRlcmluZyBu b3cgdGhhdCB0aGUgZnJhbWUgY2FuIGJlIHByZXNlbnQgaW4gY2FjaGUuCisgICAgICAgIGxvYWRl cigpLT5kZXRhY2hGcm9tUGFyZW50KCkgaXMgb25seSBhcHBsaWVkIGZvciB0aGUgbWFpbiBmcmFt ZS4KKyAgICAgICAgbG9hZGVyKCktPmNhbmNlbEFuZENsZWFyKCkgaXMgbm90IHVzZWQgYW55bW9y ZS4KKworICAgICAgICAqIGV3ay9ld2tfZnJhbWUuY3BwOgorICAgICAgICAoX2V3a19mcmFtZV9z bWFydF9kZWwpOgorCiAyMDEyLTA1LTA4ICBLYW5naWwgSGFuICA8a2FuZ2lsLmhhbkBzYW1zdW5n LmNvbT4KIAogICAgICAgICBbRUZMXVtEUlRdIEltcGxlbWVudCBUZXh0SW5wdXRDb250cm9sbGVy LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcAppbmRleCAyNGExMmVhLi4yM2ZmNThiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcApAQCAtMjI5LDggKzIyOSw5IEBAIHN0YXRp YyB2b2lkIF9ld2tfZnJhbWVfc21hcnRfZGVsKEV2YXNfT2JqZWN0KiBld2tGcmFtZSkKICAgICAg ICAgaWYgKHNtYXJ0RGF0YS0+ZnJhbWUpIHsKICAgICAgICAgICAgIFdlYkNvcmU6OkZyYW1lTG9h ZGVyQ2xpZW50RWZsKiBmbGMgPSBfZXdrX2ZyYW1lX2xvYWRlcl9lZmxfZ2V0KHNtYXJ0RGF0YS0+ ZnJhbWUpOwogICAgICAgICAgICAgZmxjLT5zZXRXZWJGcmFtZSgwKTsKLSAgICAgICAgICAgIHNt YXJ0RGF0YS0+ZnJhbWUtPmxvYWRlcigpLT5kZXRhY2hGcm9tUGFyZW50KCk7Ci0gICAgICAgICAg ICBzbWFydERhdGEtPmZyYW1lLT5sb2FkZXIoKS0+Y2FuY2VsQW5kQ2xlYXIoKTsKKyAgICAgICAg ICAgIEVXS19GUkFNRV9TRF9HRVQoZXdrX3ZpZXdfZnJhbWVfbWFpbl9nZXQoc21hcnREYXRhLT52 aWV3KSwgbXNkKTsKKyAgICAgICAgICAgIGlmIChtc2QtPmZyYW1lID09IHNtYXJ0RGF0YS0+ZnJh bWUpIC8vIG9ubHkgZm9yIG1haW4gZnJhbWUgaXMgZW5vdWdoICh3aWxsIHRyYXZlcnNlIHRocm91 Z2ggZnJhbWUgdHJlZSkKKyAgICAgICAgICAgICAgICBzbWFydERhdGEtPmZyYW1lLT5sb2FkZXIo KS0+ZGV0YWNoRnJvbVBhcmVudCgpOwogICAgICAgICAgICAgc21hcnREYXRhLT5mcmFtZSA9IDA7 CiAgICAgICAgIH0KIAo= 141114 2012-05-10 02:24:52 -0700 2012-05-16 23:40:48 -0700 patch bug85879_v2 text/plain 3004 mikhail.pozdnyakov Y29tbWl0IDEyOTc1NzJkNmZmY2Y1MTAyMWQ2MDIzOTFmZTM0NThlZjMxYjU0OTcKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg VGh1IE1heSAxMCAxMjoxMjozNiAyMDEyICswMzAwCgogICAgYnVnODU4NzkKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzgw YzAyOS4uYTBjMjk3MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA1LTEwICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtF RkxdIGZhc3QvZnJhbWVzL2ZyYW1lLWNyYXNoLXdpdGgtcGFnZS1jYWNoZS5odG1sIGlzIGNyYXNo aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTg3 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh dGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDogUmVtb3ZlZCBmYXN0L2ZyYW1lcy9mcmFt ZS1jcmFzaC13aXRoLXBhZ2UtY2FjaGUuaHRtbC4KKwogMjAxMi0wNS0xMCAgWmFuIERvYmVyc2Vr ICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGdhcmRl bmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC90ZXN0X2V4cGVjdGF0 aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvdGVzdF9leHBlY3RhdGlvbnMudHh0 CmluZGV4IGVhNWQ0ZDEuLmFiNmFmYzkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2VmbC90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZs L3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtMzk4LDYgKzM5OCw0IEBAIEJVR1dLODU5MDIgU0xP VyBERUJVRyA6IGZhc3Qvb3ZlcmZsb3cvbG90cy1vZi1zaWJsaW5nLWlubGluZS1ib3hlcy5odG1s ID0gUEFTUwogCiBCVUdXSzg1Nzk5IDogZmFzdC9jc3MvZm9udC1mYWNlLWRvd25sb2FkLWVycm9y Lmh0bWwgPSBUSU1FT1VUCiAKLUJVR1dLODU4NzkgOiBmYXN0L2ZyYW1lcy9mcmFtZS1jcmFzaC13 aXRoLXBhZ2UtY2FjaGUuaHRtbCA9IENSQVNICi0KIEJVR1dLODU5OTUgOiBmYXN0L2V2ZW50cy9m cmFtZS1jbGljay1mb2N1cy5odG1sID0gVEVYVApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCmluZGV4IDQ2M2QzZDcu LjZmZmE2Y2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNS0xMCAg TWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KKworICAg ICAgICBbRUZMXSBmYXN0L2ZyYW1lcy9mcmFtZS1jcmFzaC13aXRoLXBhZ2UtY2FjaGUuaHRtbCBp cyBjcmFzaGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODU4NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBfZXdrX2ZyYW1lX3NtYXJ0X2RlbCgpIGlzIGNvbnNpZGVyaW5nIG5vdyB0aGF0IHRoZSBmcmFt ZSBjYW4gYmUgcHJlc2VudCBpbiBjYWNoZS4KKyAgICAgICAgbG9hZGVyKCktPmRldGFjaEZyb21Q YXJlbnQoKSBpcyBvbmx5IGFwcGxpZWQgZm9yIHRoZSBtYWluIGZyYW1lLgorICAgICAgICBsb2Fk ZXIoKS0+Y2FuY2VsQW5kQ2xlYXIoKSBpcyBub3QgdXNlZCBhbnltb3JlLgorCisgICAgICAgICog ZXdrL2V3a19mcmFtZS5jcHA6CisgICAgICAgIChfZXdrX2ZyYW1lX3NtYXJ0X2RlbCk6CisKIDIw MTItMDUtMDkgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAg ICAgICBNb3ZlIHN1c3BlbmRBbmltYXRpb25zIHRvIHVzZSBJbnRlcm5hbHMgaW50ZXJmYWNlLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcAppbmRleCA5NjRiNjkyLi4xNzJiYjJlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcApAQCAtMjI5LDggKzIyOSw5IEBAIHN0YXRpYyB2 b2lkIF9ld2tfZnJhbWVfc21hcnRfZGVsKEV2YXNfT2JqZWN0KiBld2tGcmFtZSkKICAgICAgICAg aWYgKHNtYXJ0RGF0YS0+ZnJhbWUpIHsKICAgICAgICAgICAgIFdlYkNvcmU6OkZyYW1lTG9hZGVy Q2xpZW50RWZsKiBmbGMgPSBfZXdrX2ZyYW1lX2xvYWRlcl9lZmxfZ2V0KHNtYXJ0RGF0YS0+ZnJh bWUpOwogICAgICAgICAgICAgZmxjLT5zZXRXZWJGcmFtZSgwKTsKLSAgICAgICAgICAgIHNtYXJ0 RGF0YS0+ZnJhbWUtPmxvYWRlcigpLT5kZXRhY2hGcm9tUGFyZW50KCk7Ci0gICAgICAgICAgICBz bWFydERhdGEtPmZyYW1lLT5sb2FkZXIoKS0+Y2FuY2VsQW5kQ2xlYXIoKTsKKyAgICAgICAgICAg IEVXS19GUkFNRV9TRF9HRVQoZXdrX3ZpZXdfZnJhbWVfbWFpbl9nZXQoc21hcnREYXRhLT52aWV3 KSwgbWFpblNtYXJ0RGF0YSk7CisgICAgICAgICAgICBpZiAobWFpblNtYXJ0RGF0YS0+ZnJhbWUg PT0gc21hcnREYXRhLT5mcmFtZSkgLy8gYXBwbHlpbmcgb25seSBmb3IgbWFpbiBmcmFtZSBpcyBl bm91Z2ggKHdpbGwgdHJhdmVyc2UgdGhyb3VnaCBmcmFtZSB0cmVlKQorICAgICAgICAgICAgICAg IHNtYXJ0RGF0YS0+ZnJhbWUtPmxvYWRlcigpLT5kZXRhY2hGcm9tUGFyZW50KCk7CiAgICAgICAg ICAgICBzbWFydERhdGEtPmZyYW1lID0gMDsKICAgICAgICAgfQogCg== 142421 2012-05-16 23:40:48 -0700 2012-05-17 00:29:16 -0700 to be landed. bug85879_v3 text/plain 3117 mikhail.pozdnyakov Y29tbWl0IGIzZmNhY2I5MTUxMDAzMTZjOWQ0NzNjNzhiNmUxN2FiODAwZmUzNjYKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg VGh1IE1heSAxMCAxMjoxMjozNiAyMDEyICswMzAwCgogICAgYnVnODU4NzkKCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmNl NWRlYS4uYmYyM2U1OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA1LTEwICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCisgICAgICAgIFtF RkxdIGZhc3QvZnJhbWVzL2ZyYW1lLWNyYXNoLXdpdGgtcGFnZS1jYWNoZS5odG1sIGlzIGNyYXNo aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTg3 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5vYW0gUm9zZW50aGFsLgorCisgICAgICAgICogcGxh dGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDogUmVtb3ZlZCBmYXN0L2ZyYW1lcy9mcmFt ZS1jcmFzaC13aXRoLXBhZ2UtY2FjaGUuaHRtbC4KKwogMjAxMi0wNS0xNiAgRG9taW5payBSw7Z0 dHNjaGVzICA8ZG9taW5pay5yb3R0c2NoZXNAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW0RS VF0gR2FyZGVuaW5nIGZhaWx1cmVzIGFmdGVyIHIxMTcxMjMgYW5kIHIxMTcyMDUKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9lZmwvdGVzdF9leHBlY3RhdGlvbnMudHh0CmluZGV4IGRiODk3ZTgu LmI2MzVjYjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC90ZXN0X2V4cGVj dGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRp b25zLnR4dApAQCAtMzg3LDggKzM4Nyw2IEBAIEJVR1dLODU5MDIgU0xPVyBERUJVRyA6IGZhc3Qv b3ZlcmZsb3cvbG90cy1vZi1zaWJsaW5nLWlubGluZS1ib3hlcy5odG1sID0gUEFTUwogCiBCVUdX Szg1Nzk5IDogZmFzdC9jc3MvZm9udC1mYWNlLWRvd25sb2FkLWVycm9yLmh0bWwgPSBUSU1FT1VU CiAKLUJVR1dLODU4NzkgOiBmYXN0L2ZyYW1lcy9mcmFtZS1jcmFzaC13aXRoLXBhZ2UtY2FjaGUu aHRtbCA9IENSQVNICi0KIEJVR1dLRUZMIFNMT1cgREVCVUcgOiBodHRwL3Rlc3RzL2luY3JlbWVu dGFsL3Nsb3ctdXRmOC1odG1sLnBsID0gUEFTUwogCiAvLyBQZXJmIHRlc3RzIGFyZSB3YXkgdG9v IHNsb3cgb24gZGVidWcgYnVpbGRzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCmluZGV4IDAyMzUwZWIuLjE1OTUz MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNS0xMCAgTWlraGFp bCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KKworICAgICAgICBb RUZMXSBmYXN0L2ZyYW1lcy9mcmFtZS1jcmFzaC13aXRoLXBhZ2UtY2FjaGUuaHRtbCBpcyBjcmFz aGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU4 NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOb2FtIFJvc2VudGhhbC4KKworICAgICAgICBfZXdr X2ZyYW1lX3NtYXJ0X2RlbCgpIGlzIGNvbnNpZGVyaW5nIG5vdyB0aGF0IHRoZSBmcmFtZSBjYW4g YmUgcHJlc2VudCBpbiBjYWNoZS4KKyAgICAgICAgbG9hZGVyKCktPmRldGFjaEZyb21QYXJlbnQo KSBpcyBvbmx5IGFwcGxpZWQgZm9yIHRoZSBtYWluIGZyYW1lLgorICAgICAgICBsb2FkZXIoKS0+ Y2FuY2VsQW5kQ2xlYXIoKSBpcyBub3QgdXNlZCBhbnltb3JlLgorCisgICAgICAgICogZXdrL2V3 a19mcmFtZS5jcHA6CisgICAgICAgIChfZXdrX2ZyYW1lX3NtYXJ0X2RlbCk6CisKIDIwMTItMDUt MTYgIE1pY2hhxYIgUGFrdcWCYSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1zdW5nLmNvbT4KIAog ICAgICAgICBbRUZMXSBBZGQgbmV3IGNvbW1hbmRzIGZvciBFd2tfRWRpdG9yX0NvbW1hbmQuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcCBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCmluZGV4IDg3YTkzZmYuLjYxMWRlMTcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCkBAIC0yMzMsOCArMjMzLDkgQEAgc3RhdGljIHZv aWQgX2V3a19mcmFtZV9zbWFydF9kZWwoRXZhc19PYmplY3QqIGV3a0ZyYW1lKQogICAgICAgICBp ZiAoc21hcnREYXRhLT5mcmFtZSkgewogICAgICAgICAgICAgV2ViQ29yZTo6RnJhbWVMb2FkZXJD bGllbnRFZmwqIGZsYyA9IF9ld2tfZnJhbWVfbG9hZGVyX2VmbF9nZXQoc21hcnREYXRhLT5mcmFt ZSk7CiAgICAgICAgICAgICBmbGMtPnNldFdlYkZyYW1lKDApOwotICAgICAgICAgICAgc21hcnRE YXRhLT5mcmFtZS0+bG9hZGVyKCktPmRldGFjaEZyb21QYXJlbnQoKTsKLSAgICAgICAgICAgIHNt YXJ0RGF0YS0+ZnJhbWUtPmxvYWRlcigpLT5jYW5jZWxBbmRDbGVhcigpOworICAgICAgICAgICAg RVdLX0ZSQU1FX1NEX0dFVChld2tfdmlld19mcmFtZV9tYWluX2dldChzbWFydERhdGEtPnZpZXcp LCBtYWluU21hcnREYXRhKTsKKyAgICAgICAgICAgIGlmIChtYWluU21hcnREYXRhLT5mcmFtZSA9 PSBzbWFydERhdGEtPmZyYW1lKSAvLyBhcHBseWluZyBvbmx5IGZvciBtYWluIGZyYW1lIGlzIGVu b3VnaCAod2lsbCB0cmF2ZXJzZSB0aHJvdWdoIGZyYW1lIHRyZWUpCisgICAgICAgICAgICAgICAg c21hcnREYXRhLT5mcmFtZS0+bG9hZGVyKCktPmRldGFjaEZyb21QYXJlbnQoKTsKICAgICAgICAg ICAgIHNtYXJ0RGF0YS0+ZnJhbWUgPSAwOwogICAgICAgICB9CiAK