85744 2012-05-06 13:51:56 -0700 Update several build-webkit options to match the #defines they toggle 2012-05-06 17:13:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 53714 85456 1 eric eric abarth dbates webkit.review.bot oldest_to_newest 617155 0 eric 2012-05-06 13:51:56 -0700 Update several build-webkit options to match the #defines they toggle 617156 1 140432 eric 2012-05-06 13:53:12 -0700 Created attachment 140432 Patch 617157 2 eric 2012-05-06 13:55:12 -0700 Most of these defines are obscure enough that I don't believe we have any buildbots which depend on them. Users will very quickly learn the right one if they've been passing them manually on the command line. ;) 617158 3 eric 2012-05-06 13:56:21 -0700 Bug 53714 is where the #define rename happened for 3D_CANVAS in build-webkit. THis patch completes that work. :) 617159 4 140432 abarth 2012-05-06 13:58:01 -0700 Comment on attachment 140432 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140432&action=review > Tools/Scripts/webkitperl/FeatureList.pm:225 > - define => "ENABLE_JAVASCRIPT_DEBUGGER", default => 1, value => \$javaScriptDebuggerSupport }, > + define => "ENABLE_JAVASCRIPT_DEBUGGER", default => 1, value => \$javascriptDebuggerSupport }, :( 617234 5 140432 webkit.review.bot 2012-05-06 17:13:53 -0700 Comment on attachment 140432 Patch Clearing flags on attachment: 140432 Committed r116251: <http://trac.webkit.org/changeset/116251> 617235 6 webkit.review.bot 2012-05-06 17:13:57 -0700 All reviewed patches have been landed. Closing bug. 140432 2012-05-06 13:53:12 -0700 2012-05-06 17:13:53 -0700 Patch bug-85744-20120506135310.patch text/plain 4850 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MjM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWY1MDMzNTVmNjhhMjhiYjYzMjUxOTM0MzYyZmZmMDVi Nzk0OWRkNS4uZDk1Mzc1MjgyMmUwODU1YmNkMTBmOGM5ZjdiNjhlZjA1ODM0ODFkNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA1LTA2ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBVcGRhdGUgc2V2ZXJhbCBidWlsZC13ZWJraXQgb3B0aW9ucyB0byBtYXRjaCB0aGUgI2RlZmlu ZXMgdGhleSB0b2dnbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg1NzQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTW9zdCBub3RhYmxlIGhlcmUgaXMgZml4aW5nIC0tM2QtY2FudmFzIHRvIGJlIC0td2Vi Z2wgdGhlc2UgZGF5cyAtLQorICAgICAgICB0aGUgZGVmaW5lIHdhcyByZW5hbWVkIDE1IG1vbnRo cyBhZ28hCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG06CisK IDIwMTItMDUtMDIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFdl YktpdCBzaG91bGQgaGF2ZSBhbiBlYXN5IHdheSB0byBhZGQvcmVtb3ZlIEZFQVRVUkVfREVGSU5F UyBmb3IgYWxsIHBvcnRzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVh dHVyZUxpc3QucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KaW5k ZXggNmY5ZWY2ZDQ0M2EyMDk4ZmIxZDU2OGIxOTk0MWJmNzM3NDM1MzcyOC4uOWEyODY4MDdhNDEw ZjJiYjVjMTIzOWYyYWZiMmJiOGI0MDE0OTE5ZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9G ZWF0dXJlTGlzdC5wbQpAQCAtNzYsNyArNzYsNyBAQCBteSAoCiAgICAgJGlucHV0VHlwZVRpbWVT dXBwb3J0LAogICAgICRpbnB1dFR5cGVXZWVrU3VwcG9ydCwKICAgICAkaW5zcGVjdG9yU3VwcG9y dCwKLSAgICAkamF2YVNjcmlwdERlYnVnZ2VyU3VwcG9ydCwKKyAgICAkamF2YXNjcmlwdERlYnVn Z2VyU3VwcG9ydCwKICAgICAkbGVnYWN5Tm90aWZpY2F0aW9uc1N1cHBvcnQsCiAgICAgJGxlZ2Fj eVdlYktpdEJsb2JCdWlsZGVyU3VwcG9ydCwKICAgICAkbGlua1ByZWZldGNoU3VwcG9ydCwKQEAg LTg5LDcgKzg5LDcgQEAgbXkgKAogICAgICRtaHRtbFN1cHBvcnQsCiAgICAgJG1pY3JvZGF0YVN1 cHBvcnQsCiAgICAgJG11dGF0aW9uT2JzZXJ2ZXJzU3VwcG9ydCwKLSAgICAkbmV0c2NhcGVQbHVn aW5TdXBwb3J0LAorICAgICRuZXRzY2FwZVBsdWdpbkFQSVN1cHBvcnQsCiAgICAgJG5ldHdvcmtJ bmZvU3VwcG9ydCwKICAgICAkbm90aWZpY2F0aW9uc1N1cHBvcnQsCiAgICAgJG9yaWVudGF0aW9u RXZlbnRzU3VwcG9ydCwKQEAgLTEyMiw5ICsxMjIsNiBAQCBteSAoCiApOwogCiBteSBAZmVhdHVy ZXMgPSAoCi0gICAgeyBvcHRpb24gPT4gIjNkLWNhbnZhcyIsIGRlc2MgPT4gIlRvZ2dsZSBXZWJH TCBzdXBwb3J0IiwKLSAgICAgIGRlZmluZSA9PiAiRU5BQkxFX1dFQkdMIiwgZGVmYXVsdCA9PiBp c0FwcGxlTWFjV2ViS2l0KCksIHZhbHVlID0+IFwkd2ViZ2xTdXBwb3J0IH0sCi0KICAgICB7IG9w dGlvbiA9PiAiM2QtcmVuZGVyaW5nIiwgZGVzYyA9PiAiVG9nZ2xlIDNEIFJlbmRlcmluZyBzdXBw b3J0IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFXzNEX1JFTkRFUklORyIsIGRlZmF1bHQgPT4g KGlzQXBwbGVNYWNXZWJLaXQoKSB8fCBpc1F0KCkpLCB2YWx1ZSA9PiBcJHRocmVlRFJlbmRlcmlu Z1N1cHBvcnQgfSwKIApAQCAtMTM0LDcgKzEzMSw3IEBAIG15IEBmZWF0dXJlcyA9ICgKICAgICB7 IG9wdGlvbiA9PiAiYW5pbWF0aW9uLWFwaSIsIGRlc2MgPT4gIlRvZ2dsZSBBbmltYXRpb24gQVBJ IHN1cHBvcnQiLAogICAgICAgZGVmaW5lID0+ICJFTkFCTEVfQU5JTUFUSU9OX0FQSSIsIGRlZmF1 bHQgPT4gaXNCbGFja0JlcnJ5KCksIHZhbHVlID0+IFwkYW5pbWF0aW9uQVBJU3VwcG9ydCB9LAog Ci0gICAgeyBvcHRpb24gPT4gImJhdHRlcnktc3RhdHVzLWFwaSIsIGRlc2MgPT4gIlRvZ2dsZSBC YXR0ZXJ5IFN0YXR1cyBBUEkgc3VwcG9ydCIsCisgICAgeyBvcHRpb24gPT4gImJhdHRlcnktc3Rh dHVzIiwgZGVzYyA9PiAiVG9nZ2xlIEJhdHRlcnkgU3RhdHVzIHN1cHBvcnQiLAogICAgICAgZGVm aW5lID0+ICJFTkFCTEVfQkFUVEVSWV9TVEFUVVMiLCBkZWZhdWx0ID0+IChpc0VmbCgpIHx8IGlz QmxhY2tCZXJyeSgpKSwgdmFsdWUgPT4gXCRiYXR0ZXJ5U3RhdHVzU3VwcG9ydCB9LAogCiAgICAg eyBvcHRpb24gPT4gImJsb2IiLCBkZXNjID0+ICJUb2dnbGUgQmxvYiBzdXBwb3J0IiwKQEAgLTIy NSw3ICsyMjIsNyBAQCBteSBAZmVhdHVyZXMgPSAoCiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9J TlNQRUNUT1IiLCBkZWZhdWx0ID0+ICFpc1dpbkNFKCksIHZhbHVlID0+IFwkaW5zcGVjdG9yU3Vw cG9ydCB9LAogCiAgICAgeyBvcHRpb24gPT4gImphdmFzY3JpcHQtZGVidWdnZXIiLCBkZXNjID0+ ICJUb2dnbGUgSmF2YVNjcmlwdCBEZWJ1Z2dlciBzdXBwb3J0IiwKLSAgICAgIGRlZmluZSA9PiAi RU5BQkxFX0pBVkFTQ1JJUFRfREVCVUdHRVIiLCBkZWZhdWx0ID0+IDEsIHZhbHVlID0+IFwkamF2 YVNjcmlwdERlYnVnZ2VyU3VwcG9ydCB9LAorICAgICAgZGVmaW5lID0+ICJFTkFCTEVfSkFWQVND UklQVF9ERUJVR0dFUiIsIGRlZmF1bHQgPT4gMSwgdmFsdWUgPT4gXCRqYXZhc2NyaXB0RGVidWdn ZXJTdXBwb3J0IH0sCiAKICAgICB7IG9wdGlvbiA9PiAibGVnYWN5LW5vdGlmaWNhdGlvbnMiLCBk ZXNjID0+ICJUb2dnbGUgTGVnYWN5IE5vdGlmaWNhdGlvbnMgc3VwcG9ydCIsCiAgICAgICBkZWZp bmUgPT4gIkVOQUJMRV9MRUdBQ1lfTk9USUZJQ0FUSU9OUyIsIGRlZmF1bHQgPT4gaXNCbGFja0Jl cnJ5KCksIHZhbHVlID0+IFwkbGVnYWN5Tm90aWZpY2F0aW9uc1N1cHBvcnQgfSwKQEAgLTI2Mywx MyArMjYwLDEzIEBAIG15IEBmZWF0dXJlcyA9ICgKICAgICB7IG9wdGlvbiA9PiAibXV0YXRpb24t b2JzZXJ2ZXJzIiwgZGVzYyA9PiAiVG9nZ2xlIE11dGF0aW9uIE9ic2VydmVycyBzdXBwb3J0IiwK ICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX01VVEFUSU9OX09CU0VSVkVSUyIsIGRlZmF1bHQgPT4g MSwgdmFsdWUgPT4gXCRtdXRhdGlvbk9ic2VydmVyc1N1cHBvcnQgfSwKIAotICAgIHsgb3B0aW9u ID0+ICJuZXRzY2FwZS1wbHVnaW4iLCBkZXNjID0+ICJUb2dnbGUgTmV0c2NhcGUgUGx1Z2luIEFQ SSBzdXBwb3J0IiwKLSAgICAgIGRlZmluZSA9PiAiRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEki LCBkZWZhdWx0ID0+ICFpc0VmbCgpLCB2YWx1ZSA9PiBcJG5ldHNjYXBlUGx1Z2luU3VwcG9ydCB9 LAorICAgIHsgb3B0aW9uID0+ICJuZXRzY2FwZS1wbHVnaW4tYXBpIiwgZGVzYyA9PiAiVG9nZ2xl IE5ldHNjYXBlIFBsdWdpbiBBUEkgc3VwcG9ydCIsCisgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9O RVRTQ0FQRV9QTFVHSU5fQVBJIiwgZGVmYXVsdCA9PiAhaXNFZmwoKSwgdmFsdWUgPT4gXCRuZXRz Y2FwZVBsdWdpbkFQSVN1cHBvcnQgfSwKIAotICAgIHsgb3B0aW9uID0+ICJuZXR3b3JrLWluZm8i LCBkZXNjID0+ICJUb2dnbGUgTmV0d29yayBJbmZvcm1hdGlvbiBBUEkgc3VwcG9ydCIsCisgICAg eyBvcHRpb24gPT4gIm5ldHdvcmstaW5mbyIsIGRlc2MgPT4gIlRvZ2dsZSBOZXR3b3JrIEluZm8g c3VwcG9ydCIsCiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9ORVRXT1JLX0lORk8iLCBkZWZhdWx0 ID0+IGlzRWZsKCksIHZhbHVlID0+IFwkbmV0d29ya0luZm9TdXBwb3J0IH0sCiAKLSAgICB7IG9w dGlvbiA9PiAibm90aWZpY2F0aW9ucyIsIGRlc2MgPT4gIlRvZ2dsZSBOb3RpZmljYXRpb25zIFN1 cHBvcnQiLAorICAgIHsgb3B0aW9uID0+ICJub3RpZmljYXRpb25zIiwgZGVzYyA9PiAiVG9nZ2xl IE5vdGlmaWNhdGlvbnMgc3VwcG9ydCIsCiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9OT1RJRklD QVRJT05TIiwgZGVmYXVsdCA9PiBpc0JsYWNrQmVycnkoKSwgdmFsdWUgPT4gXCRub3RpZmljYXRp b25zU3VwcG9ydCB9LAogCiAgICAgeyBvcHRpb24gPT4gIm9yaWVudGF0aW9uLWV2ZW50cyIsIGRl c2MgPT4gIlRvZ2dsZSBPcmllbnRhdGlvbiBFdmVudHMgc3VwcG9ydCIsCkBAIC0zMzUsNiArMzMy LDkgQEAgbXkgQGZlYXR1cmVzID0gKAogICAgIHsgb3B0aW9uID0+ICJ2aWRlby10cmFjayIsIGRl c2MgPT4gIlRvZ2dsZSBWaWRlbyBUcmFjayBzdXBwb3J0IiwKICAgICAgIGRlZmluZSA9PiAiRU5B QkxFX1ZJREVPX1RSQUNLIiwgZGVmYXVsdCA9PiAoaXNBcHBsZVdlYktpdCgpIHx8IGlzR3RrKCkg fHwgaXNFZmwoKSksIHZhbHVlID0+IFwkdmlkZW9UcmFja1N1cHBvcnQgfSwKIAorICAgIHsgb3B0 aW9uID0+ICJ3ZWJnbCIsIGRlc2MgPT4gIlRvZ2dsZSBXZWJHTCBzdXBwb3J0IiwKKyAgICAgIGRl ZmluZSA9PiAiRU5BQkxFX1dFQkdMIiwgZGVmYXVsdCA9PiBpc0FwcGxlTWFjV2ViS2l0KCksIHZh bHVlID0+IFwkd2ViZ2xTdXBwb3J0IH0sCisKICAgICB7IG9wdGlvbiA9PiAid2ViLWF1ZGlvIiwg ZGVzYyA9PiAiVG9nZ2xlIFdlYiBBdWRpbyBzdXBwb3J0IiwKICAgICAgIGRlZmluZSA9PiAiRU5B QkxFX1dFQl9BVURJTyIsIGRlZmF1bHQgPT4gMCwgdmFsdWUgPT4gXCR3ZWJBdWRpb1N1cHBvcnQg fSwKIAo=