85709 2012-05-05 07:22:47 -0700 Web Inspector: [JSC] support JS execution in the context of an isolated world 2012-07-05 02:18:34 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 85612 90594 0 yurys webkit-unassigned apavlov barraclough bweinstein charles.wei ggaren joepeck keishi loislo mark.lam oliver PeterHWang pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 616960 0 yurys 2012-05-05 07:22:47 -0700 Web Inspector should allow console evals in isolated worlds. 617028 1 oliver 2012-05-05 10:19:27 -0700 Can you explain what this actually means? 617083 2 yurys 2012-05-05 23:37:49 -0700 After https://bugs.webkit.org/show_bug.cgi?id=85612 is landed it should be possible to select exact JS context in which snippets entered in Web Inspector console should be executed. At the moment it is only possible to select a frame and evaluation will be performed in the main world context of that. This bug is about adding an option to specify exact isolated world in which to perform the evaluation. Most of the stuff will be added once fix for 85612 is landed and the only remaining part will be to provide information about non-main-world contexts from JS bindings to the inspector code. I was going to take a look at this when https://bugs.webkit.org/show_bug.cgi?id=85612 is fixed. 630130 3 yurys 2012-05-22 02:30:29 -0700 I'm trying to figure out what can be used to discriminate between different DOMWrapperWorlds on a given Frame. In V8 bindings each isolated context has its own security origin which is used in the inspector front-end as the context name. I don't see similar API in the JS bindings and it looks to me that in case of JSC all isolated contexts will have same security origin as the DOMWindow. Can someone familiar with the JS bindings enlighten me on this? 630627 4 ggaren 2012-05-22 11:58:02 -0700 (In reply to comment #3) > I'm trying to figure out what can be used to discriminate between different DOMWrapperWorlds on a given Frame. Inside WebCore, we use a DOMWrapperWorld pointer. See WebCore::ScriptController::evaluateInWorld(). To map the current execution context to the current DOMWrapperWorld, we use WebCore::currentWorld(): inline DOMWrapperWorld* currentWorld(JSC::ExecState* exec) { return JSC::jsCast<JSDOMGlobalObject*>(exec->lexicalGlobalObject())->world(); } 631238 5 yurys 2012-05-22 22:53:59 -0700 (In reply to comment #4) > (In reply to comment #3) > > I'm trying to figure out what can be used to discriminate between different DOMWrapperWorlds on a given Frame. > > Inside WebCore, we use a DOMWrapperWorld pointer. It is still not clear to me how we can represent the world to the user in the inspector UI. In V8 bindings each V8IsolatedContext (a counterpart of JSDOMWindowShell in case of non-main world as I understand) will have its own security origin which is basically a URL of the extension which created that context. In the inspector UI we have a combobox with URLs of all the extensions that have content scripts in the selected Frame. The URLs are quite convenient for specifying a context where the console evaluation should happen. The problem is that DOMWrapperWorld doesn't provide access to such URL. I didn't find a good identifier(which could be used in the inspector UI) on JSDOMWindowShell either. 631262 6 ggaren 2012-05-22 23:17:21 -0700 (In reply to comment #5) > In the inspector UI we have a combobox with URLs of all the extensions that have content scripts in the selected Frame. Which URL do you use? The content script URL? Global page URL? Something else? In WebKit, DOMWrapperWorld doesn't require an associated URL or domain, so it doesn't have one to display. Perhaps you could infer a URL for display simply by recording the first URL passed to ScriptController::evaluateInWorld() for any give DOMWrapperWorld. 631277 7 yurys 2012-05-22 23:39:32 -0700 (In reply to comment #6) > (In reply to comment #5) > > In the inspector UI we have a combobox with URLs of all the extensions that have content scripts in the selected Frame. > > Which URL do you use? The content script URL? Global page URL? Something else? > The URL of an extension that created the context and will evaluate all content scripts in it. As I understand this URL is used for security checks when the content script sends XHR for example(a counterpart of DOMWindow::securityOrigin for isolated world). > In WebKit, DOMWrapperWorld doesn't require an associated URL or domain, so it doesn't have one to display. Perhaps you could infer a URL for display simply by recording the first URL passed to ScriptController::evaluateInWorld() for any give DOMWrapperWorld. This sounds reasonable, given that DOMWrapperWorld doesn't require an associated URL or domain I don't think we can come up with a better solution in this case. 657483 8 PeterHWang 2012-06-26 03:48:10 -0700 Is someone working on it now? If not, I'd like to have a try. 659593 9 timothy 2012-06-28 10:20:49 -0700 I don't think anyone is. 662636 10 150707 PeterHWang 2012-07-03 19:04:23 -0700 Created attachment 150707 Patch 663346 11 150707 barraclough 2012-07-04 23:52:39 -0700 Comment on attachment 150707 Patch Looks good to me. 663361 12 150707 leo.yang 2012-07-05 00:21:50 -0700 Comment on attachment 150707 Patch Sending to cq. 663382 13 150707 webkit.review.bot 2012-07-05 01:20:05 -0700 Comment on attachment 150707 Patch Clearing flags on attachment: 150707 Committed r121891: <http://trac.webkit.org/changeset/121891> 663383 14 webkit.review.bot 2012-07-05 01:20:12 -0700 All reviewed patches have been landed. Closing bug. 150707 2012-07-03 19:04:23 -0700 2012-07-05 01:20:05 -0700 Patch bug-85709-20120704100420.patch text/plain 1976 PeterHWang U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxNzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjcyZDZiN2E1YjkyNzgz MjI0MGM3ZWU0MWRmNmM1MjNiNDUxZTBlMy4uZWQ5Y2QwODg2YjYyMmUzNzNlYjU2MjJlYzc4ZGZm ZjY1Mzc4MDVkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTAzICBQZXRl ciBXYW5nICA8cGV0ZXIud2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgV2ViIElu c3BlY3RvcjogW0pTQ10gc3VwcG9ydCBKUyBleGVjdXRpb24gaW4gdGhlIGNvbnRleHQgb2YgYW4g aXNvbGF0ZWQgd29ybGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg1NzA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm8gbmV3IHRlc3QgY2FzZSBmb3IgdGhpcyBidWcuIAorCisgICAgICAgICogYmluZGlu Z3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRDb250 cm9sbGVyOjpjb2xsZWN0SXNvbGF0ZWRDb250ZXh0cyk6CisgICAgICAgIChXZWJDb3JlKToKKwog MjAxMi0wNy0wMiAgQ2hyaXMgR3VhbiAgPGNocmlzLmd1YW5AdG9yY2htb2JpbGUuY29tLmNuPgog CiAgICAgICAgIFtCbGFja0JlcnJ5XSBSZWZhY3RvciA6IG1vdmUgdGhlIGltcGxlbWVudGF0aW9u IG9mIGdldE1JTUVUeXBlRm9yRXh0ZW5zaW9uIGFuZCBnZXRQcmVmZXJyZWRFeHRlbnNpb25Gb3JN SU1FVHlwZSBpbnRvIEJsYWNrQmVycnkgcGxhdGZvcm0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHAKaW5kZXggNTBhOGFjNTMyNWM5MjY2NTIwYzkz YmEzYzJhNzFhYWE0YjM2OTlmOC4uMDZjNzk5NjQwYThmY2FkZmZlZWVhOGQ3ZTU1MjNmY2FiZDU4 YzVkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJv bGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxl ci5jcHAKQEAgLTMzNiwxMCArMzM2LDE1IEBAIHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6c2V0Q2Fw dHVyZUNhbGxTdGFja0ZvclVuY2F1Z2h0RXhjZXB0aW9ucyhib29sKQogewogfQogCi12b2lkIFNj cmlwdENvbnRyb2xsZXI6OmNvbGxlY3RJc29sYXRlZENvbnRleHRzKFZlY3RvcjxzdGQ6OnBhaXI8 SlNDOjpFeGVjU3RhdGUqLCBTZWN1cml0eU9yaWdpbio+ID4mKQordm9pZCBTY3JpcHRDb250cm9s bGVyOjpjb2xsZWN0SXNvbGF0ZWRDb250ZXh0cyhWZWN0b3I8c3RkOjpwYWlyPEpTQzo6RXhlY1N0 YXRlKiwgU2VjdXJpdHlPcmlnaW4qPiA+JiByZXN1bHQpCiB7Ci0gICAgLy8gRklYTUUoODU3MDkp OiBzdXBwb3J0IGlzb2xhdGVkIGNvbnRleHRzIGluc3BlY3Rpb24gZm9yIEpTQy4KKyAgICBmb3Ig KFNoZWxsTWFwOjppdGVyYXRvciBpdGVyID0gbV93aW5kb3dTaGVsbHMuYmVnaW4oKTsgaXRlciAh PSBtX3dpbmRvd1NoZWxscy5lbmQoKTsgKytpdGVyKSB7CisgICAgICAgIEpTQzo6RXhlY1N0YXRl KiBleGVjID0gaXRlci0+c2Vjb25kLT53aW5kb3coKS0+Z2xvYmFsRXhlYygpOworICAgICAgICBT ZWN1cml0eU9yaWdpbiogb3JpZ2luID0gaXRlci0+c2Vjb25kLT53aW5kb3coKS0+aW1wbCgpLT5z ZWN1cml0eU9yaWdpbigpOworICAgICAgICByZXN1bHQuYXBwZW5kKHN0ZDo6cGFpcjxTY3JpcHRT dGF0ZSosIFNlY3VyaXR5T3JpZ2luKj4oZXhlYywgb3JpZ2luKSk7CisgICAgfQogfQorCiAjZW5k aWYKIAogI2lmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQo=