85678 2012-05-04 15:51:16 -0700 Leaf non self-painting layers should bail out early in RenderLayer::paintLayer 2012-09-18 11:57:34 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED http://dglazkov.github.com/performance-tests/biggrid.html P2 Normal --- 75001 92258 1 jchaffraix jchaffraix enne eric jamesr mitz simon.fraser webkit.review.bot oldest_to_newest 616752 0 jchaffraix 2012-05-04 15:51:16 -0700 Currently RenderLayer::paintLayer() doesn't check for leaf non self-painting layers (it checks for fully transparent layers though). However in this case, we have no work to do. For cases like tables with RenderLayers on every cells where the RenderLayer tree is heavily weighted by its leafs, paintLayer() is introducing some overhead. The benchmark in mind here is http://dglazkov.github.com/performance-tests/biggrid.html. Create a 10,000 rows x 50 columns and tick "overflow: hidden" (which creates an overflow RenderLayer on all the cells): in this case, the paint time when scrolling is around 120 ms on my machine. This is due to walking all RenderLayers and doing some checks to end up not painting as we are not visible and don't need to anyway. Patch forthcoming. 616766 1 140349 jchaffraix 2012-05-04 16:05:21 -0700 Created attachment 140349 Propsed change. Nice improvement. 616839 2 140349 darin 2012-05-04 17:54:02 -0700 Comment on attachment 140349 Propsed change. Nice improvement. View in context: https://bugs.webkit.org/attachment.cgi?id=140349&action=review > Source/WebCore/ChangeLog:13 > + For RenderLayer trees heavily weigthed by their leafs (like a table with a leaf RenderLayer for each cells), typo: weigthed I would just say: For layer trees that have a large number of leaf nodes 616863 3 jchaffraix 2012-05-04 19:16:26 -0700 Committed r116203: <http://trac.webkit.org/changeset/116203> 620687 4 140349 jchaffraix 2012-05-10 10:22:34 -0700 Comment on attachment 140349 Propsed change. Nice improvement. Clear cq? flag from old attachment. 658406 5 mitz 2012-06-27 00:16:27 -0700 This cause bug 90052. 658407 6 mitz 2012-06-27 00:16:56 -0700 Sorry, I mean that <http://trac.webkit.org/r116203> caused bug 99052. 140349 2012-05-04 16:05:21 -0700 2012-05-10 10:22:34 -0700 Propsed change. Nice improvement. bug-85678-20120504160520.patch text/plain 2146 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1OTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODBiMzEyZTk2NWIwY2Q4 MjliZmMyZmNkODQ5YmU2NmMwZGQ1MmU2Ni4uMzZhMjJhMjc5NzE0ZDZkNzE4MTA4ZTA1Y2E2ZTkw NzYxNjk0NWVlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA1LTA0ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIExlYWYgbm9u IHNlbGYtcGFpbnRpbmcgbGF5ZXJzIHNob3VsZCBiYWlsIG91dCBlYXJseSBpbiBSZW5kZXJMYXll cjo6cGFpbnRMYXllcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODU2NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQZXJmb3JtYW5jZSBvcHRpbWl6YXRpb24sIG5vIGV4cGVjdGVkIGNoYW5nZSBpbiBiZWhh dmlvci4KKworICAgICAgICBUaGUgZ2lzdCBvZiB0aGUgY2hhbmdlIGlzIHRoYXQgbGVhZiBub24g c2VsZi1wYWludGluZyBsYXllcnMgZG9uJ3QgbmVlZCB0byBiZSBwYWludGVkIGFzIHRoZWlyCisg ICAgICAgIGFzc29jaWF0ZWQgUmVuZGVyQm94TW9kZWxPYmplY3Qgc2hvdWxkIHByb3Blcmx5IHBh aW50IGl0c2VsZiB3aXRob3V0IGFueSBoZWxwLgorCisgICAgICAgIEZvciBSZW5kZXJMYXllciB0 cmVlcyBoZWF2aWx5IHdlaWd0aGVkIGJ5IHRoZWlyIGxlYWZzIChsaWtlIGEgdGFibGUgd2l0aCBh IGxlYWYgUmVuZGVyTGF5ZXIgZm9yIGVhY2ggY2VsbHMpLAorICAgICAgICBub3QgYmFpbGluZyBv dXQgaXMgYSBiaWcgb3ZlcmhlYWQgYXMgaXQgZW5kcyB1cCBkb2luZyBhIGxvdCBvZiBjb21wdXRh dGlvbiBmb3Igbm8gcmVhbCBwYWludGluZy4gU2VlCisgICAgICAgIGh0dHA6Ly9kZ2xhemtvdi5n aXRodWIuY29tL3BlcmZvcm1hbmNlLXRlc3RzL2JpZ2dyaWQuaHRtbCBmb3IgYSBiZW5jaG1hcmsg Zm9yIHRoYXQuIE9uIG15IG1hY2hpbmUsIGl0CisgICAgICAgIHJlZHVjZXMgdGhlIHBhaW50IHRp bWUgd2hlbiBzY3JvbGxpbmcgdG8gNzBtcyBmcm9tIDEyMG1zICg0NSUgc3BlZWR1cCkuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyTGF5ZXI6OnBhaW50TGF5ZXIpOgorCiAyMDEyLTA1LTAzICBDaHJpcyBGbGVpemFjaCAgPGNm bGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgYWNjZXNzaWJpbGl0eS9taXNzcGVsbGVkLWF0 dHJpYnV0ZWQtc3RyaW5nLmh0bWwgdGVzdCBzb21ldGltZXMgdGhyb3dzIGV4Y2VwdGlvbnMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IDhjZjlhMWMwNjkzODE2 M2Y2MmYzMmFmNGVmNTEwY2VlNjllZGRhZjMuLjllM2Y0N2VkZjZmNzgwNDg4N2MyN2VjZDc2NmM2 ZDJlZDI0NDZlMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApA QCAtMjkwMCw2ICsyOTAwLDEwIEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnBhaW50TGF5ZXIoUmVuZGVy TGF5ZXIqIHJvb3RMYXllciwgR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LAogICAgIGlmICghcmVu ZGVyZXIoKS0+b3BhY2l0eSgpKQogICAgICAgICByZXR1cm47CiAKKyAgICAvLyBOb24gc2VsZi1w YWludGluZyBsZWFmIGxheWVycyBkb24ndCBuZWVkIHRvIGJlIHBhaW50ZWQgYXMgdGhlaXIgcmVu ZGVyZXIoKSBzaG91bGQgcHJvcGVybHkgcGFpbnQgaXRzZWxmLgorICAgIGlmICghaXNTZWxmUGFp bnRpbmdMYXllcigpICYmICFmaXJzdENoaWxkKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIGlm IChwYWludHNXaXRoVHJhbnNwYXJlbmN5KHBhaW50QmVoYXZpb3IpKQogICAgICAgICBwYWludEZs YWdzIHw9IFBhaW50TGF5ZXJIYXZlVHJhbnNwYXJlbmN5OwogCg==