85620 2012-05-04 07:19:42 -0700 [EFL] Page caching permission from EFL's FrameLoaderClient 2012-05-22 11:21:33 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim lucas.de.marchi rakuco tmpsantos webkit.review.bot oldest_to_newest 616181 0 mikhail.pozdnyakov 2012-05-04 07:19:42 -0700 EFL's FrameLoaderClient should allow page caching in order to fix fast/events/pagehide-xhr-open.html fast/loader/window-properties-restored-from-page-cache.html and unskip fast/events/pageshow-pagehide-on-back-cached.html (and maybe others) 616918 1 140385 mikhail.pozdnyakov 2012-05-05 01:39:51 -0700 Created attachment 140385 fix 616985 2 140385 rakuco 2012-05-05 09:03:37 -0700 Comment on attachment 140385 fix Do you know what commit should have flipped this flag? 617103 3 mikhail.pozdnyakov 2012-05-06 07:49:22 -0700 (In reply to comment #2) > (From update of attachment 140385 [details]) > Do you know what commit should have flipped this flag? e9ecc747 +2010-04-15 Leandro Pereira <leandro@profusion.mobi> + + Reviewed by Kenneth Rohde Christiansen. + + Add EFL port files to efl/WebCoreSupport. + http://webkit.org/b/35915 + + * efl/WebCoreSupport/FrameLoaderClientEfl.cpp: Added. + * efl/WebCoreSupport/FrameLoaderClientEfl.h: Added. 617142 4 rakuco 2012-05-06 11:53:03 -0700 Weird, I remember some page cache-related bugs being sent afterwards, so I thought the missing bits were implemented later. Looks fine, I guess. 617797 5 140385 gustavo 2012-05-07 12:01:58 -0700 Comment on attachment 140385 fix We also added a setting to our WebKitGTK+ API, do you (plan to )have something of the sort for EFL? 617856 6 140385 webkit.review.bot 2012-05-07 13:10:04 -0700 Comment on attachment 140385 fix Clearing flags on attachment: 140385 Committed r116341: <http://trac.webkit.org/changeset/116341> 617857 7 webkit.review.bot 2012-05-07 13:10:09 -0700 All reviewed patches have been landed. Closing bug. 618438 8 mikhail.pozdnyakov 2012-05-08 02:27:51 -0700 (In reply to comment #5) > (From update of attachment 140385 [details]) > We also added a setting to our WebKitGTK+ API, do you (plan to )have something of the sort for EFL? In EFL we have it in ewk_view: EAPI Eina_Bool ewk_view_setting_page_cache_get(const Evas_Object *o); EAPI Eina_Bool ewk_view_setting_page_cache_set(Evas_Object *o, Eina_Bool enable); 618447 9 tmpsantos 2012-05-08 02:54:23 -0700 I might be wrong, but this patch is causing this test here to crash: fast/frames/frame-crash-with-page-cache.html 618449 10 tmpsantos 2012-05-08 02:56:36 -0700 (In reply to comment #9) > I might be wrong, but this patch is causing this test here to crash: > fast/frames/frame-crash-with-page-cache.html Yes, it is. I rolled out the patch locally and it doesn't crash. I'm gonna open a bug for that. 140385 2012-05-05 01:39:51 -0700 2012-05-07 13:10:04 -0700 fix bug85620 text/plain 4286 mikhail.pozdnyakov Y29tbWl0IGIzZjI1NGY4YjA0ZmUyNTlhNTY3MzExMzEzYmMzMGE3Yzc4MmQxZmIKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg U2F0IE1heSA1IDExOjM4OjMwIDIwMTIgKzAzMDAKCiAgICBidWc4NTYyMAoKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwODkx NDIyLi4wZjE0MDNiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDUtMDUgIE1pa2hhaWwg UG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CisKKyAgICAgICAgW0VG TF0gUGFnZSBjYWNoaW5nIHBlcm1pc3Npb24gZnJvbSBFRkwncyBGcmFtZUxvYWRlckNsaWVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU2MjAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbnNraXAgYnVn LXJlbGF0ZWQgdGVzdGNhc2VzLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1NraXBwZWQ6CisK IDIwMTItMDUtMDMgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IGNyZWF0ZVJhd0xvY2F0aW9uQnlVUkwgaXMgdG9vIHNsb3cg aWYgYSBiaWcgbnVtYmVyIG9mIGV2YWxzIGhhcHBlbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2VmbC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQK aW5kZXggNTFhMTJkNi4uYThjYmZlNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v ZWZsL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKQEAgLTEw NjQsMjQgKzEwNjQsMTMgQEAgZmFzdC90ZXh0L2p1c3RpZmljYXRpb24tcGFkZGluZy1taWQtd29y ZC5odG1sCiBmYXN0L3RleHQvbWlkd29yZC1icmVhay1hZnRlci1icmVha2FibGUtY2hhci5odG1s CiBmYXN0L2NhbnZhcy93ZWJnbAogZmFzdC9kb20vV2luZG93L3RpbWVyLXJlc3VtZS1vbi1uYXZp Z2F0aW9uLWJhY2suaHRtbAotZmFzdC9ldmVudHMvcGFnZWhpZGUtdGltZW91dC5odG1sCi1mYXN0 L2V2ZW50cy9wYWdlc2hvdy1wYWdlaGlkZS1vbi1iYWNrLWNhY2hlZC13aXRoLWZyYW1lcy5odG1s Ci1mYXN0L2V2ZW50cy9wYWdlc2hvdy1wYWdlaGlkZS1vbi1iYWNrLWNhY2hlZC5odG1sCiBmYXN0 L2V2ZW50cy90YWItZm9jdXMtYW5jaG9yLmh0bWwKLWZhc3QvaGFybmVzcy9wYWdlLWNhY2hlLWNy YXNoLW9uLWRhdGEtdXJscy5odG1sCi1mYXN0L2hhcm5lc3MvdXNlLXBhZ2UtY2FjaGUuaHRtbAog ZmFzdC9oaXN0b3J5L2JhY2stZm9yd2FyZC1yZXNldC1hZnRlci1lcnJvci1oYW5kbGluZy5odG1s Ci1mYXN0L2hpc3RvcnkvdGltZWQtcmVmcmVzaC1pbi1jYWNoZWQtZnJhbWUuaHRtbAotZmFzdC9p bWFnZXMvYW5pbWF0ZWQtZ2lmLXJlc3RvcmVkLWZyb20tYmZjYWNoZS5odG1sCi1mYXN0L21lZGlh L21lZGlhLXF1ZXJ5LWxpc3QtMDQuaHRtbAotZmFzdC9vdmVyZmxvdy9ob3Jpem9udGFsLXNjcm9s bC1hZnRlci1iYWNrLmh0bWwKIGZhc3QvcmVwYWludC9uby1jYXJldC1yZXBhaW50LWluLW5vbi1j b250ZW50LWVkaXRhYmxlLWVsZW1lbnQuaHRtbAotZmFzdC92aWV3cG9ydC92aWV3cG9ydC0xMjgu aHRtbAogaHR0cC90ZXN0cy9jYW52YXMvd2ViZ2wvb3JpZ2luLWNsZWFuLWNvbmZvcm1hbmNlLmh0 bWwKIGh0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdvcmsvcGluZy5odG1sCiBodHRwL3Rlc3RzL25h dmlnYXRpb24vZ28tYmFjay10by1lcnJvci1wYWdlLmh0bWwKIGxvYWRlci9nby1iYWNrLXRvLWRp ZmZlcmVudC13aW5kb3ctc2l6ZS5odG1sCi1tZWRpYS9yZXN0b3JlLWZyb20tcGFnZS1jYWNoZS5o dG1sCiBmYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWNvbnRhaW5lci13aGl0ZS1zcGFjZS5o dG1sCiBmYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWZ1bGx5LWFsaWduZWQtaG9yaXpvbnRh bGx5Lmh0bWwKIGZhc3Qvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtaWZyYW1lLW5vLXNjcm9sbGFi bGUtY29udGVudC5odG1sCkBAIC0xNTIwLDcgKzE1MDksNiBAQCBmYXN0L2V2ZW50cy9wbGF0Zm9y bS13aGVlbGV2ZW50LXBhZ2luZy15LWluLXNjcm9sbGluZy1kaXYuaHRtbAogZmFzdC9ldmVudHMv cGxhdGZvcm0td2hlZWxldmVudC1wYWdpbmcteS1pbi1zY3JvbGxpbmctcGFnZS5odG1sCiBmYXN0 L2V2ZW50cy9wb2ludGVyLWV2ZW50cy0yLmh0bWwKIGZhc3QvZXZlbnRzL3JlbW92ZS10YXJnZXQt d2l0aC1zaGFkb3ctaW4tZHJhZy5odG1sCi1mYXN0L2V2ZW50cy9zdXNwZW5kLXRpbWVycy5odG1s CiBmYXN0L2ZpbGVzL2Jsb2ItYnVpbGRlci1jcmFzaC5odG1sCiBmYXN0L2ZpbGVzL2Jsb2Itc2xp Y2Utb3ZlcmZsb3cuaHRtbAogZmFzdC9maWxlcy9ibG9iLXNsaWNlLXRlc3QuaHRtbApAQCAtMTkw Niw3ICsxODk0LDYgQEAgaHR0cC90ZXN0cy9taXNjL1NWR0ZvbnQtZGVsYXllZC1sb2FkLmh0bWwK IGh0dHAvdGVzdHMvbWlzYy9pZnJhbWUtaW52YWxpZC1zb3VyY2UtY3Jhc2guaHRtbAogaHR0cC90 ZXN0cy9taXNjL3N1Ym1pdC1wb3N0LWtleWdlbi5odG1sCiBodHRwL3Rlc3RzL25hdmlnYXRpb24v Zm9yd2FyZC1hbmQtY2FuY2VsLmh0bWwKLWh0dHAvdGVzdHMvbmF2aWdhdGlvbi9odHRwcy1pbi1w YWdlLWNhY2hlLmh0bWwKIGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9uZXctd2luZG93LXJlZGlyZWN0 LWhpc3RvcnkuaHRtbAogaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL25vLXJlZmVycmVyLXJlc2V0Lmh0 bWwKIGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9uby1yZWZlcnJlci10YXJnZXQtYmxhbmsuaHRtbApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9l ZmwvQ2hhbmdlTG9nCmluZGV4IDVhNjFkMGIuLmZkNjgyODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvZWZsL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMi0wNS0wNSAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5w b3pkbnlha292QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBQYWdlIGNhY2hpbmcgcGVybWlz c2lvbiBmcm9tIEVGTCdzIEZyYW1lTG9hZGVyQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTYyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyYW1lTG9hZGVyQ2xpZW50RWZsOjpjYW5DYWNoZVBh Z2UoKSByZXR1cm5zIHRydWUuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRl ckNsaWVudEVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEVmbDo6 Y2FuQ2FjaGVQYWdlKToKKwogMjAxMi0wNS0wMyAgRmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZW1vdmluZyBsaW5lIGluIGNvbXB1dGVWaWV3cG9ydEF0dHJp YnV0ZXMgdGhhdCBlbmZvcmNlcyBhIG1pbmltdW0gc2NhbGUgZmFjdG9yIHRvIG5ldmVyIGFsbG93 IHpvb21pbmcgb3V0IG1vcmUgdGhhbiB2aWV3cG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRFZmwuY3BwIGIvU291cmNlL1dl YktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRFZmwuY3BwCmluZGV4IDEw ODIxMTIuLmFlYWM4MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBw b3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJD b3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5jcHAKQEAgLTg5NCw3ICs4OTQsNyBAQCBi b29sIEZyYW1lTG9hZGVyQ2xpZW50RWZsOjpzaG91bGRGYWxsQmFjayhjb25zdCBSZXNvdXJjZUVy cm9yJiBlcnJvcikKIAogYm9vbCBGcmFtZUxvYWRlckNsaWVudEVmbDo6Y2FuQ2FjaGVQYWdlKCkg Y29uc3QKIHsKLSAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIHRydWU7CiB9CiAKIEZyYW1l KiBGcmFtZUxvYWRlckNsaWVudEVmbDo6ZGlzcGF0Y2hDcmVhdGVQYWdlKGNvbnN0IE5hdmlnYXRp b25BY3Rpb24mKQo=