85609 2012-05-04 05:21:55 -0700 [EFL] media/video-poster-blocked-by-willsendrequest.html is flaky 2012-05-07 04:26:08 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85601 0 cdumez cdumez d-r gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 616094 0 cdumez 2012-05-04 05:21:55 -0700 The media/video-poster-blocked-by-willsendrequest.html test is flaky on the EFL build bot. It appears the flakyness is caused by media/crash-closing-page-with-media-as-plugin-fallback.html: This succeeds: ./Tools/Scripts/run-webkit-tests --efl -p media/video-poster-blocked-by-willsendrequest.html But this willl cause media/video-poster-blocked-by-willsendrequest.html to fail: ./Tools/Scripts/run-webkit-tests --efl -p LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback.html media/video-poster-blocked-by-willsendrequest.html 616097 1 cdumez 2012-05-04 05:24:05 -0700 This is related to the poster parameter of the video tag because the following removes flakyness: diff --git a/LayoutTests/media/resources/video-with-poster-as-object-fallback.html b/LayoutTests/media/resources/video-with-poster-as-object-fallback.html index 7f6983b..b64bcfd 100644 --- a/LayoutTests/media/resources/video-with-poster-as-object-fallback.html +++ b/LayoutTests/media/resources/video-with-poster-as-object-fallback.html @@ -1,7 +1,7 @@ <script src="../media-file.js"></script> <body onload="opener.childLoaded()"> <object height="500" width="500"> -<video id="theVideo" controls="controls" poster="../content/abe.png" preload="auto"> +<video id="theVideo" controls="controls" preload="auto"> </video> <script> document.getElementById("theVideo").src = findMediaFile('video', '../content/counting'); 616099 2 cdumez 2012-05-04 05:28:52 -0700 Same flakyness seems to happen on Lion (Bug 82976) 616148 3 140212 cdumez 2012-05-04 06:38:12 -0700 Created attachment 140212 Patch The issue was caused by the fact that media/crash-closing-page-with-media-as-plugin-fallback.html and media/video-poster-blocked-by-willsendrequest.html use the same PNG file as poster attribute in the video tag. The PNG file gets cached when the first test is executed and this somehow causes the second test to fail. I addressed this by clearing the caches between the tests in DumpRenderTreeChrome::resetDefaultsToConsistentValues(). The tests are no longer flaky. 616155 4 140212 rakuco 2012-05-04 06:41:42 -0700 Comment on attachment 140212 Patch Looks good! 616156 5 rakuco 2012-05-04 06:42:11 -0700 BTW, it'd be awesome if you could add the explanation in comment #3 to the ChangeLog. 616161 6 140214 cdumez 2012-05-04 06:50:49 -0700 Created attachment 140214 Patch Update changelog as advised. 617508 7 140214 hausmann 2012-05-07 04:20:00 -0700 Comment on attachment 140214 Patch rs=me 617513 8 140214 webkit.review.bot 2012-05-07 04:25:52 -0700 Comment on attachment 140214 Patch Clearing flags on attachment: 140214 Committed r116296: <http://trac.webkit.org/changeset/116296> 617514 9 webkit.review.bot 2012-05-07 04:26:08 -0700 All reviewed patches have been landed. Closing bug. 140212 2012-05-04 06:38:12 -0700 2012-05-04 06:50:49 -0700 Patch 85609_clear_cache.patch text/plain 1432 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMmM3 MWVkLi44ZTZlMDIwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMDQgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBtZWRpYS92aWRlby1w b3N0ZXItYmxvY2tlZC1ieS13aWxsc2VuZHJlcXVlc3QuaHRtbCBpcyBmbGFreQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU2MDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhciBtZW1vcnkgYW5kIHBh Z2UgY2FjaGVzIGJldHdlZW4gdGVzdHMgdG8gYWRkcmVzcyBmbGFraW5lc3MgaW4KKyAgICAgICAg bWVkaWEgdGVzdHMuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRy ZWVDaHJvbWUuY3BwOgorICAgICAgICAoRHVtcFJlbmRlclRyZWVDaHJvbWU6OnJlc2V0RGVmYXVs dHNUb0NvbnNpc3RlbnRWYWx1ZXMpOgorCiAyMDEyLTA1LTAzICBDaHJpc3RvcGhlIER1bWV6ICA8 Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gRFJUIHNob3VsZCBv YmV5IGxheW91dFRlc3RDb250cm9sbGVyJ3MgYWRkVVJMVG9SZWRpcmVjdCgpCmRpZmYgLS1naXQg YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAppbmRleCAxM2U2 N2JmLi4xNzY4ZjM1IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJl bmRlclRyZWVDaHJvbWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVu ZGVyVHJlZUNocm9tZS5jcHAKQEAgLTIwMiw2ICsyMDIsOCBAQCB2b2lkIER1bXBSZW5kZXJUcmVl Q2hyb21lOjpyZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzKCkKICAgICBld2tfc2V0dGlu Z3Nfd2ViX2RhdGFiYXNlX2NsZWFyKCk7CiAgICAgZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFzZV9k ZWZhdWx0X3F1b3RhX3NldCg1ICogMTAyNCAqIDEwMjQpOwogCisgICAgZXdrX3NldHRpbmdzX21l bW9yeV9jYWNoZV9jbGVhcigpOworCiAgICAgZXdrX3ZpZXdfc2V0dGluZ19wcml2YXRlX2Jyb3dz aW5nX3NldChtYWluVmlldygpLCBFSU5BX0ZBTFNFKTsKICAgICBld2tfdmlld19zZXR0aW5nX3Nw YXRpYWxfbmF2aWdhdGlvbl9zZXQobWFpblZpZXcoKSwgRUlOQV9GQUxTRSk7CiAgICAgZXdrX3Zp ZXdfc2V0dGluZ19lbmFibGVfZnJhbWVfZmxhdHRlbmluZ19zZXQobWFpblZpZXcoKSwgRUlOQV9G QUxTRSk7Cg== 140214 2012-05-04 06:50:49 -0700 2012-05-07 04:25:51 -0700 Patch 85609_clear_cache.patch text/plain 1810 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMmM3 MWVkLi5mYWI3NjhmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTItMDUtMDQgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBtZWRpYS92aWRlby1w b3N0ZXItYmxvY2tlZC1ieS13aWxsc2VuZHJlcXVlc3QuaHRtbCBpcyBmbGFreQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODU2MDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGbGFraW5lc3Mgd2FzIGNhdXNl ZCBieSB0aGUgZmFjdCB0aGF0CisgICAgICAgIG1lZGlhL2NyYXNoLWNsb3NpbmctcGFnZS13aXRo LW1lZGlhLWFzLXBsdWdpbi1mYWxsYmFjay5odG1sIGFuZAorICAgICAgICBtZWRpYS92aWRlby1w b3N0ZXItYmxvY2tlZC1ieS13aWxsc2VuZHJlcXVlc3QuaHRtbCB1c2UgdGhlIHNhbWUgUE5HCisg ICAgICAgIGZpbGUgYXMgcG9zdGVyIGF0dHJpYnV0ZSBpbiB0aGUgdmlkZW8gdGFnLiBUaGUgUE5H IGZpbGUgZ2V0cyBjYWNoZWQKKyAgICAgICAgd2hlbiB0aGUgZmlyc3QgdGVzdCBpcyBleGVjdXRl ZCBhbmQgdGhpcyBzb21laG93IGNhdXNlcyB0aGUgc2Vjb25kCisgICAgICAgIHRlc3QgdG8gZmFp bC4gCisKKyAgICAgICAgVGhlIGZsYWtpbmVzcyB3YXMgYWRkcmVzc2VkIGJ5IGNsZWFyaW5nIHRo ZSBtZW1vcnkgYW5kIHBhZ2UgY2FjaGVzCisgICAgICAgIGJldHdlZW4gdGVzdHMuCisKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwOgorICAgICAg ICAoRHVtcFJlbmRlclRyZWVDaHJvbWU6OnJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMp OgorCiAyMDEyLTA1LTAzICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRl bC5jb20+CiAKICAgICAgICAgW0VGTF0gRFJUIHNob3VsZCBvYmV5IGxheW91dFRlc3RDb250cm9s bGVyJ3MgYWRkVVJMVG9SZWRpcmVjdCgpCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJl ZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZs L0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAppbmRleCAxM2U2N2JmLi4xNzY4ZjM1IDEwMDY0NAot LS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCisr KyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKQEAg LTIwMiw2ICsyMDIsOCBAQCB2b2lkIER1bXBSZW5kZXJUcmVlQ2hyb21lOjpyZXNldERlZmF1bHRz VG9Db25zaXN0ZW50VmFsdWVzKCkKICAgICBld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX2NsZWFy KCk7CiAgICAgZXdrX3NldHRpbmdzX3dlYl9kYXRhYmFzZV9kZWZhdWx0X3F1b3RhX3NldCg1ICog MTAyNCAqIDEwMjQpOwogCisgICAgZXdrX3NldHRpbmdzX21lbW9yeV9jYWNoZV9jbGVhcigpOwor CiAgICAgZXdrX3ZpZXdfc2V0dGluZ19wcml2YXRlX2Jyb3dzaW5nX3NldChtYWluVmlldygpLCBF SU5BX0ZBTFNFKTsKICAgICBld2tfdmlld19zZXR0aW5nX3NwYXRpYWxfbmF2aWdhdGlvbl9zZXQo bWFpblZpZXcoKSwgRUlOQV9GQUxTRSk7CiAgICAgZXdrX3ZpZXdfc2V0dGluZ19lbmFibGVfZnJh bWVfZmxhdHRlbmluZ19zZXQobWFpblZpZXcoKSwgRUlOQV9GQUxTRSk7Cg==