85608 2012-05-04 05:15:05 -0700 [EFL] [DRT] Clear extra views before setting a blank page 2012-05-08 02:27:52 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85601 1 tmpsantos tmpsantos cdumez gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 616090 0 tmpsantos 2012-05-04 05:15:05 -0700 I found out so far that running fast/frames/frame-crash-with-page-cache.html before it in the same test set makes it fail. ./Tools/Scripts/run-webkit-tests --efl --debug --no-retry-failures --no-new-test-results fast/frames/frame-crash-with-page-cache.html fast/frames/frame-dead-region.html --> FAIL ./Tools/Scripts/run-webkit-tests --efl --debug --no-retry-failures --no-new-test-results fast/frames/frame-dead-region.html --> OK It's likely to be some leftover settings from the previous test. 617628 1 140534 tmpsantos 2012-05-07 09:03:19 -0700 Created attachment 140534 Patch 617640 2 140534 rakuco 2012-05-07 09:23:06 -0700 Comment on attachment 140534 Patch Looks OK. 618342 3 cdumez 2012-05-07 23:20:03 -0700 It is even crashing now for some reason: Regressions: Unexpected crashes : (1) fast/frames/frame-dead-region.html = CRASH 618376 4 140534 gyuyoung.kim 2012-05-08 00:12:49 -0700 Comment on attachment 140534 Patch LGTM. 618383 5 gyuyoung.kim 2012-05-08 00:32:39 -0700 (In reply to comment #3) > It is even crashing now for some reason: > > Regressions: Unexpected crashes : (1) > fast/frames/frame-dead-region.html = CRASH There is no crash on my linux box. 618392 6 cdumez 2012-05-08 01:06:55 -0700 (In reply to comment #5) > (In reply to comment #3) > > It is even crashing now for some reason: > > > > Regressions: Unexpected crashes : (1) > > fast/frames/frame-dead-region.html = CRASH > > There is no crash on my linux box. This is on our Debug build bot, not my box. 618398 7 140534 kenneth 2012-05-08 01:15:50 -0700 Comment on attachment 140534 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140534&action=review > Tools/DumpRenderTree/efl/DumpRenderTree.cpp:253 > + browser->clearExtraViews(); clearAdditionalViews() ? 618402 8 tmpsantos 2012-05-08 01:21:30 -0700 (In reply to comment #7) > (From update of attachment 140534 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140534&action=review > > > Tools/DumpRenderTree/efl/DumpRenderTree.cpp:253 > > + browser->clearExtraViews(); > > clearAdditionalViews() ? I used "Extra" because the member variable "m_extraViews" and the getter "DumpRenderTreeChrome::extraViews()". 618437 9 140534 webkit.review.bot 2012-05-08 02:27:47 -0700 Comment on attachment 140534 Patch Clearing flags on attachment: 140534 Committed r116407: <http://trac.webkit.org/changeset/116407> 618439 10 webkit.review.bot 2012-05-08 02:27:52 -0700 All reviewed patches have been landed. Closing bug. 140534 2012-05-07 09:03:19 -0700 2012-05-08 02:27:47 -0700 Patch fix.patch text/plain 3226 tmpsantos ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5MDVi YzM4Li4yZWJiNDQ5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTItMDUtMDcgIFRoaWFnbyBNYXJjb3MgUC4gU2Fu dG9zICA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW0RSVF0gQ2xl YXIgZXh0cmEgdmlld3MgYmVmb3JlIHNldHRpbmcgYSBibGFuayBwYWdlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTYwOAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8gY2xlYXIgdGhlIGV4 dHJhIHZpZXdzIGJlZm9yZSBzZXR0aW5nIGEgYmxhbmsgcGFnZSwKKyAgICAgICAgb3RoZXJ3aXNl IGl0IHdpbGwgY2F1c2UgbW9yZSBldmVudHMgaW50ZXJhY3Rpb25zIGFuZCBzb21ldGltZXMKKyAg ICAgICAgdHJpZ2dlciBhIHVubG9hZCgpLiBUaGlzIHdhcyBjYXVzaW5nIGZyYW1lLWNyYXNoLXdp dGgtcGFnZS1jYWNoZS5odG1sCisgICAgICAgIHRvIGxlYWsgZXZlbnRzIHRvIHRoZSBuZXh0IHRl c3QgY2F1c2luZyBhbnkgc3Vic2VxdWVudCB0ZXN0IHRvCisgICAgICAgIGZhaWwuCisKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAocnVu VGVzdCk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21l LmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlQ2hyb21lOjpjbGVhckV4dHJhVmlld3MpOgor ICAgICAgICAoRHVtcFJlbmRlclRyZWVDaHJvbWU6OnJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRW YWx1ZXMpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9t ZS5oOgorICAgICAgICAoRHVtcFJlbmRlclRyZWVDaHJvbWUpOgorCiAyMDEyLTA1LTA2ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbcHJlcGFyZS1DaGFuZ2VM b2ddIEV4Y2x1ZGVzIGEgcmVmZXJlbmNlIGZpbGUgdXNlZCBieSByZWZ0ZXN0cyBmcm9tIHRlc3Qg ZmlsZXMuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRy ZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRl eCBiNzE2YzUzLi5kODkzMWYwIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwv RHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVu ZGVyVHJlZS5jcHAKQEAgLTI1MCw2ICsyNTAsOCBAQCBzdGF0aWMgdm9pZCBydW5UZXN0KGNvbnN0 IGNoYXIqIGNUZXN0UGF0aE9yVVJMKQogICAgIGdMYXlvdXRUZXN0Q29udHJvbGxlci0+Y2xvc2VX ZWJJbnNwZWN0b3IoKTsKICAgICBnTGF5b3V0VGVzdENvbnRyb2xsZXItPnNldERldmVsb3BlckV4 dHJhc0VuYWJsZWQoZmFsc2UpOwogCisgICAgYnJvd3Nlci0+Y2xlYXJFeHRyYVZpZXdzKCk7CisK ICAgICBld2tfdmlld191cmlfc2V0KGJyb3dzZXItPm1haW5WaWV3KCksICJhYm91dDpibGFuayIp OwogCiAgICAgZ0xheW91dFRlc3RDb250cm9sbGVyLmNsZWFyKCk7CmRpZmYgLS1naXQgYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAppbmRleCA3ZmUxYzE5Li42 NjFkMDYxIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRy ZWVDaHJvbWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJl ZUNocm9tZS5jcHAKQEAgLTE2Niw2ICsxNjYsMTQgQEAgVmVjdG9yPEV2YXNfT2JqZWN0Kj4gRHVt cFJlbmRlclRyZWVDaHJvbWU6OmV4dHJhVmlld3MoKSBjb25zdAogICAgIHJldHVybiBtX2V4dHJh Vmlld3M7CiB9CiAKK3ZvaWQgRHVtcFJlbmRlclRyZWVDaHJvbWU6OmNsZWFyRXh0cmFWaWV3cygp Cit7CisgICAgVmVjdG9yPEV2YXNfT2JqZWN0Kj46Oml0ZXJhdG9yIGl0ID0gbV9leHRyYVZpZXdz LmJlZ2luKCk7CisgICAgZm9yICg7IGl0ICE9IG1fZXh0cmFWaWV3cy5lbmQoKTsgKytpdCkKKyAg ICAgICAgZXZhc19vYmplY3RfZGVsKCppdCk7CisgICAgbV9leHRyYVZpZXdzLmNsZWFyKCk7Cit9 CisKIEV2YXNfT2JqZWN0KiBEdW1wUmVuZGVyVHJlZUNocm9tZTo6bWFpbkZyYW1lKCkgY29uc3QK IHsKICAgICByZXR1cm4gbV9tYWluRnJhbWU7CkBAIC0xOTMsMTEgKzIwMSw2IEBAIHN0YXRpYyBp bmxpbmUgY29uc3QgY2hhciogZGVmYXVsdEVkaXRpbmdCZWhhdmlvcigpCiAKIHZvaWQgRHVtcFJl bmRlclRyZWVDaHJvbWU6OnJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMoKQogewotICAg IFZlY3RvcjxFdmFzX09iamVjdCo+OjppdGVyYXRvciBpdCA9IG1fZXh0cmFWaWV3cy5iZWdpbigp OwotICAgIGZvciAoOyBpdCAhPSBtX2V4dHJhVmlld3MuZW5kKCk7ICsraXQpCi0gICAgICAgIGV2 YXNfb2JqZWN0X2RlbCgqaXQpOwotICAgIG1fZXh0cmFWaWV3cy5jbGVhcigpOwotCiAgICAgZXdr X3NldHRpbmdzX2ljb25fZGF0YWJhc2VfY2xlYXIoKTsKICAgICBld2tfc2V0dGluZ3NfaWNvbl9k YXRhYmFzZV9wYXRoX3NldCgwKTsKIApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUv ZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmggYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVt cFJlbmRlclRyZWVDaHJvbWUuaAppbmRleCBjYmEzZGJkLi4zZDVmNWEzIDEwMDY0NAotLS0gYS9U b29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuaAorKysgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuaApAQCAtNDcsNiArNDcs OCBAQCBwdWJsaWM6CiAgICAgdm9pZCByZW1vdmVXaW5kb3coRXZhc19PYmplY3QqKTsKIAogICAg IFZlY3RvcjxFdmFzX09iamVjdCo+IGV4dHJhVmlld3MoKSBjb25zdDsKKyAgICB2b2lkIGNsZWFy RXh0cmFWaWV3cygpOworCiAgICAgRXZhc19PYmplY3QqIG1haW5GcmFtZSgpIGNvbnN0OwogICAg IEV2YXNfT2JqZWN0KiBtYWluVmlldygpIGNvbnN0OwogCg==