85535 2012-05-03 13:04:51 -0700 Remove dead code from build-webkit for working around old XCode dependency bug 2012-05-04 03:49:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85597 85456 1 eric eric abarth dbates webkit.review.bot oldest_to_newest 615528 0 eric 2012-05-03 13:04:51 -0700 Remove dead code from build-webkit for working around old XCode dependency bug 615533 1 140076 eric 2012-05-03 13:06:52 -0700 Created attachment 140076 Patch 615534 2 140076 eric 2012-05-03 13:07:15 -0700 Comment on attachment 140076 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140076&action=review > Tools/Scripts/build-webkit:-426 > -$blobSupport = $blobSupport || $mediaStreamSupport; I removed this line as I noticed it also was dead code. :) 615536 3 eric 2012-05-03 13:08:54 -0700 I noticed this because I was am looking at autogenerating the feature defaults in build-webkit. There are basically no uses of the local variables the default options map to, and these were 2 uses. This code is dead, so we should just kill it. :) 615604 4 140076 webkit.review.bot 2012-05-03 14:06:35 -0700 Comment on attachment 140076 Patch Clearing flags on attachment: 140076 Committed r116008: <http://trac.webkit.org/changeset/116008> 615605 5 webkit.review.bot 2012-05-03 14:06:41 -0700 All reviewed patches have been landed. Closing bug. 140076 2012-05-03 13:06:52 -0700 2012-05-03 14:06:35 -0700 Patch bug-85535-20120503130651.patch text/plain 3856 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1OTM4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmFmMWFmMWE0MWFiMTA4YjFhYjhjYTc5ODlmNDc4MTYz MzRmNTc5Yy4uMjMyYWI5ZjBhOTYxYTQzMGJmMjUwM2Q0NWY0MmUwNzNmOGFlZGU3NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA1LTAzICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBSZW1vdmUgZGVhZCBjb2RlIGZyb20gYnVpbGQtd2Via2l0IGZvciB3b3JraW5nIGFyb3VuZCBv bGQgWENvZGUgZGVwZW5kZW5jeSBidWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg1NTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgWGNvZGUgdXNlZCB0byBoYXZlIGEgYnVnIHdoZXJlYnkgaXQgZGlkbid0 IG5vdGljZSBpZiB5b3UgY2hhbmdlZCB0aGUgI2RlZmluZXMKKyAgICAgICAgcGFzc2VkIG9uIHRo ZSBjb21tYW5kIGxpbmUgdG8geGNvZGVidWlsZC4gIEkgd3JvdGUgY29kZSB0byB3b3JrIGFyb3Vu ZCB0aGlzCisgICAgICAgIHdoaWxlIGJyaW5naW5nIHVwIFNWRyBzdXBwb3J0IDUtNiB5ZWFycyBh Z28uICBJIHRoaW5rIHdlIGNhbiBmaW5hbGx5IHJlbW92ZSB0aGlzCisgICAgICAgIGNvZGUgZnJv bSBidWlsZC13ZWJraXQsIHNpbmNlIFNWRyBpcyB0aGUgb25seSBmZWF0dXJlIGZsYWcgdG8gZXZl ciB1c2UgaXQKKyAgICAgICAgKG1vZGVybiBpbi1wcm9ncmVzcyBmZWF0dXJlcyBsaWtlIE1hdGhN TCBkb24ndCBzZWVtIHRvIGJlIHVzaW5nIHRoZSBzdXBwb3J0KQorICAgICAgICBhbiBJIHN1c3Bl Y3QgdGhlIFhDb2RlIGJ1ZyBoYXMgbG9uZyBiZWVuIGZpeGVkLgorCisgICAgICAgICogU2NyaXB0 cy9idWlsZC13ZWJraXQ6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRwZXJsL2ZlYXR1cmVzLnBt OgorCiAyMDEyLTA1LTAyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAg ICBXZWJLaXQgc2hvdWxkIGhhdmUgYW4gZWFzeSB3YXkgdG8gYWRkL3JlbW92ZSBGRUFUVVJFX0RF RklORVMgZm9yIGFsbCBwb3J0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJr aXQgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAppbmRleCBiYzNjYTAyM2JkNjYxOTQ1OTRh ZTRiMzk2YTg0YzEzZGFjNTYwNTAyLi42NDgyMmU4YWM3YjBkYTkwYTdlNjMyZmE1NjdjZTk1M2Y4 ZDQ4NTdjIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAorKysgYi9Ub29s cy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtMzksNyArMzksNiBAQCB1c2UgRmluZEJpbjsKIHVz ZSBHZXRvcHQ6OkxvbmcgcXcoOmNvbmZpZyBwYXNzX3Rocm91Z2gpOwogdXNlIGxpYiAkRmluZEJp bjo6QmluOwogdXNlIHdlYmtpdGRpcnM7Ci11c2Ugd2Via2l0cGVybDo6ZmVhdHVyZXM7CiB1c2Ug UE9TSVg7CiAKIHN1YiBjTWFrZUFyZ3NGcm9tRmVhdHVyZXMoKTsKQEAgLTQyMSwxMCArNDIwLDYg QEAgZm9yZWFjaCAoQGZlYXR1cmVzKSB7CiAgICAgJHskXy0+e3ZhbHVlfX0gPSAoJG1pbmltYWwg PyAwIDogJF8tPntkZWZhdWx0fSk7CiB9CiAKLSRzdmdTdXBwb3J0ID0gJHN2Z1N1cHBvcnQgfHwg JHN2Z0RPTU9iakNCaW5kaW5nc1N1cHBvcnQgfHwgJHN2Z0ZvbnRzU3VwcG9ydDsKLQotJGJsb2JT dXBwb3J0ID0gJGJsb2JTdXBwb3J0IHx8ICRtZWRpYVN0cmVhbVN1cHBvcnQ7Ci0KIG15ICRwcm9n cmFtTmFtZSA9IGJhc2VuYW1lKCQwKTsKIG15ICR1c2FnZSA9IDw8RU9GOwogVXNhZ2U6ICRwcm9n cmFtTmFtZSBbb3B0aW9uc10gW29wdGlvbnMgdG8gcGFzcyB0byBidWlsZCBzeXN0ZW1dCkBAIC02 MzUsOSArNjMwLDYgQEAgaWYgKGlzR3RrKCkpIHsKICMgYnVpbGQgb3B0aW9ucywgZXRjLgogQHBy b2plY3RzID0gKCJTb3VyY2UvV2ViS2l0IikgaWYgJG9ubHlXZWJLaXRQcm9qZWN0OwogCi0jIEZv cmNlIHJlLWxpbmsgb2YgZXhpc3RpbmcgbGlicmFyaWVzIGlmIGRpZmZlcmVudCB0aGFuIGV4cGVj dGVkCi1yZW1vdmVMaWJyYXJ5RGVwZW5kaW5nT25GZWF0dXJlKCJXZWJDb3JlIiwgIlNWRyIsICRz dmdTdXBwb3J0KTsKLQogaWYgKGlzSW5zcGVjdG9yRnJvbnRlbmQoKSkgewogICAgIGV4aXQgZXhp dFN0YXR1cyhjb3B5SW5zcGVjdG9yRnJvbnRlbmRGaWxlcygpKTsKIH0KZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cGVybC9mZWF0dXJlcy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cGVybC9mZWF0dXJlcy5wbQppbmRleCA4OTkyNjE5N2Y2ZGZmMGFlMmU2Y2JiNWZkN2ZhMDhmNDQx OTU4NTM4Li4xOWVhMGY5ZmMzYzdkYTA0NGVlM2E4MmIyZTFiZGEzZTUxNGU0YmFlIDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvZmVhdHVyZXMucG0KKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRwZXJsL2ZlYXR1cmVzLnBtCkBAIC00MCwzMiArNDAsMTEgQEAgQkVHSU4gewog ICAgb3VyICgkVkVSU0lPTiwgQElTQSwgQEVYUE9SVCwgQEVYUE9SVF9PSywgJUVYUE9SVF9UQUdT KTsKICAgICRWRVJTSU9OICAgICA9IDEuMDA7CiAgICBASVNBICAgICAgICAgPSBxdyhFeHBvcnRl cik7Ci0gICBARVhQT1JUICAgICAgPSBxdygmY2hlY2tXZWJDb3JlRmVhdHVyZVN1cHBvcnQKLSAg ICAgICAgICAgICAgICAgICAgICZyZW1vdmVMaWJyYXJ5RGVwZW5kaW5nT25GZWF0dXJlKTsKKyAg IEBFWFBPUlQgICAgICA9IHF3KCZjaGVja1dlYkNvcmVGZWF0dXJlU3VwcG9ydCk7CiAgICAlRVhQ T1JUX1RBR1MgPSAoICk7CiAgICBARVhQT1JUX09LICAgPSAoKTsKIH0KIAotc3ViIGxpYnJhcnlD b250YWluc1N5bWJvbCgkJCkKLXsKLSAgICBteSAoJHBhdGgsICRzeW1ib2wpID0gQF87Ci0KLSAg ICBpZiAoaXNDeWd3aW4oKSBvciBpc1dpbmRvd3MoKSkgewotICAgICAgICAjIEZJWE1FOiBJbXBs ZW1lbnQgdGhpcyBmb3IgV2luZG93cy4KLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgfQotCi0gICAg bXkgJGZvdW5kU3ltYm9sID0gMDsKLSAgICBpZiAoLWUgJHBhdGgpIHsKLSAgICAgICAgb3BlbiBO TSwgIi18Iiwgbm1QYXRoKCksICRwYXRoIG9yIGRpZTsKLSAgICAgICAgd2hpbGUgKDxOTT4pIHsK LSAgICAgICAgICAgICRmb3VuZFN5bWJvbCA9IDEgaWYgLyRzeW1ib2wvOyAjIEZJWE1FOiBUaGlz IHNob3VsZCBwcm9iYWJseSBjaGVjayBmb3Igd29yZCBib3VuZGFyaWVzIGJlZm9yZS9hZnRlciB0 aGUgc3ltYm9sIG5hbWUuCi0gICAgICAgIH0KLSAgICAgICAgY2xvc2UgTk07Ci0gICAgfQotICAg IHJldHVybiAkZm91bmRTeW1ib2w7Ci19Ci0KIHN1YiBoYXNGZWF0dXJlKCQkKQogewogICAgIG15 ICgkZmVhdHVyZU5hbWUsICRwYXRoKSA9IEBfOwpAQCAtOTQsMTQgKzczLDQgQEAgc3ViIGNoZWNr V2ViQ29yZUZlYXR1cmVTdXBwb3J0KCQkKQogICAgIHJldHVybiAkaGFzRmVhdHVyZTsKIH0KIAot c3ViIHJlbW92ZUxpYnJhcnlEZXBlbmRpbmdPbkZlYXR1cmUoJCQkKQotewotICAgIG15ICgkbGli cmFyeU5hbWUsICRmZWF0dXJlTmFtZSwgJHNob3VsZEhhdmVGZWF0dXJlKSA9IEBfOwotICAgIG15 ICRwYXRoID0gYnVpbHREeWxpYlBhdGhGb3JOYW1lKCRsaWJyYXJ5TmFtZSk7Ci0gICAgcmV0dXJu IHVubGVzcyAteCAkcGF0aDsKLQotICAgIG15ICRoYXNGZWF0dXJlID0gaGFzRmVhdHVyZSgkZmVh dHVyZU5hbWUsICRwYXRoKTsKLSAgICBzeXN0ZW0gInJtIC1mICRwYXRoIiBpZiAoJHNob3VsZEhh dmVGZWF0dXJlIHhvciAkaGFzRmVhdHVyZSk7Ci19Ci0KIDE7Cg==