85289 2012-05-01 09:16:57 -0700 [chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender 2012-05-01 17:20:39 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85314 83947 85101 1 tdanderson tdanderson dpranke eric rjkroege tkent tony webkit.review.bot zmo oldest_to_newest 613445 0 tdanderson 2012-05-01 09:16:57 -0700 The parameters deltaX and deltaY will be used in GestureTap to represent the padding around the center of a rectangle used for improved rect-based hit testing. Need to land this in order to test https://bugs.webkit.org/show_bug.cgi?id=85101. 613446 1 139634 tdanderson 2012-05-01 09:18:35 -0700 Created attachment 139634 Patch 613466 2 139634 eric 2012-05-01 09:34:37 -0700 Comment on attachment 139634 Patch What tests does this affect? 613468 3 tdanderson 2012-05-01 09:36:24 -0700 (In reply to comment #2) > (From update of attachment 139634 [details]) > What tests does this affect? fast/events/touch/gesture (in particular, gesture-click.html) 613470 4 eric 2012-05-01 09:37:41 -0700 The change is fine, but you should mention which (some general idea) tests this fix in the ChangeLog (and ideally include the test_expectations update in the change. 613477 5 eric 2012-05-01 09:42:08 -0700 When is this eventSender method needed instead of just generating a synthetic event in the JS? 613479 6 eric 2012-05-01 09:42:56 -0700 I see, you explain in your bug description why you need this. I think you should just copy that to your ChangeLog. :) Many reviewers (myself included) mostly just read the ChangeLog, since that's the part which is actually commited and sticks around for easy git blaming. :) 613480 7 139642 tdanderson 2012-05-01 09:44:50 -0700 Created attachment 139642 Patch 613481 8 139642 eric 2012-05-01 09:45:50 -0700 Comment on attachment 139642 Patch Thanks. 613500 9 139642 webkit.review.bot 2012-05-01 10:18:38 -0700 Comment on attachment 139642 Patch Clearing flags on attachment: 139642 Committed r115735: <http://trac.webkit.org/changeset/115735> 613501 10 webkit.review.bot 2012-05-01 10:18:48 -0700 All reviewed patches have been landed. Closing bug. 613697 11 zmo 2012-05-01 14:55:10 -0700 fast/events/touch/page-scaled-touch-gesture-click.html fast/events/touch/gesture/gesture-click.html These two tests are crashing on debug bots: STDOUT: <empty> STDERR: ASSERTION FAILED: i < size() STDERR: third_party/WebKit/Source/WTF/wtf/Vector.h(532) : const T& WTF::Vector<T, inlineCapacity>::at(size_t) const [with T = CppVariant, long unsigned int inlineCapacity = 0ul] STDERR: 1 0x421be5 STDERR: 2 0x42171f STDERR: 3 0x43ab46 STDERR: 4 0x43a7c1 STDERR: 5 0x43e428 STDERR: 6 0x42b8ca STDERR: 7 0x42af87 STDERR: 8 0x1338999 STDERR: 9 0x1338b14 STDERR: 10 0xb33c10 STDERR: 11 0xb2eb84 STDERR: 12 0xb2eb55 STDERR: 13 0x1e670530618e STDERR: [26085:26085:3369300989752:ERROR:process_util_posix.cc(143)] Received signal 11 STDERR: base::debug::StackTrace::StackTrace() [0x86cfb2] STDERR: base::(anonymous namespace)::StackDumpSignalHandler() [0x82dbd1] STDERR: 0x7fd10cc31af0 STDERR: WTF::Vector<>::at() [0x421bef] STDERR: WTF::Vector<>::operator[]() [0x42171f] STDERR: EventSender::gestureEvent() [0x43ab46] STDERR: EventSender::gestureTap() [0x43a7c1] STDERR: CppBoundClass::MemberCallback<>::run() [0x43e428] STDERR: CppBoundClass::invoke() [0x42b8ca] STDERR: CppNPObject::invoke() [0x42af87] STDERR: WebCore::npObjectInvokeImpl() [0x1338999] STDERR: WebCore::npObjectMethodHandler() [0x1338b14] STDERR: v8::internal::HandleApiCallHelper<>() [0xb33c10] STDERR: v8::internal::Builtin_Impl_HandleApiCall() [0xb2eb84] STDERR: v8::internal::Builtin_HandleApiCall() [0xb2eb55] STDERR: 0x1e670530618e 613742 12 tdanderson 2012-05-01 16:07:36 -0700 I carelessly forgot to check the size of |arguments|, which caused two tests to crash. The landed patch was rolled out by Zhenyao, so I am about to upload a new one that will not break any tests. 613749 13 139699 tdanderson 2012-05-01 16:13:20 -0700 Created attachment 139699 Patch 613754 14 139699 eric 2012-05-01 16:20:26 -0700 Comment on attachment 139699 Patch ok. 613809 15 139699 webkit.review.bot 2012-05-01 17:20:34 -0700 Comment on attachment 139699 Patch Clearing flags on attachment: 139699 Committed r115767: <http://trac.webkit.org/changeset/115767> 613810 16 webkit.review.bot 2012-05-01 17:20:39 -0700 All reviewed patches have been landed. Closing bug. 139634 2012-05-01 09:18:35 -0700 2012-05-01 09:44:45 -0700 Patch bug-85289-20120501121833.patch text/plain 1479 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NzI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTdhMmRjMWMyYmFjNzg2ODM4YzhjOTc1ZmNjOTk4ZGJk NGVjZmY2Ny4uMGFiZGIwNjA2MzA1MjM2OGIyNmFkM2RlOThlZjFjNjlhNmRlZTc5YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTA1LTAxICBUZXJyeSBBbmRlcnNvbiAgPHRkYW5kZXJzb25AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtjaHJvbWl1bV0gQWNjZXB0IGZvdXIgcGFyYW1ldGVycyB3aGVuIGRpc3Bh dGNoaW5nIGEgV2ViSW5wdXRFdmVudDo6R2VzdHVyZVRhcCBpbiBjaHJvbWl1bSBEUlQgZXZlbnRT ZW5kZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1 Mjg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVudFNlbmRlci5jcHA6CisgICAgICAgIChFdmVudFNl bmRlcjo6Z2VzdHVyZUV2ZW50KToKKyAgICAgICAgICAgU2VlIGJ1ZyBkZXNjcmlwdGlvbi4KKwog MjAxMi0wNC0zMCAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZp eCB0ZXN0cyB0byBub3QgZGVwZW5kIG9uIHRoZSBhY3R1YWwgbGlzdCBvZiBidWlsZGVycyBhdCBi dWlsZC5jaHJvbWl1bS5vcmcuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJv bWl1bS9FdmVudFNlbmRlci5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVu dFNlbmRlci5jcHAKaW5kZXggYWQ0YTA4ZTBmNDU3MThkZGY0NzRmNzIxZGFlMmRiNzU3YzgwMzA0 Mi4uMWU1ZDk2M2I1ZWRhOTk2NDY1ZWViNzBkMjBhNjY3NDlmMjM5NDc4YSAxMDA2NDQKLS0tIGEv VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3BwCisrKyBiL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0V2ZW50U2VuZGVyLmNwcApAQCAtMTEzNCw2ICsxMTM0 LDggQEAgdm9pZCBFdmVudFNlbmRlcjo6Z2VzdHVyZUV2ZW50KFdlYklucHV0RXZlbnQ6OlR5cGUg dHlwZSwgY29uc3QgQ3BwQXJndW1lbnRMaXN0JgogICAgICAgICBldmVudC55ID0gbV9jdXJyZW50 R2VzdHVyZUxvY2F0aW9uLnk7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgV2ViSW5wdXRFdmVu dDo6R2VzdHVyZVRhcDoKKyAgICAgICAgZXZlbnQuZGVsdGFYID0gc3RhdGljX2Nhc3Q8ZmxvYXQ+ KGFyZ3VtZW50c1syXS50b0RvdWJsZSgpKTsKKyAgICAgICAgZXZlbnQuZGVsdGFZID0gc3RhdGlj X2Nhc3Q8ZmxvYXQ+KGFyZ3VtZW50c1szXS50b0RvdWJsZSgpKTsKICAgICAgICAgZXZlbnQueCA9 IHBvaW50Lng7CiAgICAgICAgIGV2ZW50LnkgPSBwb2ludC55OwogICAgICAgICBicmVhazsK 139642 2012-05-01 09:44:50 -0700 2012-05-01 16:13:16 -0700 Patch bug-85289-20120501124448.patch text/plain 1582 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NzI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTdhMmRjMWMyYmFjNzg2ODM4YzhjOTc1ZmNjOTk4ZGJk NGVjZmY2Ny4uNjhmNDA0ODJlNjhlNzNmOWNlNTMwNDVmODRiNzZkYThmYWM1ZGVlOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA1LTAxICBUZXJyeSBBbmRlcnNvbiAgPHRkYW5kZXJzb25AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtjaHJvbWl1bV0gQWNjZXB0IGZvdXIgcGFyYW1ldGVycyB3aGVuIGRpc3Bh dGNoaW5nIGEgV2ViSW5wdXRFdmVudDo6R2VzdHVyZVRhcCBpbiBjaHJvbWl1bSBEUlQgZXZlbnRT ZW5kZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1 Mjg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVudFNlbmRlci5jcHA6CisgICAgICAgIChFdmVudFNl bmRlcjo6Z2VzdHVyZUV2ZW50KToKKyAgICAgICAgICAgIFRoaXMgY2hhbmdlIHdpbGwgYWxsb3cg Zm9yIHRlc3Rpbmcgb2YgV0s4NTEwMS4gQ3VycmVudGx5IG5vIHRlc3RzIHVzZSB0aGUgZXh0cmEK KyAgICAgICAgICAgIHBhcmFtZXRlcnMgZGVsdGFYIGFuZCBkZWx0YVkuCisKIDIwMTItMDQtMzAg IE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXggdGVzdHMgdG8g bm90IGRlcGVuZCBvbiB0aGUgYWN0dWFsIGxpc3Qgb2YgYnVpbGRlcnMgYXQgYnVpbGQuY2hyb21p dW0ub3JnLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRT ZW5kZXIuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3Bw CmluZGV4IGFkNGEwOGUwZjQ1NzE4ZGRmNDc0ZjcyMWRhZTJkYjc1N2M4MDMwNDIuLjFlNWQ5NjNi NWVkYTk5NjQ2NWVlYjcwZDIwYTY2NzQ5ZjIzOTQ3OGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL0V2ZW50U2VuZGVyLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9FdmVudFNlbmRlci5jcHAKQEAgLTExMzQsNiArMTEzNCw4IEBAIHZvaWQg RXZlbnRTZW5kZXI6Omdlc3R1cmVFdmVudChXZWJJbnB1dEV2ZW50OjpUeXBlIHR5cGUsIGNvbnN0 IENwcEFyZ3VtZW50TGlzdCYKICAgICAgICAgZXZlbnQueSA9IG1fY3VycmVudEdlc3R1cmVMb2Nh dGlvbi55OwogICAgICAgICBicmVhazsKICAgICBjYXNlIFdlYklucHV0RXZlbnQ6Okdlc3R1cmVU YXA6CisgICAgICAgIGV2ZW50LmRlbHRhWCA9IHN0YXRpY19jYXN0PGZsb2F0Pihhcmd1bWVudHNb Ml0udG9Eb3VibGUoKSk7CisgICAgICAgIGV2ZW50LmRlbHRhWSA9IHN0YXRpY19jYXN0PGZsb2F0 Pihhcmd1bWVudHNbM10udG9Eb3VibGUoKSk7CiAgICAgICAgIGV2ZW50LnggPSBwb2ludC54Owog ICAgICAgICBldmVudC55ID0gcG9pbnQueTsKICAgICAgICAgYnJlYWs7Cg== 139699 2012-05-01 16:13:20 -0700 2012-05-01 17:20:34 -0700 Patch bug-85289-20120501191319.patch text/plain 1659 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1NzU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjBmMmVjNTY2YmQzYjdmM2ZkN2MwMzBmMGYwNWVmZDUw YTM0NDA2MS4uMTkzODFmMDcyZmM5ZWU2ZGU3ZGZlZGQyNjBjZDU0NWIzOTdjNTlmYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA1LTAxICBUZXJyeSBBbmRlcnNvbiAgPHRkYW5kZXJzb25AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtjaHJvbWl1bV0gQWNjZXB0IGZvdXIgcGFyYW1ldGVycyB3aGVuIGRpc3Bh dGNoaW5nIGEgV2ViSW5wdXRFdmVudDo6R2VzdHVyZVRhcCBpbiBjaHJvbWl1bSBEUlQgZXZlbnRT ZW5kZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1 Mjg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCisKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVudFNlbmRlci5jcHA6CisgICAgICAgIChFdmVudFNlbmRl cjo6Z2VzdHVyZUV2ZW50KToKKyAgICAgICAgICAgIFRoaXMgY2hhbmdlIHdpbGwgYWxsb3cgZm9y IHRlc3Rpbmcgb2YgV0s4NTEwMS4gQ3VycmVudGx5CisgICAgICAgICAgICBubyB0ZXN0cyB1c2Ug dGhlIGV4dHJhIHBhcmFtZXRlcnMgZGVsdGFYIGFuZCBkZWx0YVkuIEFkZGVkCisgICAgICAgICAg ICBhIGNoZWNrIGZvciB0aGUgc2l6ZSBvZiB8YXJndW1lbnRzfC4KKwogMjAxMi0wNS0wMSAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjExNTczNS4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2Nocm9taXVtL0V2ZW50U2VuZGVyLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL0V2ZW50U2VuZGVyLmNwcAppbmRleCBhZDRhMDhlMGY0NTcxOGRkZjQ3NGY3MjFkYWUyZGI3 NTdjODAzMDQyLi5hMTVjNzJjM2VjYWM3NDUxNTQ4NzAxM2M5NjAyOTNmZTUwNGIwMzU2IDEwMDY0 NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9FdmVudFNlbmRlci5jcHAKKysr IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRXZlbnRTZW5kZXIuY3BwCkBAIC0xMTM0 LDYgKzExMzQsMTAgQEAgdm9pZCBFdmVudFNlbmRlcjo6Z2VzdHVyZUV2ZW50KFdlYklucHV0RXZl bnQ6OlR5cGUgdHlwZSwgY29uc3QgQ3BwQXJndW1lbnRMaXN0JgogICAgICAgICBldmVudC55ID0g bV9jdXJyZW50R2VzdHVyZUxvY2F0aW9uLnk7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgV2Vi SW5wdXRFdmVudDo6R2VzdHVyZVRhcDoKKyAgICAgICAgaWYgKGFyZ3VtZW50cy5zaXplKCkgPj0g NCkgeworICAgICAgICAgICAgZXZlbnQuZGVsdGFYID0gc3RhdGljX2Nhc3Q8ZmxvYXQ+KGFyZ3Vt ZW50c1syXS50b0RvdWJsZSgpKTsKKyAgICAgICAgICAgIGV2ZW50LmRlbHRhWSA9IHN0YXRpY19j YXN0PGZsb2F0Pihhcmd1bWVudHNbM10udG9Eb3VibGUoKSk7CisgICAgICAgIH0KICAgICAgICAg ZXZlbnQueCA9IHBvaW50Lng7CiAgICAgICAgIGV2ZW50LnkgPSBwb2ludC55OwogICAgICAgICBi cmVhazsK