85249 2012-04-30 17:40:35 -0700 Change RenderBoxModelObject::calculateBackgroundImageGeometry to use roundToInt 2012-04-30 20:24:03 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 eae eae eric leviw webkit.review.bot oldest_to_newest 613100 0 eae 2012-04-30 17:40:35 -0700 In RenderBoxModelObject::calculateBackgroundImageGeometry we need to use a modulo operator to compute the phase for the repeating background image. As the position will be a FractionalLayoutUnit we need to round it. 613122 1 139558 eae 2012-04-30 18:06:26 -0700 Created attachment 139558 Patch 613132 2 139558 eric 2012-04-30 18:16:19 -0700 Comment on attachment 139558 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139558&action=review > Source/WebCore/ChangeLog:9 > + Prepare RenderBoxModelObject for FractionalLayoutUnits by adding rounding > + logic to calculateBackgroundImageGeometry. Why? Why should it round? (i'm not saying it shouldn't,it's jus tnot very well explained here. :) 613138 3 139563 eae 2012-04-30 18:21:47 -0700 Created attachment 139563 Patch 613139 4 eae 2012-04-30 18:22:22 -0700 Expanded on why. 613144 5 139563 eric 2012-04-30 18:26:58 -0700 Comment on attachment 139563 Patch OK. 613145 6 eae 2012-04-30 18:27:29 -0700 Thanks Eric! 613202 7 139563 webkit.review.bot 2012-04-30 20:23:59 -0700 Comment on attachment 139563 Patch Clearing flags on attachment: 139563 Committed r115707: <http://trac.webkit.org/changeset/115707> 613203 8 webkit.review.bot 2012-04-30 20:24:03 -0700 All reviewed patches have been landed. Closing bug. 139558 2012-04-30 18:06:26 -0700 2012-04-30 18:21:37 -0700 Patch bug-85249-20120430180625.patch text/plain 2295 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTY5NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTMwICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaGFuZ2UgUmVuZGVyQm94TW9k ZWxPYmplY3Q6OmNhbGN1bGF0ZUJhY2tncm91bmRJbWFnZUdlb21ldHJ5IHRvIHVzZSByb3VuZFRv SW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTI0 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByZXBh cmUgUmVuZGVyQm94TW9kZWxPYmplY3QgZm9yIEZyYWN0aW9uYWxMYXlvdXRVbml0cyBieSBhZGRp bmcgcm91bmRpbmcKKyAgICAgICAgbG9naWMgdG8gY2FsY3VsYXRlQmFja2dyb3VuZEltYWdlR2Vv bWV0cnkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0 eS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJCb3hNb2RlbE9iamVjdDo6Y2FsY3VsYXRlQmFja2dyb3VuZElt YWdlR2VvbWV0cnkpOgorCiAyMDEyLTA0LTMwICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5j b20+CiAKICAgICAgICAgSGFyZGVuIGFyaXRobWV0aWMgaW4gSW1hZ2VCdWZmZXJEYXRhQ0cKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0 LmNwcAkocmV2aXNpb24gMTE1NjkyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJveE1vZGVsT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIzOCwxMyArMTIzOCwxMyBA QCB2b2lkIFJlbmRlckJveE1vZGVsT2JqZWN0OjpjYWxjdWxhdGVCYWNrCiAKICAgICBMYXlvdXRV bml0IHhQb3NpdGlvbiA9IG1pbmltdW1WYWx1ZUZvckxlbmd0aChmaWxsTGF5ZXItPnhQb3NpdGlv bigpLCBwb3NpdGlvbmluZ0FyZWFTaXplLndpZHRoKCkgLSBnZW9tZXRyeS50aWxlU2l6ZSgpLndp ZHRoKCksIHJlbmRlclZpZXcsIHRydWUpOwogICAgIGlmIChiYWNrZ3JvdW5kUmVwZWF0WCA9PSBS ZXBlYXRGaWxsKQotICAgICAgICBnZW9tZXRyeS5zZXRQaGFzZVgoZ2VvbWV0cnkudGlsZVNpemUo KS53aWR0aCgpID8gZ2VvbWV0cnkudGlsZVNpemUoKS53aWR0aCgpIC0gKHhQb3NpdGlvbiArIGxl ZnQpICUgZ2VvbWV0cnkudGlsZVNpemUoKS53aWR0aCgpIDogMCk7CisgICAgICAgIGdlb21ldHJ5 LnNldFBoYXNlWChnZW9tZXRyeS50aWxlU2l6ZSgpLndpZHRoKCkgPyBnZW9tZXRyeS50aWxlU2l6 ZSgpLndpZHRoKCkgLSByb3VuZFRvSW50KHhQb3NpdGlvbiArIGxlZnQpICUgZ2VvbWV0cnkudGls ZVNpemUoKS53aWR0aCgpIDogMCk7CiAgICAgZWxzZQogICAgICAgICBnZW9tZXRyeS5zZXROb1Jl cGVhdFgoeFBvc2l0aW9uICsgbGVmdCk7CiAKICAgICBMYXlvdXRVbml0IHlQb3NpdGlvbiA9IG1p bmltdW1WYWx1ZUZvckxlbmd0aChmaWxsTGF5ZXItPnlQb3NpdGlvbigpLCBwb3NpdGlvbmluZ0Fy ZWFTaXplLmhlaWdodCgpIC0gZ2VvbWV0cnkudGlsZVNpemUoKS5oZWlnaHQoKSwgcmVuZGVyVmll dywgdHJ1ZSk7CiAgICAgaWYgKGJhY2tncm91bmRSZXBlYXRZID09IFJlcGVhdEZpbGwpCi0gICAg ICAgIGdlb21ldHJ5LnNldFBoYXNlWShnZW9tZXRyeS50aWxlU2l6ZSgpLmhlaWdodCgpID8gZ2Vv bWV0cnkudGlsZVNpemUoKS5oZWlnaHQoKSAtICh5UG9zaXRpb24gKyB0b3ApICUgZ2VvbWV0cnku dGlsZVNpemUoKS5oZWlnaHQoKSA6IDApOworICAgICAgICBnZW9tZXRyeS5zZXRQaGFzZVkoZ2Vv bWV0cnkudGlsZVNpemUoKS5oZWlnaHQoKSA/IGdlb21ldHJ5LnRpbGVTaXplKCkuaGVpZ2h0KCkg LSByb3VuZFRvSW50KHlQb3NpdGlvbiArIHRvcCkgJSBnZW9tZXRyeS50aWxlU2l6ZSgpLmhlaWdo dCgpIDogMCk7CiAgICAgZWxzZSAKICAgICAgICAgZ2VvbWV0cnkuc2V0Tm9SZXBlYXRZKHlQb3Np dGlvbiArIHRvcCk7CiAK 139563 2012-04-30 18:21:47 -0700 2012-04-30 20:23:59 -0700 Patch bug-85249-20120430182146.patch text/plain 2436 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTY5NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTMwICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBDaGFuZ2UgUmVuZGVyQm94TW9k ZWxPYmplY3Q6OmNhbGN1bGF0ZUJhY2tncm91bmRJbWFnZUdlb21ldHJ5IHRvIHVzZSByb3VuZFRv SW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTI0 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByZXBh cmUgUmVuZGVyQm94TW9kZWxPYmplY3QgZm9yIEZyYWN0aW9uYWxMYXlvdXRVbml0cyBieSBhZGRp bmcgcm91bmRpbmcKKyAgICAgICAgbG9naWMgdG8gY2FsY3VsYXRlQmFja2dyb3VuZEltYWdlR2Vv bWV0cnkuIEJhY2tncm91bmQgaW1hZ2VzLCBhcyBhbGwKKyAgICAgICAgaW1hZ2VzLCBuZWVkcyB0 byBiZSBsYXllZCBvdXQgb24gcGl4ZWwgYm91bmRhcmllcyB0aHVzIHdlIG5lZWQgdG8gY29udmVy dAorICAgICAgICBpdCB0byBhIGludGVnZXIgdmFsdWUuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCBubyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJCb3hNb2RlbE9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3hNb2RlbE9i amVjdDo6Y2FsY3VsYXRlQmFja2dyb3VuZEltYWdlR2VvbWV0cnkpOgorCiAyMDEyLTA0LTMwICBP bGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgSGFyZGVuIGFyaXRobWV0 aWMgaW4gSW1hZ2VCdWZmZXJEYXRhQ0cKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAkocmV2aXNpb24gMTE1NjkyKQorKysgU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTIzOCwxMyArMTIzOCwxMyBAQCB2b2lkIFJlbmRlckJveE1vZGVsT2JqZWN0Ojpj YWxjdWxhdGVCYWNrCiAKICAgICBMYXlvdXRVbml0IHhQb3NpdGlvbiA9IG1pbmltdW1WYWx1ZUZv ckxlbmd0aChmaWxsTGF5ZXItPnhQb3NpdGlvbigpLCBwb3NpdGlvbmluZ0FyZWFTaXplLndpZHRo KCkgLSBnZW9tZXRyeS50aWxlU2l6ZSgpLndpZHRoKCksIHJlbmRlclZpZXcsIHRydWUpOwogICAg IGlmIChiYWNrZ3JvdW5kUmVwZWF0WCA9PSBSZXBlYXRGaWxsKQotICAgICAgICBnZW9tZXRyeS5z ZXRQaGFzZVgoZ2VvbWV0cnkudGlsZVNpemUoKS53aWR0aCgpID8gZ2VvbWV0cnkudGlsZVNpemUo KS53aWR0aCgpIC0gKHhQb3NpdGlvbiArIGxlZnQpICUgZ2VvbWV0cnkudGlsZVNpemUoKS53aWR0 aCgpIDogMCk7CisgICAgICAgIGdlb21ldHJ5LnNldFBoYXNlWChnZW9tZXRyeS50aWxlU2l6ZSgp LndpZHRoKCkgPyBnZW9tZXRyeS50aWxlU2l6ZSgpLndpZHRoKCkgLSByb3VuZFRvSW50KHhQb3Np dGlvbiArIGxlZnQpICUgZ2VvbWV0cnkudGlsZVNpemUoKS53aWR0aCgpIDogMCk7CiAgICAgZWxz ZQogICAgICAgICBnZW9tZXRyeS5zZXROb1JlcGVhdFgoeFBvc2l0aW9uICsgbGVmdCk7CiAKICAg ICBMYXlvdXRVbml0IHlQb3NpdGlvbiA9IG1pbmltdW1WYWx1ZUZvckxlbmd0aChmaWxsTGF5ZXIt PnlQb3NpdGlvbigpLCBwb3NpdGlvbmluZ0FyZWFTaXplLmhlaWdodCgpIC0gZ2VvbWV0cnkudGls ZVNpemUoKS5oZWlnaHQoKSwgcmVuZGVyVmlldywgdHJ1ZSk7CiAgICAgaWYgKGJhY2tncm91bmRS ZXBlYXRZID09IFJlcGVhdEZpbGwpCi0gICAgICAgIGdlb21ldHJ5LnNldFBoYXNlWShnZW9tZXRy eS50aWxlU2l6ZSgpLmhlaWdodCgpID8gZ2VvbWV0cnkudGlsZVNpemUoKS5oZWlnaHQoKSAtICh5 UG9zaXRpb24gKyB0b3ApICUgZ2VvbWV0cnkudGlsZVNpemUoKS5oZWlnaHQoKSA6IDApOworICAg ICAgICBnZW9tZXRyeS5zZXRQaGFzZVkoZ2VvbWV0cnkudGlsZVNpemUoKS5oZWlnaHQoKSA/IGdl b21ldHJ5LnRpbGVTaXplKCkuaGVpZ2h0KCkgLSByb3VuZFRvSW50KHlQb3NpdGlvbiArIHRvcCkg JSBnZW9tZXRyeS50aWxlU2l6ZSgpLmhlaWdodCgpIDogMCk7CiAgICAgZWxzZSAKICAgICAgICAg Z2VvbWV0cnkuc2V0Tm9SZXBlYXRZKHlQb3NpdGlvbiArIHRvcCk7CiAK