85239 2012-04-30 15:25:19 -0700 Update LayoutUnit usage in InlineFlowBox and RenderWidget 2012-04-30 16:41:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric webkit.review.bot oldest_to_newest 613007 0 leviw 2012-04-30 15:25:19 -0700 See changelog for description and justification. 613029 1 139534 leviw 2012-04-30 15:51:09 -0700 Created attachment 139534 Patch 613032 2 139534 eric 2012-04-30 15:54:18 -0700 Comment on attachment 139534 Patch The widget stuff definitely makes sense. r=me to land that. The InlineFlowBox change feels like it could use a comment to explain why it's rounding. Are lines always pixel-aligned? 613033 3 leviw 2012-04-30 15:57:08 -0700 (In reply to comment #2) > (From update of attachment 139534 [details]) > The widget stuff definitely makes sense. r=me to land that. The InlineFlowBox change feels like it could use a comment to explain why it's rounding. Are lines always pixel-aligned? Root boxes are. You'll notice that top, maxAscent, and FontMetrics::ascent are all integers. I was surprised to discover this as well. I'll add a comment. 613043 4 139540 leviw 2012-04-30 16:07:31 -0700 Created attachment 139540 Patch for landing 613057 5 139540 webkit.review.bot 2012-04-30 16:41:21 -0700 Comment on attachment 139540 Patch for landing Clearing flags on attachment: 139540 Committed r115689: <http://trac.webkit.org/changeset/115689> 613058 6 webkit.review.bot 2012-04-30 16:41:30 -0700 All reviewed patches have been landed. Closing bug. 139534 2012-04-30 15:51:09 -0700 2012-04-30 16:07:27 -0700 Patch bug-85239-20120430155108.patch text/plain 3027 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTY3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA0LTMwICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBVcGRhdGUgTGF5b3V0VW5p dCB1c2FnZSBpbiBJbmxpbmVGbG93Qm94IGFuZCBSZW5kZXJXaWRnZXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MjM5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRpbmcgTGF5b3V0VW5pdCB1c2Fn ZSBpbiBhIHBhaXIgb2YgcmVtYWluaW5nIGZ1bmN0aW9ucyB0byBtaW5pbWl6ZSB0aGUgcmVtYWlu aW5nIHdvcmsgdG8gc3dpdGNoaW5nCisgICAgICAgIHRvIEZyYWN0aW9uYWxMYXlvdXRVbml0cyBm b3IgbGF5b3V0IGluc3RlYWQgb2YgaW50ZWdlcnMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBO byBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiByZW5kZXJpbmcvSW5saW5lRmxvd0Jv eC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVGbG93Qm94OjpwbGFjZUJveGVzSW5CbG9j a0RpcmVjdGlvbik6IFRob3VnaCBzdG9yZWQgYXMgYSBmbG9hdCwgdGhlIHRvcCBpcyBhbHdheXMK KyAgICAgICAgc2V0IHRvIGFuIGludGVnZXIgdmFsdWUuIFdoZW4gd2UgbW92ZSB0byBzdWItcGl4 ZWwsIHdlIG5lZWQgdG8gcHJlc2VydmUgdGhpcy4gTm90IHByZXNlcnZpbmcgdGhpcworICAgICAg ICBiZWhhdmlvciBhZmZlY3RzIHRleHQgZGVjb3JhdGlvbnMsIG1vc3Qgbm90YWJseSB1bmRlcmxp bmVzLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJXaWRnZXQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyV2lkZ2V0Ojp1cGRhdGVXaWRnZXRHZW9tZXRyeSk6IEFkZGluZyBwaXhlbCBz bmFwcGluZyBmb3IgdGhlIGNvbnRlbnQgYm94IGlmIGl0J3MKKyAgICAgICAgbm90IHRyYW5zZm9y bWVkIChhYnNvbHV0ZUNvbnRlbnRCb3ggaW5jbHVkZXMgcGl4ZWwgc25hcHBpbmcpLCBhbmQgcHJv cGVybHkgdHJlYXRpbmcgdGhlIGJvdW5kaW5nQm94CisgICAgICAgIGFzIGFuIEludFJlY3QuCisK IDIwMTItMDQtMzAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAg ICAgICBBZGQgYSB3YXkgdG8gYXN5bmNocm9ub3VzbHkgY2FsbCBhIGZ1bmN0aW9uIG9uY2UgdGhl IHNjcm9sbCBwb3NpdGlvbiBvZiBhIHBhZ2UgaGFzIGJlZW4gdXBkYXRlZApJbmRleDogU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNwcAkocmV2aXNpb24gMTE1NjQ3KQor KysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwCSh3b3JraW5nIGNv cHkpCkBAIC01OTQsNyArNTk0LDcgQEAgdm9pZCBJbmxpbmVGbG93Qm94OjpwbGFjZUJveGVzSW5C bG9ja0RpcgogICAgIGJvb2wgaXNSb290Qm94ID0gaXNSb290SW5saW5lQm94KCk7CiAgICAgaWYg KGlzUm9vdEJveCkgewogICAgICAgICBjb25zdCBGb250TWV0cmljcyYgZm9udE1ldHJpY3MgPSBy ZW5kZXJlcigpLT5zdHlsZShpc0ZpcnN0TGluZVN0eWxlKCkpLT5mb250TWV0cmljcygpOwotICAg ICAgICBzZXRMb2dpY2FsVG9wKHRvcCArIG1heEFzY2VudCAtIGZvbnRNZXRyaWNzLmFzY2VudChi YXNlbGluZVR5cGUpKTsKKyAgICAgICAgc2V0TG9naWNhbFRvcChyb3VuZFRvSW50KHRvcCArIG1h eEFzY2VudCAtIGZvbnRNZXRyaWNzLmFzY2VudChiYXNlbGluZVR5cGUpKSk7CiAgICAgfQogCiAg ICAgTGF5b3V0VW5pdCBhZGp1c3RtZW50Rm9yQ2hpbGRyZW5XaXRoU2FtZUxpbmVIZWlnaHRBbmRC YXNlbGluZSA9IDA7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyV2lkZ2V0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyV2lkZ2V0 LmNwcAkocmV2aXNpb24gMTE1NjQ3KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl cldpZGdldC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3NiwxMSArMTc2LDExIEBAIGJvb2wgUmVu ZGVyV2lkZ2V0OjpzZXRXaWRnZXRHZW9tZXRyeShjb24KIAogYm9vbCBSZW5kZXJXaWRnZXQ6OnVw ZGF0ZVdpZGdldEdlb21ldHJ5KCkKIHsKLSAgICBMYXlvdXRSZWN0IGNvbnRlbnRCb3ggPSBjb250 ZW50Qm94UmVjdCgpOworICAgIEludFJlY3QgY29udGVudEJveCA9IHBpeGVsU25hcHBlZEludFJl Y3QoY29udGVudEJveFJlY3QoKSk7CiAgICAgaWYgKCFtX3dpZGdldC0+dHJhbnNmb3Jtc0FmZmVj dEZyYW1lUmVjdCgpKQogICAgICAgICByZXR1cm4gc2V0V2lkZ2V0R2VvbWV0cnkoYWJzb2x1dGVD b250ZW50Qm94KCkpOwogCi0gICAgTGF5b3V0UmVjdCBhYnNvbHV0ZUNvbnRlbnRCb3gobG9jYWxU b0Fic29sdXRlUXVhZChGbG9hdFF1YWQoY29udGVudEJveCkpLmJvdW5kaW5nQm94KCkpOworICAg IEludFJlY3QgYWJzb2x1dGVDb250ZW50Qm94KGxvY2FsVG9BYnNvbHV0ZVF1YWQoRmxvYXRRdWFk KGNvbnRlbnRCb3gpKS5ib3VuZGluZ0JveCgpKTsKICAgICBpZiAobV93aWRnZXQtPmlzRnJhbWVW aWV3KCkpIHsKICAgICAgICAgY29udGVudEJveC5zZXRMb2NhdGlvbihhYnNvbHV0ZUNvbnRlbnRC b3gubG9jYXRpb24oKSk7CiAgICAgICAgIHJldHVybiBzZXRXaWRnZXRHZW9tZXRyeShjb250ZW50 Qm94KTsK 139540 2012-04-30 16:07:31 -0700 2012-04-30 16:41:21 -0700 Patch for landing bug-85239-20120430160730.patch text/plain 3225 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNTY3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA0LTMwICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBVcGRhdGUgTGF5b3V0VW5p dCB1c2FnZSBpbiBJbmxpbmVGbG93Qm94IGFuZCBSZW5kZXJXaWRnZXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MjM5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgRXJpYyBTZWlkZWwuCisKKyAgICAgICAgVXBkYXRpbmcgTGF5b3V0VW5pdCB1c2FnZSBp biBhIHBhaXIgb2YgcmVtYWluaW5nIGZ1bmN0aW9ucyB0byBtaW5pbWl6ZSB0aGUgcmVtYWluaW5n IHdvcmsgdG8gc3dpdGNoaW5nCisgICAgICAgIHRvIEZyYWN0aW9uYWxMYXlvdXRVbml0cyBmb3Ig bGF5b3V0IGluc3RlYWQgb2YgaW50ZWdlcnMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBj aGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiByZW5kZXJpbmcvSW5saW5lRmxvd0JveC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVGbG93Qm94OjpwbGFjZUJveGVzSW5CbG9ja0Rp cmVjdGlvbik6IFRob3VnaCBzdG9yZWQgYXMgYSBmbG9hdCwgdGhlIHRvcCBpcyBhbHdheXMKKyAg ICAgICAgc2V0IHRvIGFuIGludGVnZXIgdmFsdWUuIFdoZW4gd2UgbW92ZSB0byBzdWItcGl4ZWws IHdlIG5lZWQgdG8gcHJlc2VydmUgdGhpcy4gTm90IHByZXNlcnZpbmcgdGhpcworICAgICAgICBi ZWhhdmlvciBhZmZlY3RzIHRleHQgZGVjb3JhdGlvbnMsIG1vc3Qgbm90YWJseSB1bmRlcmxpbmVz LgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJXaWRnZXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyV2lkZ2V0Ojp1cGRhdGVXaWRnZXRHZW9tZXRyeSk6IEFkZGluZyBwaXhlbCBzbmFw cGluZyBmb3IgdGhlIGNvbnRlbnQgYm94IGlmIGl0J3MKKyAgICAgICAgbm90IHRyYW5zZm9ybWVk IChhYnNvbHV0ZUNvbnRlbnRCb3ggaW5jbHVkZXMgcGl4ZWwgc25hcHBpbmcpLCBhbmQgcHJvcGVy bHkgdHJlYXRpbmcgdGhlIGJvdW5kaW5nQm94CisgICAgICAgIGFzIGFuIEludFJlY3QuCisKIDIw MTItMDQtMzAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgYSB3YXkgdG8gYXN5bmNocm9ub3VzbHkgY2FsbCBhIGZ1bmN0aW9uIG9uY2UgdGhlIHNj cm9sbCBwb3NpdGlvbiBvZiBhIHBhZ2UgaGFzIGJlZW4gdXBkYXRlZApJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNwcAkocmV2aXNpb24gMTE1NjQ3KQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dCb3guY3BwCSh3b3JraW5nIGNvcHkp CkBAIC01OTQsNyArNTk0LDkgQEAgdm9pZCBJbmxpbmVGbG93Qm94OjpwbGFjZUJveGVzSW5CbG9j a0RpcgogICAgIGJvb2wgaXNSb290Qm94ID0gaXNSb290SW5saW5lQm94KCk7CiAgICAgaWYgKGlz Um9vdEJveCkgewogICAgICAgICBjb25zdCBGb250TWV0cmljcyYgZm9udE1ldHJpY3MgPSByZW5k ZXJlcigpLT5zdHlsZShpc0ZpcnN0TGluZVN0eWxlKCkpLT5mb250TWV0cmljcygpOwotICAgICAg ICBzZXRMb2dpY2FsVG9wKHRvcCArIG1heEFzY2VudCAtIGZvbnRNZXRyaWNzLmFzY2VudChiYXNl bGluZVR5cGUpKTsKKyAgICAgICAgLy8gUm9vdElubGluZUJveGVzIGFyZSBhbHdheXMgcGxhY2Vk IG9uIGF0IHBpeGVsIGJvdW5kYXJpZXMgaW4gdGhlaXIgbG9naWNhbCB5IGRpcmVjdGlvbi4gTm90 IGRvaW5nCisgICAgICAgIC8vIHNvIHJlc3VsdHMgaW4gaW5jb3JyZWN0IHJlbmRlcmluZyBvZiB0 ZXh0IGRlY29yYXRpb25zLCBtb3N0IG5vdGFibHkgdW5kZXJsaW5lcy4KKyAgICAgICAgc2V0TG9n aWNhbFRvcChyb3VuZFRvSW50KHRvcCArIG1heEFzY2VudCAtIGZvbnRNZXRyaWNzLmFzY2VudChi YXNlbGluZVR5cGUpKSk7CiAgICAgfQogCiAgICAgTGF5b3V0VW5pdCBhZGp1c3RtZW50Rm9yQ2hp bGRyZW5XaXRoU2FtZUxpbmVIZWlnaHRBbmRCYXNlbGluZSA9IDA7CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyV2lkZ2V0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyV2lkZ2V0LmNwcAkocmV2aXNpb24gMTE1NjQ3KQorKysgU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcldpZGdldC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE3NiwxMSArMTc2LDExIEBAIGJvb2wgUmVuZGVyV2lkZ2V0OjpzZXRXaWRnZXRHZW9tZXRyeShj b24KIAogYm9vbCBSZW5kZXJXaWRnZXQ6OnVwZGF0ZVdpZGdldEdlb21ldHJ5KCkKIHsKLSAgICBM YXlvdXRSZWN0IGNvbnRlbnRCb3ggPSBjb250ZW50Qm94UmVjdCgpOworICAgIEludFJlY3QgY29u dGVudEJveCA9IHBpeGVsU25hcHBlZEludFJlY3QoY29udGVudEJveFJlY3QoKSk7CiAgICAgaWYg KCFtX3dpZGdldC0+dHJhbnNmb3Jtc0FmZmVjdEZyYW1lUmVjdCgpKQogICAgICAgICByZXR1cm4g c2V0V2lkZ2V0R2VvbWV0cnkoYWJzb2x1dGVDb250ZW50Qm94KCkpOwogCi0gICAgTGF5b3V0UmVj dCBhYnNvbHV0ZUNvbnRlbnRCb3gobG9jYWxUb0Fic29sdXRlUXVhZChGbG9hdFF1YWQoY29udGVu dEJveCkpLmJvdW5kaW5nQm94KCkpOworICAgIEludFJlY3QgYWJzb2x1dGVDb250ZW50Qm94KGxv Y2FsVG9BYnNvbHV0ZVF1YWQoRmxvYXRRdWFkKGNvbnRlbnRCb3gpKS5ib3VuZGluZ0JveCgpKTsK ICAgICBpZiAobV93aWRnZXQtPmlzRnJhbWVWaWV3KCkpIHsKICAgICAgICAgY29udGVudEJveC5z ZXRMb2NhdGlvbihhYnNvbHV0ZUNvbnRlbnRCb3gubG9jYXRpb24oKSk7CiAgICAgICAgIHJldHVy biBzZXRXaWRnZXRHZW9tZXRyeShjb250ZW50Qm94KTsK