85112 2012-04-27 17:07:17 -0700 Add &lrm; &rlm; and &nbsp; to WebVTT parser 2014-01-21 10:39:43 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85035 1 annacc eric.carlson commit-queue ddkilzer eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble oldest_to_newest 612033 0 annacc 2012-04-27 17:07:17 -0700 &lrm; &rlm; and &nbsp; were recently added to the WebVTT spec http://dev.w3.org/html5/webvtt/#webvtt-cue-components 969567 1 ddkilzer 2014-01-18 19:47:11 -0800 Fixed in Blink: http://src.chromium.org/viewvc/blink?view=revision&revision=161822 969568 2 ddkilzer 2014-01-18 19:47:23 -0800 (In reply to comment #1) > Fixed in Blink: http://src.chromium.org/viewvc/blink?view=revision&revision=161822 https://code.google.com/p/chromium/issues/detail?id=314028 970036 3 eric.carlson 2014-01-20 15:15:46 -0800 I have had changes for this in my local repository for a while, guess I forgot to post a patch. 970038 4 221697 eric.carlson 2014-01-20 15:17:43 -0800 Created attachment 221697 Proposed patch 970251 5 eric.carlson 2014-01-21 08:02:59 -0800 Doesn't look like the efl failure has anything to do with this patch: Last 500 characters of output: ing CXX object Source/WebCore/CMakeFiles/WebCore.dir/dom/ScriptedAnimationController.cpp.o c++: internal compiler error: Killed (program cc1plus) 970291 6 221697 jer.noble 2014-01-21 09:54:14 -0800 Comment on attachment 221697 Proposed patch r=me 970312 7 221697 commit-queue 2014-01-21 10:39:41 -0800 Comment on attachment 221697 Proposed patch Clearing flags on attachment: 221697 Committed r162450: <http://trac.webkit.org/changeset/162450> 970313 8 commit-queue 2014-01-21 10:39:43 -0800 All reviewed patches have been landed. Closing bug. 221697 2014-01-20 15:17:43 -0800 2014-01-21 10:39:41 -0800 Proposed patch patch_1.txt text/plain 6663 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjM3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTIwICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCAmbHJtOyAmcmxt OyBhbmQgJm5ic3A7IHRvIFdlYlZUVCBwYXJzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0cmFjay13ZWJ2dHQtdGMwMjItZW50 aXRpZXMuaHRtbCB3YXMgdXBkYXRlZCB0byB0ZXN0IHRoaXMuCisKKyAgICAgICAgKiBodG1sL3Ry YWNrL1dlYlZUVFRva2VuaXplci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJWVFRUb2tlbml6 ZXI6Om5leHRUb2tlbik6IFN1cHBvcnQgUkxNLCBMUk0sIGFuZCBOQlNQIGVudGl0aWVzLgorCiAy MDE0LTAxLTIwICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KIAogICAgICAgICBB ZGQgQVZLaXQgZnVsbHNjcmVlbiB2aWRlbyBpbnRlcmZhY2UuCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9odG1sL3RyYWNrL1dlYlZUVFRva2VuaXplci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvaHRtbC90cmFjay9XZWJWVFRUb2tlbml6ZXIuY3BwCShyZXZpc2lvbiAxNjIzMzkpCisr KyBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1dlYlZUVFRva2VuaXplci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTM1LDYgKzM1LDcgQEAKICNpbmNsdWRlICJXZWJWVFRUb2tlbml6ZXIuaCIKIAog I2luY2x1ZGUgIk1hcmt1cFRva2VuaXplcklubGluZXMuaCIKKyNpbmNsdWRlIDx3dGYvdW5pY29k ZS9DaGFyYWN0ZXJOYW1lcy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTEwNyw2ICsx MDgsMTIgQEAgYm9vbCBXZWJWVFRUb2tlbml6ZXI6Om5leHRUb2tlbihTZWdtZW50ZQogICAgICAg ICAgICAgICAgIGJ1ZmZlckNoYXJhY3RlcignPCcpOwogICAgICAgICAgICAgZWxzZSBpZiAodmVj dG9yRXF1YWxzU3RyaW5nKG1fYnVmZmVyLCAiJmd0IikpCiAgICAgICAgICAgICAgICAgYnVmZmVy Q2hhcmFjdGVyKCc+Jyk7CisgICAgICAgICAgICBlbHNlIGlmICh2ZWN0b3JFcXVhbHNTdHJpbmco bV9idWZmZXIsICImbHJtIikpCisgICAgICAgICAgICAgICAgYnVmZmVyQ2hhcmFjdGVyKGxlZnRU b1JpZ2h0TWFyayk7CisgICAgICAgICAgICBlbHNlIGlmICh2ZWN0b3JFcXVhbHNTdHJpbmcobV9i dWZmZXIsICImcmxtIikpCisgICAgICAgICAgICAgICAgYnVmZmVyQ2hhcmFjdGVyKHJpZ2h0VG9M ZWZ0TWFyayk7CisgICAgICAgICAgICBlbHNlIGlmICh2ZWN0b3JFcXVhbHNTdHJpbmcobV9idWZm ZXIsICImbmJzcCIpKQorICAgICAgICAgICAgICAgIGJ1ZmZlckNoYXJhY3Rlcihub0JyZWFrU3Bh Y2UpOwogICAgICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICAgICAgbV9idWZmZXIuYXBwZW5k KHN0YXRpY19jYXN0PExDaGFyPihjYykpOwogICAgICAgICAgICAgICAgIG1fdG9rZW4tPmFwcGVu ZFRvQ2hhcmFjdGVyKG1fYnVmZmVyKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjM3OSkKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0 LTAxLTIwICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAg IEFkZCAmbHJtOyAmcmxtOyBhbmQgJm5ic3A7IHRvIFdlYlZUVCBwYXJzZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MTEyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtZWRpYS90cmFjay9jYXB0aW9u cy13ZWJ2dHQvdGMwMjItZW50aXRpZXMudnR0OgorICAgICAgICAqIG1lZGlhL3RyYWNrL3RyYWNr LXdlYnZ0dC10YzAyMi1lbnRpdGllcy1leHBlY3RlZC50eHQ6CisgICAgICAgICogbWVkaWEvdHJh Y2svdHJhY2std2VidnR0LXRjMDIyLWVudGl0aWVzLmh0bWw6CisKIDIwMTQtMDEtMjAgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgc3ZnL2ZpbHRlcnMvZmVD b21wb25lbnRUcmFuc2Zlci1zdHlsZS1jcmFzaC54aHRtbCBpcyBmbGFreQpJbmRleDogTGF5b3V0 VGVzdHMvbWVkaWEvdHJhY2svdHJhY2std2VidnR0LXRjMDIyLWVudGl0aWVzLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay13ZWJ2dHQtdGMw MjItZW50aXRpZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxNjIzMzkpCisrKyBMYXlvdXRUZXN0 cy9tZWRpYS90cmFjay90cmFjay13ZWJ2dHQtdGMwMjItZW50aXRpZXMtZXhwZWN0ZWQudHh0CSh3 b3JraW5nIGNvcHkpCkBAIC0zLDEwICszLDEzIEBAIFRlc3RzIHNwZWNpYWwgY2hhcmFjdGVycyAm LCA8LCBhbmQgPiBpbiAKIAogCiAqKiogVGVzdGluZyB0ZXh0IHRyYWNrIDAKLUVYUEVDVEVEIChj dWVzLmxlbmd0aCA9PSAnMycpIE9LCi1FWFBFQ1RFRCAoY3Vlc1swXS5nZXRDdWVBc0hUTUwoKS50 ZXh0Q29udGVudCA9PSAnVGhpcyBjdWUgaGFzIGFuIGFtcCAmIGNoYXJhY3Rlci4nKSBPSwotRVhQ RUNURUQgKGN1ZXNbMV0uZ2V0Q3VlQXNIVE1MKCkudGV4dENvbnRlbnQgPT0gJ1RoaXMgY3VlIGhh cyBhIGxlc3MgdGhhbiA8IGNoYXJhY3Rlci4nKSBPSwotRVhQRUNURUQgKGN1ZXNbMl0uZ2V0Q3Vl QXNIVE1MKCkudGV4dENvbnRlbnQgPT0gJ1RoaXMgY3VlIGhhcyBhIGdyZWF0ZXIgdGhhbiA+IGNo YXJhY3Rlci4nKSBPSworRVhQRUNURUQgKGN1ZXMubGVuZ3RoID09ICc2JykgT0sKK0VYUEVDVEVE IChjdWVzWzBdLmdldEN1ZUFzSFRNTCgpLnRleHRDb250ZW50ID09ICdUaGlzIGN1ZSBoYXMgYW4g YW1wIGNoYXJhY3RlcjogJicpIE9LCitFWFBFQ1RFRCAoY3Vlc1sxXS5nZXRDdWVBc0hUTUwoKS50 ZXh0Q29udGVudCA9PSAnVGhpcyBjdWUgaGFzIGEgbGVzcyB0aGFuIGNoYXJhY3RlcjogPCcpIE9L CitFWFBFQ1RFRCAoY3Vlc1syXS5nZXRDdWVBc0hUTUwoKS50ZXh0Q29udGVudCA9PSAnVGhpcyBj dWUgaGFzIGEgZ3JlYXRlciB0aGFuIGNoYXJhY3RlcjogPicpIE9LCitFWFBFQ1RFRCAoY3Vlc1sz XS5nZXRDdWVBc0hUTUwoKS50ZXh0Q29udGVudCA9PSAnVGhpcyBjdWUgaGFzIGEgcmlnaHQtdG8t bGVmdCBtYXJrIChSTE0pOiDigI8nKSBPSworRVhQRUNURUQgKGN1ZXNbNF0uZ2V0Q3VlQXNIVE1M KCkudGV4dENvbnRlbnQgPT0gJ1RoaXMgY3VlIGhhcyBhIGxlZnQtdG8tcmlnaHQgbWFyayAoTFJN KTog4oCOJykgT0sKK0VYUEVDVEVEIChjdWVzWzVdLmdldEN1ZUFzSFRNTCgpLnRleHRDb250ZW50 ID09ICdUaGlzIGN1ZSBoYXMgYSBub24tYnJlYWthYmxlIHNwYWNlIChOQlNQKTogwqAnKSBPSwog CiAqKiogVGVzdGluZyB0ZXh0IHRyYWNrIDEKIEVYUEVDVEVEIChjdWVzLmxlbmd0aCA9PSAnMycp IE9LCkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay13ZWJ2dHQtdGMwMjItZW50 aXRpZXMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay13 ZWJ2dHQtdGMwMjItZW50aXRpZXMuaHRtbAkocmV2aXNpb24gMTYyMzM5KQorKysgTGF5b3V0VGVz dHMvbWVkaWEvdHJhY2svdHJhY2std2VidnR0LXRjMDIyLWVudGl0aWVzLmh0bWwJKHdvcmtpbmcg Y29weSkKQEAgLTI0LDE0ICsyNCwxOSBAQAogICAgICAgICAgICAgICAgIGZpbmRNZWRpYUVsZW1l bnQoKTsKICAgICAgICAgICAgICAgICB2YXIgZXhwZWN0ZWQgPSAKICAgICAgICAgICAgICAgICB7 Ci0gICAgICAgICAgICAgICAgICAgIGxlbmd0aCA6IDMsCisgICAgICAgICAgICAgICAgICAgIGxl bmd0aCA6IDYsCiAgICAgICAgICAgICAgICAgICAgIHRlc3RzOgogICAgICAgICAgICAgICAgICAg ICBbCiAgICAgICAgICAgICAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgcHJvcGVydHkgOiAiZ2V0Q3VlQXNIVE1MKCkudGV4dENvbnRlbnQiLAotICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHZhbHVlcyA6IFsiVGhpcyBjdWUgaGFzIGFuIGFtcCAmIGNoYXJhY3Rl ci4iLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiVGhpcyBjdWUgaGFz IGEgbGVzcyB0aGFuIDwgY2hhcmFjdGVyLiIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICJUaGlzIGN1ZSBoYXMgYSBncmVhdGVyIHRoYW4gPiBjaGFyYWN0ZXIuIl0sCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdmFsdWVzIDogWworICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICJUaGlzIGN1ZSBoYXMgYW4gYW1wIGNoYXJhY3RlcjogXHUw MDI2IiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiVGhpcyBjdWUg aGFzIGEgbGVzcyB0aGFuIGNoYXJhY3RlcjogXHUwMDNDIiwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAiVGhpcyBjdWUgaGFzIGEgZ3JlYXRlciB0aGFuIGNoYXJhY3Rl cjogXHUwMDNFIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiVGhp cyBjdWUgaGFzIGEgcmlnaHQtdG8tbGVmdCBtYXJrIChSTE0pOiBcdTIwMGYiLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJUaGlzIGN1ZSBoYXMgYSBsZWZ0LXRvLXJp Z2h0IG1hcmsgKExSTSk6IFx1MjAwZSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIlRoaXMgY3VlIGhhcyBhIG5vbi1icmVha2FibGUgc3BhY2UgKE5CU1ApOiBcdTAw YTAiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXSwKICAgICAgICAgICAg ICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgICAgIF0sCiAgICAgICAgICAgICAgICAg fTsKSW5kZXg6IExheW91dFRlc3RzL21lZGlhL3RyYWNrL2NhcHRpb25zLXdlYnZ0dC90YzAyMi1l bnRpdGllcy52dHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svY2FwdGlv bnMtd2VidnR0L3RjMDIyLWVudGl0aWVzLnZ0dAkocmV2aXNpb24gMTYyMzM5KQorKysgTGF5b3V0 VGVzdHMvbWVkaWEvdHJhY2svY2FwdGlvbnMtd2VidnR0L3RjMDIyLWVudGl0aWVzLnZ0dAkod29y a2luZyBjb3B5KQpAQCAtMSwxNCArMSwyNiBAQAogV0VCVlRUCi1DdWUgY29udGVudCB3aXRoIGVz Y2FwZSBjaGFyYWN0ZXJzIGZvciAmLCA8LCBhbmQgPi4KK0N1ZSBjb250ZW50IHdpdGggZXNjYXBl IGNoYXJhY3RlcnMgZm9yICYsIDwsID4sIExSTSwgUkxNIGFuZCBub24tYnJlYWtpbmcgc3BhY2Uu CiAKIDEKIDAwOjAwOjAwLjAwMCAtLT4gMDA6MDA6MzAuNTAwIGFsaWduOnN0YXJ0IHBvc2l0aW9u OjIwJQotVGhpcyBjdWUgaGFzIGFuIGFtcCAmYW1wOyBjaGFyYWN0ZXIuCitUaGlzIGN1ZSBoYXMg YW4gYW1wIGNoYXJhY3RlcjogJmFtcDsKIAogMgogMDA6MDA6MzEuMDAwIC0tPiAwMDowMTowMC41 MDAgYWxpZ246c3RhcnQgcG9zaXRpb246MjAlCi1UaGlzIGN1ZSBoYXMgYSBsZXNzIHRoYW4gJmx0 OyBjaGFyYWN0ZXIuCitUaGlzIGN1ZSBoYXMgYSBsZXNzIHRoYW4gY2hhcmFjdGVyOiAmbHQ7CiAK IDMKIDAwOjAxOjAxLjAwMCAtLT4gMDA6MDI6MDAuNTAwIGFsaWduOnN0YXJ0IHBvc2l0aW9uOjIw JQotVGhpcyBjdWUgaGFzIGEgZ3JlYXRlciB0aGFuICZndDsgY2hhcmFjdGVyLgorVGhpcyBjdWUg aGFzIGEgZ3JlYXRlciB0aGFuIGNoYXJhY3RlcjogJmd0OworCis0CiswMDowMjowMS4wMDAgLS0+ IDAwOjAzOjAwLjUwMCBhbGlnbjpzdGFydCBwb3NpdGlvbjoyMCUKK1RoaXMgY3VlIGhhcyBhIHJp Z2h0LXRvLWxlZnQgbWFyayAoUkxNKTogJnJsbTsKKworNQorMDA6MDM6MDEuMDAwIC0tPiAwMDow NDowMC41MDAgYWxpZ246c3RhcnQgcG9zaXRpb246MjAlCitUaGlzIGN1ZSBoYXMgYSBsZWZ0LXRv LXJpZ2h0IG1hcmsgKExSTSk6ICZscm07CisKKzYKKzAwOjA0OjAxLjAwMCAtLT4gMDA6MDU6MDAu NTAwIGFsaWduOnN0YXJ0IHBvc2l0aW9uOjIwJQorVGhpcyBjdWUgaGFzIGEgbm9uLWJyZWFrYWJs ZSBzcGFjZSAoTkJTUCk6ICZuYnNwOwpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK