85041 2012-04-27 02:32:23 -0700 [EFL][WK2] Compile webkit1 and webkit2 by default. 2012-06-06 21:26:46 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 61838 0 mariusz.g webkit-unassigned cshu d-r g.czajkowski gyuyoung.kim rakuco ryuan.choi tmpsantos webkit.review.bot oldest_to_newest 611330 0 mariusz.g 2012-04-27 02:32:23 -0700 There is no option to build EFL's webkit2 from Tools/Scripts/build-webkit script. 611333 1 139156 mariusz.g 2012-04-27 02:35:32 -0700 Created attachment 139156 Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script 631214 2 139156 gyuyoung.kim 2012-05-22 22:14:35 -0700 Comment on attachment 139156 Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script Basically, looks good to me. However, can efl webkit2 be built on trunk ? 631360 3 mariusz.g 2012-05-23 01:02:20 -0700 (In reply to comment #2) > (From update of attachment 139156 [details]) > Basically, looks good to me. However, can efl webkit2 be built on trunk ? If all related patches will be merged, webkit2 can be built on trunk like gtk port. 635214 4 d-r 2012-05-28 07:43:14 -0700 Mariusz, I am seeing the same issue as the EWS on my machine: "-- Configuring done CMake Error in Source/WebKit2/CMakeLists.txt: Cannot find source file "WebCoreArgumentCodersEfl.cpp". Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx" I am looking into it. 638282 5 ryuan.choi 2012-05-31 05:40:10 -0700 mariusz, Could you rebase the patch? I think that WebKit/Efl will be compiled in ews now. 638294 6 gyuyoung.kim 2012-05-31 05:57:34 -0700 I think we need to support --only-webkit and --no-webkit2 options for EFL port. For example, GTK port supports this option as below, - http://trac.webkit.org/browser/trunk/Tools/Scripts/build-webkit#L365 If possible, could you support this option as well? 638573 7 mariusz.g 2012-05-31 11:03:42 -0700 (In reply to comment #6) > I think we need to support --only-webkit and --no-webkit2 options for EFL port. > > For example, GTK port supports this option as below, > - http://trac.webkit.org/browser/trunk/Tools/Scripts/build-webkit#L365 > > If possible, could you support this option as well? --no-webkit2 option is used as $noWebKit2 variable, and --only-webkit is as I see platform independent 638576 8 145116 mariusz.g 2012-05-31 11:04:57 -0700 Created attachment 145116 Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script Rebased. 638800 9 ryuan.choi 2012-05-31 16:30:22 -0700 (In reply to comment #8) > Created an attachment (id=145116) [details] > Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script > > Rebased. Thank you. informal r+ on my side. 638837 10 gyuyoung.kim 2012-05-31 17:31:36 -0700 Looks good to me. Thanks. 639314 11 145116 rakuco 2012-06-01 07:17:16 -0700 Comment on attachment 145116 Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script View in context: https://bugs.webkit.org/attachment.cgi?id=145116&action=review It looks good. You need to rebase your patch, and I don't think the EWS has actually run it, as ENABLE_WEBKIT2 is still OFF in its CMakeCache.txt. > Tools/Scripts/build-webkit:677 > + $cmakeArgs .= ($cmakeArgs ? " " : "") . "-DENABLE_WEBKIT=On"; > + $cmakeArgs .= " -DENABLE_WEBKIT2=On" if !$noWebKit2; Style nit: we generally use "ON" instead of "On". 640474 12 mariusz.g 2012-06-04 04:37:58 -0700 > It looks good. You need to rebase your patch, and I don't think the EWS has actually run it, as ENABLE_WEBKIT2 is still OFF in its CMakeCache.txt. Hm, I've ran webkit build like on EWS "perl ./Tools/Scripts/build-webkit --release --efl" and both webkit1 and webkit2 were built. In CMakeCache.txt I have "ENABLE_WEBKIT2:UNINITIALIZED=On". Is this right command, or EWS makes something extra? 641078 13 gyuyoung.kim 2012-06-04 18:15:13 -0700 (In reply to comment #12) EWS is compiling webkit using "Tools/Scripts/build-webkit --efl". If there is no problems when you build WebKit with your patches, I think EWS also won't have problems.(In reply to comment #12) > > It looks good. You need to rebase your patch, and I don't think the EWS has actually run it, as ENABLE_WEBKIT2 is still OFF in its CMakeCache.txt. > > Hm, I've ran webkit build like on EWS "perl ./Tools/Scripts/build-webkit --release --efl" and both webkit1 and webkit2 were built. In CMakeCache.txt I have "ENABLE_WEBKIT2:UNINITIALIZED=On". Is this right command, or EWS makes something extra? If the feature is not defined in WebKitFeatures, UNINITIALIZED is added to CMakeCache.txt. But, I think we don't need to add ENABLE_WEBKIT2 to WebKitFeatures yet. http://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake#L14 I ran webkit1 and webkit2 with this patch. Then, I could get both libewebkit2.so and libewebkit.so. It seems to me there is no problem. Kubo, do you think ENABLE_WEBKIT2 is off yet ? Mariusz, as kubo said, you need to use uppercase for "On". 641435 14 145759 mariusz.g 2012-06-05 04:54:39 -0700 Created attachment 145759 Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script Rebased, make changes pointed by Raphael 642389 15 g.czajkowski 2012-06-06 05:30:22 -0700 LGTM. 643109 16 145759 gyuyoung.kim 2012-06-06 19:45:13 -0700 Comment on attachment 145759 Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script Looks good to me. 643110 17 ryuan.choi 2012-06-06 19:46:16 -0700 LGTM too. 643181 18 145759 webkit.review.bot 2012-06-06 21:26:40 -0700 Comment on attachment 145759 Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script Clearing flags on attachment: 145759 Committed r119678: <http://trac.webkit.org/changeset/119678> 643182 19 webkit.review.bot 2012-06-06 21:26:46 -0700 All reviewed patches have been landed. Closing bug. 139156 2012-04-27 02:35:32 -0700 2012-05-31 11:04:57 -0700 Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script [[EFL][WK2]Compile-webkit1-and-webkit2-EFL-by-default].patch text/plain 1333 mariusz.g ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhYjRk N2M1Li5lOWQ1MDRhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDQtMjcgIE1hcml1c3ogR3J6ZWdvcmN6eWsg IDxtYXJpdXN6LmdAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBDb21waWxlIHdl YmtpdDEgYW5kIHdlYmtpdDIgYnkgZGVmYXVsdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MDQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ29tcGlsZSB3ZWJraXQxIGFuZCB3ZWJraXQyIHdoaWxlIHJ1 bm5pbmcgVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgLS1lZmwuCisgICAgICAgIFdlYmtpdDIg YnVpbGQgY2FuIGJlIHNraXBwZWQgYnkgYWRkaW5nIC0tbm8td2Via2l0MiBvcHRpb24gdG8gYnVp bGQtd2Via2l0IHNjcmlwdC4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtd2Via2l0OgorCiAy MDEyLTA0LTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbU09VUF0gQWRkIGEgd2F5IHRvIHJlZ2lzdGVyIGN1c3RvbSB1cmkgc2NoZW1lcyBp biBXZWJLaXQyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xz L1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDIyYTMzNjMuLmQ5YjE4ZWYgMTAwNzU1Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0CkBAIC02NzMsNiArNjczLDggQEAgaWYgKGlzQ2hyb21pdW0oKSkgewogaWYgKGlzRWZsKCkp IHsKICAgICAjIEJ5IGRlZmF1bHQgd2UgYnVpbGQgdXNpbmcgYWxsIG9mIHRoZSBhdmFpbGFibGUg Q1BVcy4KICAgICAkbWFrZUFyZ3MgLj0gKCRtYWtlQXJncyA/ICIgIiA6ICIiKSAuICItaiIgLiBu dW1iZXJPZkNQVXMoKSBpZiAkbWFrZUFyZ3MgIX4gLy1qXHMqXGQrLzsKKyAgICAkY21ha2VBcmdz IC49ICgkY21ha2VBcmdzID8gIiAiIDogIiIpIC4gIi1ERU5BQkxFX1dFQktJVD1PbiI7CisgICAg JGNtYWtlQXJncyAuPSAiIC1ERU5BQkxFX1dFQktJVDI9T24iIGlmICEkbm9XZWJLaXQyOwogICAg IGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCRjbGVhbiwgIkVmbCIsICRwcmVmaXhQYXRoLCAkbWFr ZUFyZ3MsIChjbWFrZUJhc2VkUG9ydEFyZ3VtZW50cygpLCBjTWFrZUFyZ3NGcm9tRmVhdHVyZXMo KSksICRjbWFrZUFyZ3MpOwogfQogCg== 145116 2012-05-31 11:04:57 -0700 2012-06-05 04:54:39 -0700 Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script [[EFL][WK2]Compile-webkit1-and-webkit2-EFL-by-default].patch text/plain 1333 mariusz.g ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhYjRk N2M1Li5lOWQ1MDRhIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDQtMjcgIE1hcml1c3ogR3J6ZWdvcmN6eWsg IDxtYXJpdXN6LmdAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBDb21waWxlIHdl YmtpdDEgYW5kIHdlYmtpdDIgYnkgZGVmYXVsdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MDQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ29tcGlsZSB3ZWJraXQxIGFuZCB3ZWJraXQyIHdoaWxlIHJ1 bm5pbmcgVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgLS1lZmwuCisgICAgICAgIFdlYmtpdDIg YnVpbGQgY2FuIGJlIHNraXBwZWQgYnkgYWRkaW5nIC0tbm8td2Via2l0MiBvcHRpb24gdG8gYnVp bGQtd2Via2l0IHNjcmlwdC4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtd2Via2l0OgorCiAy MDEyLTA0LTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbU09VUF0gQWRkIGEgd2F5IHRvIHJlZ2lzdGVyIGN1c3RvbSB1cmkgc2NoZW1lcyBp biBXZWJLaXQyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xz L1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDIyYTMzNjMuLmQ5YjE4ZWYgMTAwNzU1Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0CkBAIC02NzMsNiArNjczLDggQEAgaWYgKGlzQ2hyb21pdW0oKSkgewogaWYgKGlzRWZsKCkp IHsKICAgICAjIEJ5IGRlZmF1bHQgd2UgYnVpbGQgdXNpbmcgYWxsIG9mIHRoZSBhdmFpbGFibGUg Q1BVcy4KICAgICAkbWFrZUFyZ3MgLj0gKCRtYWtlQXJncyA/ICIgIiA6ICIiKSAuICItaiIgLiBu dW1iZXJPZkNQVXMoKSBpZiAkbWFrZUFyZ3MgIX4gLy1qXHMqXGQrLzsKKyAgICAkY21ha2VBcmdz IC49ICgkY21ha2VBcmdzID8gIiAiIDogIiIpIC4gIi1ERU5BQkxFX1dFQktJVD1PbiI7CisgICAg JGNtYWtlQXJncyAuPSAiIC1ERU5BQkxFX1dFQktJVDI9T24iIGlmICEkbm9XZWJLaXQyOwogICAg IGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCRjbGVhbiwgIkVmbCIsICRwcmVmaXhQYXRoLCAkbWFr ZUFyZ3MsIChjbWFrZUJhc2VkUG9ydEFyZ3VtZW50cygpLCBjTWFrZUFyZ3NGcm9tRmVhdHVyZXMo KSksICRjbWFrZUFyZ3MpOwogfQogCg== 145759 2012-06-05 04:54:39 -0700 2012-06-06 21:26:39 -0700 Make webkit2 EFL's port compilable from Tools/Scripts/build-webkit script [[EFL][WK2]Compile-webkit1-and-webkit2-EFL-by-default].patch text/plain 1351 mariusz.g ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZWRl NDU3Li5hZDJmOWM3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDYtMDUgIE1hcml1c3ogR3J6ZWdvcmN6eWsg IDxtYXJpdXN6LmdAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBDb21waWxlIHdl YmtpdDEgYW5kIHdlYmtpdDIgYnkgZGVmYXVsdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg1MDQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ29tcGlsZSB3ZWJraXQxIGFuZCB3ZWJraXQyIHdoaWxlIHJ1 bm5pbmcgVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgLS1lZmwuCisgICAgICAgIFdlYmtpdDIg YnVpbGQgY2FuIGJlIHNraXBwZWQgYnkgYWRkaW5nIC0tbm8td2Via2l0MiBvcHRpb24gdG8gYnVp bGQtd2Via2l0IHNjcmlwdC4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtd2Via2l0OgorCiAy MDEyLTA2LTA1ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXVtXSzJdIEltcGxlbWVudCBBUEkgZm9yIEdlb2xvY2F0aW9uIHBlcm1pc3Np b24gcmVxdWVzdHMgaW4gdGhlIEdUSyBwb3J0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1 aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDIwNTk1MjQuLjRi ZTJkNGIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xz L1NjcmlwdHMvYnVpbGQtd2Via2l0CkBAIC0zMjQsNiArMzI0LDggQEAgaWYgKGlzQ2hyb21pdW0o KSkgewogaWYgKGlzRWZsKCkpIHsKICAgICAjIEJ5IGRlZmF1bHQgd2UgYnVpbGQgdXNpbmcgYWxs IG9mIHRoZSBhdmFpbGFibGUgQ1BVcy4KICAgICAkbWFrZUFyZ3MgLj0gKCRtYWtlQXJncyA/ICIg IiA6ICIiKSAuICItaiIgLiBudW1iZXJPZkNQVXMoKSBpZiAkbWFrZUFyZ3MgIX4gLy1qXHMqXGQr LzsKKyAgICAkY21ha2VBcmdzIC49ICgkY21ha2VBcmdzID8gIiAiIDogIiIpIC4gIi1ERU5BQkxF X1dFQktJVD1PTiI7CisgICAgJGNtYWtlQXJncyAuPSAiIC1ERU5BQkxFX1dFQktJVDI9T04iIGlm ICEkbm9XZWJLaXQyOwogICAgIGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCRjbGVhbiwgIkVmbCIs ICRwcmVmaXhQYXRoLCAkbWFrZUFyZ3MsIChjbWFrZUJhc2VkUG9ydEFyZ3VtZW50cygpLCBjTWFr ZUFyZ3NGcm9tRmVhdHVyZXMoKSksICRjbWFrZUFyZ3MpOwogfQogCg==