84923 2012-04-25 18:47:24 -0700 [V8] Pass Isolate to wrap() in SerializedScriptValue.cpp 2012-04-26 14:52:46 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 610287 0 haraken 2012-04-25 18:47:24 -0700 The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to wrap() in SerializedScriptValue.cpp. 610288 1 138922 haraken 2012-04-25 18:49:10 -0700 Created attachment 138922 Patch 611011 2 138922 webkit.review.bot 2012-04-26 14:52:40 -0700 Comment on attachment 138922 Patch Clearing flags on attachment: 138922 Committed r115374: <http://trac.webkit.org/changeset/115374> 611012 3 webkit.review.bot 2012-04-26 14:52:46 -0700 All reviewed patches have been landed. Closing bug. 138922 2012-04-25 18:49:10 -0700 2012-04-26 14:52:39 -0700 Patch bug-84923-20120425184909.patch text/plain 3839 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjRjNzc2YWUxYWFhZjA2 NDcxNDA0OTRlNGQyMTMyZTg4ZDYyZWQ5Yy4uZGM5NDI0ZjVhNTA4NzM2ZWJkNWMwZmQ3NzQxYmQ2 NWQ2Njc4YmUwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTI1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFBhc3MgSXNv bGF0ZSB0byB3cmFwKCkgaW4gU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ5MjMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgb2JqZWN0aXZlIGlzIHRvIHBh c3MgSXNvbGF0ZSBhcm91bmQgaW4gVjggYmluZGluZ3MuCisgICAgICAgIEluIHRoaXMgYnVnIHdl IHBhc3MgSXNvbGF0ZSB0byB3cmFwKCkgaW4gU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcC4KKwor ICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmlu ZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcDoKKwogMjAxMi0wNC0yNSAgR3JlZyBC aWxsb2NrICA8Z2JpbGxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgb2JqZWN0 LWxpdGVyYWwgY29uc3RydWN0b3IgZm9yIHRoZSBJbnRlbnQgb2JqZWN0LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKaW5kZXgg YTU0ZTNjNGMzOTcxMTAwMzc4MTA5ZmJlMGRmZWM1NjU1YjRmZTMwNi4uOTYxZjMwMGI1MzRmNzVk Y2MzNDJmZWE4ZGNiNDJiNDg2NDAxMzkyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwCkBAIC01MDQsNiArNTA0LDcgQEAg cHVibGljOgogICAgICAgICBkb1dyaXRlVWludDMyKGxlbmd0aCk7CiAgICAgfQogCisgICAgdjg6 Oklzb2xhdGUqIGdldElzb2xhdGUoKSB7IHJldHVybiBtX2lzb2xhdGU7IH0KIAogcHJpdmF0ZToK ICAgICB2b2lkIGRvV3JpdGVBcnJheUJ1ZmZlcihjb25zdCBBcnJheUJ1ZmZlciYgYXJyYXlCdWZm ZXIpCkBAIC02MTgsMTEgKzYxOSwxMSBAQCBwdWJsaWM6CiAgICAgICAgIEFTU0VSVCghdHJ5Q2F0 Y2guSGFzQ2F1Z2h0KCkpOwogICAgICAgICBpZiAobWVzc2FnZVBvcnRzKSB7CiAgICAgICAgICAg ICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1lc3NhZ2VQb3J0cy0+c2l6ZSgpOyBpKyspCi0gICAg ICAgICAgICAgICAgbV90cmFuc2ZlcnJlZE1lc3NhZ2VQb3J0cy5zZXQoVjhNZXNzYWdlUG9ydDo6 d3JhcChtZXNzYWdlUG9ydHMtPmF0KGkpLmdldCgpKSwgaSk7CisgICAgICAgICAgICAgICAgbV90 cmFuc2ZlcnJlZE1lc3NhZ2VQb3J0cy5zZXQoVjhNZXNzYWdlUG9ydDo6d3JhcChtZXNzYWdlUG9y dHMtPmF0KGkpLmdldCgpLCBtX3dyaXRlci5nZXRJc29sYXRlKCkpLCBpKTsKICAgICAgICAgfQog ICAgICAgICBpZiAoYXJyYXlCdWZmZXJzKSB7CiAgICAgICAgICAgICBmb3IgKHNpemVfdCBpID0g MDsgaSA8IGFycmF5QnVmZmVycy0+c2l6ZSgpOyBpKyspICB7Ci0gICAgICAgICAgICAgICAgdjg6 OkhhbmRsZTx2ODo6T2JqZWN0PiB2OEFycmF5QnVmZmVyID0gVjhBcnJheUJ1ZmZlcjo6d3JhcChh cnJheUJ1ZmZlcnMtPmF0KGkpLmdldCgpKTsKKyAgICAgICAgICAgICAgICB2ODo6SGFuZGxlPHY4 OjpPYmplY3Q+IHY4QXJyYXlCdWZmZXIgPSBWOEFycmF5QnVmZmVyOjp3cmFwKGFycmF5QnVmZmVy cy0+YXQoaSkuZ2V0KCksIG1fd3JpdGVyLmdldElzb2xhdGUoKSk7CiAgICAgICAgICAgICAgICAg Ly8gQ29hbGVzY2UgbXVsdGlwbGUgb2NjdXJlbmNlcyBvZiB0aGUgc2FtZSBidWZmZXIgdG8gdGhl IGZpcnN0IGluZGV4LgogICAgICAgICAgICAgICAgIGlmICghbV90cmFuc2ZlcnJlZEFycmF5QnVm ZmVycy5jb250YWlucyh2OEFycmF5QnVmZmVyKSkKICAgICAgICAgICAgICAgICAgICAgbV90cmFu c2ZlcnJlZEFycmF5QnVmZmVycy5zZXQodjhBcnJheUJ1ZmZlciwgaSk7CkBAIC0xMDI0LDcgKzEw MjUsNyBAQCBwcml2YXRlOgogICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIGlmICghYXJy YXlCdWZmZXJWaWV3LT5idWZmZXIoKSkKICAgICAgICAgICAgIHJldHVybiBoYW5kbGVFcnJvcihE YXRhQ2xvbmVFcnJvciwgbmV4dCk7Ci0gICAgICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB1bmRl cmx5aW5nQnVmZmVyID0gdG9WOChhcnJheUJ1ZmZlclZpZXctPmJ1ZmZlcigpKTsKKyAgICAgICAg djg6OkhhbmRsZTx2ODo6VmFsdWU+IHVuZGVybHlpbmdCdWZmZXIgPSB0b1Y4KGFycmF5QnVmZmVy Vmlldy0+YnVmZmVyKCksIG1fd3JpdGVyLmdldElzb2xhdGUoKSk7CiAgICAgICAgIGlmICh1bmRl cmx5aW5nQnVmZmVyLklzRW1wdHkoKSkKICAgICAgICAgICAgIHJldHVybiBoYW5kbGVFcnJvcihE YXRhQ2xvbmVFcnJvciwgbmV4dCk7CiAgICAgICAgIFN0YXRlQmFzZSogc3RhdGVPdXQgPSBkb1Nl cmlhbGl6ZSh1bmRlcmx5aW5nQnVmZmVyLCAwKTsKQEAgLTE0NjgsNiArMTQ2OSw4IEBAIHB1Ymxp YzoKICAgICAgICAgbV92ZXJzaW9uID0gdmVyc2lvbjsKICAgICB9CiAKKyAgICB2ODo6SXNvbGF0 ZSogZ2V0SXNvbGF0ZSgpIHsgcmV0dXJuIG1faXNvbGF0ZTsgfQorCiBwcml2YXRlOgogICAgIGJv b2wgcmVhZFRhZyhTZXJpYWxpemF0aW9uVGFnKiB0YWcpCiAgICAgewpAQCAtMTk1OCw3ICsxOTYx LDcgQEAgcHVibGljOgogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBpZiAoaW5k ZXggPj0gbV90cmFuc2ZlcnJlZE1lc3NhZ2VQb3J0cy0+c2l6ZSgpKQogICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwotICAgICAgICAqb2JqZWN0ID0gVjhNZXNzYWdlUG9ydDo6d3JhcChtX3RyYW5z ZmVycmVkTWVzc2FnZVBvcnRzLT5hdChpbmRleCkuZ2V0KCkpOworICAgICAgICAqb2JqZWN0ID0g VjhNZXNzYWdlUG9ydDo6d3JhcChtX3RyYW5zZmVycmVkTWVzc2FnZVBvcnRzLT5hdChpbmRleCku Z2V0KCksIG1fcmVhZGVyLmdldElzb2xhdGUoKSk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAg IH0KIApAQCAtMTk3MCw3ICsxOTczLDcgQEAgcHVibGljOgogICAgICAgICAgICAgcmV0dXJuIGZh bHNlOwogICAgICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHJlc3VsdCA9IG1fYXJyYXlCdWZm ZXJzLmF0KGluZGV4KTsKICAgICAgICAgaWYgKHJlc3VsdC5Jc0VtcHR5KCkpIHsKLSAgICAgICAg ICAgIHJlc3VsdCA9IFY4QXJyYXlCdWZmZXI6OndyYXAoQXJyYXlCdWZmZXI6OmNyZWF0ZShtX2Fy cmF5QnVmZmVyQ29udGVudHMtPmF0KGluZGV4KSkuZ2V0KCkpOworICAgICAgICAgICAgcmVzdWx0 ID0gVjhBcnJheUJ1ZmZlcjo6d3JhcChBcnJheUJ1ZmZlcjo6Y3JlYXRlKG1fYXJyYXlCdWZmZXJD b250ZW50cy0+YXQoaW5kZXgpKS5nZXQoKSwgbV9yZWFkZXIuZ2V0SXNvbGF0ZSgpKTsKICAgICAg ICAgICAgIG1fYXJyYXlCdWZmZXJzW2luZGV4XSA9IHJlc3VsdDsKICAgICAgICAgfQogICAgICAg ICAqb2JqZWN0ID0gcmVzdWx0Owo=