84918 2012-04-25 17:52:47 -0700 [V8] Pass Isolate to toV8() in SerializedScriptValue.cpp 2012-04-26 13:40:43 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 610229 0 haraken 2012-04-25 17:52:47 -0700 This is the last step to pass Isolate around in SerializedScriptValue.cpp. We pass Isolate to toV8(). 610233 1 138912 haraken 2012-04-25 17:54:32 -0700 Created attachment 138912 Patch 610922 2 138912 webkit.review.bot 2012-04-26 13:40:38 -0700 Comment on attachment 138912 Patch Clearing flags on attachment: 138912 Committed r115351: <http://trac.webkit.org/changeset/115351> 610923 3 webkit.review.bot 2012-04-26 13:40:43 -0700 All reviewed patches have been landed. Closing bug. 138912 2012-04-25 17:54:32 -0700 2012-04-26 13:40:38 -0700 Patch bug-84918-20120425175431.patch text/plain 6349 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjRjNzc2YWUxYWFhZjA2 NDcxNDA0OTRlNGQyMTMyZTg4ZDYyZWQ5Yy4uMDJiOWY1ODM5ZmFkOTFmMDM3MjI4ZTUzZDE1MGFl NWIwYTNmNWQ0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTI1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFBhc3MgSXNv bGF0ZSB0byB0b1Y4KCkgaW4gU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ5MTgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIHRoZSBsYXN0IHN0ZXAg dG8gcGFzcyBJc29sYXRlIGFyb3VuZCBpbgorICAgICAgICBTZXJpYWxpemVkU2NyaXB0VmFsdWUu Y3BwLiBUaGlzIHBhdGNoIHBhc3NlcyBJc29sYXRlCisgICAgICAgIHRvIHRvVjgoKS4KKworICAg ICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGlu Z3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcDoKKwogMjAxMi0wNC0yNSAgR3JlZyBCaWxs b2NrICA8Z2JpbGxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgb2JqZWN0LWxp dGVyYWwgY29uc3RydWN0b3IgZm9yIHRoZSBJbnRlbnQgb2JqZWN0LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKaW5kZXggYTU0 ZTNjNGMzOTcxMTAwMzc4MTA5ZmJlMGRmZWM1NjU1YjRmZTMwNi4uZGU4YWY0YTg3YzQ2ZDllN2Q4 MDQ2Y2VhZGRjMjNkYmNhYjM1NDA1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwCkBAIC0xNTg4LDcgKzE1ODgsNyBAQCBw cml2YXRlOgogICAgICAgICBBU1NFUlQocGl4ZWxBcnJheS0+bGVuZ3RoKCkgPj0gcGl4ZWxEYXRh TGVuZ3RoKTsKICAgICAgICAgbWVtY3B5KHBpeGVsQXJyYXktPmRhdGEoKSwgbV9idWZmZXIgKyBt X3Bvc2l0aW9uLCBwaXhlbERhdGFMZW5ndGgpOwogICAgICAgICBtX3Bvc2l0aW9uICs9IHBpeGVs RGF0YUxlbmd0aDsKLSAgICAgICAgKnZhbHVlID0gdG9WOChpbWFnZURhdGEucmVsZWFzZSgpKTsK KyAgICAgICAgKnZhbHVlID0gdG9WOChpbWFnZURhdGEucmVsZWFzZSgpLCBtX2lzb2xhdGUpOwog ICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKQEAgLTE2MTAsNyArMTYxMCw3IEBAIHByaXZh dGU6CiAgICAgICAgIFJlZlB0cjxBcnJheUJ1ZmZlcj4gYXJyYXlCdWZmZXIgPSBkb1JlYWRBcnJh eUJ1ZmZlcigpOwogICAgICAgICBpZiAoIWFycmF5QnVmZmVyKQogICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwotICAgICAgICAqdmFsdWUgPSB0b1Y4KGFycmF5QnVmZmVyLnJlbGVhc2UoKSk7Cisg ICAgICAgICp2YWx1ZSA9IHRvVjgoYXJyYXlCdWZmZXIucmVsZWFzZSgpLCBtX2lzb2xhdGUpOwog ICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKQEAgLTE2MzYsNTggKzE2MzYsNTggQEAgcHJp dmF0ZToKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgc3dpdGNoIChzdWJUYWcp IHsKICAgICAgICAgY2FzZSBCeXRlQXJyYXlUYWc6Ci0gICAgICAgICAgICAqdmFsdWUgPSB0b1Y4 KEludDhBcnJheTo6Y3JlYXRlKGFycmF5QnVmZmVyLnJlbGVhc2UoKSwgYnl0ZU9mZnNldCwgYnl0 ZUxlbmd0aCkpOworICAgICAgICAgICAgKnZhbHVlID0gdG9WOChJbnQ4QXJyYXk6OmNyZWF0ZShh cnJheUJ1ZmZlci5yZWxlYXNlKCksIGJ5dGVPZmZzZXQsIGJ5dGVMZW5ndGgpLCBtX2lzb2xhdGUp OwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgVW5zaWduZWRCeXRlQXJyYXlUYWc6 Ci0gICAgICAgICAgICAqdmFsdWUgPSB0b1Y4KFVpbnQ4QXJyYXk6OmNyZWF0ZShhcnJheUJ1ZmZl ci5yZWxlYXNlKCksIGJ5dGVPZmZzZXQsIGJ5dGVMZW5ndGgpKTsKKyAgICAgICAgICAgICp2YWx1 ZSA9IHRvVjgoVWludDhBcnJheTo6Y3JlYXRlKGFycmF5QnVmZmVyLnJlbGVhc2UoKSwgYnl0ZU9m ZnNldCwgYnl0ZUxlbmd0aCksIG1faXNvbGF0ZSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgY2FzZSBVbnNpZ25lZEJ5dGVDbGFtcGVkQXJyYXlUYWc6Ci0gICAgICAgICAgICAqdmFsdWUg PSB0b1Y4KFVpbnQ4Q2xhbXBlZEFycmF5OjpjcmVhdGUoYXJyYXlCdWZmZXIucmVsZWFzZSgpLCBi eXRlT2Zmc2V0LCBieXRlTGVuZ3RoKSk7CisgICAgICAgICAgICAqdmFsdWUgPSB0b1Y4KFVpbnQ4 Q2xhbXBlZEFycmF5OjpjcmVhdGUoYXJyYXlCdWZmZXIucmVsZWFzZSgpLCBieXRlT2Zmc2V0LCBi eXRlTGVuZ3RoKSwgbV9pc29sYXRlKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNl IFNob3J0QXJyYXlUYWc6IHsKICAgICAgICAgICAgIHVpbnQzMl90IHNob3J0TGVuZ3RoID0gYnl0 ZUxlbmd0aCAvIHNpemVvZihpbnQxNl90KTsKICAgICAgICAgICAgIGlmIChzaG9ydExlbmd0aCAq IHNpemVvZihpbnQxNl90KSAhPSBieXRlTGVuZ3RoKQogICAgICAgICAgICAgICAgIHJldHVybiBm YWxzZTsKLSAgICAgICAgICAgICp2YWx1ZSA9IHRvVjgoSW50MTZBcnJheTo6Y3JlYXRlKGFycmF5 QnVmZmVyLnJlbGVhc2UoKSwgYnl0ZU9mZnNldCwgc2hvcnRMZW5ndGgpKTsKKyAgICAgICAgICAg ICp2YWx1ZSA9IHRvVjgoSW50MTZBcnJheTo6Y3JlYXRlKGFycmF5QnVmZmVyLnJlbGVhc2UoKSwg Ynl0ZU9mZnNldCwgc2hvcnRMZW5ndGgpLCBtX2lzb2xhdGUpOwogICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgIH0KICAgICAgICAgY2FzZSBVbnNpZ25lZFNob3J0QXJyYXlUYWc6IHsKICAgICAg ICAgICAgIHVpbnQzMl90IHNob3J0TGVuZ3RoID0gYnl0ZUxlbmd0aCAvIHNpemVvZih1aW50MTZf dCk7CiAgICAgICAgICAgICBpZiAoc2hvcnRMZW5ndGggKiBzaXplb2YodWludDE2X3QpICE9IGJ5 dGVMZW5ndGgpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICAgICAgKnZh bHVlID0gdG9WOChVaW50MTZBcnJheTo6Y3JlYXRlKGFycmF5QnVmZmVyLnJlbGVhc2UoKSwgYnl0 ZU9mZnNldCwgc2hvcnRMZW5ndGgpKTsKKyAgICAgICAgICAgICp2YWx1ZSA9IHRvVjgoVWludDE2 QXJyYXk6OmNyZWF0ZShhcnJheUJ1ZmZlci5yZWxlYXNlKCksIGJ5dGVPZmZzZXQsIHNob3J0TGVu Z3RoKSwgbV9pc29sYXRlKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAg IGNhc2UgSW50QXJyYXlUYWc6IHsKICAgICAgICAgICAgIHVpbnQzMl90IGludExlbmd0aCA9IGJ5 dGVMZW5ndGggLyBzaXplb2YoaW50MzJfdCk7CiAgICAgICAgICAgICBpZiAoaW50TGVuZ3RoICog c2l6ZW9mKGludDMyX3QpICE9IGJ5dGVMZW5ndGgpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZh bHNlOwotICAgICAgICAgICAgKnZhbHVlID0gdG9WOChJbnQzMkFycmF5OjpjcmVhdGUoYXJyYXlC dWZmZXIucmVsZWFzZSgpLCBieXRlT2Zmc2V0LCBpbnRMZW5ndGgpKTsKKyAgICAgICAgICAgICp2 YWx1ZSA9IHRvVjgoSW50MzJBcnJheTo6Y3JlYXRlKGFycmF5QnVmZmVyLnJlbGVhc2UoKSwgYnl0 ZU9mZnNldCwgaW50TGVuZ3RoKSwgbV9pc29sYXRlKTsKICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICB9CiAgICAgICAgIGNhc2UgVW5zaWduZWRJbnRBcnJheVRhZzogewogICAgICAgICAgICAg dWludDMyX3QgaW50TGVuZ3RoID0gYnl0ZUxlbmd0aCAvIHNpemVvZih1aW50MzJfdCk7CiAgICAg ICAgICAgICBpZiAoaW50TGVuZ3RoICogc2l6ZW9mKHVpbnQzMl90KSAhPSBieXRlTGVuZ3RoKQog ICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgICAgICp2YWx1ZSA9IHRvVjgo VWludDMyQXJyYXk6OmNyZWF0ZShhcnJheUJ1ZmZlci5yZWxlYXNlKCksIGJ5dGVPZmZzZXQsIGlu dExlbmd0aCkpOworICAgICAgICAgICAgKnZhbHVlID0gdG9WOChVaW50MzJBcnJheTo6Y3JlYXRl KGFycmF5QnVmZmVyLnJlbGVhc2UoKSwgYnl0ZU9mZnNldCwgaW50TGVuZ3RoKSwgbV9pc29sYXRl KTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGNhc2UgRmxvYXRBcnJh eVRhZzogewogICAgICAgICAgICAgdWludDMyX3QgZmxvYXRMZW5ndGggPSBieXRlTGVuZ3RoIC8g c2l6ZW9mKGZsb2F0KTsKICAgICAgICAgICAgIGlmIChmbG9hdExlbmd0aCAqIHNpemVvZihmbG9h dCkgIT0gYnl0ZUxlbmd0aCkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAg ICAgICAqdmFsdWUgPSB0b1Y4KEZsb2F0MzJBcnJheTo6Y3JlYXRlKGFycmF5QnVmZmVyLnJlbGVh c2UoKSwgYnl0ZU9mZnNldCwgZmxvYXRMZW5ndGgpKTsKKyAgICAgICAgICAgICp2YWx1ZSA9IHRv VjgoRmxvYXQzMkFycmF5OjpjcmVhdGUoYXJyYXlCdWZmZXIucmVsZWFzZSgpLCBieXRlT2Zmc2V0 LCBmbG9hdExlbmd0aCksIG1faXNvbGF0ZSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg fQogICAgICAgICBjYXNlIERvdWJsZUFycmF5VGFnOiB7CiAgICAgICAgICAgICB1aW50MzJfdCBm bG9hdExlbmd0aCA9IGJ5dGVMZW5ndGggLyBzaXplb2YoZG91YmxlKTsKICAgICAgICAgICAgIGlm IChmbG9hdExlbmd0aCAqIHNpemVvZihkb3VibGUpICE9IGJ5dGVMZW5ndGgpCiAgICAgICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICAgICAgKnZhbHVlID0gdG9WOChGbG9hdDY0QXJy YXk6OmNyZWF0ZShhcnJheUJ1ZmZlci5yZWxlYXNlKCksIGJ5dGVPZmZzZXQsIGZsb2F0TGVuZ3Ro KSk7CisgICAgICAgICAgICAqdmFsdWUgPSB0b1Y4KEZsb2F0NjRBcnJheTo6Y3JlYXRlKGFycmF5 QnVmZmVyLnJlbGVhc2UoKSwgYnl0ZU9mZnNldCwgZmxvYXRMZW5ndGgpLCBtX2lzb2xhdGUpOwog ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAgICAgY2FzZSBEYXRhVmlld1RhZzoK LSAgICAgICAgICAgICp2YWx1ZSA9IHRvVjgoRGF0YVZpZXc6OmNyZWF0ZShhcnJheUJ1ZmZlci5y ZWxlYXNlKCksIGJ5dGVPZmZzZXQsIGJ5dGVMZW5ndGgpKTsKKyAgICAgICAgICAgICp2YWx1ZSA9 IHRvVjgoRGF0YVZpZXc6OmNyZWF0ZShhcnJheUJ1ZmZlci5yZWxlYXNlKCksIGJ5dGVPZmZzZXQs IGJ5dGVMZW5ndGgpLCBtX2lzb2xhdGUpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGRl ZmF1bHQ6CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CkBAIC0xNzIyLDcgKzE3MjIsNyBAQCBw cml2YXRlOgogICAgICAgICBpZiAoIWRvUmVhZFVpbnQ2NCgmc2l6ZSkpCiAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgICAgIFBhc3NSZWZQdHI8QmxvYj4gYmxvYiA9IEJsb2I6OmNyZWF0 ZShLVVJMKFBhcnNlZFVSTFN0cmluZywgdXJsKSwgdHlwZSwgc2l6ZSk7Ci0gICAgICAgICp2YWx1 ZSA9IHRvVjgoYmxvYik7CisgICAgICAgICp2YWx1ZSA9IHRvVjgoYmxvYiwgbV9pc29sYXRlKTsK ICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCkBAIC0xNzM4LDcgKzE3MzgsNyBAQCBwcml2 YXRlOgogICAgICAgICBpZiAoIXJlYWRXZWJDb3JlU3RyaW5nKCZ0eXBlKSkKICAgICAgICAgICAg IHJldHVybiBmYWxzZTsKICAgICAgICAgUGFzc1JlZlB0cjxGaWxlPiBmaWxlID0gRmlsZTo6Y3Jl YXRlKHBhdGgsIEtVUkwoUGFyc2VkVVJMU3RyaW5nLCB1cmwpLCB0eXBlKTsKLSAgICAgICAgKnZh bHVlID0gdG9WOChmaWxlKTsKKyAgICAgICAgKnZhbHVlID0gdG9WOChmaWxlLCBtX2lzb2xhdGUp OwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKQEAgLTE3NjAsNyArMTc2MCw3IEBAIHBy aXZhdGU6CiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgZmlsZUxp c3QtPmFwcGVuZChGaWxlOjpjcmVhdGUocGF0aCwgS1VSTChQYXJzZWRVUkxTdHJpbmcsIHVybFN0 cmluZyksIHR5cGUpKTsKICAgICAgICAgfQotICAgICAgICAqdmFsdWUgPSB0b1Y4KGZpbGVMaXN0 KTsKKyAgICAgICAgKnZhbHVlID0gdG9WOChmaWxlTGlzdCwgbV9pc29sYXRlKTsKICAgICAgICAg cmV0dXJuIHRydWU7CiAgICAgfQogCg==