84758 2012-04-24 14:00:29 -0700 [V8] Pass Isolate to SerializedScriptValue::deserialize() 2012-04-25 11:56:52 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 609021 0 haraken 2012-04-24 14:00:29 -0700 The objective is to pass Isolate around. In this bug we pass Isolate to SerializedScriptValue::deserialize(). 609025 1 138637 haraken 2012-04-24 14:02:30 -0700 Created attachment 138637 Patch 609947 2 138637 webkit.review.bot 2012-04-25 11:56:47 -0700 Comment on attachment 138637 Patch Clearing flags on attachment: 138637 Committed r115234: <http://trac.webkit.org/changeset/115234> 609948 3 webkit.review.bot 2012-04-25 11:56:52 -0700 All reviewed patches have been landed. Closing bug. 138637 2012-04-24 14:02:30 -0700 2012-04-25 11:56:47 -0700 Patch bug-84758-20120424140229.patch text/plain 4584 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGE5MzUyY2IxYzE4N2Mx ZmZhYzNhZmZlMzFlODk2ZWY1NmFiNWM4NS4uMmI3YjU4NjhlMDIzNTVkNDlhMTRhNzg1ODRkNGJi OGEzNWJlOGVlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTA0LTI0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFBhc3MgSXNv bGF0ZSB0byBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmRlc2VyaWFsaXplKCkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NzU4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG9iamVjdGl2ZSBpcyB0byBw YXNzIElzb2xhdGUgYXJvdW5kLiBUaGlzIHBhdGNoIHBhc3NlcworICAgICAgICBJc29sYXRlIHRv IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6ZGVzZXJpYWxpemUoKS4KKworICAgICAgICBObyB0ZXN0 cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9t L1Y4SGlzdG9yeUN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOEhpc3Rvcnk6OnN0YXRl QWNjZXNzb3JHZXR0ZXIpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOElEQkFueUN1 c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b1Y4KToKKyAgICAgICAgKiBiaW5kaW5ncy92 OC9jdXN0b20vVjhNZXNzYWdlRXZlbnRDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhN ZXNzYWdlRXZlbnQ6OmRhdGFBY2Nlc3NvckdldHRlcik6CisgICAgICAgICogYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4UG9wU3RhdGVFdmVudEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFBv cFN0YXRlRXZlbnQ6OnN0YXRlQWNjZXNzb3JHZXR0ZXIpOgorCisyMDEyLTA0LTI0ICBLZW50YXJv IEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwogICAgICAgICBbVjhdIFBhc3MgSXNvbGF0 ZSBhcm91bmQgaW4gU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcCAoUGFydDEpCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDY2MwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIaXN0b3J5Q3VzdG9tLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhpc3RvcnlDdXN0b20uY3BwCmlu ZGV4IGFiYWRkY2FhMTU1MTA2YzhkYTZiYmE2YmEzMzdmZTA4NTQxYTk4NDkuLjNjMDFmMTM3NWE5 MzExNjZkMTUxODM2YjA0NmVhMTQ3ZDBmZWNiMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhpc3RvcnlDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhpc3RvcnlDdXN0b20uY3BwCkBAIC01Myw3ICs1Myw3 IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEhpc3Rvcnk6OnN0YXRlQWNjZXNzb3JHZXR0ZXIo djg6OkxvY2FsPHY4OjpTdHJpbmc+IG5hbWUsCiAgICAgICAgIHJldHVybiB2YWx1ZTsKIAogICAg IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSogc2VyaWFsaXplZCA9IGhpc3RvcnktPnN0YXRlKCk7Ci0g ICAgdmFsdWUgPSBzZXJpYWxpemVkID8gc2VyaWFsaXplZC0+ZGVzZXJpYWxpemUoKSA6IHY4OjpI YW5kbGU8djg6OlZhbHVlPih2ODo6TnVsbCgpKTsKKyAgICB2YWx1ZSA9IHNlcmlhbGl6ZWQgPyBz ZXJpYWxpemVkLT5kZXNlcmlhbGl6ZSgwLCBpbmZvLkdldElzb2xhdGUoKSkgOiB2ODo6SGFuZGxl PHY4OjpWYWx1ZT4odjg6Ok51bGwoKSk7CiAgICAgaW5mby5Ib2xkZXIoKS0+U2V0SGlkZGVuVmFs dWUoVjhIaWRkZW5Qcm9wZXJ0eU5hbWU6OnN0YXRlKCksIHZhbHVlKTsKIAogICAgIHJldHVybiB2 YWx1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOElE QkFueUN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhJREJB bnlDdXN0b20uY3BwCmluZGV4IDc1ZWRkNDhkODJjM2M1MDAxMDM0NjMzNjQ4M2ZmN2U2NGMzMzE0 MzQuLjE3MzNlYzhiY2RhM2E0N2UzZmIwZmE0ZmFjZjU5MGM2NmNhYmNhZGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOElEQkFueUN1c3RvbS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SURCQW55Q3VzdG9tLmNwcApA QCAtNzMsNyArNzMsNyBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdG9WOChJREJBbnkqIGltcGws IHY4OjpJc29sYXRlKiBpc29sYXRlKQogICAgIGNhc2UgSURCQW55OjpJREJUcmFuc2FjdGlvblR5 cGU6CiAgICAgICAgIHJldHVybiB0b1Y4KGltcGwtPmlkYlRyYW5zYWN0aW9uKCkpOwogICAgIGNh c2UgSURCQW55OjpTZXJpYWxpemVkU2NyaXB0VmFsdWVUeXBlOgotICAgICAgICByZXR1cm4gaW1w bC0+c2VyaWFsaXplZFNjcmlwdFZhbHVlKCktPmRlc2VyaWFsaXplKCk7CisgICAgICAgIHJldHVy biBpbXBsLT5zZXJpYWxpemVkU2NyaXB0VmFsdWUoKS0+ZGVzZXJpYWxpemUoMCwgaXNvbGF0ZSk7 CiAgICAgfQogCiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhNZXNzYWdlRXZlbnRDdXN0b20uY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4TWVzc2FnZUV2ZW50Q3VzdG9tLmNwcApp bmRleCAzYmUxYjQxMmU5YmQzNTE1ZjZjYWVmZGEwZmY1NzY2NWEzMmEyOTg2Li41YmIwMTg3YWUw YTgwYzE4M2RlNmQ5MDBlZTYzOTgxYzYwZTJlN2Y5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhNZXNzYWdlRXZlbnRDdXN0b20uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE1lc3NhZ2VFdmVudEN1c3RvbS5jcHAKQEAg LTYxLDcgKzYxLDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4TWVzc2FnZUV2ZW50OjpkYXRh QWNjZXNzb3JHZXR0ZXIodjg6OkxvY2FsPHY4OjpTdHJpbmc+IG4KIAogICAgIGNhc2UgTWVzc2Fn ZUV2ZW50OjpEYXRhVHlwZVNlcmlhbGl6ZWRTY3JpcHRWYWx1ZToKICAgICAgICAgaWYgKFNlcmlh bGl6ZWRTY3JpcHRWYWx1ZSogc2VyaWFsaXplZFZhbHVlID0gZXZlbnQtPmRhdGFBc1NlcmlhbGl6 ZWRTY3JpcHRWYWx1ZSgpKQotICAgICAgICAgICAgcmVzdWx0ID0gc2VyaWFsaXplZFZhbHVlLT5k ZXNlcmlhbGl6ZShldmVudC0+cG9ydHMoKSk7CisgICAgICAgICAgICByZXN1bHQgPSBzZXJpYWxp emVkVmFsdWUtPmRlc2VyaWFsaXplKGV2ZW50LT5wb3J0cygpLCBpbmZvLkdldElzb2xhdGUoKSk7 CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHJlc3VsdCA9IHY4OjpOdWxsKCk7CiAgICAgICAg IGJyZWFrOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4 UG9wU3RhdGVFdmVudEN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0 b20vVjhQb3BTdGF0ZUV2ZW50Q3VzdG9tLmNwcAppbmRleCBlMzcwMGViOTAwYzUxMzM4OWI1ZDNi ZmQ3YTlkMDAxYTVmMmIyNGM0Li5iM2Q5MGY0ZDIwYjY4MTVlNDc0NTQzM2E0ODEwNTM2NTcwMmI2 OWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhQb3BT dGF0ZUV2ZW50Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0 b20vVjhQb3BTdGF0ZUV2ZW50Q3VzdG9tLmNwcApAQCAtNzksMTAgKzc5LDEwIEBAIHY4OjpIYW5k bGU8djg6OlZhbHVlPiBWOFBvcFN0YXRlRXZlbnQ6OnN0YXRlQWNjZXNzb3JHZXR0ZXIodjg6Okxv Y2FsPHY4OjpTdHJpbmc+CiAgICAgICAgICAgICBpZiAoIXJlc3VsdC5Jc0VtcHR5KCkpCiAgICAg ICAgICAgICAgICAgcmV0dXJuIGNhY2hlU3RhdGUoaW5mby5Ib2xkZXIoKSwgcmVzdWx0KTsKICAg ICAgICAgfQotICAgICAgICByZXN1bHQgPSBldmVudC0+c2VyaWFsaXplZFN0YXRlKCktPmRlc2Vy aWFsaXplKCk7CisgICAgICAgIHJlc3VsdCA9IGV2ZW50LT5zZXJpYWxpemVkU3RhdGUoKS0+ZGVz ZXJpYWxpemUoMCwgaW5mby5HZXRJc29sYXRlKCkpOwogICAgICAgICB2OEhpc3RvcnktPlNldEhp ZGRlblZhbHVlKFY4SGlkZGVuUHJvcGVydHlOYW1lOjpzdGF0ZSgpLCByZXN1bHQpOwogICAgIH0g ZWxzZQotICAgICAgICByZXN1bHQgPSBldmVudC0+c2VyaWFsaXplZFN0YXRlKCktPmRlc2VyaWFs aXplKCk7CisgICAgICAgIHJlc3VsdCA9IGV2ZW50LT5zZXJpYWxpemVkU3RhdGUoKS0+ZGVzZXJp YWxpemUoMCwgaW5mby5HZXRJc29sYXRlKCkpOwogCiAgICAgcmV0dXJuIGNhY2hlU3RhdGUoaW5m by5Ib2xkZXIoKSwgcmVzdWx0KTsKIH0K