84757 2012-04-24 13:46:33 -0700 [V8] Pass Isolate to SerializedScriptValue::create() in custom bindings 2012-04-25 11:38:09 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 609003 0 haraken 2012-04-24 13:46:33 -0700 The objective is to pass Isolate around in V8 bindings. In this bug, we pass Isolate to SerializedScriptValue::create() in custom bindings. 609007 1 138635 haraken 2012-04-24 13:48:41 -0700 Created attachment 138635 Patch 609938 2 138635 webkit.review.bot 2012-04-25 11:38:04 -0700 Comment on attachment 138635 Patch Clearing flags on attachment: 138635 Committed r115233: <http://trac.webkit.org/changeset/115233> 609939 3 webkit.review.bot 2012-04-25 11:38:09 -0700 All reviewed patches have been landed. Closing bug. 138635 2012-04-24 13:48:41 -0700 2012-04-25 11:38:04 -0700 Patch bug-84757-20120424134840.patch text/plain 6243 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGE5MzUyY2IxYzE4N2Mx ZmZhYzNhZmZlMzFlODk2ZWY1NmFiNWM4NS4uNjM3MTI0NWUwZTg1ZmFkZGMxZmU2YThiZTg5Mjg3 MTdmNmIzODViMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDEyLTA0LTI0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFBhc3MgSXNv bGF0ZSB0byBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmNyZWF0ZSgpIGluIGN1c3RvbSBiaW5kaW5n cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ3NTcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgb2Jq ZWN0aXZlIGlzIHRvIHBhc3MgSXNvbGF0ZSBhcm91bmQgaW4gVjggYmluZGluZ3MuCisgICAgICAg IFRoaXMgcGF0Y2ggcGFzc2VzIElzb2xhdGUgdG8gU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpjcmVh dGUoKQorICAgICAgICBpbiBjdXN0b20gYmluZGluZ3MuCisKKyAgICAgICAgTm8gdGVzdHMuIE5v IGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOERP TVdpbmRvd0N1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpoYW5kbGVQb3N0TWVzc2FnZUNh bGxiYWNrKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhEZWRpY2F0ZWRXb3JrZXJD b250ZXh0Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmhhbmRsZVBvc3RNZXNzYWdlQ2Fs bGJhY2spOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEhpc3RvcnlDdXN0b20uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6VjhIaXN0b3J5OjpwdXNoU3RhdGVDYWxsYmFjayk6CisgICAg ICAgIChXZWJDb3JlOjpWOEhpc3Rvcnk6OnJlcGxhY2VTdGF0ZUNhbGxiYWNrKToKKyAgICAgICAg KiBiaW5kaW5ncy92OC9jdXN0b20vVjhNZXNzYWdlUG9ydEN1c3RvbS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpoYW5kbGVQb3N0TWVzc2FnZUNhbGxiYWNrKToKKyAgICAgICAgKiBiaW5kaW5ncy92 OC9jdXN0b20vVjhXb3JrZXJDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6aGFuZGxlUG9z dE1lc3NhZ2VDYWxsYmFjayk6CisKKzIwMTItMDQtMjQgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5A Y2hyb21pdW0ub3JnPgorCiAgICAgICAgIFtWOF0gUGFzcyBJc29sYXRlIGFyb3VuZCBpbiBTZXJp YWxpemVkU2NyaXB0VmFsdWUuY3BwIChQYXJ0MSkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NjYzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwCmluZGV4IGJmMDgzYjUy MTIxODA4NGYxODA3YjZjYjA4ZDFiMzg2ZDE4MjNlYzguLjJhYmNmM2NhNjIxOGI5YmYyZDM1Njc5 ZDgxODZiYzA4MGY4YjkwOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcApAQCAtMzM2LDcgKzMzNiw4IEBAIHN0 YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gaGFuZGxlUG9zdE1lc3NhZ2VDYWxsYmFjayhjb25z dCB2ODo6QXJndW1lbnRzJiBhcmdzCiAgICAgICAgIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6Y3Jl YXRlKGFyZ3NbMF0sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZwb3J0 QXJyYXksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGV4dGVuZGVkVHJh bnNmZXIgPyAmYXJyYXlCdWZmZXJBcnJheSA6IDAsCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGRpZFRocm93KTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZGlkVGhyb3csCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFy Z3MuR2V0SXNvbGF0ZSgpKTsKICAgICBpZiAoZGlkVGhyb3cpCiAgICAgICAgIHJldHVybiB2ODo6 VW5kZWZpbmVkKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOERlZGljYXRlZFdvcmtlckNvbnRleHRDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvY3VzdG9tL1Y4RGVkaWNhdGVkV29ya2VyQ29udGV4dEN1c3RvbS5jcHAKaW5k ZXggYzE4ZWJlMDYxM2FjYmI2NWUxYmFjNjk3ZTliYWUzMTVmNjdkMTllNy4uODlhYWY3MmFlYmFh OWZlNmU2ZDQ0ZGE0MGI4ZmIwZDdjZTg5NGQ3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvY3VzdG9tL1Y4RGVkaWNhdGVkV29ya2VyQ29udGV4dEN1c3RvbS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RGVkaWNhdGVkV29ya2VyQ29u dGV4dEN1c3RvbS5jcHAKQEAgLTU3LDcgKzU3LDggQEAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZh bHVlPiBoYW5kbGVQb3N0TWVzc2FnZUNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MK ICAgICAgICAgU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpjcmVhdGUoYXJnc1swXSwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJnBvcnRzLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBleHRlbmRlZFRyYW5zZmVyID8gJmFycmF5QnVmZmVycyA6IDAs Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRpZFRocm93KTsKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGlkVGhyb3csCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGFyZ3MuR2V0SXNvbGF0ZSgpKTsKICAgICBpZiAoZGlk VGhyb3cpCiAgICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CiAgICAgRXhjZXB0aW9uQ29k ZSBlYyA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20v VjhIaXN0b3J5Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9W OEhpc3RvcnlDdXN0b20uY3BwCmluZGV4IGFiYWRkY2FhMTU1MTA2YzhkYTZiYmE2YmEzMzdmZTA4 NTQxYTk4NDkuLjI5NDY2Y2UyODY0MzU2Nzk1MzA5OTc3M2IyN2IwNzZhMWYyMDJjZmEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhpc3RvcnlDdXN0b20u Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhpc3RvcnlDdXN0 b20uY3BwCkBAIC02Miw3ICs2Miw3IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEhpc3Rvcnk6 OnN0YXRlQWNjZXNzb3JHZXR0ZXIodjg6OkxvY2FsPHY4OjpTdHJpbmc+IG5hbWUsCiB2ODo6SGFu ZGxlPHY4OjpWYWx1ZT4gVjhIaXN0b3J5OjpwdXNoU3RhdGVDYWxsYmFjayhjb25zdCB2ODo6QXJn dW1lbnRzJiBhcmdzKQogewogICAgIGJvb2wgZGlkVGhyb3cgPSBmYWxzZTsKLSAgICBSZWZQdHI8 U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBoaXN0b3J5U3RhdGUgPSBTZXJpYWxpemVkU2NyaXB0VmFs dWU6OmNyZWF0ZShhcmdzWzBdLCAwLCAwLCBkaWRUaHJvdyk7CisgICAgUmVmUHRyPFNlcmlhbGl6 ZWRTY3JpcHRWYWx1ZT4gaGlzdG9yeVN0YXRlID0gU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpjcmVh dGUoYXJnc1swXSwgMCwgMCwgZGlkVGhyb3csIGFyZ3MuR2V0SXNvbGF0ZSgpKTsKICAgICBpZiAo ZGlkVGhyb3cpCiAgICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CiAKQEAgLTg3LDcgKzg3 LDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4SGlzdG9yeTo6cHVzaFN0YXRlQ2FsbGJhY2so Y29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOEhpc3Rv cnk6OnJlcGxhY2VTdGF0ZUNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCiB7CiAg ICAgYm9vbCBkaWRUaHJvdyA9IGZhbHNlOwotICAgIFJlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFs dWU+IGhpc3RvcnlTdGF0ZSA9IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6Y3JlYXRlKGFyZ3NbMF0s IDAsIDAsIGRpZFRocm93KTsKKyAgICBSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBoaXN0 b3J5U3RhdGUgPSBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmNyZWF0ZShhcmdzWzBdLCAwLCAwLCBk aWRUaHJvdywgYXJncy5HZXRJc29sYXRlKCkpOwogICAgIGlmIChkaWRUaHJvdykKICAgICAgICAg cmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4TWVzc2FnZVBvcnRDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvY3VzdG9tL1Y4TWVzc2FnZVBvcnRDdXN0b20uY3BwCmluZGV4IGI3ZTg0MmRl M2MxZTc1MjA0M2EzYjlkZWQzY2QwMWQ3OGM1ZTcxYjEuLmVlN2QxNmNhZmY5MGU4MGQ4NDM5OWQw OGM2NDI1YWEwNTgwNjA5N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOE1lc3NhZ2VQb3J0Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhNZXNzYWdlUG9ydEN1c3RvbS5jcHAKQEAgLTU2LDcgKzU2LDggQEAg c3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBoYW5kbGVQb3N0TWVzc2FnZUNhbGxiYWNrKGNv bnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MKICAgICAgICAgU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpj cmVhdGUoYXJnc1swXSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJnBv cnRBcnJheSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZXh0ZW5kZWRU cmFuc2ZlciA/ICZhcnJheUJ1ZmZlckFycmF5IDogMCwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZGlkVGhyb3cpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBkaWRUaHJvdywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg YXJncy5HZXRJc29sYXRlKCkpOwogICAgIGlmIChkaWRUaHJvdykKICAgICAgICAgcmV0dXJuIHY4 OjpVbmRlZmluZWQoKTsKICAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdvcmtlckN1c3RvbS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXb3JrZXJDdXN0b20uY3BwCmluZGV4IDU1 NTA3ZDA2YzFmZjE3ZmJmZDAzZTNmYWRlZTZmOWEyNmQxYzg5YTQuLjYwZTViYmU0NzQxZWY3NjQz MmNlOTAxY2NlMzUzNTQ2ZmZlMjc4NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L2N1c3RvbS9WOFdvcmtlckN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4V29ya2VyQ3VzdG9tLmNwcApAQCAtNjIsNyArNjIsOCBAQCBzdGF0 aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGhhbmRsZVBvc3RNZXNzYWdlQ2FsbGJhY2soY29uc3Qg djg6OkFyZ3VtZW50cyYgYXJncwogICAgICAgICBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmNyZWF0 ZShhcmdzWzBdLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmcG9ydHMs CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGV4dGVuZGVkVHJhbnNmZXIg PyAmYXJyYXlCdWZmZXJzIDogMCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZGlkVGhyb3cpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaWRU aHJvdywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYXJncy5HZXRJc29s YXRlKCkpOwogICAgIGlmIChkaWRUaHJvdykKICAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQo KTsKICAgICBFeGNlcHRpb25Db2RlIGVjID0gMDsK