84739 2012-04-24 10:26:29 -0700 [V8] Add m_isolate to SerializedScriptValue::Writer and SerializedScriptValue::Reader 2012-04-25 11:06:58 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 608809 0 haraken 2012-04-24 10:26:29 -0700 This is the second step to pass Isolate around in SerializedScriptValue. We add m_isolate to SerializedScriptValue::Writer and SerializedScriptValue::Reader, so that they can use the isolate around. The fix is safe since Writer and Reader are guaranteed to be used by one Isolate. 608815 1 138593 haraken 2012-04-24 10:36:11 -0700 Created attachment 138593 Patch 609916 2 138593 webkit.review.bot 2012-04-25 11:06:52 -0700 Comment on attachment 138593 Patch Clearing flags on attachment: 138593 Committed r115229: <http://trac.webkit.org/changeset/115229> 609917 3 webkit.review.bot 2012-04-25 11:06:58 -0700 All reviewed patches have been landed. Closing bug. 138593 2012-04-24 10:36:11 -0700 2012-04-25 11:06:52 -0700 Patch bug-84739-20120424103609.patch text/plain 6881 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGE5MzUyY2IxYzE4N2Mx ZmZhYzNhZmZlMzFlODk2ZWY1NmFiNWM4NS4uMjdmMGVjMWYwNjQxN2Q2NWNlMDIzOGEyYjkyMmMx NzRjNzdjODM5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMyIEBACiAyMDEyLTA0LTI0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIEFkZCBtX2lz b2xhdGUgdG8gU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpXcml0ZXIKKyAgICAgICAgYW5kIFNlcmlh bGl6ZWRTY3JpcHRWYWx1ZTo6UmVhZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04NDczOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgaXMgdGhlIHNlY29uZCBzdGVwIHRvIHBhc3MgSXNvbGF0ZSBh cm91bmQKKyAgICAgICAgaW4gU2VyaWFsaXplZFNjcmlwdFZhbHVlLiBUaGlzIHBhdGNoIGFkZHMg bV9pc29sYXRlIHRvCisgICAgICAgIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6V3JpdGVyIGFuZCBT ZXJpYWxpemVkU2NyaXB0VmFsdWU6OlJlYWRlciwKKyAgICAgICAgc28gdGhhdCB0aGV5IGNhbiB1 c2UgdGhlIGlzb2xhdGUgYXJvdW5kLiBUaGUgZml4IGlzIHNhZmUgc2luY2UKKyAgICAgICAgV3Jp dGVyIGFuZCBSZWFkZXIgYXJlIGd1YXJhbnRlZWQgdG8gYmUgdXNlZCBieSBvbmUgSXNvbGF0ZS4K KworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICog YmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6Y3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OlNlcmlh bGl6ZWRTY3JpcHRWYWx1ZTo6bnVsbFZhbHVlKToKKyAgICAgICAgKFdlYkNvcmU6OlNlcmlhbGl6 ZWRTY3JpcHRWYWx1ZTo6dW5kZWZpbmVkVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6U2VyaWFs aXplZFNjcmlwdFZhbHVlOjpib29sZWFuVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6U2VyaWFs aXplZFNjcmlwdFZhbHVlOjpudW1iZXJWYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpTZXJpYWxp emVkU2NyaXB0VmFsdWU6OlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSk6CisgICAgICAgIChXZWJDb3Jl OjpTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmRlc2VyaWFsaXplKToKKyAgICAgICAgKiBiaW5kaW5n cy92OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUuaDoKKyAgICAgICAgKFNlcmlhbGl6ZWRTY3JpcHRW YWx1ZSk6CisKKzIwMTItMDQtMjQgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3Jn PgorCiAgICAgICAgIFtWOF0gUGFzcyBJc29sYXRlIGFyb3VuZCBpbiBTZXJpYWxpemVkU2NyaXB0 VmFsdWUuY3BwIChQYXJ0MSkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg0NjYzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9T ZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwCmluZGV4IDI1MWYzNDllMWJmNTAzNGJmNGI5ODA4YjFm MzViYjgxNDNhNTdlYTAuLjZjZjkwMjA4MzY5MmVmYzBjYzM0OTUyYmFhOTg2NWRmNzllNGIxNjAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRW YWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlw dFZhbHVlLmNwcApAQCAtMjc0LDggKzI3NCw5IEBAIHByaXZhdGU6CiBjbGFzcyBXcml0ZXIgewog ICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKFdyaXRlcik7CiBwdWJsaWM6Ci0gICAgV3JpdGVyKCkK KyAgICBXcml0ZXIodjg6Oklzb2xhdGUqIGlzb2xhdGUpCiAgICAgICAgIDogbV9wb3NpdGlvbigw KQorICAgICAgICAsIG1faXNvbGF0ZShpc29sYXRlKQogICAgIHsKICAgICB9CiAKQEAgLTU5MSw2 ICs1OTIsNyBAQCBwcml2YXRlOgogCiAgICAgVmVjdG9yPEJ1ZmZlclZhbHVlVHlwZT4gbV9idWZm ZXI7CiAgICAgdW5zaWduZWQgbV9wb3NpdGlvbjsKKyAgICB2ODo6SXNvbGF0ZSogbV9pc29sYXRl OwogfTsKIAogY2xhc3MgU2VyaWFsaXplciB7CkBAIC0xMjIyLDExICsxMjI0LDEyIEBAIHB1Ymxp YzoKIC8vIHJlc3RvcmluZyBpbmZvcm1hdGlvbiBhYm91dCBzYXZlZCBvYmplY3RzIG9mIGNvbXBv c2l0ZSB0eXBlcy4KIGNsYXNzIFJlYWRlciB7CiBwdWJsaWM6Ci0gICAgUmVhZGVyKGNvbnN0IHVp bnQ4X3QqIGJ1ZmZlciwgaW50IGxlbmd0aCkKKyAgICBSZWFkZXIoY29uc3QgdWludDhfdCogYnVm ZmVyLCBpbnQgbGVuZ3RoLCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKICAgICAgICAgOiBtX2J1ZmZl cihidWZmZXIpCiAgICAgICAgICwgbV9sZW5ndGgobGVuZ3RoKQogICAgICAgICAsIG1fcG9zaXRp b24oMCkKICAgICAgICAgLCBtX3ZlcnNpb24oMCkKKyAgICAgICAgLCBtX2lzb2xhdGUoaXNvbGF0 ZSkKICAgICB7CiAgICAgICAgIEFTU0VSVChsZW5ndGggPj0gMCk7CiAgICAgfQpAQCAtMTgwMiw2 ICsxODA1LDcgQEAgcHJpdmF0ZToKICAgICBjb25zdCB1bnNpZ25lZCBtX2xlbmd0aDsKICAgICB1 bnNpZ25lZCBtX3Bvc2l0aW9uOwogICAgIHVpbnQzMl90IG1fdmVyc2lvbjsKKyAgICB2ODo6SXNv bGF0ZSogbV9pc29sYXRlOwogfTsKIAogCkBAIC0yMDgxLDcgKzIwODUsNyBAQCBQYXNzUmVmUHRy PFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpjcmVhdGVGcm9t V2lyZShjb25zdCBTdAogCiBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gU2VyaWFs aXplZFNjcmlwdFZhbHVlOjpjcmVhdGUoY29uc3QgU3RyaW5nJiBkYXRhLCB2ODo6SXNvbGF0ZSog aXNvbGF0ZSkKIHsKLSAgICBXcml0ZXIgd3JpdGVyOworICAgIFdyaXRlciB3cml0ZXIoaXNvbGF0 ZSk7CiAgICAgd3JpdGVyLndyaXRlV2ViQ29yZVN0cmluZyhkYXRhKTsKICAgICBTdHJpbmcgd2ly ZURhdGEgPSBTdHJpbmdJbXBsOjphZG9wdCh3cml0ZXIuZGF0YSgpKTsKICAgICByZXR1cm4gYWRv cHRSZWYobmV3IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSh3aXJlRGF0YSkpOwpAQCAtMjA5MiwxMyAr MjA5NiwxMyBAQCBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gU2VyaWFsaXplZFNj cmlwdFZhbHVlOjpjcmVhdGUoKQogICAgIHJldHVybiBhZG9wdFJlZihuZXcgU2VyaWFsaXplZFNj cmlwdFZhbHVlKCkpOwogfQogCi1TZXJpYWxpemVkU2NyaXB0VmFsdWUqIFNlcmlhbGl6ZWRTY3Jp cHRWYWx1ZTo6bnVsbFZhbHVlKCkKK1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZSogU2VyaWFsaXplZFNj cmlwdFZhbHVlOjpudWxsVmFsdWUodjg6Oklzb2xhdGUqIGlzb2xhdGUpCiB7CiAgICAgLy8gRklY TUU6IFRoaXMgaXMgbm90IHRocmVhZC1zYWZlLiBNb3ZlIGNhY2hpbmcgdG8gY2FsbGVycy4KICAg ICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA4MzMKICAgICBE RUZJTkVfU1RBVElDX0xPQ0FMKFJlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+LCBudWxsVmFs dWUsICgwKSk7CiAgICAgaWYgKCFudWxsVmFsdWUpIHsKLSAgICAgICAgV3JpdGVyIHdyaXRlcjsK KyAgICAgICAgV3JpdGVyIHdyaXRlcihpc29sYXRlKTsKICAgICAgICAgd3JpdGVyLndyaXRlTnVs bCgpOwogICAgICAgICBTdHJpbmcgd2lyZURhdGEgPSBTdHJpbmdJbXBsOjphZG9wdCh3cml0ZXIu ZGF0YSgpKTsKICAgICAgICAgbnVsbFZhbHVlID0gYWRvcHRSZWYobmV3IFNlcmlhbGl6ZWRTY3Jp cHRWYWx1ZSh3aXJlRGF0YSkpOwpAQCAtMjEwOCw3ICsyMTEyLDcgQEAgU2VyaWFsaXplZFNjcmlw dFZhbHVlKiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6Om51bGxWYWx1ZSgpCiAKIFBhc3NSZWZQdHI8 U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OnVuZGVmaW5lZFZh bHVlKHY4OjpJc29sYXRlKiBpc29sYXRlKQogewotICAgIFdyaXRlciB3cml0ZXI7CisgICAgV3Jp dGVyIHdyaXRlcihpc29sYXRlKTsKICAgICB3cml0ZXIud3JpdGVVbmRlZmluZWQoKTsKICAgICBT dHJpbmcgd2lyZURhdGEgPSBTdHJpbmdJbXBsOjphZG9wdCh3cml0ZXIuZGF0YSgpKTsKICAgICBy ZXR1cm4gYWRvcHRSZWYobmV3IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSh3aXJlRGF0YSkpOwpAQCAt MjExNiw3ICsyMTIwLDcgQEAgUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IFNlcmlh bGl6ZWRTY3JpcHRWYWx1ZTo6dW5kZWZpbmVkVmFsdWUodjg6Oklzb2wKIAogUGFzc1JlZlB0cjxT ZXJpYWxpemVkU2NyaXB0VmFsdWU+IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6Ym9vbGVhblZhbHVl KGJvb2wgdmFsdWUsIHY4OjpJc29sYXRlKiBpc29sYXRlKQogewotICAgIFdyaXRlciB3cml0ZXI7 CisgICAgV3JpdGVyIHdyaXRlcihpc29sYXRlKTsKICAgICBpZiAodmFsdWUpCiAgICAgICAgIHdy aXRlci53cml0ZVRydWUoKTsKICAgICBlbHNlCkBAIC0yMTI3LDcgKzIxMzEsNyBAQCBQYXNzUmVm UHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpib29sZWFu VmFsdWUoYm9vbCB2YWx1ZQogCiBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gU2Vy aWFsaXplZFNjcmlwdFZhbHVlOjpudW1iZXJWYWx1ZShkb3VibGUgdmFsdWUsIHY4OjpJc29sYXRl KiBpc29sYXRlKQogewotICAgIFdyaXRlciB3cml0ZXI7CisgICAgV3JpdGVyIHdyaXRlcihpc29s YXRlKTsKICAgICB3cml0ZXIud3JpdGVOdW1iZXIodmFsdWUpOwogICAgIFN0cmluZyB3aXJlRGF0 YSA9IFN0cmluZ0ltcGw6OmFkb3B0KHdyaXRlci5kYXRhKCkpOwogICAgIHJldHVybiBhZG9wdFJl ZihuZXcgU2VyaWFsaXplZFNjcmlwdFZhbHVlKHdpcmVEYXRhKSk7CkBAIC0yMTk0LDcgKzIxOTgs NyBAQCBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSh2ODo6SGFu ZGxlPHY4OjpWYWx1ZT4gdmFsdWUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKICAgICBkaWRUaHJvdyA9IGZhbHNl OwotICAgIFdyaXRlciB3cml0ZXI7CisgICAgV3JpdGVyIHdyaXRlcihpc29sYXRlKTsKICAgICBT ZXJpYWxpemVyOjpTdGF0dXMgc3RhdHVzOwogICAgIHsKICAgICAgICAgdjg6OlRyeUNhdGNoIHRy eUNhdGNoOwpAQCAtMjI0Nyw3ICsyMjUxLDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFNlcmlh bGl6ZWRTY3JpcHRWYWx1ZTo6ZGVzZXJpYWxpemUoTWVzc2FnZVBvcnRBcnJheSogbWVzc2EKICAg ICBpZiAoIW1fZGF0YS5pbXBsKCkpCiAgICAgICAgIHJldHVybiB2ODo6TnVsbCgpOwogICAgIENP TVBJTEVfQVNTRVJUKHNpemVvZihCdWZmZXJWYWx1ZVR5cGUpID09IDIsIEJ1ZmZlclZhbHVlVHlw ZUlzVHdvQnl0ZXMpOwotICAgIFJlYWRlciByZWFkZXIocmVpbnRlcnByZXRfY2FzdDxjb25zdCB1 aW50OF90Kj4obV9kYXRhLmltcGwoKS0+Y2hhcmFjdGVycygpKSwgMiAqIG1fZGF0YS5sZW5ndGgo KSk7CisgICAgUmVhZGVyIHJlYWRlcihyZWludGVycHJldF9jYXN0PGNvbnN0IHVpbnQ4X3QqPiht X2RhdGEuaW1wbCgpLT5jaGFyYWN0ZXJzKCkpLCAyICogbV9kYXRhLmxlbmd0aCgpLCBpc29sYXRl KTsKICAgICBEZXNlcmlhbGl6ZXIgZGVzZXJpYWxpemVyKHJlYWRlciwgbWVzc2FnZVBvcnRzLCBt X2FycmF5QnVmZmVyQ29udGVudHNBcnJheS5nZXQoKSk7CiAgICAgcmV0dXJuIGRlc2VyaWFsaXpl ci5kZXNlcmlhbGl6ZSgpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9T ZXJpYWxpemVkU2NyaXB0VmFsdWUuaAppbmRleCAxODQ3ZmQyMGJkYzI4ZTYyZDk4YTI1NWIyNjQy OWZkYjAxMjU5ZTUwLi4xZmE5OWU4YTRkNzY0MDZhMjJkNTM2Yjc3ZGRhNGZjY2NkMDZlNGNjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TZXJpYWxpemVkU2NyaXB0VmFs dWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TZXJpYWxpemVkU2NyaXB0VmFs dWUuaApAQCAtNTgsNyArNTgsNyBAQCBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8U2Vy aWFsaXplZFNjcmlwdFZhbHVlPiBjcmVhdGUoY29uc3QgU3RyaW5nJiBkYXRhLCB2ODo6SXNvbGF0 ZSogPSAwKTsKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IGNy ZWF0ZSgpOwogCi0gICAgc3RhdGljIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSogbnVsbFZhbHVlKCk7 CisgICAgc3RhdGljIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSogbnVsbFZhbHVlKHY4OjpJc29sYXRl KiA9IDApOwogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gdW5k ZWZpbmVkVmFsdWUodjg6Oklzb2xhdGUqID0gMCk7CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8U2Vy aWFsaXplZFNjcmlwdFZhbHVlPiBib29sZWFuVmFsdWUoYm9vbCB2YWx1ZSwgdjg6Oklzb2xhdGUq ID0gMCk7CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBudW1i ZXJWYWx1ZShkb3VibGUgdmFsdWUsIHY4OjpJc29sYXRlKiA9IDApOwo=