<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>84736</bug_id>
          
          <creation_ts>2012-04-24 09:55:06 -0700</creation_ts>
          <short_desc>[V8] Make the Isolate* parameter non-optional in setDOMException()</short_desc>
          <delta_ts>2012-04-25 10:57:39 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore JavaScript</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>84074</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kentaro Hara">haraken</reporter>
          <assigned_to name="Kentaro Hara">haraken</assigned_to>
          <cc>abarth</cc>
    
    <cc>japhet</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>608780</commentid>
    <comment_count>0</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-04-24 09:55:06 -0700</bug_when>
    <thetext>Now all setDOMException() callers pass Isolate* to setDOMException(). We can make the Isolate* parameter non-optional.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>608782</commentid>
    <comment_count>1</comment_count>
      <attachid>138584</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-04-24 09:56:50 -0700</bug_when>
    <thetext>Created attachment 138584
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>609905</commentid>
    <comment_count>2</comment_count>
      <attachid>138584</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-04-25 10:57:35 -0700</bug_when>
    <thetext>Comment on attachment 138584
Patch

Clearing flags on attachment: 138584

Committed r115228: &lt;http://trac.webkit.org/changeset/115228&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>609906</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-04-25 10:57:39 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>138584</attachid>
            <date>2012-04-24 09:56:50 -0700</date>
            <delta_ts>2012-04-25 10:57:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-84736-20120424095649.patch</filename>
            <type>text/plain</type>
            <size>1639</size>
            <attacher name="Kentaro Hara">haraken</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE1MDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWY5MmNjMjJlYTQ1ZGM5
NzhmNjc3MTU5ODBmOTgyZjNmNjlmY2M2OS4uNTkwMmVmYWQ4YjlmYjcyYzE2YmM1ODgxZmUyMzg3
N2E0M2JlZjk1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA0LTI0ICBLZW50
YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIE1ha2UgdGhl
IElzb2xhdGUqIHBhcmFtZXRlciBub24tb3B0aW9uYWwgaW4gc2V0RE9NRXhjZXB0aW9uKCkKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NzM2CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm93IGFsbCBzZXRE
T01FeGNlcHRpb24oKSBjYWxsZXJzIHBhc3MgSXNvbGF0ZSogdG8gc2V0RE9NRXhjZXB0aW9uKCku
CisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgdGhlIElzb2xhdGUqIHBhcmFtZXRlciBub24tb3B0
aW9uYWwuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAg
ICAgICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHkuaDoKKyAgICAgICAgKFY4UHJveHkpOgorCisyMDEy
LTA0LTI0ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwogICAgICAgICBb
VjhdIFBhc3MgSXNvbGF0ZSB0byBzZXRET01FeGNlcHRpb24oKSBpbiBDb2RlR2VuZXJhdG9yVjgu
cG0KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0NjYw
CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaCBiL1Nv
dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaAppbmRleCA3YzM4Nzk1YTZjOTc1MjVm
Yzk4ZWMwZjRjNTk2MTZjOGVjMzg0N2ZjLi5lYWFhN2U2ZTU0MDY4YjRkZDkzYzRmODIzZGJiOGU4
MjhkY2JiNTc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5
LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCkBAIC0yMzUsNyAr
MjM1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIC8vIElmIHRoZSBleGNlcHRp
b24gY29kZSBpcyBkaWZmZXJlbnQgZnJvbSB6ZXJvLCBhIERPTSBleGNlcHRpb24gaXMKICAgICAg
ICAgLy8gc2NoZWR1bGUgdG8gYmUgdGhyb3duLgotICAgICAgICBzdGF0aWMgdm9pZCBzZXRET01F
eGNlcHRpb24oaW50IGV4Y2VwdGlvbkNvZGUsIHY4OjpJc29sYXRlKiA9IDApOworICAgICAgICBz
dGF0aWMgdm9pZCBzZXRET01FeGNlcHRpb24oaW50IGV4Y2VwdGlvbkNvZGUsIHY4OjpJc29sYXRl
Kik7CiAKICAgICAgICAgLy8gU2NoZWR1bGUgYW4gZXJyb3Igb2JqZWN0IHRvIGJlIHRocm93bi4K
ICAgICAgICAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB0aHJvd0Vycm9yKEVycm9yVHlw
ZSwgY29uc3QgY2hhciogbWVzc2FnZSwgdjg6Oklzb2xhdGUqID0gMCk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>