84486 2012-04-20 13:27:52 -0700 Crash in getOrDrawNodeHighlight after r114659 2012-04-20 14:39:58 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wangxianzhu wangxianzhu eric jer.noble pfeldman oldest_to_newest 606853 0 wangxianzhu 2012-04-20 13:27:52 -0700 See crbug.com/124382. 606870 1 138155 wangxianzhu 2012-04-20 13:52:32 -0700 Created attachment 138155 patch 606895 2 jer.noble 2012-04-20 14:18:04 -0700 *** Bug 84492 has been marked as a duplicate of this bug. *** 606905 3 138155 jer.noble 2012-04-20 14:22:21 -0700 Comment on attachment 138155 patch Looks good to me. After applying the patch, the crash no longer occurs on that test. 606909 4 jer.noble 2012-04-20 14:29:17 -0700 And by "that test", I mean inspector/elements/elements-panel-selection-on-refresh.html, which was the crashing test in bug 84492, which was marked as a dup of this bug. 606913 5 138155 dbates 2012-04-20 14:30:11 -0700 Comment on attachment 138155 patch Looks good to me. For completeness, Jer Noble told me on IRC that the test case inspector/elements/elements-panel-selection-on-refresh.html covers this crash. 606915 6 138155 dbates 2012-04-20 14:31:34 -0700 Comment on attachment 138155 patch View in context: https://bugs.webkit.org/attachment.cgi?id=138155&action=review > Source/WebCore/ChangeLog:8 > + No new tests. Just a quick fix of a crash caused by r114659. Per comment 5, I suggest that we mention that this fix is covered by test inspector/elements/elements-panel-selection-on-refresh.html. 606917 7 138167 wangxianzhu 2012-04-20 14:35:50 -0700 Created attachment 138167 patch for landing Test case mentioned in ChangeLog. Thanks for review! 606919 8 jer.noble 2012-04-20 14:38:17 -0700 Committed r114783: <http://trac.webkit.org/changeset/114783> 606920 9 138167 dbates 2012-04-20 14:39:29 -0700 Comment on attachment 138167 patch for landing cq-'ing this patch since it landed in <http://trac.webkit.org/changeset/114783>. 606921 10 jer.noble 2012-04-20 14:39:58 -0700 (In reply to comment #7) > Created an attachment (id=138167) [details] > patch for landing > > Test case mentioned in ChangeLog. Thanks for review! Landed this patch manually. (I updated the ChangeLog to mention the crashing test, so my wording is not exactly the same as your most recently uploaded patch, but the meaning is there.) :) 138155 2012-04-20 13:52:32 -0700 2012-04-20 14:35:50 -0700 patch 84486 text/plain 1438 wangxianzhu SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDc3NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA0LTIwICBYaWFuemh1 IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ3Jhc2ggaW4gZ2V0 T3JEcmF3Tm9kZUhpZ2hsaWdodCBhZnRlciByMTE0NjU5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDQ4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gSnVzdCBhIHF1aWNrIGZpeCBv ZiBhIGNyYXNoIGNhdXNlZCBieSByMTE0NjU5LgorCisgICAgICAgICogaW5zcGVjdG9yL0RPTU5v ZGVIaWdobGlnaHRlci5jcHA6CisKIDIwMTItMDQtMjAgIEVtaWwgQSBFa2x1bmQgIDxlYWVAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIEZpeCB1c2Ugb2YgTGF5b3V0VW5pdHMgaW4gRE9NTm9kZUhp Z2hsaWdodGVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvRE9NTm9kZUhpZ2hsaWdo dGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvRE9NTm9kZUhp Z2hsaWdodGVyLmNwcAkocmV2aXNpb24gMTE0Nzc2KQorKysgU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0RPTU5vZGVIaWdobGlnaHRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2NiwxMSArMzY2 LDExIEBAIHN0YXRpYyB2b2lkIGdldE9yRHJhd05vZGVIaWdobGlnaHQoR3JhcGgKICAgICBOb2Rl KiBub2RlID0gaGlnaGxpZ2h0RGF0YS0+bm9kZS5nZXQoKTsKICAgICBSZW5kZXJPYmplY3QqIHJl bmRlcmVyID0gbm9kZS0+cmVuZGVyZXIoKTsKICAgICBGcmFtZSogY29udGFpbmluZ0ZyYW1lID0g bm9kZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKTsKLSAgICBGcmFtZVZpZXcqIGNvbnRhaW5pbmdWaWV3 ID0gY29udGFpbmluZ0ZyYW1lLT52aWV3KCk7CiAKICAgICBpZiAoIXJlbmRlcmVyIHx8ICFjb250 YWluaW5nRnJhbWUpCiAgICAgICAgIHJldHVybjsKIAorICAgIEZyYW1lVmlldyogY29udGFpbmlu Z1ZpZXcgPSBjb250YWluaW5nRnJhbWUtPnZpZXcoKTsKICAgICBMYXlvdXRSZWN0IGJvdW5kaW5n Qm94ID0gY29udGFpbmluZ1ZpZXctPmNvbnRlbnRzVG9Sb290VmlldyhyZW5kZXJlci0+YWJzb2x1 dGVCb3VuZGluZ0JveFJlY3QoKSk7CiAgICAgTGF5b3V0UmVjdCB0aXRsZUFuY2hvckJveCA9IGJv dW5kaW5nQm94OwogCg== 138167 2012-04-20 14:35:50 -0700 2012-04-20 14:39:29 -0700 patch for landing 84486a text/plain 1492 wangxianzhu SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDc3NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA0LTIwICBYaWFuemh1 IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ3Jhc2ggaW4gZ2V0 T3JEcmF3Tm9kZUhpZ2hsaWdodCBhZnRlciByMTE0NjU5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDQ4NgorCisgICAgICAgIFJldmlld2VkIGJ5IERh bmllbCBCYXRlcy4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoZSBidWcgY2F1c2VkIGluc3Bl Y3Rvci9lbGVtZW50cy9lbGVtZW50cy1wYW5lbC1zZWxlY3Rpb24tb24tcmVmcmVzaC5odG1sIHRv IGNyYXNoIG9uIHNvbWUgcGxhdGZvcm1zLgorCisgICAgICAgICogaW5zcGVjdG9yL0RPTU5vZGVI aWdobGlnaHRlci5jcHA6CisKIDIwMTItMDQtMjAgIEVtaWwgQSBFa2x1bmQgIDxlYWVAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIEZpeCB1c2Ugb2YgTGF5b3V0VW5pdHMgaW4gRE9NTm9kZUhpZ2hs aWdodGVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvRE9NTm9kZUhpZ2hsaWdodGVy LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvRE9NTm9kZUhpZ2hs aWdodGVyLmNwcAkocmV2aXNpb24gMTE0Nzc2KQorKysgU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0RPTU5vZGVIaWdobGlnaHRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2NiwxMSArMzY2LDEx IEBAIHN0YXRpYyB2b2lkIGdldE9yRHJhd05vZGVIaWdobGlnaHQoR3JhcGgKICAgICBOb2RlKiBu b2RlID0gaGlnaGxpZ2h0RGF0YS0+bm9kZS5nZXQoKTsKICAgICBSZW5kZXJPYmplY3QqIHJlbmRl cmVyID0gbm9kZS0+cmVuZGVyZXIoKTsKICAgICBGcmFtZSogY29udGFpbmluZ0ZyYW1lID0gbm9k ZS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKTsKLSAgICBGcmFtZVZpZXcqIGNvbnRhaW5pbmdWaWV3ID0g Y29udGFpbmluZ0ZyYW1lLT52aWV3KCk7CiAKICAgICBpZiAoIXJlbmRlcmVyIHx8ICFjb250YWlu aW5nRnJhbWUpCiAgICAgICAgIHJldHVybjsKIAorICAgIEZyYW1lVmlldyogY29udGFpbmluZ1Zp ZXcgPSBjb250YWluaW5nRnJhbWUtPnZpZXcoKTsKICAgICBMYXlvdXRSZWN0IGJvdW5kaW5nQm94 ID0gY29udGFpbmluZ1ZpZXctPmNvbnRlbnRzVG9Sb290VmlldyhyZW5kZXJlci0+YWJzb2x1dGVC b3VuZGluZ0JveFJlY3QoKSk7CiAgICAgTGF5b3V0UmVjdCB0aXRsZUFuY2hvckJveCA9IGJvdW5k aW5nQm94OwogCg==