84450 2012-04-20 07:24:01 -0700 Ensure text is centered for default captions 2012-04-20 10:46:30 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 43668 1 vcarbune vcarbune eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 606566 0 vcarbune 2012-04-20 07:24:01 -0700 Default width of 100% has been removed in changeset 114640 (http://trac.webkit.org/changeset/114640), which affects default caption position (they are no longer centered). 606568 1 138092 vcarbune 2012-04-20 07:33:57 -0700 Created attachment 138092 Fix 606694 2 138092 webkit.review.bot 2012-04-20 10:46:26 -0700 Comment on attachment 138092 Fix Clearing flags on attachment: 138092 Committed r114760: <http://trac.webkit.org/changeset/114760> 606695 3 webkit.review.bot 2012-04-20 10:46:30 -0700 All reviewed patches have been landed. Closing bug. 138092 2012-04-20 07:33:57 -0700 2012-04-20 10:46:26 -0700 Fix bug-84450-20120420173355.patch text/plain 6374 vcarbune U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzY4MjdlZDViMWJmOGVk ODM3NjEyODlkM2MxYzIwOWU2ZDkxNWFkNi4uZjllNDk2MjliZWU1YzEyNDczYjZhNDYyNDM3OWJi ZTY4YTlmMzliZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA0LTIwICBWaWN0 b3IgQ2FyYnVuZSAgPHZjYXJidW5lQGFkb2JlLmNvbT4KKworICAgICAgICBFbnN1cmUgdGV4dCBp cyBjZW50ZXJlZCBmb3IgZGVmYXVsdCBjYXB0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQ0NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGVkIGV4aXN0aW5nIHRlc3QuCisKKyAgICAgICAg KiBodG1sL3RyYWNrL1RleHRUcmFja0N1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0VHJh Y2tDdWU6OmdldERpc3BsYXlUcmVlKTogQWRkZWQgZGVmYXVsdCB3aWR0aC4KKwogMjAxMi0wNC0x OSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBtYWtlIFNjcmlwdE5hdmlnYXRvckNvbnRyb2xsZXIgdXNlIHZpZXdzIG9ubHks IHJlbmFtZSB0byBOYXZpZ2F0b3JPdmVybGF5Q29udHJvbGxlci4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvdHJhY2svVGV4dFRyYWNrQ3VlLmNwcAppbmRleCBmZTVkYjc0MWM4NzEzOTI1YjJkZGQwNGUy MTBiYmJmYTRiZWRhNzdjLi40MTA1ZGEyZjVmNzZkY2NhOWJkYzk3MzQ5YzFlYjEzOGQ3MTIwZjVl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFja0N1ZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2tDdWUuY3BwCkBAIC01Njks NiArNTY5LDExIEBAIFBhc3NSZWZQdHI8SFRNTERpdkVsZW1lbnQ+IFRleHRUcmFja0N1ZTo6Z2V0 RGlzcGxheVRyZWUoKQogICAgIC8vIGJ1dCBpZiB0aGVyZSBpcyBhIHBhcnRpY3VsYXJseSBsb25n IHdvcmQsIGl0IGRvZXMgbm90IG92ZXJmbG93IGFzIGl0CiAgICAgLy8gbm9ybWFsbHkgd291bGQg aW4gQ1NTLCBpdCBpcyBpbnN0ZWFkIGZvcmNpYmx5IHdyYXBwZWQgYXQgdGhlIGJveCdzIGVkZ2Uu KQogCisgICAgLy8gRklYTUUoQlVHIDc5OTE2KTogQ1NTIHdpZHRoIHByb3BlcnR5IHNob3VsZCBi ZSBzZXQgdG8gJ3NpemUgdncnLCB3aGVuIHRoZQorICAgIC8vIG1heGltdW0gY3VlIHNpemUgY29t cHV0YXRpb24gaXMgY29ycmVjdGVkIGluIHRoZSBzcGVjaWZpY2F0aW9uLgorICAgIGlmIChtX3Nu YXBUb0xpbmVzKQorICAgICAgICBtX2Rpc3BsYXlUcmVlLT5zZXRJbmxpbmVTdHlsZVByb3BlcnR5 KENTU1Byb3BlcnR5V2lkdGgsIChkb3VibGUpIG1fY3VlU2l6ZSwgQ1NTUHJpbWl0aXZlVmFsdWU6 OkNTU19QRVJDRU5UQUdFKTsKKwogICAgIC8vIEZJWE1FKEJVRyA3OTc1MCwgNzk3NTEpOiBTdGVw cyAxMC4xMiAtIDEwLjE0CiAKICAgICBpZiAoIW1fc25hcFRvTGluZXMpIHsKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlYWEz ZTk0NTBhZTExMWY3NzljZDYxYmYzOWEzN2JhNTEyZDU4YzZmLi4xYjBiZjIyOGQ2ZmY2OGY0Nzdi N2EyNTU0NGI0ODFiODA4ZGQ4MzE2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDQtMjAg IFZpY3RvciBDYXJidW5lICA8dmNhcmJ1bmVAYWRvYmUuY29tPgorCisgICAgICAgIEVuc3VyZSB0 ZXh0IGlzIGNlbnRlcmVkIGZvciBkZWZhdWx0IGNhcHRpb25zCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDQ1MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZWQgdGVzdCB0byBjb3ZlciBkZWZhdWx0 IHBvc2l0aW9uaW5nIG9mIGNhcHRpb25zLgorCisgICAgICAgICogbWVkaWEvdHJhY2svdHJhY2st Y3VlLXJlbmRlcmluZy1leHBlY3RlZC50eHQ6IFVwZGF0ZWQuCisgICAgICAgICogbWVkaWEvdHJh Y2svdHJhY2stY3VlLXJlbmRlcmluZy5odG1sOiBVcGRhdGVkLgorCiAyMDEyLTA0LTIwICBNaWto YWlsIE5hZ2Fub3YgIDxtbmFnYW5vdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVt XSBVbnJldmlld2VkIHRlc3QgZXhwZWN0YXRpb25zIHVwZGF0ZS4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWN1ZS1yZW5kZXJpbmctZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stY3VlLXJlbmRlcmluZy1leHBlY3RlZC50eHQKaW5k ZXggYjgwMTI0NmM0M2YzZmFiNTM0NTM4YTVhNDU4ZGYzODhkYzY3YmI1Mi4uYmMyN2RmMDdlZmE0 YzUxY2JjMTY5ZDIwYmQxNzk2YmNiMWM4MDQ3ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVk aWEvdHJhY2svdHJhY2stY3VlLXJlbmRlcmluZy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvbWVkaWEvdHJhY2svdHJhY2stY3VlLXJlbmRlcmluZy1leHBlY3RlZC50eHQKQEAgLTEsMzEg KzEsMzUgQEAKLVRlc3QgdGhhdCBUZXh0VHJhY2sncyBjdWVzIGFyZSByZW5kZXJlZCBjb3JyZWN0 bHkuCitUZXN0IHRoYXQgZGVmYXVsdCBwb3NpdGlvbmVkIFRleHRUcmFjaydzIGN1ZXMgYXJlIHJl bmRlcmVkIGNvcnJlY3RseS4KIEVWRU5UKGNhbnBsYXl0aHJvdWdoKQogRVZFTlQoc2Vla2VkKQog RVhQRUNURUQgKHZpZGVvLmN1cnJlbnRUaW1lID09ICcwLjUnKSBPSwogRVhQRUNURUQgKHRlc3RU cmFjay50cmFjay5hY3RpdmVDdWVzLmxlbmd0aCA9PSAnMScpIE9LCiBFWFBFQ1RFRCAodGVzdFRy YWNrLnRyYWNrLmFjdGl2ZUN1ZXNbMF0udGV4dCA9PSAnTG9yZW0nKSBPSwotRVhQRUNURUQgKHRl eHRUcmFja0Rpc3BsYXlFbGVtZW50KHZpZGVvLCAnZGlzcGxheScpLmlubmVyVGV4dCA9PSAnTG9y ZW0nKSBPSworRVhQRUNURUQgKHRlc3RDdWVEaXNwbGF5Qm94LmlubmVyVGV4dCA9PSAnTG9yZW0n KSBPSworRVhQRUNURUQgKDIgKiB0ZXN0Q3VlRGlzcGxheUJveC5vZmZzZXRMZWZ0ID09IHZpZGVv LnZpZGVvV2lkdGggLSB0ZXN0Q3VlRGlzcGxheUJveC5vZmZzZXRXaWR0aCA9PSAndHJ1ZScpIE9L CiAKIFJVTih2aWRlby5jdXJyZW50VGltZSA9IDEuNSkKIEVWRU5UKHNlZWtlZCkKIEVYUEVDVEVE ICh2aWRlby5jdXJyZW50VGltZSA9PSAnMS41JykgT0sKIEVYUEVDVEVEICh0ZXN0VHJhY2sudHJh Y2suYWN0aXZlQ3Vlcy5sZW5ndGggPT0gJzEnKSBPSwogRVhQRUNURUQgKHRlc3RUcmFjay50cmFj ay5hY3RpdmVDdWVzWzBdLnRleHQgPT0gJ2lwc3VtJykgT0sKLUVYUEVDVEVEICh0ZXh0VHJhY2tE aXNwbGF5RWxlbWVudCh2aWRlbywgJ2Rpc3BsYXknKS5pbm5lclRleHQgPT0gJ2lwc3VtJykgT0sK K0VYUEVDVEVEICh0ZXN0Q3VlRGlzcGxheUJveC5pbm5lclRleHQgPT0gJ2lwc3VtJykgT0sKK0VY UEVDVEVEICgyICogdGVzdEN1ZURpc3BsYXlCb3gub2Zmc2V0TGVmdCA9PSB2aWRlby52aWRlb1dp ZHRoIC0gdGVzdEN1ZURpc3BsYXlCb3gub2Zmc2V0V2lkdGggPT0gJ3RydWUnKSBPSwogCiBSVU4o dmlkZW8uY3VycmVudFRpbWUgPSAyLjUpCiBFVkVOVChzZWVrZWQpCiBFWFBFQ1RFRCAodmlkZW8u Y3VycmVudFRpbWUgPT0gJzIuNScpIE9LCiBFWFBFQ1RFRCAodGVzdFRyYWNrLnRyYWNrLmFjdGl2 ZUN1ZXMubGVuZ3RoID09ICcxJykgT0sKIEVYUEVDVEVEICh0ZXN0VHJhY2sudHJhY2suYWN0aXZl Q3Vlc1swXS50ZXh0ID09ICdkb2xvcicpIE9LCi1FWFBFQ1RFRCAodGV4dFRyYWNrRGlzcGxheUVs ZW1lbnQodmlkZW8sICdkaXNwbGF5JykuaW5uZXJUZXh0ID09ICdkb2xvcicpIE9LCitFWFBFQ1RF RCAodGVzdEN1ZURpc3BsYXlCb3guaW5uZXJUZXh0ID09ICdkb2xvcicpIE9LCitFWFBFQ1RFRCAo MiAqIHRlc3RDdWVEaXNwbGF5Qm94Lm9mZnNldExlZnQgPT0gdmlkZW8udmlkZW9XaWR0aCAtIHRl c3RDdWVEaXNwbGF5Qm94Lm9mZnNldFdpZHRoID09ICd0cnVlJykgT0sKIAogUlVOKHZpZGVvLmN1 cnJlbnRUaW1lID0gMy41KQogRVZFTlQoc2Vla2VkKQogRVhQRUNURUQgKHZpZGVvLmN1cnJlbnRU aW1lID09ICczLjUnKSBPSwogRVhQRUNURUQgKHRlc3RUcmFjay50cmFjay5hY3RpdmVDdWVzLmxl bmd0aCA9PSAnMScpIE9LCiBFWFBFQ1RFRCAodGVzdFRyYWNrLnRyYWNrLmFjdGl2ZUN1ZXNbMF0u dGV4dCA9PSAnc2l0JykgT0sKLUVYUEVDVEVEICh0ZXh0VHJhY2tEaXNwbGF5RWxlbWVudCh2aWRl bywgJ2Rpc3BsYXknKS5pbm5lclRleHQgPT0gJ3NpdCcpIE9LCitFWFBFQ1RFRCAodGVzdEN1ZURp c3BsYXlCb3guaW5uZXJUZXh0ID09ICdzaXQnKSBPSworRVhQRUNURUQgKDIgKiB0ZXN0Q3VlRGlz cGxheUJveC5vZmZzZXRMZWZ0ID09IHZpZGVvLnZpZGVvV2lkdGggLSB0ZXN0Q3VlRGlzcGxheUJv eC5vZmZzZXRXaWR0aCA9PSAndHJ1ZScpIE9LCiAKIFRlc3QgdGhlIGN1ZSBkaXNwbGF5IGNvbG9y cyBhbmQgZm9udC4KIFJVTih2aWRlby53aWR0aCA9IDMyMCkKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL21lZGlhL3RyYWNrL3RyYWNrLWN1ZS1yZW5kZXJpbmcuaHRtbCBiL0xheW91dFRlc3RzL21l ZGlhL3RyYWNrL3RyYWNrLWN1ZS1yZW5kZXJpbmcuaHRtbAppbmRleCBjMzA3YzZlZTU2MWY3M2Vi YTQ5ZGI3Y2VhMzlkNDM2M2E0ZDY3ODk5Li41YTdlOGU2NWQ4ZWIxZTM0MGIwZTk0ZjQxMTVjYTg3 NmViYzk4NjU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jdWUt cmVuZGVyaW5nLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stY3VlLXJl bmRlcmluZy5odG1sCkBAIC0xMCw2ICsxMCw3IEBACiAgICAgICAgIDxzY3JpcHQ+ICAgICAgICAg ICAgCiAKICAgICAgICAgdmFyIHRlc3RUcmFjazsKKyAgICAgICAgdmFyIHRlc3RDdWVEaXNwbGF5 Qm94OwogICAgICAgICB2YXIgc2Vla2VkQ291bnQgPSAwOwogICAgICAgICB2YXIgaW5mbyA9IFsg IkxvcmVtIiwgImlwc3VtIiwgImRvbG9yIiwgInNpdCIgXTsKIApAQCAtNDksNyArNTAsMTAgQEAK ICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8uY3VycmVudFRpbWUiLCBzZWVrZWRDb3Vu dCArIC41KTsKICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgidGVzdFRyYWNrLnRyYWNrLmFjdGl2 ZUN1ZXMubGVuZ3RoIiwgMSk7CiAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInRlc3RUcmFjay50 cmFjay5hY3RpdmVDdWVzWzBdLnRleHQiLCBpbmZvW3NlZWtlZENvdW50XSk7Ci0gICAgICAgICAg ICB0ZXN0RXhwZWN0ZWQoInRleHRUcmFja0Rpc3BsYXlFbGVtZW50KHZpZGVvLCAnZGlzcGxheScp LmlubmVyVGV4dCIsIGluZm9bc2Vla2VkQ291bnRdKTsKKworICAgICAgICAgICAgdGVzdEN1ZURp c3BsYXlCb3ggPSB0ZXh0VHJhY2tEaXNwbGF5RWxlbWVudCh2aWRlbywgJ2Rpc3BsYXknKTsKKyAg ICAgICAgICAgIHRlc3RFeHBlY3RlZCgidGVzdEN1ZURpc3BsYXlCb3guaW5uZXJUZXh0IiwgaW5m b1tzZWVrZWRDb3VudF0pOworICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCIyICogdGVzdEN1ZURp c3BsYXlCb3gub2Zmc2V0TGVmdCA9PSB2aWRlby52aWRlb1dpZHRoIC0gdGVzdEN1ZURpc3BsYXlC b3gub2Zmc2V0V2lkdGgiLCB0cnVlKQogCiAgICAgICAgICAgICBpZiAoKytzZWVrZWRDb3VudCA9 PSBpbmZvLmxlbmd0aCkKICAgICAgICAgICAgICAgICB0ZXN0Q3VlU3R5bGUoKTsKQEAgLTYyLDcg KzY2LDcgQEAKIAogICAgICAgICBmdW5jdGlvbiBsb2FkZWQoKQogICAgICAgICB7Ci0gICAgICAg ICAgICBjb25zb2xlV3JpdGUoIlRlc3QgdGhhdCBUZXh0VHJhY2sncyBjdWVzIGFyZSByZW5kZXJl ZCBjb3JyZWN0bHkuIik7CisgICAgICAgICAgICBjb25zb2xlV3JpdGUoIlRlc3QgdGhhdCBkZWZh dWx0IHBvc2l0aW9uZWQgVGV4dFRyYWNrJ3MgY3VlcyBhcmUgcmVuZGVyZWQgY29ycmVjdGx5LiIp OwogICAgICAgICAgICAgZmluZE1lZGlhRWxlbWVudCgpOwogICAgICAgICAgICAgdGVzdFRyYWNr ID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcigndHJhY2snKTsKICAgICAgICAgICAgIHZpZGVvLnNy YyA9IGZpbmRNZWRpYUZpbGUoJ3ZpZGVvJywgJy4uL2NvbnRlbnQvdGVzdCcpOwo=