84385 2012-04-19 14:36:26 -0700 Default to null value for HistoryItem::m_pageScaleFactor 2012-05-10 00:38:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84408 66687 1 aelias aelias abarth aelias bdakin japhet webkit.review.bot oldest_to_newest 605922 0 aelias 2012-04-19 14:36:26 -0700 Default to null value for HistoryItem::m_pageScaleFactor 605939 1 137980 aelias 2012-04-19 14:46:00 -0700 Created attachment 137980 Patch 606132 2 137980 webkit.review.bot 2012-04-19 16:30:45 -0700 Comment on attachment 137980 Patch Clearing flags on attachment: 137980 Committed r114690: <http://trac.webkit.org/changeset/114690> 606133 3 webkit.review.bot 2012-04-19 16:30:49 -0700 All reviewed patches have been landed. Closing bug. 619868 4 abarth 2012-05-09 14:50:31 -0700 I'm told this was reverted. 619886 5 abarth 2012-05-09 15:02:58 -0700 Apparently this patch is blocked on <https://chromiumcodereview.appspot.com/10153008/>, which is now in the Chromium commit-queue. 620313 6 abarth 2012-05-10 00:20:58 -0700 https://chromiumcodereview.appspot.com/10153008/ landed as Chromium@136194. I think that means we're ready to land this patch again. 620331 7 137980 webkit.review.bot 2012-05-10 00:38:08 -0700 Comment on attachment 137980 Patch Clearing flags on attachment: 137980 Committed r116617: <http://trac.webkit.org/changeset/116617> 620332 8 webkit.review.bot 2012-05-10 00:38:13 -0700 All reviewed patches have been landed. Closing bug. 137980 2012-04-19 14:46:00 -0700 2012-05-10 00:38:08 -0700 Patch bug-84385-20120419144559.patch text/plain 4090 aelias U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODUxNjI1OTJlMWIxYzUx YTdkYTBiYWI5ODc0YzUxNzhhOWE1NmIzMy4uODc1NjQxZGQ1YjQyYThiNmI4MzMxNmEzOThkMjNj ZDNmMTZmMzhkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEyLTA0LTE5ICBBbGV4 YW5kcmUgRWxpYXMgIDxhZWxpYXNAZ29vZ2xlLmNvbT4KKworICAgICAgICBEZWZhdWx0IHRvIG51 bGwgdmFsdWUgZm9yIEhpc3RvcnlJdGVtOjptX3BhZ2VTY2FsZUZhY3RvcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQzODUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV2aW91c2x5LCBIaXN0b3J5SXRl bTo6bV9wYWdlU2NhbGVGYWN0b3IgZGVmYXVsdGVkIHRvIGEgdmFsdWUKKyAgICAgICAgb2YgMSwg bWFraW5nIGl0IGltcG9zc2libGUgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgdGhpcyB2YWx1ZSB3YXMg bmV2ZXIKKyAgICAgICAgc2V0LCBvciBpbnRlbnRpb25hbGx5IHNldCB0byAxLiAgVGhpcyBwYXRj aCBpbnRyb2R1Y2VzIGEgZGVmYXVsdCB2YWx1ZQorICAgICAgICBvZiAwIGFuZCBtYWtlcyByZXN0 b3JlU2Nyb2xsUG9zaXRpb25BbmRWaWV3U3RhdGUgbm90IHRvdWNoIHRoZSBwYWdlCisgICAgICAg IHNjYWxlIGZhY3RvciBpZiB0aGlzIHZhbHVlIGlzIHN0aWxsIHByZXNlbnQgYXQgdGltZSBvZiBy ZWxvYWQuCisKKyAgICAgICAgVGhpcyBpcyBhIG5vLW9wIGNoYW5nZSBmb3IgY29tbW9uIG5hdmln YXRpb24gc2NlbmFyaW9zLiAgVGhlCisgICAgICAgIG1vdGl2YXRpb24gZm9yIHRoaXMgY2hhbmdl IGlzIHRoZSBjb3JuZXIgY2FzZSBvZiBzeW5jaW5nIGhpc3RvcnkgaXRlbXMKKyAgICAgICAgZnJv bSBhIGRlc2t0b3AgYnJvd3NlciB0byBhIG1vYmlsZSBkZXZpY2UuICBJbiB0aGF0IGNhc2UsIHdl IG5lZWQgYQorICAgICAgICB3YXkgdG8gc3BlY2lmeSB0aGF0IHRoZSBoaXN0b3J5IGl0ZW0gZG9l cyBub3QgY29udGFpbiBhCisgICAgICAgIHBhZ2VTY2FsZUZhY3RvciBzbyB0aGF0IHRoZSBtb2Jp bGUgZGV2aWNlIGRvZXMgbm90IGRpc3BsYXkgdGhlIHBhZ2UKKyAgICAgICAgb3Zlcmx5IHpvb21l ZCBpbi4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBoaXN0b3J5L0hpc3Rv cnlJdGVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okhpc3RvcnlJdGVtOjpIaXN0b3J5SXRlbSk6 CisgICAgICAgICogbG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Okhpc3RvcnlDb250cm9sbGVyOjpyZXN0b3JlU2Nyb2xsUG9zaXRpb25BbmRWaWV3U3RhdGUp OgorCiAyMDEyLTA0LTE5ICB2c2V2aWtAY2hyb21pdW0ub3JnICA8dnNldmlrQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBObyByZXNwb25zZSBib2R5IGF2YWlsYWJsZSBm b3IgY2FjaGVkIHJlc291cmNlIHJlcXVlc3RzIHdpdGggZXJyb3Igc3RhdHVzIGNvZGVzLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9IaXN0b3J5SXRlbS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmNwcAppbmRleCAyMWM4MWVkZTdlZmUyNjFhZDg2 OTc1MWRjZjllOGYyYTQwYTVlODkyLi5jNTlkYmFiM2I2ZWUxMGJjNDIzYzU0YmQ0N2Q5YmExZWVl YTQyOTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0hpc3RvcnlJdGVtLmNwcApAQCAtNjEsNyAr NjEsNyBAQCB2b2lkICgqbm90aWZ5SGlzdG9yeUl0ZW1DaGFuZ2VkKShIaXN0b3J5SXRlbSopID0g ZGVmYXVsdE5vdGlmeUhpc3RvcnlJdGVtQ2hhbmdlZAogSGlzdG9yeUl0ZW06Okhpc3RvcnlJdGVt KCkKICAgICA6IG1fbGFzdFZpc2l0ZWRUaW1lKDApCiAgICAgLCBtX2xhc3RWaXNpdFdhc0hUVFBO b25HZXQoZmFsc2UpCi0gICAgLCBtX3BhZ2VTY2FsZUZhY3RvcigxKQorICAgICwgbV9wYWdlU2Nh bGVGYWN0b3IoMCkKICAgICAsIG1fbGFzdFZpc2l0V2FzRmFpbHVyZShmYWxzZSkKICAgICAsIG1f aXNUYXJnZXRJdGVtKGZhbHNlKQogICAgICwgbV92aXNpdENvdW50KDApCkBAIC03OCw3ICs3OCw3 IEBAIEhpc3RvcnlJdGVtOjpIaXN0b3J5SXRlbShjb25zdCBTdHJpbmcmIHVybFN0cmluZywgY29u c3QgU3RyaW5nJiB0aXRsZSwgZG91YmxlIHRpCiAgICAgLCBtX3RpdGxlKHRpdGxlKQogICAgICwg bV9sYXN0VmlzaXRlZFRpbWUodGltZSkKICAgICAsIG1fbGFzdFZpc2l0V2FzSFRUUE5vbkdldChm YWxzZSkKLSAgICAsIG1fcGFnZVNjYWxlRmFjdG9yKDEpCisgICAgLCBtX3BhZ2VTY2FsZUZhY3Rv cigwKQogICAgICwgbV9sYXN0VmlzaXRXYXNGYWlsdXJlKGZhbHNlKQogICAgICwgbV9pc1Rhcmdl dEl0ZW0oZmFsc2UpCiAgICAgLCBtX3Zpc2l0Q291bnQoMCkKQEAgLTk3LDcgKzk3LDcgQEAgSGlz dG9yeUl0ZW06Okhpc3RvcnlJdGVtKGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nLCBjb25zdCBTdHJp bmcmIHRpdGxlLCBjb25zdCBTdHIKICAgICAsIG1fZGlzcGxheVRpdGxlKGFsdGVybmF0ZVRpdGxl KQogICAgICwgbV9sYXN0VmlzaXRlZFRpbWUodGltZSkKICAgICAsIG1fbGFzdFZpc2l0V2FzSFRU UE5vbkdldChmYWxzZSkKLSAgICAsIG1fcGFnZVNjYWxlRmFjdG9yKDEpCisgICAgLCBtX3BhZ2VT Y2FsZUZhY3RvcigwKQogICAgICwgbV9sYXN0VmlzaXRXYXNGYWlsdXJlKGZhbHNlKQogICAgICwg bV9pc1RhcmdldEl0ZW0oZmFsc2UpCiAgICAgLCBtX3Zpc2l0Q291bnQoMCkKQEAgLTExNyw3ICsx MTcsNyBAQCBIaXN0b3J5SXRlbTo6SGlzdG9yeUl0ZW0oY29uc3QgS1VSTCYgdXJsLCBjb25zdCBT dHJpbmcmIHRhcmdldCwgY29uc3QgU3RyaW5nJiBwYQogICAgICwgbV90aXRsZSh0aXRsZSkKICAg ICAsIG1fbGFzdFZpc2l0ZWRUaW1lKDApCiAgICAgLCBtX2xhc3RWaXNpdFdhc0hUVFBOb25HZXQo ZmFsc2UpCi0gICAgLCBtX3BhZ2VTY2FsZUZhY3RvcigxKQorICAgICwgbV9wYWdlU2NhbGVGYWN0 b3IoMCkKICAgICAsIG1fbGFzdFZpc2l0V2FzRmFpbHVyZShmYWxzZSkKICAgICAsIG1faXNUYXJn ZXRJdGVtKGZhbHNlKQogICAgICwgbV92aXNpdENvdW50KDApCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcAppbmRleCBlYzQ3OGE3OTJiZTQyODUzNTIxZjlhNzBj ZTc4YTYyMzRkNGY0OTI0Li5kNWRmNjM5YmNiOGRlNTk1NTYzNzk0MjFjN2YyMWMyYmVlZWM3OTkw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAKQEAgLTEy Niw3ICsxMjYsNyBAQCB2b2lkIEhpc3RvcnlDb250cm9sbGVyOjpyZXN0b3JlU2Nyb2xsUG9zaXRp b25BbmRWaWV3U3RhdGUoKQogICAgICAgICBpZiAoIXZpZXctPndhc1Njcm9sbGVkQnlVc2VyKCkp IHsKICAgICAgICAgICAgIHZpZXctPnNldFNjcm9sbFBvc2l0aW9uKG1fY3VycmVudEl0ZW0tPnNj cm9sbFBvaW50KCkpOwogICAgICAgICAgICAgUGFnZSogcGFnZSA9IG1fZnJhbWUtPnBhZ2UoKTsK LSAgICAgICAgICAgIGlmIChwYWdlICYmIHBhZ2UtPm1haW5GcmFtZSgpID09IG1fZnJhbWUpCisg ICAgICAgICAgICBpZiAocGFnZSAmJiBwYWdlLT5tYWluRnJhbWUoKSA9PSBtX2ZyYW1lICYmIG1f Y3VycmVudEl0ZW0tPnBhZ2VTY2FsZUZhY3RvcigpKQogICAgICAgICAgICAgICAgIHBhZ2UtPnNl dFBhZ2VTY2FsZUZhY3RvcihtX2N1cnJlbnRJdGVtLT5wYWdlU2NhbGVGYWN0b3IoKSwgbV9jdXJy ZW50SXRlbS0+c2Nyb2xsUG9pbnQoKSk7CiAgICAgICAgIH0KICAgICB9Cg==