84310 2012-04-18 19:32:04 -0700 [V8] Add an optional Isolate argument to setDOMException() and throwError() 2012-04-23 10:48:17 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 605302 0 haraken 2012-04-18 19:32:04 -0700 The objective is to pass Isolate to setDOMException() and throwError(). This bug adds an optional Isolate argument to setDOMException() and throwError(). I'll pass the Isolate to them in the following patches. 605305 1 137821 haraken 2012-04-18 19:35:22 -0700 Created attachment 137821 Patch 607830 2 137821 webkit.review.bot 2012-04-23 10:48:12 -0700 Comment on attachment 137821 Patch Clearing flags on attachment: 137821 Committed r114919: <http://trac.webkit.org/changeset/114919> 607831 3 webkit.review.bot 2012-04-23 10:48:17 -0700 All reviewed patches have been landed. Closing bug. 137821 2012-04-18 19:35:22 -0700 2012-04-23 10:48:12 -0700 Patch bug-84310-20120418193521.patch text/plain 5642 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQxMzY3NzFiNmIzMGZm ZmIzNzBhOWMxN2MwYjlkNTc3NTVmNzU1Yi4uZTNjYjljNWFmNjNlODVlMTRiOGNiYzVlMzcxOTEx ZjE1MDg4MGE1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA0LTE4ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEFkZCBhbiBv cHRpb25hbCBJc29sYXRlIGFyZ3VtZW50IHRvIHNldERPTUV4Y2VwdGlvbigpIGFuZCB0aHJvd0Vy cm9yKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0 MzEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IG9iamVjdGl2ZSBpcyB0byBwYXNzIElzb2xhdGUgdG8gc2V0RE9NRXhjZXB0aW9uKCkKKyAgICAg ICAgYW5kIHRocm93RXJyb3IoKS4gVGhpcyBwYXRjaCBhZGRzIGFuIG9wdGlvbmFsIElzb2xhdGUg YXJndW1lbnQKKyAgICAgICAgdG8gc2V0RE9NRXhjZXB0aW9uKCkgYW5kIHRocm93RXJyb3IoKS4g SSdsbCBwYXNzIHRoZSBJc29sYXRlCisgICAgICAgIHRvIHRoZXNlIG1ldGhvZHMgaW4gdGhlIGZv bGxvd2luZyBwYXRjaGVzLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZp b3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNv cmUpOgorICAgICAgICAoV2ViQ29yZTo6VjhQcm94eTo6c2V0RE9NRXhjZXB0aW9uKToKKyAgICAg ICAgKFdlYkNvcmU6OlY4UHJveHk6OnRocm93RXJyb3IpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4 L1Y4UHJveHkuaDoKKyAgICAgICAgKFY4UHJveHkpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAg ICAgIChXZWJDb3JlOjp0aHJvd0Vycm9yKToKKwogMjAxMi0wNC0xOCAgRG9taW5payBSw7Z0dHNj aGVzICA8ZG9taW5pay5yb3R0c2NoZXNAbGludXguaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxd W0RSVF0gQGZvbnQtZmFjZSBzdXBwb3J0IGZhaWxzIG9uIEVGTApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOFByb3h5LmNwcAppbmRleCBkNDhmOGVhMDhhODIwZjg2OWQ4ZjJmNTFhZjhhMDNkNzZl OWE3MTA4Li44MmQ3NDBhYTE5NWY4MDdiZjJkNjEzZjYwYmRlMzUyMjcwZmE3MzgzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcApAQCAtNTQyLDEwICs1NDIsMTAgQEAgdm9p ZCBWOFByb3h5OjpjbGVhckZvck5hdmlnYXRpb24oKQogCiAjZGVmaW5lIFRSWV9UT19DUkVBVEVf RVhDRVBUSU9OKGludGVyZmFjZU5hbWUpIFwKICAgICBjYXNlIGludGVyZmFjZU5hbWUjI1R5cGU6 IFwKLSAgICAgICAgZXhjZXB0aW9uID0gdG9WOChpbnRlcmZhY2VOYW1lOjpjcmVhdGUoZGVzY3Jp cHRpb24pKTsgXAorICAgICAgICBleGNlcHRpb24gPSB0b1Y4KGludGVyZmFjZU5hbWU6OmNyZWF0 ZShkZXNjcmlwdGlvbiksIGlzb2xhdGUpOyBcCiAgICAgICAgIGJyZWFrOwogCi12b2lkIFY4UHJv eHk6OnNldERPTUV4Y2VwdGlvbihpbnQgZWMpCit2b2lkIFY4UHJveHk6OnNldERPTUV4Y2VwdGlv bihpbnQgZWMsIHY4OjpJc29sYXRlKiBpc29sYXRlKQogewogICAgIGlmIChlYyA8PSAwKQogICAg ICAgICByZXR1cm47CkBAIC01NjMsMTkgKzU2MywxOSBAQCB2b2lkIFY4UHJveHk6OnNldERPTUV4 Y2VwdGlvbihpbnQgZWMpCiAKICN1bmRlZiBUUllfVE9fQ1JFQVRFX0VYQ0VQVElPTgogCi12ODo6 SGFuZGxlPHY4OjpWYWx1ZT4gVjhQcm94eTo6dGhyb3dFcnJvcihFcnJvclR5cGUgdHlwZSwgY29u c3QgY2hhciogbWVzc2FnZSkKK3Y4OjpIYW5kbGU8djg6OlZhbHVlPiBWOFByb3h5Ojp0aHJvd0Vy cm9yKEVycm9yVHlwZSB0eXBlLCBjb25zdCBjaGFyKiBtZXNzYWdlLCB2ODo6SXNvbGF0ZSogaXNv bGF0ZSkKIHsKICAgICBzd2l0Y2ggKHR5cGUpIHsKICAgICBjYXNlIFJhbmdlRXJyb3I6Ci0gICAg ICAgIHJldHVybiB2ODo6VGhyb3dFeGNlcHRpb24odjg6OkV4Y2VwdGlvbjo6UmFuZ2VFcnJvcih2 OFN0cmluZyhtZXNzYWdlKSkpOworICAgICAgICByZXR1cm4gdjg6OlRocm93RXhjZXB0aW9uKHY4 OjpFeGNlcHRpb246OlJhbmdlRXJyb3IodjhTdHJpbmcobWVzc2FnZSwgaXNvbGF0ZSkpKTsKICAg ICBjYXNlIFJlZmVyZW5jZUVycm9yOgotICAgICAgICByZXR1cm4gdjg6OlRocm93RXhjZXB0aW9u KHY4OjpFeGNlcHRpb246OlJlZmVyZW5jZUVycm9yKHY4U3RyaW5nKG1lc3NhZ2UpKSk7CisgICAg ICAgIHJldHVybiB2ODo6VGhyb3dFeGNlcHRpb24odjg6OkV4Y2VwdGlvbjo6UmVmZXJlbmNlRXJy b3IodjhTdHJpbmcobWVzc2FnZSwgaXNvbGF0ZSkpKTsKICAgICBjYXNlIFN5bnRheEVycm9yOgot ICAgICAgICByZXR1cm4gdjg6OlRocm93RXhjZXB0aW9uKHY4OjpFeGNlcHRpb246OlN5bnRheEVy cm9yKHY4U3RyaW5nKG1lc3NhZ2UpKSk7CisgICAgICAgIHJldHVybiB2ODo6VGhyb3dFeGNlcHRp b24odjg6OkV4Y2VwdGlvbjo6U3ludGF4RXJyb3IodjhTdHJpbmcobWVzc2FnZSwgaXNvbGF0ZSkp KTsKICAgICBjYXNlIFR5cGVFcnJvcjoKLSAgICAgICAgcmV0dXJuIHY4OjpUaHJvd0V4Y2VwdGlv bih2ODo6RXhjZXB0aW9uOjpUeXBlRXJyb3IodjhTdHJpbmcobWVzc2FnZSkpKTsKKyAgICAgICAg cmV0dXJuIHY4OjpUaHJvd0V4Y2VwdGlvbih2ODo6RXhjZXB0aW9uOjpUeXBlRXJyb3IodjhTdHJp bmcobWVzc2FnZSwgaXNvbGF0ZSkpKTsKICAgICBjYXNlIEdlbmVyYWxFcnJvcjoKLSAgICAgICAg cmV0dXJuIHY4OjpUaHJvd0V4Y2VwdGlvbih2ODo6RXhjZXB0aW9uOjpFcnJvcih2OFN0cmluZyht ZXNzYWdlKSkpOworICAgICAgICByZXR1cm4gdjg6OlRocm93RXhjZXB0aW9uKHY4OjpFeGNlcHRp b246OkVycm9yKHY4U3RyaW5nKG1lc3NhZ2UsIGlzb2xhdGUpKSk7CiAgICAgZGVmYXVsdDoKICAg ICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgIHJldHVybiBub3RIYW5kbGVkQnlJ bnRlcmNlcHRvcigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQ cm94eS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCmluZGV4IDIxZWRm NWQzM2M5YWFkMDliNTc4NDhhYjVhYjAxY2U4YTkwY2I2MDYuLmVlNWE1NzFiY2RmYzQwMGRhYmM0 OTIwOTFiZDg2OGJmMmJjMDhiNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4UHJveHkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgK QEAgLTIzNSwxMCArMjM1LDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICAvLyBJ ZiB0aGUgZXhjZXB0aW9uIGNvZGUgaXMgZGlmZmVyZW50IGZyb20gemVybywgYSBET00gZXhjZXB0 aW9uIGlzCiAgICAgICAgIC8vIHNjaGVkdWxlIHRvIGJlIHRocm93bi4KLSAgICAgICAgc3RhdGlj IHZvaWQgc2V0RE9NRXhjZXB0aW9uKGludCBleGNlcHRpb25Db2RlKTsKKyAgICAgICAgc3RhdGlj IHZvaWQgc2V0RE9NRXhjZXB0aW9uKGludCBleGNlcHRpb25Db2RlLCB2ODo6SXNvbGF0ZSogPSAw KTsKIAogICAgICAgICAvLyBTY2hlZHVsZSBhbiBlcnJvciBvYmplY3QgdG8gYmUgdGhyb3duLgot ICAgICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHRocm93RXJyb3IoRXJyb3JUeXBl LCBjb25zdCBjaGFyKiBtZXNzYWdlKTsKKyAgICAgICAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZh bHVlPiB0aHJvd0Vycm9yKEVycm9yVHlwZSwgY29uc3QgY2hhciogbWVzc2FnZSwgdjg6Oklzb2xh dGUqID0gMCk7CiAKICAgICAgICAgLy8gSGVscGVycyBmb3IgdGhyb3dpbmcgc3ludGF4IGFuZCB0 eXBlIGVycm9ycyB3aXRoIHByZWRlZmluZWQgbWVzc2FnZXMuCiAgICAgICAgIHN0YXRpYyB2ODo6 SGFuZGxlPHY4OjpWYWx1ZT4gdGhyb3dUeXBlRXJyb3IoKTsKQEAgLTMyNCwyMSArMzI0LDI5IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICB7CiAgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6 OkJvb2xlYW4+KCk7CiAgICAgfQotICAgIGlubGluZSB2ODo6SGFuZGxlPHY4OjpQcmltaXRpdmU+ IHRocm93RXJyb3IoY29uc3QgY2hhciogbWVzc2FnZSwgVjhQcm94eTo6RXJyb3JUeXBlIHR5cGUg PSBWOFByb3h5OjpUeXBlRXJyb3IpCisKKyAgICBpbmxpbmUgdjg6OkhhbmRsZTx2ODo6UHJpbWl0 aXZlPiB0aHJvd0Vycm9yKGNvbnN0IGNoYXIqIG1lc3NhZ2UsIHY4OjpJc29sYXRlKiBpc29sYXRl ID0gMCkKKyAgICB7CisgICAgICAgIGlmICghdjg6OlY4OjpJc0V4ZWN1dGlvblRlcm1pbmF0aW5n KCkpCisgICAgICAgICAgICBWOFByb3h5Ojp0aHJvd0Vycm9yKFY4UHJveHk6OlR5cGVFcnJvciwg bWVzc2FnZSwgaXNvbGF0ZSk7CisgICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CisgICAg fQorCisgICAgaW5saW5lIHY4OjpIYW5kbGU8djg6OlByaW1pdGl2ZT4gdGhyb3dFcnJvcihjb25z dCBjaGFyKiBtZXNzYWdlLCBWOFByb3h5OjpFcnJvclR5cGUgdHlwZSwgdjg6Oklzb2xhdGUqIGlz b2xhdGUgPSAwKQogICAgIHsKICAgICAgICAgaWYgKCF2ODo6Vjg6OklzRXhlY3V0aW9uVGVybWlu YXRpbmcoKSkKLSAgICAgICAgICAgIFY4UHJveHk6OnRocm93RXJyb3IodHlwZSwgbWVzc2FnZSk7 CisgICAgICAgICAgICBWOFByb3h5Ojp0aHJvd0Vycm9yKHR5cGUsIG1lc3NhZ2UsIGlzb2xhdGUp OwogICAgICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOwogICAgIH0KIAotICAgIGlubGluZSB2 ODo6SGFuZGxlPHY4OjpQcmltaXRpdmU+IHRocm93RXJyb3IoRXhjZXB0aW9uQ29kZSBlYykKKyAg ICBpbmxpbmUgdjg6OkhhbmRsZTx2ODo6UHJpbWl0aXZlPiB0aHJvd0Vycm9yKEV4Y2VwdGlvbkNv ZGUgZWMsIHY4OjpJc29sYXRlKiBpc29sYXRlID0gMCkKICAgICB7CiAgICAgICAgIGlmICghdjg6 OlY4OjpJc0V4ZWN1dGlvblRlcm1pbmF0aW5nKCkpCi0gICAgICAgICAgICBWOFByb3h5OjpzZXRE T01FeGNlcHRpb24oZWMpOworICAgICAgICAgICAgVjhQcm94eTo6c2V0RE9NRXhjZXB0aW9uKGVj LCBpc29sYXRlKTsKICAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKICAgICB9CiAKLSAg ICBpbmxpbmUgdjg6OkhhbmRsZTx2ODo6UHJpbWl0aXZlPiB0aHJvd0Vycm9yKHY4OjpMb2NhbDx2 ODo6VmFsdWU+IGV4Y2VwdGlvbikKKyAgICBpbmxpbmUgdjg6OkhhbmRsZTx2ODo6UHJpbWl0aXZl PiB0aHJvd0Vycm9yKHY4OjpMb2NhbDx2ODo6VmFsdWU+IGV4Y2VwdGlvbiwgdjg6Oklzb2xhdGUq IGlzb2xhdGUgPSAwKQogICAgIHsKICAgICAgICAgaWYgKCF2ODo6Vjg6OklzRXhlY3V0aW9uVGVy bWluYXRpbmcoKSkKICAgICAgICAgICAgIHY4OjpUaHJvd0V4Y2VwdGlvbihleGNlcHRpb24pOwo=