84299 2012-04-18 16:11:58 -0700 [V8] Pass Isolate around in V8Collection.h 2012-04-23 13:06:35 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84074 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 605201 0 haraken 2012-04-18 16:11:58 -0700 The objective is to pass Isolate around in V8 bindings. In this bug, we pass Isolate around in V8Collection.h. 605203 1 137797 haraken 2012-04-18 16:13:37 -0700 Created attachment 137797 Patch 607948 2 137797 webkit.review.bot 2012-04-23 13:06:30 -0700 Comment on attachment 137797 Patch Clearing flags on attachment: 137797 Committed r114934: <http://trac.webkit.org/changeset/114934> 607950 3 webkit.review.bot 2012-04-23 13:06:35 -0700 All reviewed patches have been landed. Closing bug. 137797 2012-04-18 16:13:37 -0700 2012-04-23 13:06:30 -0700 Patch bug-84299-20120418161336.patch text/plain 5105 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQxMzY3NzFiNmIzMGZm ZmIzNzBhOWMxN2MwYjlkNTc3NTVmNzU1Yi4uNzBmN2U5ZjhhZWI1YjBiNTNhYTM2Y2QzNjg4Njcy ZTZkM2I0ZWEyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA0LTE4ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFBhc3MgSXNv bGF0ZSBhcm91bmQgaW4gVjhDb2xsZWN0aW9uLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg0Mjk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIG9iamVjdGl2ZSBpcyB0byBwYXNzIElzb2xhdGUgYXJv dW5kIGluIFY4IGJpbmRpbmdzLgorICAgICAgICBUaGlzIHBhdGNoIHBhc3NlcyBJc29sYXRlIGFy b3VuZCBpbiBWOENvbGxlY3Rpb24uaC4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGlu IGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhDb2xsZWN0aW9uLmg6CisgICAg ICAgIChXZWJDb3JlOjpnZXRWOE9iamVjdCk6CisgICAgICAgIChXZWJDb3JlOjpnZXROYW1lZFBy b3BlcnR5T2ZDb2xsZWN0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OmNvbGxlY3Rpb25OYW1lZFBy b3BlcnR5R2V0dGVyKToKKyAgICAgICAgKFdlYkNvcmU6OmdldEluZGV4ZWRQcm9wZXJ0eU9mQ29s bGVjdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpjb2xsZWN0aW9uSW5kZXhlZFByb3BlcnR5R2V0 dGVyKToKKwogMjAxMi0wNC0xOCAgRG9taW5payBSw7Z0dHNjaGVzICA8ZG9taW5pay5yb3R0c2No ZXNAbGludXguaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW0RSVF0gQGZvbnQtZmFjZSBzdXBw b3J0IGZhaWxzIG9uIEVGTApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhDb2xsZWN0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOENvbGxlY3Rpb24u aAppbmRleCAzOGE3YzhjZjczZDllOTQyYzQ3OTFlZjM4MDYxNTRkMjcyMzY3MTIwLi4zMGRlNjBl OGUzOGUwZTc1OTI3MThjZDIwZTE5OTdkMzg4NWVjMzM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOENvbGxlY3Rpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOENvbGxlY3Rpb24uaApAQCAtNDIsMTEgKzQyLDExIEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKIC8vIEZJWE1FOiBUaGVzZSBmdW5jdGlvbnMgc2hvdWxkIGJlIG5hbWVkIHVzaW5nIHRv KiBzaW5jZSB0aGV5IHJldHVybiB0aGUgaXRlbSAoZ2V0KiBpcyB1c2VkIGZvciBtZXRob2QgdGhh dCB0YWtlIGEgcmVmIHBhcmFtKS4KIC8vIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjQ2NjQuCiAKLXRlbXBsYXRlPGNsYXNzIFQ+IHN0YXRpYyB2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gZ2V0VjhPYmplY3QoVCogaW1wbGVtZW50YXRpb24pCit0ZW1wbGF0ZTxjbGFz cyBUPiBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGdldFY4T2JqZWN0KFQqIGltcGxlbWVu dGF0aW9uLCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKICAgICBpZiAoIWltcGxlbWVudGF0aW9u KQogICAgICAgICByZXR1cm4gdjg6OkhhbmRsZTx2ODo6VmFsdWU+KCk7Ci0gICAgcmV0dXJuIHRv VjgoaW1wbGVtZW50YXRpb24pOworICAgIHJldHVybiB0b1Y4KGltcGxlbWVudGF0aW9uLCBpc29s YXRlKTsKIH0KIAogdGVtcGxhdGU8Y2xhc3MgQ29sbGVjdGlvbj4gc3RhdGljIENvbGxlY3Rpb24q IHRvTmF0aXZlQ29sbGVjdGlvbih2ODo6TG9jYWw8djg6Ok9iamVjdD4gb2JqZWN0KQpAQCAtNTQs MjAgKzU0LDIwIEBAIHRlbXBsYXRlPGNsYXNzIENvbGxlY3Rpb24+IHN0YXRpYyBDb2xsZWN0aW9u KiB0b05hdGl2ZUNvbGxlY3Rpb24odjg6OkxvY2FsPHY4OjpPCiAgICAgcmV0dXJuIHJlaW50ZXJw cmV0X2Nhc3Q8Q29sbGVjdGlvbio+KG9iamVjdC0+R2V0UG9pbnRlckZyb21JbnRlcm5hbEZpZWxk KHY4RE9NV3JhcHBlck9iamVjdEluZGV4KSk7CiB9CiAKLXRlbXBsYXRlPGNsYXNzIFQ+IHN0YXRp YyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gZ2V0VjhPYmplY3QoUGFzc1JlZlB0cjxUPiBpbXBsZW1l bnRhdGlvbikKK3RlbXBsYXRlPGNsYXNzIFQ+IHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4g Z2V0VjhPYmplY3QoUGFzc1JlZlB0cjxUPiBpbXBsZW1lbnRhdGlvbiwgdjg6Oklzb2xhdGUqIGlz b2xhdGUpCiB7Ci0gICAgcmV0dXJuIGdldFY4T2JqZWN0KGltcGxlbWVudGF0aW9uLmdldCgpKTsK KyAgICByZXR1cm4gZ2V0VjhPYmplY3QoaW1wbGVtZW50YXRpb24uZ2V0KCksIGlzb2xhdGUpOwog fQogCiAvLyBSZXR1cm5zIG5hbWVkIHByb3BlcnR5IG9mIGEgY29sbGVjdGlvbi4KLXRlbXBsYXRl PGNsYXNzIENvbGxlY3Rpb24sIGNsYXNzIEl0ZW1UeXBlPiBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6 VmFsdWU+IGdldE5hbWVkUHJvcGVydHlPZkNvbGxlY3Rpb24odjg6OkxvY2FsPHY4OjpTdHJpbmc+ IG5hbWUsIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBvYmplY3QpCit0ZW1wbGF0ZTxjbGFzcyBDb2xs ZWN0aW9uLCBjbGFzcyBJdGVtVHlwZT4gc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBnZXRO YW1lZFByb3BlcnR5T2ZDb2xsZWN0aW9uKHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lLCB2ODo6 TG9jYWw8djg6Ok9iamVjdD4gb2JqZWN0LCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKICAgICAv LyBGSVhNRTogYXNzZXJ0IG9iamVjdCBpcyBhIGNvbGxlY3Rpb24gdHlwZQogICAgIEFTU0VSVChW OERPTVdyYXBwZXI6Om1heWJlRE9NV3JhcHBlcihvYmplY3QpKTsKICAgICBBU1NFUlQoVjhET01X cmFwcGVyOjpkb21XcmFwcGVyVHlwZShvYmplY3QpICE9ICZWOE5vZGU6OmluZm8pOwogICAgIENv bGxlY3Rpb24qIGNvbGxlY3Rpb24gPSB0b05hdGl2ZUNvbGxlY3Rpb248Q29sbGVjdGlvbj4ob2Jq ZWN0KTsKICAgICBBdG9taWNTdHJpbmcgcHJvcGVydHlOYW1lID0gdG9BdG9taWNXZWJDb3JlU3Ry aW5nV2l0aE51bGxDaGVjayhuYW1lKTsKLSAgICByZXR1cm4gZ2V0VjhPYmplY3Q8SXRlbVR5cGU+ KGNvbGxlY3Rpb24tPm5hbWVkSXRlbShwcm9wZXJ0eU5hbWUpKTsKKyAgICByZXR1cm4gZ2V0VjhP YmplY3Q8SXRlbVR5cGU+KGNvbGxlY3Rpb24tPm5hbWVkSXRlbShwcm9wZXJ0eU5hbWUpLCBpc29s YXRlKTsKIH0KIAogLy8gQSB0ZW1wbGF0ZSBvZiBuYW1lZCBwcm9wZXJ0eSBhY2Nlc3NvciBvZiBj b2xsZWN0aW9ucy4KQEAgLTc4LDIzICs3OCwyMyBAQCB0ZW1wbGF0ZTxjbGFzcyBDb2xsZWN0aW9u LCBjbGFzcyBJdGVtVHlwZT4gc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjb2xsZWN0aQog ICAgIGlmIChpbmZvLkhvbGRlcigpLT5IYXNSZWFsTmFtZWRDYWxsYmFja1Byb3BlcnR5KG5hbWUp KQogICAgICAgICByZXR1cm4gbm90SGFuZGxlZEJ5SW50ZXJjZXB0b3IoKTsKIAotICAgIHJldHVy biBnZXROYW1lZFByb3BlcnR5T2ZDb2xsZWN0aW9uPENvbGxlY3Rpb24sIEl0ZW1UeXBlPihuYW1l LCBpbmZvLkhvbGRlcigpKTsKKyAgICByZXR1cm4gZ2V0TmFtZWRQcm9wZXJ0eU9mQ29sbGVjdGlv bjxDb2xsZWN0aW9uLCBJdGVtVHlwZT4obmFtZSwgaW5mby5Ib2xkZXIoKSwgaW5mby5HZXRJc29s YXRlKCkpOwogfQogCiAvLyBSZXR1cm5zIHRoZSBwcm9wZXJ0eSBhdCB0aGUgaW5kZXggb2YgYSBj b2xsZWN0aW9uLgotdGVtcGxhdGU8Y2xhc3MgQ29sbGVjdGlvbiwgY2xhc3MgSXRlbVR5cGU+IHN0 YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gZ2V0SW5kZXhlZFByb3BlcnR5T2ZDb2xsZWN0aW9u KHVpbnQzMl90IGluZGV4LCB2ODo6TG9jYWw8djg6Ok9iamVjdD4gb2JqZWN0KQordGVtcGxhdGU8 Y2xhc3MgQ29sbGVjdGlvbiwgY2xhc3MgSXRlbVR5cGU+IHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpW YWx1ZT4gZ2V0SW5kZXhlZFByb3BlcnR5T2ZDb2xsZWN0aW9uKHVpbnQzMl90IGluZGV4LCB2ODo6 TG9jYWw8djg6Ok9iamVjdD4gb2JqZWN0LCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKICAgICAv LyBGSVhNRTogQXNzZXJ0IHRoYXQgb2JqZWN0IG11c3QgYmUgYSBjb2xsZWN0aW9uIHR5cGUuCiAg ICAgQVNTRVJUKFY4RE9NV3JhcHBlcjo6bWF5YmVET01XcmFwcGVyKG9iamVjdCkpOwogICAgIEFT U0VSVChWOERPTVdyYXBwZXI6OmRvbVdyYXBwZXJUeXBlKG9iamVjdCkgIT0gJlY4Tm9kZTo6aW5m byk7CiAgICAgQ29sbGVjdGlvbiogY29sbGVjdGlvbiA9IHRvTmF0aXZlQ29sbGVjdGlvbjxDb2xs ZWN0aW9uPihvYmplY3QpOwotICAgIHJldHVybiBnZXRWOE9iamVjdDxJdGVtVHlwZT4oY29sbGVj dGlvbi0+aXRlbShpbmRleCkpOworICAgIHJldHVybiBnZXRWOE9iamVjdDxJdGVtVHlwZT4oY29s bGVjdGlvbi0+aXRlbShpbmRleCksIGlzb2xhdGUpOwogfQogCiAvLyBBIHRlbXBsYXRlIG9mIGlu ZGV4IGludGVyY2VwdG9yIG9mIGNvbGxlY3Rpb25zLgogdGVtcGxhdGU8Y2xhc3MgQ29sbGVjdGlv biwgY2xhc3MgSXRlbVR5cGU+IHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gY29sbGVjdGlv bkluZGV4ZWRQcm9wZXJ0eUdldHRlcih1aW50MzJfdCBpbmRleCwgY29uc3Qgdjg6OkFjY2Vzc29y SW5mbyYgaW5mbykKIHsKLSAgICByZXR1cm4gZ2V0SW5kZXhlZFByb3BlcnR5T2ZDb2xsZWN0aW9u PENvbGxlY3Rpb24sIEl0ZW1UeXBlPihpbmRleCwgaW5mby5Ib2xkZXIoKSk7CisgICAgcmV0dXJu IGdldEluZGV4ZWRQcm9wZXJ0eU9mQ29sbGVjdGlvbjxDb2xsZWN0aW9uLCBJdGVtVHlwZT4oaW5k ZXgsIGluZm8uSG9sZGVyKCksIGluZm8uR2V0SXNvbGF0ZSgpKTsKIH0KIAogLy8gR2V0IGFuIGFy cmF5IGNvbnRhaW5pbmcgdGhlIG5hbWVzIG9mIGluZGV4ZWQgcHJvcGVydGllcyBvZiBIVE1MU2Vs ZWN0RWxlbWVudCBhbmQgSFRNTEZvcm1FbGVtZW50Lgo=