84283 2012-04-18 14:40:19 -0700 [win] Update windows platform code to use pixel snapped values 2012-04-20 11:13:30 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 eae eae eric leviw webkit.review.bot oldest_to_newest 605103 0 eae 2012-04-18 14:40:19 -0700 Update windows platform code to use pixel snapped values in preparation for turning on subpixel layout. 605123 1 137775 eae 2012-04-18 14:53:39 -0700 Created attachment 137775 Patch 606670 2 eae 2012-04-20 10:14:16 -0700 Ping? 606714 3 eae 2012-04-20 11:03:09 -0700 Thanks Eric! 606725 4 137775 webkit.review.bot 2012-04-20 11:13:07 -0700 Comment on attachment 137775 Patch Clearing flags on attachment: 137775 Committed r114764: <http://trac.webkit.org/changeset/114764> 606726 5 webkit.review.bot 2012-04-20 11:13:30 -0700 All reviewed patches have been landed. Closing bug. 137775 2012-04-18 14:53:39 -0700 2012-04-20 11:13:06 -0700 Patch bug-84283-20120418145338.patch text/plain 4675 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDU2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA0LTE4ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBbd2luXSBVcGRhdGUgd2luZG93 cyBwbGF0Zm9ybSBjb2RlIHRvIHVzZSBwaXhlbCBzbmFwcGVkIHZhbHVlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQyODMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5n ZSBpbiBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5T2JqZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0OjpwaXhl bFNuYXBwZWRFbGVtZW50UmVjdCk6CisgICAgICAgIFVzZSBwaXhlbCBzbmFwcGVkIHZhbHVlcyB3 aGVuIGNvbXB1dGluZyBzY3JlZW5SZWN0LgorICAgICAgICAKKyAgICAgICAgKiBwbGF0Zm9ybS93 aW4vUG9wdXBNZW51V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTWVudVdpbjo6Y2Fs Y3VsYXRlUG9zaXRpb25BbmRTaXplKToKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTWVudVdpbjo6 cGFpbnQpOgorICAgICAgICBDYXN0IGNsaWVudCBwYWRkaW5nIHRvIGludHMgYXMgdGhleSBhcmUg Z3VhcmFudGVlZCB0byBhbGlnbiB3aXRoIGRldmljZSBwaXhlbHMuCisKIDIwMTItMDQtMTggIEx1 a2UgTWFjcGhlcnNvbiAgPG1hY3BoZXJzb25AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFByZXZl bnQgc3dpdGNoIGNhc2UgZmFsbHRocm91Z2ggaW4gU3R5bGVQcm9wZXJ0eVNldDo6Z2V0UHJvcGVy dHlWYWx1ZSgpLgpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5T2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5T2JqZWN0LmgJKHJldmlzaW9uIDExNDU1MCkKKysrIFNvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC01 MDYsNiArNTA2LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgTGF5b3V0UmVjdCBib3VuZGluZ0Jv eFJlY3QoKSBjb25zdCB7IHJldHVybiBMYXlvdXRSZWN0KCk7IH0KICAgICBJbnRSZWN0IHBpeGVs U25hcHBlZEJvdW5kaW5nQm94UmVjdCgpIGNvbnN0IHsgcmV0dXJuIHBpeGVsU25hcHBlZEludFJl Y3QoYm91bmRpbmdCb3hSZWN0KCkpOyB9CiAgICAgdmlydHVhbCBMYXlvdXRSZWN0IGVsZW1lbnRS ZWN0KCkgY29uc3QgPSAwOworICAgIEludFJlY3QgcGl4ZWxTbmFwcGVkRWxlbWVudFJlY3QoKSBj b25zdCB7IHJldHVybiBwaXhlbFNuYXBwZWRJbnRSZWN0KGVsZW1lbnRSZWN0KCkpOyB9CiAgICAg TGF5b3V0U2l6ZSBzaXplKCkgY29uc3QgeyByZXR1cm4gZWxlbWVudFJlY3QoKS5zaXplKCk7IH0K ICAgICBJbnRTaXplIHBpeGVsU25hcHBlZFNpemUoKSBjb25zdCB7IHJldHVybiBlbGVtZW50UmVj dCgpLnBpeGVsU25hcHBlZFNpemUoKTsgfQogICAgIHZpcnR1YWwgSW50UG9pbnQgY2xpY2tQb2lu dCgpOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1BvcHVwTWVudVdpbi5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1BvcHVwTWVudVdpbi5j cHAJKHJldmlzaW9uIDExNDU1MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Qb3B1 cE1lbnVXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNDEsNyArMzQxLDcgQEAgdm9pZCBQb3B1 cE1lbnVXaW46OmNhbGN1bGF0ZVBvc2l0aW9uQW5kUwogICAgICAgICBwb3B1cFdpZHRoICs9IFNj cm9sbGJhclRoZW1lOjp0aGVtZSgpLT5zY3JvbGxiYXJUaGlja25lc3MoU21hbGxTY3JvbGxiYXIp OwogCiAgICAgLy8gQWRkIHBhZGRpbmcgdG8gYWxpZ24gdGhlIHBvcHVwIHRleHQgd2l0aCB0aGUg PHNlbGVjdD4gdGV4dAotICAgIHBvcHVwV2lkdGggKz0gbWF4KDAsIGNsaWVudCgpLT5jbGllbnRQ YWRkaW5nUmlnaHQoKSAtIGNsaWVudCgpLT5jbGllbnRJbnNldFJpZ2h0KCkpICsgbWF4KDAsIGNs aWVudCgpLT5jbGllbnRQYWRkaW5nTGVmdCgpIC0gY2xpZW50KCktPmNsaWVudEluc2V0TGVmdCgp KTsKKyAgICBwb3B1cFdpZHRoICs9IG1heDxpbnQ+KDAsIGNsaWVudCgpLT5jbGllbnRQYWRkaW5n UmlnaHQoKSAtIGNsaWVudCgpLT5jbGllbnRJbnNldFJpZ2h0KCkpICsgbWF4PGludD4oMCwgY2xp ZW50KCktPmNsaWVudFBhZGRpbmdMZWZ0KCkgLSBjbGllbnQoKS0+Y2xpZW50SW5zZXRMZWZ0KCkp OwogCiAgICAgLy8gTGVhdmUgcm9vbSBmb3IgdGhlIGJvcmRlcgogICAgIHBvcHVwV2lkdGggKz0g MiAqIHBvcHVwV2luZG93Qm9yZGVyV2lkdGg7CkBAIC02NTMsNyArNjUzLDcgQEAgdm9pZCBQb3B1 cE1lbnVXaW46OnBhaW50KGNvbnN0IEludFJlY3QmIAogICAgICAgICAKICAgICAgICAgLy8gRHJh dyB0aGUgaXRlbSB0ZXh0CiAgICAgICAgIGlmIChpdGVtU3R5bGUuaXNWaXNpYmxlKCkpIHsKLSAg ICAgICAgICAgIGludCB0ZXh0WCA9IG1heCgwLCBjbGllbnQoKS0+Y2xpZW50UGFkZGluZ0xlZnQo KSAtIGNsaWVudCgpLT5jbGllbnRJbnNldExlZnQoKSk7CisgICAgICAgICAgICBpbnQgdGV4dFgg PSBtYXg8aW50PigwLCBjbGllbnQoKS0+Y2xpZW50UGFkZGluZ0xlZnQoKSAtIGNsaWVudCgpLT5j bGllbnRJbnNldExlZnQoKSk7CiAgICAgICAgICAgICBpZiAoUmVuZGVyVGhlbWU6OmRlZmF1bHRU aGVtZSgpLT5wb3B1cE9wdGlvblN1cHBvcnRzVGV4dEluZGVudCgpICYmIGl0ZW1TdHlsZS50ZXh0 RGlyZWN0aW9uKCkgPT0gTFRSKQogICAgICAgICAgICAgICAgIHRleHRYICs9IG1pbmltdW1WYWx1 ZUZvckxlbmd0aChpdGVtU3R5bGUudGV4dEluZGVudCgpLCBpdGVtUmVjdC53aWR0aCgpKTsKICAg ICAgICAgICAgIGludCB0ZXh0WSA9IGl0ZW1SZWN0LnkoKSArIGl0ZW1Gb250LmZvbnRNZXRyaWNz KCkuYXNjZW50KCkgKyAoaXRlbVJlY3QuaGVpZ2h0KCkgLSBpdGVtRm9udC5mb250TWV0cmljcygp LmhlaWdodCgpKSAvIDI7CkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTQ1NjQpCisr KyBTb3VyY2UvV2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MyBAQAorMjAxMi0wNC0xOCAgRW1pbCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgW3dpbl0gVXBkYXRlIHdpbmRvd3MgcGxhdGZvcm0gY29kZSB0byB1c2UgcGl4ZWwgc25h cHBlZCB2YWx1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg0MjgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBBY2Nlc3NpYmxlQmFzZS5jcHA6CisgICAgICAgIChBY2Nlc3NpYmxlQmFzZTo6YWNjTG9j YXRpb24pOgorCiAyMDEyLTA0LTE4ICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21h aWwuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERpc2FibGluZyBJbnNwZWN0b3IgY2F1 c2VzIGJ1aWxkIGZhaWx1cmUgb24gV2luZG93cwpJbmRleDogU291cmNlL1dlYktpdC93aW4vQWNj ZXNzaWJsZUJhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL0FjY2Vzc2li bGVCYXNlLmNwcAkocmV2aXNpb24gMTE0NTUwKQorKysgU291cmNlL1dlYktpdC93aW4vQWNjZXNz aWJsZUJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OTgsNyArNDk4LDcgQEAgSFJFU1VMVCBT VERNRVRIT0RDQUxMVFlQRSBBY2Nlc3NpYmxlQmFzZQogICAgIGlmICghY2hpbGRPYmotPmRvY3Vt ZW50RnJhbWVWaWV3KCkpCiAgICAgICAgIHJldHVybiBFX0ZBSUw7CiAKLSAgICBJbnRSZWN0IHNj cmVlblJlY3QoY2hpbGRPYmotPmRvY3VtZW50RnJhbWVWaWV3KCktPmNvbnRlbnRzVG9TY3JlZW4o Y2hpbGRPYmotPmVsZW1lbnRSZWN0KCkpKTsKKyAgICBJbnRSZWN0IHNjcmVlblJlY3QoY2hpbGRP YmotPmRvY3VtZW50RnJhbWVWaWV3KCktPmNvbnRlbnRzVG9TY3JlZW4oY2hpbGRPYmotPnBpeGVs U25hcHBlZEVsZW1lbnRSZWN0KCkpKTsKICAgICAqbGVmdCA9IHNjcmVlblJlY3QueCgpOwogICAg ICp0b3AgPSBzY3JlZW5SZWN0LnkoKTsKICAgICAqd2lkdGggPSBzY3JlZW5SZWN0LndpZHRoKCk7 Cg==