84264 2012-04-18 12:27:28 -0700 Add explicit template instantiation to chromium/PopupListBox.cpp to prepare for sub-pixel layout 2012-04-18 15:04:07 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric jchaffraix webkit.review.bot oldest_to_newest 604984 0 leviw 2012-04-18 12:27:28 -0700 Need to explicitly use integral min/max templates in this platform code to fix compilation. 605026 1 137752 leviw 2012-04-18 13:15:09 -0700 Created attachment 137752 Patch 605044 2 137752 eric 2012-04-18 13:39:50 -0700 Comment on attachment 137752 Patch OK. 605045 3 137752 leviw 2012-04-18 13:40:26 -0700 Comment on attachment 137752 Patch Thanks! 605136 4 137752 webkit.review.bot 2012-04-18 15:04:02 -0700 Comment on attachment 137752 Patch Clearing flags on attachment: 137752 Committed r114568: <http://trac.webkit.org/changeset/114568> 605137 5 webkit.review.bot 2012-04-18 15:04:07 -0700 All reviewed patches have been landed. Closing bug. 137752 2012-04-18 13:15:09 -0700 2012-04-18 15:04:02 -0700 Patch bug-84264-20120418131508.patch text/plain 3585 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDU0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTE4ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgZXhwbGljaXQgdGVt cGxhdGUgaW5zdGFudGlhdGlvbiB0byBjaHJvbWl1bS9Qb3B1cExpc3RCb3guY3BwIHRvIHByZXBh cmUgZm9yIHN1Yi1waXhlbCBsYXlvdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg0MjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRXhwbGljaXRseSBpbnN0YW50aWF0aW5nIGludGVnZXIgbWF4IGFuZCBt aW4gdGVtcGxhdGVzIHRvIGZpeCBjb21waWxhdGlvbiBpbiBDaHJvbWl1bS4gV2UKKyAgICAgICAg aW50ZW50aW9uYWxseSB0cnVuY2F0ZWQgdGhlc2UgdmFsdWVzIGluIHBsYXRmb3JtIGNvZGUsIHdo aWNoIG1hdGNoZXMgZWFybGllciBiZWhhdmlvci4KKyAgICAgICAgU2VlIGh0dHBzOi8vdHJhYy53 ZWJraXQub3JnL3dpa2kvTGF5b3V0VW5pdCBmb3IgZGV0YWlscy4KKworICAgICAgICBObyBuZXcg dGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9t aXVtL1BvcHVwTGlzdEJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQb3B1cExpc3RCb3g6OnBh aW50Um93KToKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTGlzdEJveDo6bGF5b3V0KToKKwogMjAx Mi0wNC0xOCAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4K IAogICAgICAgICBbUXRdIFdoZWVsRXZlbnRRdC5jcHAgc2hvdWxkIGJlIGRlbGV0ZWQuCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cExpc3RCb3guY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTGlzdEJveC5j cHAJKHJldmlzaW9uIDExNDUyMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L1BvcHVwTGlzdEJveC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1Myw5ICs0NTMsOSBAQCB2b2lk IFBvcHVwTGlzdEJveDo6cGFpbnRSb3coR3JhcGhpY3NDb250CiAgICAgaW50IHRleHRYID0gMDsK ICAgICBpbnQgbWF4V2lkdGggPSAwOwogICAgIGlmIChyaWdodEFsaWduZWQpCi0gICAgICAgIG1h eFdpZHRoID0gcm93UmVjdC53aWR0aCgpIC0gbWF4KDAsIG1fcG9wdXBDbGllbnQtPmNsaWVudFBh ZGRpbmdSaWdodCgpIC0gbV9wb3B1cENsaWVudC0+Y2xpZW50SW5zZXRSaWdodCgpKTsKKyAgICAg ICAgbWF4V2lkdGggPSByb3dSZWN0LndpZHRoKCkgLSBtYXg8aW50PigwLCBtX3BvcHVwQ2xpZW50 LT5jbGllbnRQYWRkaW5nUmlnaHQoKSAtIG1fcG9wdXBDbGllbnQtPmNsaWVudEluc2V0UmlnaHQo KSk7CiAgICAgZWxzZSB7Ci0gICAgICAgIHRleHRYID0gbWF4KDAsIG1fcG9wdXBDbGllbnQtPmNs aWVudFBhZGRpbmdMZWZ0KCkgLSBtX3BvcHVwQ2xpZW50LT5jbGllbnRJbnNldExlZnQoKSk7Cisg ICAgICAgIHRleHRYID0gbWF4PGludD4oMCwgbV9wb3B1cENsaWVudC0+Y2xpZW50UGFkZGluZ0xl ZnQoKSAtIG1fcG9wdXBDbGllbnQtPmNsaWVudEluc2V0TGVmdCgpKTsKICAgICAgICAgbWF4V2lk dGggPSByb3dSZWN0LndpZHRoKCkgLSB0ZXh0WDsKICAgICB9CiAgICAgLy8gUHJlcGFyZSB0ZXh0 IHRvIGJlIGRyYXduLgpAQCAtNDkxLDcgKzQ5MSw3IEBAIHZvaWQgUG9wdXBMaXN0Qm94OjpwYWlu dFJvdyhHcmFwaGljc0NvbnQKIAogICAgIC8vIFdlIGFyZSB1c2luZyB0aGUgbGVmdCBwYWRkaW5n IGFzIHRoZSByaWdodCBwYWRkaW5nIGluY2x1ZGVzIHJvb20gZm9yIHRoZSBzY3JvbGwtYmFyIHdo aWNoCiAgICAgLy8gZG9lcyBub3Qgc2hvdyBpbiB0aGlzIGNhc2UuCi0gICAgaW50IHJpZ2h0UGFk ZGluZyA9IG1heCgwLCBtX3BvcHVwQ2xpZW50LT5jbGllbnRQYWRkaW5nTGVmdCgpIC0gbV9wb3B1 cENsaWVudC0+Y2xpZW50SW5zZXRMZWZ0KCkpOworICAgIGludCByaWdodFBhZGRpbmcgPSBtYXg8 aW50PigwLCBtX3BvcHVwQ2xpZW50LT5jbGllbnRQYWRkaW5nTGVmdCgpIC0gbV9wb3B1cENsaWVu dC0+Y2xpZW50SW5zZXRMZWZ0KCkpOwogICAgIGludCByZW1haW5pbmdXaWR0aCA9IHJvd1JlY3Qu d2lkdGgoKSAtIHJpZ2h0UGFkZGluZzsKIAogICAgIC8vIERyYXcgdGhlIGljb24gaWYgYXBwbGlj YWJsZS4KQEAgLTUxOSw3ICs1MTksNyBAQCB2b2lkIFBvcHVwTGlzdEJveDo6cGFpbnRSb3coR3Jh cGhpY3NDb250CiAKICAgICBUZXh0UnVuIGxhYmVsVGV4dFJ1bihpdGVtTGFiZWwuY2hhcmFjdGVy cygpLCBpdGVtTGFiZWwubGVuZ3RoKCksIGZhbHNlLCAwLCAwLCBUZXh0UnVuOjpBbGxvd1RyYWls aW5nRXhwYW5zaW9uLCBzdHlsZS50ZXh0RGlyZWN0aW9uKCksIHN0eWxlLmhhc1RleHREaXJlY3Rp b25PdmVycmlkZSgpKTsKICAgICBpZiAocmlnaHRBbGlnbmVkKQotICAgICAgICB0ZXh0WCA9IG1h eCgwLCBtX3BvcHVwQ2xpZW50LT5jbGllbnRQYWRkaW5nTGVmdCgpIC0gbV9wb3B1cENsaWVudC0+ Y2xpZW50SW5zZXRMZWZ0KCkpOworICAgICAgICB0ZXh0WCA9IG1heDxpbnQ+KDAsIG1fcG9wdXBD bGllbnQtPmNsaWVudFBhZGRpbmdMZWZ0KCkgLSBtX3BvcHVwQ2xpZW50LT5jbGllbnRJbnNldExl ZnQoKSk7CiAgICAgZWxzZQogICAgICAgICB0ZXh0WCA9IHJlbWFpbmluZ1dpZHRoIC0gaXRlbUZv bnQud2lkdGgobGFiZWxUZXh0UnVuKTsKIApAQCAtODQ4LDkgKzg0OCw5IEBAIHZvaWQgUG9wdXBM aXN0Qm94OjpsYXlvdXQoKQogCiAgICAgICAgIGJhc2VXaWR0aCA9IG1heChiYXNlV2lkdGgsIHdp ZHRoKTsKICAgICAgICAgLy8gRklYTUU6IGh0dHA6Ly9iLzEyMTA0ODEgV2Ugc2hvdWxkIGdldCB0 aGUgcGFkZGluZyBvZiBpbmRpdmlkdWFsIG9wdGlvbiBlbGVtZW50cy4KLSAgICAgICAgcGFkZGlu Z1dpZHRoID0gbWF4KHBhZGRpbmdXaWR0aCwKKyAgICAgICAgcGFkZGluZ1dpZHRoID0gbWF4PGlu dD4ocGFkZGluZ1dpZHRoLAogICAgICAgICAgICAgbV9wb3B1cENsaWVudC0+Y2xpZW50UGFkZGlu Z0xlZnQoKSArIG1fcG9wdXBDbGllbnQtPmNsaWVudFBhZGRpbmdSaWdodCgpKTsKLSAgICAgICAg bGluZUVuZFBhZGRpbmdXaWR0aCA9IG1heChsaW5lRW5kUGFkZGluZ1dpZHRoLAorICAgICAgICBs aW5lRW5kUGFkZGluZ1dpZHRoID0gbWF4PGludD4obGluZUVuZFBhZGRpbmdXaWR0aCwKICAgICAg ICAgICAgIGlzUmlnaHRBbGlnbmVkID8gbV9wb3B1cENsaWVudC0+Y2xpZW50UGFkZGluZ0xlZnQo KSA6IG1fcG9wdXBDbGllbnQtPmNsaWVudFBhZGRpbmdSaWdodCgpKTsKICAgICB9CiAK