84116 2012-04-16 18:57:03 -0700 [Chromium] Move popup location detection code from WebViewImpl to WebPagePopupImpl 2012-04-16 20:43:09 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84007 1 tkent tkent haraken morrita webkit.review.bot oldest_to_newest 603674 0 tkent 2012-04-16 18:57:03 -0700 This is a preparation to fix Bug 84007. 603679 1 137457 tkent 2012-04-16 19:06:54 -0700 Created attachment 137457 Patch 603706 2 137457 haraken 2012-04-16 19:37:36 -0700 Comment on attachment 137457 Patch OK 603708 3 137457 tkent 2012-04-16 19:38:11 -0700 Comment on attachment 137457 Patch Thanks! 603749 4 137457 webkit.review.bot 2012-04-16 20:43:05 -0700 Comment on attachment 137457 Patch Clearing flags on attachment: 137457 Committed r114336: <http://trac.webkit.org/changeset/114336> 603750 5 webkit.review.bot 2012-04-16 20:43:09 -0700 All reviewed patches have been landed. Closing bug. 137457 2012-04-16 19:06:54 -0700 2012-04-16 20:43:04 -0700 Patch bug-84116-20120417110651.patch text/plain 5225 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGU0NjFjZGU1YmFhMWFhODMyN2MyNjc1ODZlN2YyYjA5NmIxZmNkZjMuLmEwMTY5YjliMWI1OWZi NWMwZDgwMjA5NTk3NGQwNmVlYmFlOTI5OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDQtMTYgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gTW92ZSBwb3B1cCBsb2NhdGlvbiBkZXRlY3Rpb24g Y29kZSBmcm9tIFdlYlZpZXdJbXBsIHRvIFdlYlBhZ2VQb3B1cEltcGwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MTE2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBtYWtlcyBubyBiZWhhdmlvciBj aGFuZ2UuIEp1c3QgbW92ZSBzb21lIGNvZGUuCisgICAgICAgIFRvIGZpeCBCdWcgODQwMDcsIFdl YlBhZ2VQb3B1cEltcGwgbmVlZHMgdG8ga25vdyBpZiB0aGUgcG9wdXAgaXMKKyAgICAgICAgYWJv dmUgdGhlIHRhcmdldCBlbGVtZW50IG9yIGJlbG93IHRoZSB0YXJnZXQgZWxlbWVudC4KKworICAg ICAgICAqIHNyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZVBvcHVwSW1wbDo6aW5pdCk6IE1vdmUgc29tZSBjb2RlIGZyb20gV2ViVmlld0ltcGw6Om9wZW5Q YWdlUG9wdXAoKS4KKyAgICAgICAgKiBzcmMvV2ViUGFnZVBvcHVwSW1wbC5oOgorICAgICAgICAo V2ViUGFnZVBvcHVwSW1wbCk6IFJlbmFtZSBhbiBhcmd1bWVudCBuYW1lLgorICAgICAgICAqIHNy Yy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpvcGVuUGFn ZVBvcHVwKTogTW92ZSBzb21lIGNvZGUgdG8gV2ViUGFnZVBvcHVwSW1wbDo6aW5pdCgpLgorCiAy MDEyLTA0LTE2ICBUZXJyeSBBbmRlcnNvbiAgPHRkYW5kZXJzb25AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFtjaHJvbWl1bV0gQWxsb3cgV2ViR2VzdHVyZUV2ZW50IHRvIHN0b3JlIGZvdXIgZmxv YXRpbmcgcG9pbnQgdmFsdWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJQYWdlUG9wdXBJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBh Z2VQb3B1cEltcGwuY3BwCmluZGV4IDBjMmNjNmRiYTZjMjJlODdhZmIyY2MwNGMzZDFhZjNmYTA1 MmJlODYuLjdmYjZmMzRlOWZmY2JiNDMzODA2M2JiMjhiOGUyNzBlZjdiMmJlNDAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBhZ2VQb3B1cEltcGwuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBhZ2VQb3B1cEltcGwuY3BwCkBAIC0zMSw2 ICszMSw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiV2ViUGFnZVBvcHVwSW1w bC5oIgogCisjaW5jbHVkZSAiQ2hyb21lLmgiCiAjaW5jbHVkZSAiRW1wdHlDbGllbnRzLmgiCiAj aW5jbHVkZSAiRmlsZUNob29zZXIuaCIKICNpbmNsdWRlICJGb2N1c0NvbnRyb2xsZXIuaCIKQEAg LTQ0LDkgKzQ1LDExIEBACiAjaW5jbHVkZSAiV2ViSW5wdXRFdmVudC5oIgogI2luY2x1ZGUgIldl YklucHV0RXZlbnRDb252ZXJzaW9uLmgiCiAjaW5jbHVkZSAiV2ViUGFnZVBvcHVwLmgiCisjaW5j bHVkZSAiV2ViVmlld0ltcGwuaCIKICNpbmNsdWRlICJXZWJXaWRnZXRDbGllbnQuaCIKIAogdXNp bmcgbmFtZXNwYWNlIFdlYkNvcmU7Cit1c2luZyBuYW1lc3BhY2Ugc3RkOwogCiBuYW1lc3BhY2Ug V2ViS2l0IHsKIApAQCAtMTMzLDEzICsxMzYsMjIgQEAgV2ViUGFnZVBvcHVwSW1wbDo6fldlYlBh Z2VQb3B1cEltcGwoKQogICAgIEFTU0VSVCghbV9wYWdlKTsKIH0KIAotYm9vbCBXZWJQYWdlUG9w dXBJbXBsOjppbml0KFdlYlZpZXdJbXBsKiB3ZWJWaWV3LCBQYWdlUG9wdXBDbGllbnQqIHBvcHVw Q2xpZW50LCBjb25zdCBJbnRSZWN0JiBib3VuZHNJblNjcmVlbikKK2Jvb2wgV2ViUGFnZVBvcHVw SW1wbDo6aW5pdChXZWJWaWV3SW1wbCogd2ViVmlldywgUGFnZVBvcHVwQ2xpZW50KiBwb3B1cENs aWVudCwgY29uc3QgSW50UmVjdCYgb3JpZ2luQm91bmRzSW5Sb290VmlldykKIHsKICAgICBBU1NF UlQod2ViVmlldyk7CiAgICAgQVNTRVJUKHBvcHVwQ2xpZW50KTsKICAgICBtX3dlYlZpZXcgPSB3 ZWJWaWV3OwogICAgIG1fcG9wdXBDbGllbnQgPSBwb3B1cENsaWVudDsKIAorICAgIFdlYlNpemUg cm9vdFZpZXdTaXplID0gd2ViVmlldy0+c2l6ZSgpOworICAgIEludFNpemUgcG9wdXBTaXplID0g cG9wdXBDbGllbnQtPmNvbnRlbnRTaXplKCk7CisgICAgSW50UmVjdCBwb3B1cEJvdW5kc0luUm9v dFZpZXcoSW50UG9pbnQobWF4KDAsIG9yaWdpbkJvdW5kc0luUm9vdFZpZXcueCgpKSwgbWF4KDAs IG9yaWdpbkJvdW5kc0luUm9vdFZpZXcubWF4WSgpKSksIHBvcHVwU2l6ZSk7CisgICAgaWYgKHBv cHVwQm91bmRzSW5Sb290Vmlldy5tYXhZKCkgPiByb290Vmlld1NpemUuaGVpZ2h0KQorICAgICAg ICBwb3B1cEJvdW5kc0luUm9vdFZpZXcuc2V0WShtYXgoMCwgb3JpZ2luQm91bmRzSW5Sb290Vmll dy55KCkgLSBwb3B1cFNpemUuaGVpZ2h0KCkpKTsKKyAgICBpZiAocG9wdXBCb3VuZHNJblJvb3RW aWV3Lm1heFgoKSA+IHJvb3RWaWV3U2l6ZS53aWR0aCkKKyAgICAgICAgcG9wdXBCb3VuZHNJblJv b3RWaWV3LnNldFgobWF4KDAsIHJvb3RWaWV3U2l6ZS53aWR0aCAtIHBvcHVwU2l6ZS53aWR0aCgp KSk7CisgICAgSW50UmVjdCBib3VuZHNJblNjcmVlbiA9IHdlYlZpZXctPnBhZ2UoKS0+Y2hyb21l KCktPnJvb3RWaWV3VG9TY3JlZW4ocG9wdXBCb3VuZHNJblJvb3RWaWV3KTsKKwogICAgIG1fd2lk Z2V0Q2xpZW50LT5zZXRXaW5kb3dSZWN0KGJvdW5kc0luU2NyZWVuKTsKICAgICBtX3dpbmRvd1Jl Y3RJblNjcmVlbiA9IGJvdW5kc0luU2NyZWVuOwogICAgIGlmICghaW5pdFBhZ2UoKSkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBhZ2VQb3B1cEltcGwuaCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBhZ2VQb3B1cEltcGwuaAppbmRleCAyNWFmY2I0 MWFkOGE1OTA1NGFjZTZjZThjYzlkYjJjNDJiNDQ5OTQzLi4zYjc3NmYxMmUwNmQ4YzFkNDdmNmQ0 MjM3MDQzMjllMTc3MTRiOTRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJQYWdlUG9wdXBJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi UGFnZVBvcHVwSW1wbC5oCkBAIC01Niw3ICs1Niw3IEBAIGNsYXNzIFdlYlBhZ2VQb3B1cEltcGwg OiBwdWJsaWMgV2ViUGFnZVBvcHVwLAogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogCiBw dWJsaWM6Ci0gICAgYm9vbCBpbml0KFdlYlZpZXdJbXBsKiwgV2ViQ29yZTo6UGFnZVBvcHVwQ2xp ZW50KiwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYgYm91bmRzSW5TY3JlZW4pOworICAgIGJvb2wg aW5pdChXZWJWaWV3SW1wbCosIFdlYkNvcmU6OlBhZ2VQb3B1cENsaWVudCosIGNvbnN0IFdlYkNv cmU6OkludFJlY3QmIG9yaWdpbkJvdW5kc0luUm9vdFZpZXcpOwogICAgIGJvb2wgaGFuZGxlS2V5 RXZlbnQoY29uc3QgV2ViQ29yZTo6UGxhdGZvcm1LZXlib2FyZEV2ZW50Jik7CiAgICAgdm9pZCBj bG9zZVBvcHVwKCk7CiAgICAgV2ViV2lkZ2V0Q2xpZW50KiB3aWRnZXRDbGllbnQoKSBjb25zdCB7 IHJldHVybiBtX3dpZGdldENsaWVudDsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwCmluZGV4IGMyYmJhZGI5ODAyYWM1MzM0MDliMWU2ZGZiMWIyMWRmOTFiZmFm YWUuLjY3YjBiMWNmNzNiNWMyMjQ0ODNhOTg1NDQzODE3MDAzMDczYjVmZjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTEyMDcsMTQgKzEyMDcsNyBA QCBQYWdlUG9wdXAqIFdlYlZpZXdJbXBsOjpvcGVuUGFnZVBvcHVwKFBhZ2VQb3B1cENsaWVudCog Y2xpZW50LCBjb25zdCBJbnRSZWN0JiBvcgogICAgIFdlYldpZGdldCogcG9wdXBXaWRnZXQgPSBt X2NsaWVudC0+Y3JlYXRlUG9wdXBNZW51KFdlYlBvcHVwVHlwZVBhZ2UpOwogICAgIEFTU0VSVChw b3B1cFdpZGdldCk7CiAgICAgbV9wYWdlUG9wdXAgPSBzdGF0aWNfY2FzdDxXZWJQYWdlUG9wdXBJ bXBsKj4ocG9wdXBXaWRnZXQpOwotICAgIFdlYlNpemUgcm9vdFZpZXdTaXplID0gc2l6ZSgpOwot ICAgIEludFNpemUgcG9wdXBTaXplID0gY2xpZW50LT5jb250ZW50U2l6ZSgpOwotICAgIEludFJl Y3QgcG9wdXBCb3VuZHNJblJvb3RWaWV3KEludFBvaW50KG1heCgwLCBvcmlnaW5Cb3VuZHNJblJv b3RWaWV3LngoKSksIG1heCgwLCBvcmlnaW5Cb3VuZHNJblJvb3RWaWV3Lm1heFkoKSkpLCBwb3B1 cFNpemUpOwotICAgIGlmIChwb3B1cEJvdW5kc0luUm9vdFZpZXcubWF4WSgpID4gcm9vdFZpZXdT aXplLmhlaWdodCkKLSAgICAgICAgcG9wdXBCb3VuZHNJblJvb3RWaWV3LnNldFkobWF4KDAsIG9y aWdpbkJvdW5kc0luUm9vdFZpZXcueSgpIC0gcG9wdXBTaXplLmhlaWdodCgpKSk7Ci0gICAgaWYg KHBvcHVwQm91bmRzSW5Sb290Vmlldy5tYXhYKCkgPiByb290Vmlld1NpemUud2lkdGgpCi0gICAg ICAgIHBvcHVwQm91bmRzSW5Sb290Vmlldy5zZXRYKG1heCgwLCByb290Vmlld1NpemUud2lkdGgg LSBwb3B1cFNpemUud2lkdGgoKSkpOwotICAgIGlmICghbV9wYWdlUG9wdXAtPmluaXQodGhpcywg Y2xpZW50LCBtX2Nocm9tZUNsaWVudEltcGwucm9vdFZpZXdUb1NjcmVlbihwb3B1cEJvdW5kc0lu Um9vdFZpZXcpKSkgeworICAgIGlmICghbV9wYWdlUG9wdXAtPmluaXQodGhpcywgY2xpZW50LCBv cmlnaW5Cb3VuZHNJblJvb3RWaWV3KSkgewogICAgICAgICBtX3BhZ2VQb3B1cC0+Y2xvc2VQb3B1 cCgpOwogICAgICAgICBtX3BhZ2VQb3B1cCA9IDA7CiAgICAgfQo=