<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>84077</bug_id>
          
          <creation_ts>2012-04-16 14:13:38 -0700</creation_ts>
          <short_desc>[Refactoring][V8] Remove $indent from NativeToJSValue()</short_desc>
          <delta_ts>2012-04-16 14:19:59 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore JavaScript</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>84074</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kentaro Hara">haraken</reporter>
          <assigned_to name="Kentaro Hara">haraken</assigned_to>
          <cc>abarth</cc>
    
    <cc>dglazkov</cc>
    
    <cc>japhet</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>603426</commentid>
    <comment_count>0</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-04-16 14:13:38 -0700</bug_when>
    <thetext>$indent in NativeToJSValue() in CodeGeneratorV8.pm is not used. We can remove it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>603433</commentid>
    <comment_count>1</comment_count>
      <attachid>137400</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-04-16 14:15:34 -0700</bug_when>
    <thetext>Created attachment 137400
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>603438</commentid>
    <comment_count>2</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-04-16 14:19:59 -0700</bug_when>
    <thetext>Committed r114298: &lt;http://trac.webkit.org/changeset/114298&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>137400</attachid>
            <date>2012-04-16 14:15:34 -0700</date>
            <delta_ts>2012-04-16 14:16:35 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-84077-20120416141533.patch</filename>
            <type>text/plain</type>
            <size>2084</size>
            <attacher name="Kentaro Hara">haraken</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0Mjk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWY5YWM0Zjg4ZmMzMTU3
NGNjNDhlMGI0YTg3Njc1ZmE4NzA5ZjMwOS4uYTVlNThjOTljZWMwY2U2MTAwZWMwMTkxMmNhNTdl
ZWEyY2VkZTBhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTE2ICBLZW50
YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jpbmdd
W1Y4XSBSZW1vdmUgJGluZGVudCBmcm9tIE5hdGl2ZVRvSlNWYWx1ZSgpCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDA3NworCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICRpbmRlbnQgaW4gTmF0aXZlVG9KU1Zh
bHVlKCkgaW4gQ29kZUdlbmVyYXRvclY4LnBtIGlzIG5vdCB1c2VkLgorICAgICAgICBUaGlzIHBh
dGNoIHJlbW92ZXMgaXQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVo
YXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToK
KyAgICAgICAgKEdlbmVyYXRlTm9ybWFsQXR0ckdldHRlcik6CisgICAgICAgIChHZW5lcmF0ZUZ1
bmN0aW9uQ2FsbFN0cmluZyk6CisgICAgICAgIChOYXRpdmVUb0pTVmFsdWUpOgorCiAyMDEyLTA0
LTE2ICBMdWl6IEFnb3N0aW5pICA8bHVpei5hZ29zdGluaUBwYWxtLmNvbT4KIAogICAgICAgICBt
YXRjaE1lZGlhKCkgTWVkaWFRdWVyeUxpc3Qgbm90IHVwZGF0aW5nCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1NvdXJjZS9X
ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4IGU5NjhhNzM1
OWI3MWE2MGY4NTgzMWE4NjRkM2I4Yzk5OTExMTNlM2UuLjA5ZGI4MDY3MmUwOWQ5N2U5MDBiZTcy
ZDdiODUyMDY3NTQ1ODlkNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj
cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj
cmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC05OTQsNyArOTk0LDcgQEAgRU5ECiAgICAgcmV0
dXJuIHZhbHVlOwogRU5ECiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBwdXNoKEBpbXBs
Q29udGVudERlY2xzLCAiICAgICIgLiBSZXR1cm5OYXRpdmVUb0pTVmFsdWUoJGF0dHJpYnV0ZS0+
c2lnbmF0dXJlLCAkcmVzdWx0LCAiICAgICIpLiI7XG4iKTsKKyAgICAgICAgICAgIHB1c2goQGlt
cGxDb250ZW50RGVjbHMsICIgICAgIiAuIFJldHVybk5hdGl2ZVRvSlNWYWx1ZSgkYXR0cmlidXRl
LT5zaWduYXR1cmUsICRyZXN1bHQpLiI7XG4iKTsKICAgICAgICAgfQogICAgIH0KIApAQCAtMzMw
Niw3ICszMzA2LDcgQEAgc3ViIEdlbmVyYXRlRnVuY3Rpb25DYWxsU3RyaW5nKCkKICAgICB9CiAK
ICAgICAkcmV0dXJuIC49ICIucmVsZWFzZSgpIiBpZiAoJHJldHVybklzUmVmKTsKLSAgICAkcmVz
dWx0IC49ICRpbmRlbnQgLiBSZXR1cm5OYXRpdmVUb0pTVmFsdWUoJGZ1bmN0aW9uLT5zaWduYXR1
cmUsICRyZXR1cm4sICRpbmRlbnQpIC4gIjtcbiI7CisgICAgJHJlc3VsdCAuPSAkaW5kZW50IC4g
UmV0dXJuTmF0aXZlVG9KU1ZhbHVlKCRmdW5jdGlvbi0+c2lnbmF0dXJlLCAkcmV0dXJuKSAuICI7
XG4iOwogCiAgICAgcmV0dXJuICRyZXN1bHQ7CiB9CkBAIC0zNzIzLDcgKzM3MjMsNiBAQCBzdWIg
TmF0aXZlVG9KU1ZhbHVlCiB7CiAgICAgbXkgJHNpZ25hdHVyZSA9IHNoaWZ0OwogICAgIG15ICR2
YWx1ZSA9IHNoaWZ0OwotICAgIG15ICRpbmRlbnQgPSBzaGlmdDsKICAgICBteSAkdHlwZSA9IEdl
dFR5cGVGcm9tU2lnbmF0dXJlKCRzaWduYXR1cmUpOwogCiAgICAgcmV0dXJuICJ2OEJvb2xlYW4o
JHZhbHVlKSIgaWYgJHR5cGUgZXEgImJvb2xlYW4iOwo=
</data>
<flag name="review"
          id="142432"
          type_id="1"
          status="+"
          setter="japhet"
    />
          </attachment>
      

    </bug>

</bugzilla>