83991 2012-04-14 18:56:19 -0700 WebCore::createWeekDayShortLabels() for ICU always returns the fallback labels 2012-04-15 23:12:26 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 53961 1 tkent tkent haraken morrita webkit.review.bot oldest_to_newest 602720 0 tkent 2012-04-14 18:56:19 -0700 WebCore::createWeekDayShortLabels() for ICU always returns the fallback labels 602886 1 137275 tkent 2012-04-15 21:25:08 -0700 Created attachment 137275 Patch 602906 2 137275 tkent 2012-04-15 23:01:27 -0700 Comment on attachment 137275 Patch Thank you! 602908 3 137275 webkit.review.bot 2012-04-15 23:12:21 -0700 Comment on attachment 137275 Patch Clearing flags on attachment: 137275 Committed r114224: <http://trac.webkit.org/changeset/114224> 602909 4 webkit.review.bot 2012-04-15 23:12:26 -0700 All reviewed patches have been landed. Closing bug. 137275 2012-04-15 21:25:08 -0700 2012-04-15 23:12:21 -0700 Patch bug-83991-20120416132506.patch text/plain 3837 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmY1ZDExYjNkNDgwYmQ1 ZDEwOWNhMTQ4MjM2YWU0YTk3Yzg1MTM2ZS4uZDEzMWVjMmQ5MzUwYmNmZDkxMzU1NDkzY2YzZWQx OWFjMjA1MTkyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTE1ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWJDb3JlOjp3ZWVrRGF5 U2hvcnRMYWJlbHMoKSBmb3IgSUNVIGFsd2F5cyByZXR1cm5zIHRoZSBmYWxsYmFjayBsYWJlbHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzOTkxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0 byBzcGVjZml5IDEtYmFzZWQgaW5kZXggdG8gdWRhdF9nZXRTeW1ib2xzKCkgd2l0aAorICAgICAg ICBVREFUX1NIT1JUX1dFRUtEQVlTLiBBbHNvLCB1ZGF0X2NvdW50U3ltYm9scygpIHdpdGggVURB VF9TSE9SVF9XRUVLREFZUworICAgICAgICByZXR1cm5zIDguCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIGJlY2F1c2UgdGhpcyBiZWhhdmlvciBkZXBlbmRzIG9uIGxvY2FsZSBzZXR0aW5nLgorCisg ICAgICAgICogcGxhdGZvcm0vdGV4dC9Mb2NhbGl6ZWRDYWxlbmRhcklDVS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpjcmVhdGVMYWJlbFZlY3Rvcik6IEFkZCBzdGFydEluZGV4IGFyZ3VtZW50Lgor ICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlTW9udGhMYWJlbHMpOgorICAgICAgICBQYXNzIFVEQVRf SkFOVUFSUlkoMCkgYXMgc3RhcnRJbmRleCB0byBjcmVhdGVMYWJlbFZlY3RvcigpLgorICAgICAg ICAoV2ViQ29yZTo6Y3JlYXRlV2Vla0RheVNob3J0TGFiZWxzKToKKyAgICAgICAgUGFzcyBVREFU X1NVTkRBWSgxKSBhcyBzdGFydEluZGV4IHRvIGNyZWF0ZUxhYmVsVmVjdG9yKCkuCisKIDIwMTIt MDQtMTQgIEVtaWwgQSBFa2x1bmQgIDxlYWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCBw aXhlbFNuYXBwaW5nIGZvciBDYWxlbmRhclBpY2tlciwgTWVkaWFDb250cm9sIGFuZCBTY3JvbGxi YXJQYXJ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsaXpl ZENhbGVuZGFySUNVLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxpemVk Q2FsZW5kYXJJQ1UuY3BwCmluZGV4IDQ1M2E5Y2E1YjU2YTQwYTIxOWM4OGQzNDcyNDA5YTEzMTg5 MDAyZGYuLmMzY2JhMzBmZDdjYTU4MzJlZjljYmJmMmFhYmM1MDI0YzI5MDZjMDQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxpemVkQ2FsZW5kYXJJQ1UuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxpemVkQ2FsZW5kYXJJQ1Uu Y3BwCkBAIC03OSwyNCArNzksMjQgQEAgc3RhdGljIFBhc3NPd25QdHI8VmVjdG9yPFN0cmluZz4g PiBjcmVhdGVGYWxsYmFja01vbnRoTGFiZWxzKCkKICAgICByZXR1cm4gbGFiZWxzLnJlbGVhc2Uo KTsKIH0KIAotc3RhdGljIFBhc3NPd25QdHI8VmVjdG9yPFN0cmluZz4gPiBjcmVhdGVMYWJlbFZl Y3RvcihVRGF0ZUZvcm1hdFN5bWJvbFR5cGUgdHlwZSwgaW50MzJfdCBzaXplKQorc3RhdGljIFBh c3NPd25QdHI8VmVjdG9yPFN0cmluZz4gPiBjcmVhdGVMYWJlbFZlY3RvcihVRGF0ZUZvcm1hdFN5 bWJvbFR5cGUgdHlwZSwgaW50MzJfdCBzdGFydEluZGV4LCBpbnQzMl90IHNpemUpCiB7CiAgICAg U2NvcGVkRGF0ZUZvcm1hdCBkYXRlRm9ybWF0OwogICAgIGlmICghZGF0ZUZvcm1hdC5nZXQoKSkK ICAgICAgICAgcmV0dXJuIFBhc3NPd25QdHI8VmVjdG9yPFN0cmluZz4gPigpOwotICAgIGlmICh1 ZGF0X2NvdW50U3ltYm9scyhkYXRlRm9ybWF0LmdldCgpLCB0eXBlKSAhPSBzaXplKQorICAgIGlm ICh1ZGF0X2NvdW50U3ltYm9scyhkYXRlRm9ybWF0LmdldCgpLCB0eXBlKSAhPSBzdGFydEluZGV4 ICsgc2l6ZSkKICAgICAgICAgcmV0dXJuIFBhc3NPd25QdHI8VmVjdG9yPFN0cmluZz4gPigpOwog CiAgICAgT3duUHRyPFZlY3RvcjxTdHJpbmc+ID4gbGFiZWxzID0gYWRvcHRQdHIobmV3IFZlY3Rv cjxTdHJpbmc+KCkpOwogICAgIGxhYmVscy0+cmVzZXJ2ZUNhcGFjaXR5KHNpemUpOwogICAgIGZv ciAoaW50MzJfdCBpID0gMDsgaSA8IHNpemU7ICsraSkgewogICAgICAgICBVRXJyb3JDb2RlIHN0 YXR1cyA9IFVfWkVST19FUlJPUjsKLSAgICAgICAgaW50MzJfdCBsZW5ndGggPSB1ZGF0X2dldFN5 bWJvbHMoZGF0ZUZvcm1hdC5nZXQoKSwgdHlwZSwgaSwgMCwgMCwgJnN0YXR1cyk7CisgICAgICAg IGludDMyX3QgbGVuZ3RoID0gdWRhdF9nZXRTeW1ib2xzKGRhdGVGb3JtYXQuZ2V0KCksIHR5cGUs IHN0YXJ0SW5kZXggKyBpLCAwLCAwLCAmc3RhdHVzKTsKICAgICAgICAgaWYgKHN0YXR1cyAhPSBV X0JVRkZFUl9PVkVSRkxPV19FUlJPUikKICAgICAgICAgICAgIHJldHVybiBQYXNzT3duUHRyPFZl Y3RvcjxTdHJpbmc+ID4oKTsKICAgICAgICAgVmVjdG9yPFVDaGFyPiBidWZmZXIobGVuZ3RoKTsK ICAgICAgICAgc3RhdHVzID0gVV9aRVJPX0VSUk9SOwotICAgICAgICB1ZGF0X2dldFN5bWJvbHMo ZGF0ZUZvcm1hdC5nZXQoKSwgdHlwZSwgaSwgYnVmZmVyLmRhdGEoKSwgbGVuZ3RoLCAmc3RhdHVz KTsKKyAgICAgICAgdWRhdF9nZXRTeW1ib2xzKGRhdGVGb3JtYXQuZ2V0KCksIHR5cGUsIHN0YXJ0 SW5kZXggKyBpLCBidWZmZXIuZGF0YSgpLCBsZW5ndGgsICZzdGF0dXMpOwogICAgICAgICBpZiAo VV9GQUlMVVJFKHN0YXR1cykpCiAgICAgICAgICAgICByZXR1cm4gUGFzc093blB0cjxWZWN0b3I8 U3RyaW5nPiA+KCk7CiAgICAgICAgIGxhYmVscy0+YXBwZW5kKFN0cmluZzo6YWRvcHQoYnVmZmVy KSk7CkBAIC0xMDYsNyArMTA2LDcgQEAgc3RhdGljIFBhc3NPd25QdHI8VmVjdG9yPFN0cmluZz4g PiBjcmVhdGVMYWJlbFZlY3RvcihVRGF0ZUZvcm1hdFN5bWJvbFR5cGUgdHlwZSwKIAogc3RhdGlj IFBhc3NPd25QdHI8VmVjdG9yPFN0cmluZz4gPiBjcmVhdGVNb250aExhYmVscygpCiB7Ci0gICAg T3duUHRyPFZlY3RvcjxTdHJpbmc+ID4gbGFiZWxzID0gY3JlYXRlTGFiZWxWZWN0b3IoVURBVF9N T05USFMsIDEyKTsKKyAgICBPd25QdHI8VmVjdG9yPFN0cmluZz4gPiBsYWJlbHMgPSBjcmVhdGVM YWJlbFZlY3RvcihVREFUX01PTlRIUywgVUNBTF9KQU5VQVJZLCAxMik7CiAgICAgcmV0dXJuIGxh YmVscyA/IGxhYmVscy5yZWxlYXNlKCkgOiBjcmVhdGVGYWxsYmFja01vbnRoTGFiZWxzKCk7CiB9 CiAKQEAgLTEzMiw3ICsxMzIsNyBAQCBzdGF0aWMgUGFzc093blB0cjxWZWN0b3I8U3RyaW5nPiA+ IGNyZWF0ZUZhbGxiYWNrV2Vla0RheVNob3J0TGFiZWxzKCkKIAogc3RhdGljIFBhc3NPd25QdHI8 VmVjdG9yPFN0cmluZz4gPiBjcmVhdGVXZWVrRGF5U2hvcnRMYWJlbHMoKQogewotICAgIE93blB0 cjxWZWN0b3I8U3RyaW5nPiA+IGxhYmVscyA9IGNyZWF0ZUxhYmVsVmVjdG9yKFVEQVRfU0hPUlRf V0VFS0RBWVMsIDcpOworICAgIE93blB0cjxWZWN0b3I8U3RyaW5nPiA+IGxhYmVscyA9IGNyZWF0 ZUxhYmVsVmVjdG9yKFVEQVRfU0hPUlRfV0VFS0RBWVMsIFVDQUxfU1VOREFZLCA3KTsKICAgICBy ZXR1cm4gbGFiZWxzID8gbGFiZWxzLnJlbGVhc2UoKSA6IGNyZWF0ZUZhbGxiYWNrV2Vla0RheVNo b3J0TGFiZWxzKCk7CiB9CiAK