83859 2012-04-12 22:16:19 -0700 LocalizedDateICU should ignore timezones 2012-04-12 23:07:59 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Major --- 83852 1 tkent tkent haraken morrita oldest_to_newest 601824 0 tkent 2012-04-12 22:16:19 -0700 LocalizedDateICU should ignore timezones 601825 1 137038 tkent 2012-04-12 22:20:12 -0700 Created attachment 137038 Patch 601826 2 tkent 2012-04-12 22:26:05 -0700 This is a root cause of fast/forms/date-input-visible-string.html failure. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fforms%2Fdate%2Fdate-input-visible-string 601838 3 137038 morrita 2012-04-12 22:51:46 -0700 Comment on attachment 137038 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137038&action=review Looks good. Picked a few nits. > Source/WebCore/platform/text/LocalizedDateICU.cpp:48 > + const UChar gmtTimezone[3] = {'G', 'M', 'T'}; Don't we need L prefix for each char? > Source/WebCore/platform/text/LocalizedDateICU.cpp:50 > + return udat_open(UDAT_NONE, UDAT_SHORT, defaultLanguage().utf8().data(), gmtTimezone, 3, 0, -1, &status); We could use WTF_ARRAY_LENGTH? 601839 4 tkent 2012-04-12 22:53:45 -0700 Thanks. (In reply to comment #3) > > Source/WebCore/platform/text/LocalizedDateICU.cpp:48 > > + const UChar gmtTimezone[3] = {'G', 'M', 'T'}; > > Don't we need L prefix for each char? No. UChar is not always wchar_t. > > Source/WebCore/platform/text/LocalizedDateICU.cpp:50 > > + return udat_open(UDAT_NONE, UDAT_SHORT, defaultLanguage().utf8().data(), gmtTimezone, 3, 0, -1, &status); > > We could use WTF_ARRAY_LENGTH? Yes. will do. 601846 5 tkent 2012-04-12 23:07:59 -0700 Committed r114085: <http://trac.webkit.org/changeset/114085> 137038 2012-04-12 22:20:12 -0700 2012-04-12 22:51:45 -0700 Patch bug-83859-20120413142010.patch text/plain 3498 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjJjOTNmMGU2NjAwZjZl MTY3ZTVjOGQ5OGNmOWE5YzAzNjQwNjI2My4uNzYxMTBmZjZjYzA1NzJjMTNlMzQ5NjI0Y2UxMzkw YTc5YmI3MWUyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTEyICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBMb2NhbGl6ZWREYXRlSUNV IHNob3VsZCBpZ25vcmUgdGltZXpvbmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04Mzg1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIHVkYXRfcGFyc2UoKSBhbmQgdWRhdF9mb3JtYXQoKSBzaGlmdCB0aGUg aW5wdXQgZGF0ZSBieSB0aGUgb2Zmc2V0IG9mIHRoZQorICAgICAgICBkZWZhdWx0IHRpbWV6b25l LiBXZSBkb24ndCBuZWVkIHRoaXMgYmVoYXZpb3IgZm9yIHR5cGU9ZGF0ZS4gU28gd2UKKyAgICAg ICAgc3BlY2lmeSAiR01UIiB0byB1ZGF0X29wZW4oKS4KKworICAgICAgICBObyBuZXcgdGVzdHMu IFRoaXMgYmVoYXZpb3IgZGVwZW5kcyBvbiB0aGUgdGltZXpvbmUgc2V0dGluZyBvZiB0aGUgbG9j YWwgbWFjaGluZS4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvTG9jYWxpemVkRGF0ZUlDVS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVTaG9ydERhdGVGb3JtYXR0ZXIpOgorICAgICAg ICBBZGRlZC4gQ29tbW9uIGZhY3RvcnkgZnVuY3RpbyBmb3IgVURhdGVGb3JtYXQuIFVzZSAiR01U IiBpbnN0ZWFkIG9mIHRoZQorICAgICAgICBkZWZhdWx0IHRpbWV6b25lLgorICAgICAgICAoV2Vi Q29yZTo6cGFyc2VMb2NhbGl6ZWREYXRlKTogVXNlIGNyZWF0ZVNob3J0RGF0ZUZvcm1hdHRlcigp LgorICAgICAgICAoV2ViQ29yZTo6Zm9ybWF0TG9jYWxpemVkRGF0ZSk6IGRpdHRvLgorCiAyMDEy LTA0LTEyICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg W2Nocm9taXVtXVtyZWZhY3RvcmluZ10gbWVyZ2UgQ0NTaW5nbGVUaHJlYWRQcm94eTo6e2NvbW1p dElmTmVlZGVkLGRvQ29tcG9zaXRlfSBpbnRvIGNvbW1pdEFuZENvbXBvc2l0ZSgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsaXplZERhdGVJQ1UuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGl6ZWREYXRlSUNVLmNwcAppbmRleCAx Mjg5NWQzODVkZDA4MmNiNWQxZDliNDdjOTk2ZGY3ODBhZDhhODllLi4zMTQwZWZhMGExNDcxYzgw NDVjZDQyZGM4M2RlNDU1YzliNjNhZjMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS90ZXh0L0xvY2FsaXplZERhdGVJQ1UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3RleHQvTG9jYWxpemVkRGF0ZUlDVS5jcHAKQEAgLTQzLDYgKzQzLDEzIEBAIHVzaW5nIG5h bWVzcGFjZSBzdGQ7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorc3RhdGljIGlubGluZSBVRGF0 ZUZvcm1hdCogY3JlYXRlU2hvcnREYXRlRm9ybWF0dGVyKCkKK3sKKyAgICBjb25zdCBVQ2hhciBn bXRUaW1lem9uZVszXSA9IHsnRycsICdNJywgJ1QnfTsKKyAgICBVRXJyb3JDb2RlIHN0YXR1cyA9 IFVfWkVST19FUlJPUjsKKyAgICByZXR1cm4gdWRhdF9vcGVuKFVEQVRfTk9ORSwgVURBVF9TSE9S VCwgZGVmYXVsdExhbmd1YWdlKCkudXRmOCgpLmRhdGEoKSwgZ210VGltZXpvbmUsIDMsIDAsIC0x LCAmc3RhdHVzKTsKK30KKwogZG91YmxlIHBhcnNlTG9jYWxpemVkRGF0ZShjb25zdCBTdHJpbmcm IGlucHV0LCBEYXRlQ29tcG9uZW50czo6VHlwZSB0eXBlKQogewogICAgIHN3aXRjaCAodHlwZSkg ewpAQCAtNTAsMTEgKzU3LDEwIEBAIGRvdWJsZSBwYXJzZUxvY2FsaXplZERhdGUoY29uc3QgU3Ry aW5nJiBpbnB1dCwgRGF0ZUNvbXBvbmVudHM6OlR5cGUgdHlwZSkKICAgICAgICAgaWYgKGlucHV0 Lmxlbmd0aCgpID4gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KG51bWVyaWNfbGltaXRzPGludDMyX3Q+ OjptYXgoKSkpCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgaW50MzJfdCBpbnB1dExlbmd0 aCA9IHN0YXRpY19jYXN0PGludDMyX3Q+KGlucHV0Lmxlbmd0aCgpKTsKLSAgICAgICAgVUVycm9y Q29kZSBzdGF0dXMgPSBVX1pFUk9fRVJST1I7Ci0gICAgICAgIFVEYXRlRm9ybWF0KiBkYXRlRm9y bWF0ID0gdWRhdF9vcGVuKFVEQVRfTk9ORSwgVURBVF9TSE9SVCwgZGVmYXVsdExhbmd1YWdlKCku dXRmOCgpLmRhdGEoKSwgMCwgLTEsIDAsIC0xLCAmc3RhdHVzKTsKKyAgICAgICAgVURhdGVGb3Jt YXQqIGRhdGVGb3JtYXQgPSBjcmVhdGVTaG9ydERhdGVGb3JtYXR0ZXIoKTsKICAgICAgICAgaWYg KCFkYXRlRm9ybWF0KQogICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIHN0YXR1cyA9IFVfWkVS T19FUlJPUjsKKyAgICAgICAgVUVycm9yQ29kZSBzdGF0dXMgPSBVX1pFUk9fRVJST1I7CiAgICAg ICAgIGludDMyX3QgcGFyc2VQb3NpdGlvbiA9IDA7CiAgICAgICAgIFVEYXRlIGRhdGUgPSB1ZGF0 X3BhcnNlKGRhdGVGb3JtYXQsIGlucHV0LmNoYXJhY3RlcnMoKSwgaW5wdXRMZW5ndGgsICZwYXJz ZVBvc2l0aW9uLCAmc3RhdHVzKTsKICAgICAgICAgdWRhdF9jbG9zZShkYXRlRm9ybWF0KTsKQEAg LTc4LDExICs4NCwxMSBAQCBTdHJpbmcgZm9ybWF0TG9jYWxpemVkRGF0ZShjb25zdCBEYXRlQ29t cG9uZW50cyYgZGF0ZUNvbXBvbmVudHMpCiB7CiAgICAgc3dpdGNoIChkYXRlQ29tcG9uZW50cy50 eXBlKCkpIHsKICAgICBjYXNlIERhdGVDb21wb25lbnRzOjpEYXRlOiB7Ci0gICAgICAgIFVFcnJv ckNvZGUgc3RhdHVzID0gVV9aRVJPX0VSUk9SOwotICAgICAgICBVRGF0ZUZvcm1hdCogZGF0ZUZv cm1hdCA9IHVkYXRfb3BlbihVREFUX05PTkUsIFVEQVRfU0hPUlQsIGRlZmF1bHRMYW5ndWFnZSgp LnV0ZjgoKS5kYXRhKCksIDAsIC0xLCAwLCAtMSwgJnN0YXR1cyk7CisgICAgICAgIFVEYXRlRm9y bWF0KiBkYXRlRm9ybWF0ID0gY3JlYXRlU2hvcnREYXRlRm9ybWF0dGVyKCk7CiAgICAgICAgIGlm ICghZGF0ZUZvcm1hdCkKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBkb3VibGUgaW5wdXQg PSBkYXRlQ29tcG9uZW50cy5taWxsaXNlY29uZHNTaW5jZUVwb2NoKCk7CisgICAgICAgIFVFcnJv ckNvZGUgc3RhdHVzID0gVV9aRVJPX0VSUk9SOwogICAgICAgICBpbnQzMl90IGxlbmd0aCA9IHVk YXRfZm9ybWF0KGRhdGVGb3JtYXQsIGlucHV0LCAwLCAwLCAwLCAmc3RhdHVzKTsKICAgICAgICAg aWYgKHN0YXR1cyAhPSBVX0JVRkZFUl9PVkVSRkxPV19FUlJPUikgewogICAgICAgICAgICAgdWRh dF9jbG9zZShkYXRlRm9ybWF0KTsK