83157 2012-04-04 06:35:09 -0700 RenderTable should layout captions using LayoutUnits 2012-04-05 04:57:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 83089 P2 Normal --- 60318 1 leviw leviw eae eric jchaffraix webkit.review.bot oldest_to_newest 595487 0 leviw 2012-04-04 06:35:09 -0700 Currently it's still using integers (yuck!) 595501 1 135582 leviw 2012-04-04 06:50:01 -0700 Created attachment 135582 Patch 596466 2 135582 leviw 2012-04-05 04:19:23 -0700 Comment on attachment 135582 Patch Thanks! 596484 3 135582 webkit.review.bot 2012-04-05 04:52:17 -0700 Comment on attachment 135582 Patch Rejecting attachment 135582 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/RenderTable.cpp Hunk #1 FAILED at 282. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderTable.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Julien Cha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12340280 596488 4 leviw 2012-04-05 04:57:25 -0700 Appears that Emil and I are stepping on each others toes :-/ *** This bug has been marked as a duplicate of bug 83089 *** 135582 2012-04-04 06:50:01 -0700 2012-04-05 04:52:17 -0700 Patch bug-83157-20120404154956.patch text/plain 2567 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzE4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTA0ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5kZXJUYWJsZSBzaG91 bGQgbGF5b3V0IGNhcHRpb25zIHVzaW5nIExheW91dFVuaXRzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzE1NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmRlclRhYmxlIGlzIHJlc3BvbnNpYmxlIGZv ciBsYXlpbmcgb3V0IGl0cyBjYXB0aW9ucy4gVGhpcyBwYXRjaCBzd2l0Y2hlcyB0aGUgc3RvcmFn ZSBvZiBSZW5kZXJDYXB0aW9uCisgICAgICAgIGxheW91dCB2YWx1ZXMgZnJvbSBpbnRlZ2VycyB0 byBMYXlvdXRVbml0cyBzbyBzdWItcGl4ZWwgdmFsdWVzIGFyZSBwcmVzZXJ2ZWQuIEFsc28gY2xl YW5pbmcgdXAgdXNhZ2Ugb2YKKyAgICAgICAgZGVjb21wb3NlZCBvZmZzZXQgdmFsdWVzIHdpdGgg YSBzaW5nbGUgY2FsbCB0byBmcmFtZVJlY3QuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBj aGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGUuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGU6OmxheW91dENhcHRpb24pOgorCiAyMDEy LTA0LTA0ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgog CiAgICAgICAgIEJlc3Qgem9vbWFibGUgYXJlYSBkb2VzIG5vdCBiYWxhbmNlIGludGVyc2VjdGlv biB3aXRoIHRhcmdldCBhcmVhLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRhYmxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGFibGUuY3BwCShyZXZpc2lvbiAxMTMxNjEpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGFibGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODIsMTcgKzI4MiwxNyBAQCBMYXlv dXRVbml0IFJlbmRlclRhYmxlOjpjb252ZXJ0U3R5bGVMb2dpCiAKIHZvaWQgUmVuZGVyVGFibGU6 OmxheW91dENhcHRpb24oUmVuZGVyVGFibGVDYXB0aW9uKiBjYXB0aW9uKQogewotICAgIEludFJl Y3QgY2FwdGlvblJlY3QoY2FwdGlvbi0+eCgpLCBjYXB0aW9uLT55KCksIGNhcHRpb24tPndpZHRo KCksIGNhcHRpb24tPmhlaWdodCgpKTsKKyAgICBMYXlvdXRSZWN0IGNhcHRpb25SZWN0KGNhcHRp b24tPmZyYW1lUmVjdCgpKTsKIAogICAgIGlmIChjYXB0aW9uLT5uZWVkc0xheW91dCgpKSB7CiAg ICAgICAgIC8vIFRoZSBtYXJnaW5zIG1heSBub3QgYmUgYXZhaWxhYmxlIGJ1dCBlbnN1cmUgdGhl IGNhcHRpb24gaXMgYXQgbGVhc3QgbG9jYXRlZCBiZW5lYXRoIGFueSBwcmV2aW91cyBzaWJsaW5n IGNhcHRpb24KICAgICAgICAgLy8gc28gdGhhdCBpdCBkb2VzIG5vdCBtaXN0YWtlbmx5IHRoaW5r IGFueSBmbG9hdHMgaW4gdGhlIHByZXZpb3VzIGNhcHRpb24gaW50cnVkZSBpbnRvIGl0LgotICAg ICAgICBjYXB0aW9uLT5zZXRMb2dpY2FsTG9jYXRpb24oSW50UG9pbnQoY2FwdGlvbi0+bWFyZ2lu U3RhcnQoKSwgY2FwdGlvbi0+bWFyZ2luQmVmb3JlKCkgKyBsb2dpY2FsSGVpZ2h0KCkpKTsKKyAg ICAgICAgY2FwdGlvbi0+c2V0TG9naWNhbExvY2F0aW9uKExheW91dFBvaW50KGNhcHRpb24tPm1h cmdpblN0YXJ0KCksIGNhcHRpb24tPm1hcmdpbkJlZm9yZSgpICsgbG9naWNhbEhlaWdodCgpKSk7 CiAgICAgICAgIC8vIElmIFJlbmRlclRhYmxlQ2FwdGlvbiBldmVyIGdldHMgYSBsYXlvdXQoKSBm dW5jdGlvbiwgdXNlIGl0IGhlcmUuCiAgICAgICAgIGNhcHRpb24tPmxheW91dElmTmVlZGVkKCk7 CiAgICAgfQogICAgIC8vIEFwcGx5IHRoZSBtYXJnaW5zIHRvIHRoZSBsb2NhdGlvbiBub3cgdGhh dCB0aGV5IGFyZSBkZWZpbml0ZWx5IGF2YWlsYWJsZSBmcm9tIGxheW91dAotICAgIGNhcHRpb24t PnNldExvZ2ljYWxMb2NhdGlvbihJbnRQb2ludChjYXB0aW9uLT5tYXJnaW5TdGFydCgpLCBjYXB0 aW9uLT5tYXJnaW5CZWZvcmUoKSArIGxvZ2ljYWxIZWlnaHQoKSkpOworICAgIGNhcHRpb24tPnNl dExvZ2ljYWxMb2NhdGlvbihMYXlvdXRQb2ludChjYXB0aW9uLT5tYXJnaW5TdGFydCgpLCBjYXB0 aW9uLT5tYXJnaW5CZWZvcmUoKSArIGxvZ2ljYWxIZWlnaHQoKSkpOwogCiAgICAgaWYgKCFzZWxm TmVlZHNMYXlvdXQoKSAmJiBjYXB0aW9uLT5jaGVja0ZvclJlcGFpbnREdXJpbmdMYXlvdXQoKSkK ICAgICAgICAgY2FwdGlvbi0+cmVwYWludER1cmluZ0xheW91dElmTW92ZWQoY2FwdGlvblJlY3Qp Owo=