83154 2012-04-04 06:15:18 -0700 Correct LayoutUnit usage in style functions adjustRectForShadow and getRoundedBorderFor 2012-04-09 11:10:22 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric jchaffraix webkit.review.bot oldest_to_newest 595474 0 leviw 2012-04-04 06:15:18 -0700 adjustRectForShadow needs to adjust a LayoutRect since it's used to adjust repaint rects and such, while getRoundedBorderFor returns a pixel snapped RoundedRect. 595485 1 135578 leviw 2012-04-04 06:28:38 -0700 Created attachment 135578 Patch 597443 2 135578 leviw 2012-04-06 10:14:02 -0700 Comment on attachment 135578 Patch Thanks! 597460 3 135578 webkit.review.bot 2012-04-06 10:30:41 -0700 Comment on attachment 135578 Patch Rejecting attachment 135578 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Core/rendering/style/ShadowData.cpp Hunk #1 FAILED at 68. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/style/ShadowData.cpp.rej patching file Source/WebCore/rendering/style/ShadowData.h Hunk #1 FAILED at 79. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/style/ShadowData.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Julien Cha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12264970 598357 4 136244 leviw 2012-04-09 09:56:26 -0700 Created attachment 136244 Patch for landing 598440 5 136244 webkit.review.bot 2012-04-09 11:10:17 -0700 Comment on attachment 136244 Patch for landing Clearing flags on attachment: 136244 Committed r113594: <http://trac.webkit.org/changeset/113594> 598441 6 webkit.review.bot 2012-04-09 11:10:22 -0700 All reviewed patches have been landed. Closing bug. 135578 2012-04-04 06:28:38 -0700 2012-04-09 09:56:22 -0700 Patch bug-83154-20120404152828.patch text/plain 4413 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzE4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA0LTA0ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBDb3JyZWN0IExheW91dFVu aXQgdXNhZ2UgaW4gc3R5bGUgZnVuY3Rpb25zIGFkanVzdFJlY3RGb3JTaGFkb3cgYW5kIGdldFJv dW5kZWRCb3JkZXJGb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTgzMTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ29ycmVjdGluZyBMYXlvdXRVbml0IHVzYWdlIGluIGEgcGFpciBvZiBzdHlsZSByZW5k ZXJpbmcgZnVuY3Rpb25zLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJl aGF2aW9yLgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OmNhbGNSYWRpaUZvcik6IFRoaXMgaXMgYSBzdGF0aWMgaW50ZXJuYWwg ZnVuY3Rpb24gdGhhdCByZXR1cm5zIHRoZSByYWRpaSBiYXNlZCBvbiBhIHNpemUuCisgICAgICAg IEl0J3Mgb25seSBjYWxsZWQgZnJvbSBnZXRSb3VuZGVkQm9yZGVyRm9yLCBzbyB3ZSdyZSBub3cg cGl4ZWwgc25hcHBpbmcgdGhlIHNpemUgYmVmb3JlIGhhbmRpbmcgaXQKKyAgICAgICAgdG8gdGhp cyBmdW5jdGlvbi4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclN0eWxlOjpnZXRSb3VuZGVkQm9y ZGVyRm9yKTogVGFrZXMgYSBMYXlvdXRSZWN0IGFuZCByZXR1cm5zIHRoZSBwaXhlbC1zbmFwcGVk CisgICAgICAgIHJlc3VsdGluZyBSb3VuZGVkUmVjdC4gVXNpbmcgYSBsb2NhbCBJbnRSZWN0IHRv IGF2b2lkIHNuYXBwaW5nIHR3aWNlLgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9TaGFkb3dE YXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYWRvd0RhdGE6OmFkanVzdFJlY3RGb3JTaGFk b3cpOiBUaGlzIGZ1bmN0aW9ucyBleHBhbmRzIGEgcmVuZGVyZXIncyByZWN0IHRvIHRha2Ugc2hh ZG93cworICAgICAgICBpbnRvIGFjY291bnQuIFRoZXNlIHJlY3RzIGFyZSBub3QgeWV0IHBpeGVs IHNuYXBwZWQgKHRoaW5rIHJlcGFpbnRpbmcpLCBzbyB3ZSBuZWVkIHRvIG9wZXJhdGUgb24gYQor ICAgICAgICBMYXlvdXRSZWN0LgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9TaGFkb3dEYXRh Lmg6CisgICAgICAgIChTaGFkb3dEYXRhKToKKwogMjAxMi0wNC0wNCAgQWxsYW4gU2FuZGZlbGQg SmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4KIAogICAgICAgICBCZXN0IHpvb21hYmxl IGFyZWEgZG9lcyBub3QgYmFsYW5jZSBpbnRlcnNlY3Rpb24gd2l0aCB0YXJnZXQgYXJlYS4KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAko cmV2aXNpb24gMTEzMTYxKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRl clN0eWxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODgwLDcgKzg4MCw3IEBAIHZvaWQgUmVuZGVy U3R5bGU6OnNldEJveFNoYWRvdyhQYXNzT3duUHQKICAgICByYXJlRGF0YS0+bV9ib3hTaGFkb3cg PSBzaGFkb3dEYXRhOwogfQogCi1zdGF0aWMgUm91bmRlZFJlY3Q6OlJhZGlpIGNhbGNSYWRpaUZv cihjb25zdCBCb3JkZXJEYXRhJiBib3JkZXIsIExheW91dFNpemUgc2l6ZSwgUmVuZGVyVmlldyog cmVuZGVyVmlldykKK3N0YXRpYyBSb3VuZGVkUmVjdDo6UmFkaWkgY2FsY1JhZGlpRm9yKGNvbnN0 IEJvcmRlckRhdGEmIGJvcmRlciwgSW50U2l6ZSBzaXplLCBSZW5kZXJWaWV3KiByZW5kZXJWaWV3 KQogewogICAgIHJldHVybiBSb3VuZGVkUmVjdDo6UmFkaWkoCiAgICAgICAgIEludFNpemUodmFs dWVGb3JMZW5ndGgoYm9yZGVyLnRvcExlZnQoKS53aWR0aCgpLCBzaXplLndpZHRoKCksIHJlbmRl clZpZXcpLCAKQEAgLTkyNywxMCArOTI3LDExIEBAIHN0YXRpYyBmbG9hdCBjYWxjQ29uc3RyYWlu dFNjYWxlRm9yKGNvbnMKIAogUm91bmRlZFJlY3QgUmVuZGVyU3R5bGU6OmdldFJvdW5kZWRCb3Jk ZXJGb3IoY29uc3QgTGF5b3V0UmVjdCYgYm9yZGVyUmVjdCwgUmVuZGVyVmlldyogcmVuZGVyVmll dywgYm9vbCBpbmNsdWRlTG9naWNhbExlZnRFZGdlLCBib29sIGluY2x1ZGVMb2dpY2FsUmlnaHRF ZGdlKSBjb25zdAogewotICAgIFJvdW5kZWRSZWN0IHJvdW5kZWRSZWN0KHBpeGVsU25hcHBlZElu dFJlY3QoYm9yZGVyUmVjdCkpOworICAgIEludFJlY3Qgc25hcHBlZEJvcmRlclJlY3QocGl4ZWxT bmFwcGVkSW50UmVjdChib3JkZXJSZWN0KSk7CisgICAgUm91bmRlZFJlY3Qgcm91bmRlZFJlY3Qo c25hcHBlZEJvcmRlclJlY3QpOwogICAgIGlmIChoYXNCb3JkZXJSYWRpdXMoKSkgewotICAgICAg ICBSb3VuZGVkUmVjdDo6UmFkaWkgcmFkaWkgPSBjYWxjUmFkaWlGb3Ioc3Vycm91bmQtPmJvcmRl ciwgYm9yZGVyUmVjdC5zaXplKCksIHJlbmRlclZpZXcpOwotICAgICAgICByYWRpaS5zY2FsZShj YWxjQ29uc3RyYWludFNjYWxlRm9yKGJvcmRlclJlY3QsIHJhZGlpKSk7CisgICAgICAgIFJvdW5k ZWRSZWN0OjpSYWRpaSByYWRpaSA9IGNhbGNSYWRpaUZvcihzdXJyb3VuZC0+Ym9yZGVyLCBzbmFw cGVkQm9yZGVyUmVjdC5zaXplKCksIHJlbmRlclZpZXcpOworICAgICAgICByYWRpaS5zY2FsZShj YWxjQ29uc3RyYWludFNjYWxlRm9yKHNuYXBwZWRCb3JkZXJSZWN0LCByYWRpaSkpOwogICAgICAg ICByb3VuZGVkUmVjdC5pbmNsdWRlTG9naWNhbEVkZ2VzKHJhZGlpLCBpc0hvcml6b250YWxXcml0 aW5nTW9kZSgpLCBpbmNsdWRlTG9naWNhbExlZnRFZGdlLCBpbmNsdWRlTG9naWNhbFJpZ2h0RWRn ZSk7CiAgICAgfQogICAgIHJldHVybiByb3VuZGVkUmVjdDsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9zdHlsZS9TaGFkb3dEYXRhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3R5bGUvU2hhZG93RGF0YS5jcHAJKHJldmlzaW9uIDExMzE2MSkKKysr IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TaGFkb3dEYXRhLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjgsNyArNjgsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgY2FsY3VsYXRlU2hhZG93 RXh0ZW50CiAgICAgfSB3aGlsZSAoc2hhZG93KTsKIH0KIAotdm9pZCBTaGFkb3dEYXRhOjphZGp1 c3RSZWN0Rm9yU2hhZG93KEludFJlY3QmIHJlY3QsIGludCBhZGRpdGlvbmFsT3V0bGluZVNpemUp IGNvbnN0Cit2b2lkIFNoYWRvd0RhdGE6OmFkanVzdFJlY3RGb3JTaGFkb3coTGF5b3V0UmVjdCYg cmVjdCwgaW50IGFkZGl0aW9uYWxPdXRsaW5lU2l6ZSkgY29uc3QKIHsKICAgICBMYXlvdXRVbml0 IHNoYWRvd0xlZnQgPSAwOwogICAgIExheW91dFVuaXQgc2hhZG93UmlnaHQgPSAwOwpJbmRleDog U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1NoYWRvd0RhdGEuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU2hhZG93RGF0YS5oCShyZXZpc2lvbiAx MTMxNjEpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU2hhZG93RGF0YS5oCSh3 b3JraW5nIGNvcHkpCkBAIC03OSw3ICs3OSw3IEBAIHB1YmxpYzoKICAgICBjb25zdCBTaGFkb3dE YXRhKiBuZXh0KCkgY29uc3QgeyByZXR1cm4gbV9uZXh0LmdldCgpOyB9CiAgICAgdm9pZCBzZXRO ZXh0KFBhc3NPd25QdHI8U2hhZG93RGF0YT4gc2hhZG93KSB7IG1fbmV4dCA9IHNoYWRvdzsgfQog Ci0gICAgdm9pZCBhZGp1c3RSZWN0Rm9yU2hhZG93KEludFJlY3QmLCBpbnQgYWRkaXRpb25hbE91 dGxpbmVTaXplID0gMCkgY29uc3Q7CisgICAgdm9pZCBhZGp1c3RSZWN0Rm9yU2hhZG93KExheW91 dFJlY3QmLCBpbnQgYWRkaXRpb25hbE91dGxpbmVTaXplID0gMCkgY29uc3Q7CiAgICAgdm9pZCBh ZGp1c3RSZWN0Rm9yU2hhZG93KEZsb2F0UmVjdCYsIGludCBhZGRpdGlvbmFsT3V0bGluZVNpemUg PSAwKSBjb25zdDsKIAogcHJpdmF0ZToK 136244 2012-04-09 09:56:26 -0700 2012-04-09 11:10:17 -0700 Patch for landing bug-83154-20120409095625.patch text/plain 2758 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzU4NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA0LTA0ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBDb3JyZWN0IExheW91dFVu aXQgdXNhZ2UgaW4gc3R5bGUgZnVuY3Rpb25zIGdldFJvdW5kZWRCb3JkZXJGb3IKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMTU0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgSnVsaWVuIENoYWZmcmFpeC4KKworICAgICAgICBDb3JyZWN0aW5nIExheW91 dFVuaXQgdXNhZ2UgaW4gZ2V0Um91bmRlZEJvcmRlckZvciBhbmQgdGhlIGNhbGNSYWRpaUZvciBo ZWxwZXIgZnVuY3Rpb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVo YXZpb3IuCisKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Y2FsY1JhZGlpRm9yKTogVGhpcyBpcyBhIHN0YXRpYyBpbnRlcm5hbCBm dW5jdGlvbiB0aGF0IHJldHVybnMgdGhlIHJhZGlpIGJhc2VkIG9uIGEgc2l6ZS4KKyAgICAgICAg SXQncyBvbmx5IGNhbGxlZCBmcm9tIGdldFJvdW5kZWRCb3JkZXJGb3IsIHNvIHdlJ3JlIG5vdyBw aXhlbCBzbmFwcGluZyB0aGUgc2l6ZSBiZWZvcmUgaGFuZGluZyBpdAorICAgICAgICB0byB0aGlz IGZ1bmN0aW9uLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU3R5bGU6OmdldFJvdW5kZWRCb3Jk ZXJGb3IpOiBUYWtlcyBhIExheW91dFJlY3QgYW5kIHJldHVybnMgdGhlIHBpeGVsLXNuYXBwZWQK KyAgICAgICAgcmVzdWx0aW5nIFJvdW5kZWRSZWN0LiBVc2luZyBhIGxvY2FsIEludFJlY3QgdG8g YXZvaWQgc25hcHBpbmcgdHdpY2UuCisKIDIwMTItMDQtMDkgIFBhdmVsIEZlbGRtYW4gIDxwZmVs ZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW25ldHdvcmsgcGFu ZWxdIHR5cGUgY29sdW1uIHNob3dzICJ1bmRlZmluZWQiIGluc3RlYWQgb2YgIihQZW5kaW5nKSIg dXBvbiBsb2FkLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0 eWxlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVu ZGVyU3R5bGUuY3BwCShyZXZpc2lvbiAxMTM1ODUpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04ODAsNyArODgwLDcg QEAgdm9pZCBSZW5kZXJTdHlsZTo6c2V0Qm94U2hhZG93KFBhc3NPd25QdAogICAgIHJhcmVEYXRh LT5tX2JveFNoYWRvdyA9IHNoYWRvd0RhdGE7CiB9CiAKLXN0YXRpYyBSb3VuZGVkUmVjdDo6UmFk aWkgY2FsY1JhZGlpRm9yKGNvbnN0IEJvcmRlckRhdGEmIGJvcmRlciwgTGF5b3V0U2l6ZSBzaXpl LCBSZW5kZXJWaWV3KiByZW5kZXJWaWV3KQorc3RhdGljIFJvdW5kZWRSZWN0OjpSYWRpaSBjYWxj UmFkaWlGb3IoY29uc3QgQm9yZGVyRGF0YSYgYm9yZGVyLCBJbnRTaXplIHNpemUsIFJlbmRlclZp ZXcqIHJlbmRlclZpZXcpCiB7CiAgICAgcmV0dXJuIFJvdW5kZWRSZWN0OjpSYWRpaSgKICAgICAg ICAgSW50U2l6ZSh2YWx1ZUZvckxlbmd0aChib3JkZXIudG9wTGVmdCgpLndpZHRoKCksIHNpemUu d2lkdGgoKSwgcmVuZGVyVmlldyksIApAQCAtOTI3LDEwICs5MjcsMTEgQEAgc3RhdGljIGZsb2F0 IGNhbGNDb25zdHJhaW50U2NhbGVGb3IoY29ucwogCiBSb3VuZGVkUmVjdCBSZW5kZXJTdHlsZTo6 Z2V0Um91bmRlZEJvcmRlckZvcihjb25zdCBMYXlvdXRSZWN0JiBib3JkZXJSZWN0LCBSZW5kZXJW aWV3KiByZW5kZXJWaWV3LCBib29sIGluY2x1ZGVMb2dpY2FsTGVmdEVkZ2UsIGJvb2wgaW5jbHVk ZUxvZ2ljYWxSaWdodEVkZ2UpIGNvbnN0CiB7Ci0gICAgUm91bmRlZFJlY3Qgcm91bmRlZFJlY3Qo cGl4ZWxTbmFwcGVkSW50UmVjdChib3JkZXJSZWN0KSk7CisgICAgSW50UmVjdCBzbmFwcGVkQm9y ZGVyUmVjdChwaXhlbFNuYXBwZWRJbnRSZWN0KGJvcmRlclJlY3QpKTsKKyAgICBSb3VuZGVkUmVj dCByb3VuZGVkUmVjdChzbmFwcGVkQm9yZGVyUmVjdCk7CiAgICAgaWYgKGhhc0JvcmRlclJhZGl1 cygpKSB7CiAgICAgICAgIFJvdW5kZWRSZWN0OjpSYWRpaSByYWRpaSA9IGNhbGNSYWRpaUZvcihz dXJyb3VuZC0+Ym9yZGVyLCBib3JkZXJSZWN0LnNpemUoKSwgcmVuZGVyVmlldyk7Ci0gICAgICAg IHJhZGlpLnNjYWxlKGNhbGNDb25zdHJhaW50U2NhbGVGb3IocGl4ZWxTbmFwcGVkSW50UmVjdChi b3JkZXJSZWN0KSwgcmFkaWkpKTsKKyAgICAgICAgcmFkaWkuc2NhbGUoY2FsY0NvbnN0cmFpbnRT Y2FsZUZvcihzbmFwcGVkQm9yZGVyUmVjdCwgcmFkaWkpKTsKICAgICAgICAgcm91bmRlZFJlY3Qu aW5jbHVkZUxvZ2ljYWxFZGdlcyhyYWRpaSwgaXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSwgaW5j bHVkZUxvZ2ljYWxMZWZ0RWRnZSwgaW5jbHVkZUxvZ2ljYWxSaWdodEVkZ2UpOwogICAgIH0KICAg ICByZXR1cm4gcm91bmRlZFJlY3Q7Cg==