83041 2012-04-03 09:42:31 -0700 Fix getFilterOutsets parameter types in RenderLayer 2012-04-04 14:06:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82535 60318 1 eae eae eric jchaffraix leviw webkit.review.bot oldest_to_newest 594564 0 eae 2012-04-03 09:42:31 -0700 getFilterOutsets was changed to take integer arguments in r112475 but RenderLater wasn't updated. 594586 1 135351 eae 2012-04-03 10:06:54 -0700 Created attachment 135351 Patch 595088 2 135351 jchaffraix 2012-04-03 18:09:39 -0700 Comment on attachment 135351 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135351&action=review > Source/WebCore/rendering/RenderLayer.cpp:4157 > // filtered areas with the outsets if we know that the filter is going to render in hardware. Above there are tons of implicit conversion due to calculateLayerBounds returning an IntRect, could we make those explicit? 595211 3 eae 2012-04-03 20:54:13 -0700 (In reply to comment #2) > (From update of attachment 135351 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135351&action=review > > > Source/WebCore/rendering/RenderLayer.cpp:4157 > > // filtered areas with the outsets if we know that the filter is going to render in hardware. > > Above there are tons of implicit conversion due to calculateLayerBounds returning an IntRect, could we make those explicit? That seems like a good idea, I'll go through them all tomorrow and make it explicit where it makes sense. Thanks! 595790 4 135649 eae 2012-04-04 12:19:24 -0700 Created attachment 135649 Patch for landing 595912 5 135649 webkit.review.bot 2012-04-04 14:06:28 -0700 Comment on attachment 135649 Patch for landing Clearing flags on attachment: 135649 Committed r113236: <http://trac.webkit.org/changeset/113236> 595913 6 webkit.review.bot 2012-04-04 14:06:32 -0700 All reviewed patches have been landed. Closing bug. 135351 2012-04-03 10:06:54 -0700 2012-04-04 12:19:17 -0700 Patch bug-83041-20120403100653.patch text/plain 2545 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzA0NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTAzICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggZ2V0RmlsdGVyT3V0c2V0 cyBwYXJhbWV0ZXIgdHlwZXMgaW4gUmVuZGVyTGF5ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMDQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGdldEZpbHRlck91dHNldHMgbWV0aG9kIHdhcyBj aGFuZ2VkIHRvIHRha2UgaW50ZWdlcnMgaW4gcjExMjQ3NSwgdXBkYXRlCisgICAgICAgIFJlbmRl ckxheWVyIHRvIHVzZSB0aGUgcmlnaHQgZGF0YSB0eXBlIGZvciB0aGUgb3V0c2V0IGFyZ3VtZW50 cy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5Lgor CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckxheWVyOjpzZXRGaWx0ZXJCYWNrZW5kTmVlZHNSZXBhaW50aW5nSW5SZWN0KToKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpjYWxjdWxhdGVMYXllckJvdW5kcyk6CisKIDIw MTItMDQtMDMgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCBBU1NFUlQgZml4IG9uIENocm9taXVtIGJvdHMgKGluIGRlYnVn KS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkocmV2aXNp b24gMTEzMDQ0KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtOTg4LDEwICs5ODgsMTAgQEAgdm9pZCBSZW5kZXJMYXllcjo6c2V0 RmlsdGVyQmFja2VuZE5lZWRzUgogICAgIAogI2lmIEVOQUJMRShDU1NfRklMVEVSUykKICAgICBp ZiAocmVuZGVyZXIoKS0+c3R5bGUoKS0+aGFzRmlsdGVyT3V0c2V0cygpKSB7Ci0gICAgICAgIExh eW91dFVuaXQgdG9wT3V0c2V0OwotICAgICAgICBMYXlvdXRVbml0IHJpZ2h0T3V0c2V0OwotICAg ICAgICBMYXlvdXRVbml0IGJvdHRvbU91dHNldDsKLSAgICAgICAgTGF5b3V0VW5pdCBsZWZ0T3V0 c2V0OworICAgICAgICBpbnQgdG9wT3V0c2V0OworICAgICAgICBpbnQgcmlnaHRPdXRzZXQ7Cisg ICAgICAgIGludCBib3R0b21PdXRzZXQ7CisgICAgICAgIGludCBsZWZ0T3V0c2V0OwogICAgICAg ICByZW5kZXJlcigpLT5zdHlsZSgpLT5nZXRGaWx0ZXJPdXRzZXRzKHRvcE91dHNldCwgcmlnaHRP dXRzZXQsIGJvdHRvbU91dHNldCwgbGVmdE91dHNldCk7CiAgICAgICAgIHJlY3RGb3JSZXBhaW50 Lm1vdmUoLWxlZnRPdXRzZXQsIC10b3BPdXRzZXQpOwogICAgICAgICByZWN0Rm9yUmVwYWludC5l eHBhbmQobGVmdE91dHNldCArIHJpZ2h0T3V0c2V0LCB0b3BPdXRzZXQgKyBib3R0b21PdXRzZXQp OwpAQCAtNDE1NywxMCArNDE1NywxMCBAQCBJbnRSZWN0IFJlbmRlckxheWVyOjpjYWxjdWxhdGVM YXllckJvdW5kCiAgICAgLy8gZmlsdGVyZWQgYXJlYXMgd2l0aCB0aGUgb3V0c2V0cyBpZiB3ZSBr bm93IHRoYXQgdGhlIGZpbHRlciBpcyBnb2luZyB0byByZW5kZXIgaW4gaGFyZHdhcmUuCiAgICAg Ly8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxMjM5CiAgICAgaWYg KGluY2x1ZGVMYXllckZpbHRlck91dHNldHMgJiYgbGF5ZXItPnJlbmRlcmVyKCktPnN0eWxlKCkt Pmhhc0ZpbHRlck91dHNldHMoKSkgewotICAgICAgICBMYXlvdXRVbml0IHRvcE91dHNldDsKLSAg ICAgICAgTGF5b3V0VW5pdCByaWdodE91dHNldDsKLSAgICAgICAgTGF5b3V0VW5pdCBib3R0b21P dXRzZXQ7Ci0gICAgICAgIExheW91dFVuaXQgbGVmdE91dHNldDsKKyAgICAgICAgaW50IHRvcE91 dHNldDsKKyAgICAgICAgaW50IHJpZ2h0T3V0c2V0OworICAgICAgICBpbnQgYm90dG9tT3V0c2V0 OworICAgICAgICBpbnQgbGVmdE91dHNldDsKICAgICAgICAgbGF5ZXItPnJlbmRlcmVyKCktPnN0 eWxlKCktPmdldEZpbHRlck91dHNldHModG9wT3V0c2V0LCByaWdodE91dHNldCwgYm90dG9tT3V0 c2V0LCBsZWZ0T3V0c2V0KTsKICAgICAgICAgdW5pb25Cb3VuZHMubW92ZSgtbGVmdE91dHNldCwg LXRvcE91dHNldCk7CiAgICAgICAgIHVuaW9uQm91bmRzLmV4cGFuZChsZWZ0T3V0c2V0ICsgcmln aHRPdXRzZXQsIHRvcE91dHNldCArIGJvdHRvbU91dHNldCk7Cg== 135649 2012-04-04 12:19:24 -0700 2012-04-04 14:06:28 -0700 Patch for landing bug-83041-20120404121923.patch text/plain 4325 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzEwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTA0ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggZ2V0RmlsdGVyT3V0c2V0 cyBwYXJhbWV0ZXIgdHlwZXMgaW4gUmVuZGVyTGF5ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzMDQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSnVs aWVuIENoYWZmcmFpeC4KKworICAgICAgICBUaGUgZ2V0RmlsdGVyT3V0c2V0cyBtZXRob2Qgd2Fz IGNoYW5nZWQgdG8gdGFrZSBpbnRlZ2VycyBpbiByMTEyNDc1LCB1cGRhdGUKKyAgICAgICAgUmVu ZGVyTGF5ZXIgdG8gdXNlIHRoZSByaWdodCBkYXRhIHR5cGUgZm9yIHRoZSBvdXRzZXQgYXJndW1l bnRzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHku CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyTGF5ZXI6OnNldEZpbHRlckJhY2tlbmROZWVkc1JlcGFpbnRpbmdJblJlY3QpOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmNhbGN1bGF0ZUxheWVyQm91bmRzKToKKwog MjAxMi0wNC0wMyAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIENyYXNoIGluIFNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tPbmVTZWxlY3Rvci4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkocmV2aXNpb24gMTEzMDQ0KQor KysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtOTg4LDEwICs5ODgsMTAgQEAgdm9pZCBSZW5kZXJMYXllcjo6c2V0RmlsdGVyQmFja2Vu ZE5lZWRzUgogICAgIAogI2lmIEVOQUJMRShDU1NfRklMVEVSUykKICAgICBpZiAocmVuZGVyZXIo KS0+c3R5bGUoKS0+aGFzRmlsdGVyT3V0c2V0cygpKSB7Ci0gICAgICAgIExheW91dFVuaXQgdG9w T3V0c2V0OwotICAgICAgICBMYXlvdXRVbml0IHJpZ2h0T3V0c2V0OwotICAgICAgICBMYXlvdXRV bml0IGJvdHRvbU91dHNldDsKLSAgICAgICAgTGF5b3V0VW5pdCBsZWZ0T3V0c2V0OworICAgICAg ICBpbnQgdG9wT3V0c2V0OworICAgICAgICBpbnQgcmlnaHRPdXRzZXQ7CisgICAgICAgIGludCBi b3R0b21PdXRzZXQ7CisgICAgICAgIGludCBsZWZ0T3V0c2V0OwogICAgICAgICByZW5kZXJlcigp LT5zdHlsZSgpLT5nZXRGaWx0ZXJPdXRzZXRzKHRvcE91dHNldCwgcmlnaHRPdXRzZXQsIGJvdHRv bU91dHNldCwgbGVmdE91dHNldCk7CiAgICAgICAgIHJlY3RGb3JSZXBhaW50Lm1vdmUoLWxlZnRP dXRzZXQsIC10b3BPdXRzZXQpOwogICAgICAgICByZWN0Rm9yUmVwYWludC5leHBhbmQobGVmdE91 dHNldCArIHJpZ2h0T3V0c2V0LCB0b3BPdXRzZXQgKyBib3R0b21PdXRzZXQpOwpAQCAtNDExMiw3 ICs0MTEyLDcgQEAgSW50UmVjdCBSZW5kZXJMYXllcjo6Y2FsY3VsYXRlTGF5ZXJCb3VuZAogCiAg ICAgaWYgKFJlbmRlckxheWVyKiByZWZsZWN0aW9uID0gbGF5ZXItPnJlZmxlY3Rpb25MYXllcigp KSB7CiAgICAgICAgIGlmICghcmVmbGVjdGlvbi0+aXNDb21wb3NpdGVkKCkpIHsKLSAgICAgICAg ICAgIExheW91dFJlY3QgY2hpbGRVbmlvbkJvdW5kcyA9IGNhbGN1bGF0ZUxheWVyQm91bmRzKHJl ZmxlY3Rpb24sIGxheWVyKTsKKyAgICAgICAgICAgIEludFJlY3QgY2hpbGRVbmlvbkJvdW5kcyA9 IGNhbGN1bGF0ZUxheWVyQm91bmRzKHJlZmxlY3Rpb24sIGxheWVyKTsKICAgICAgICAgICAgIHVu aW9uQm91bmRzLnVuaXRlKGNoaWxkVW5pb25Cb3VuZHMpOwogICAgICAgICB9CiAgICAgfQpAQCAt NDEyNCw3ICs0MTI0LDcgQEAgSW50UmVjdCBSZW5kZXJMYXllcjo6Y2FsY3VsYXRlTGF5ZXJCb3Vu ZAogICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGxpc3RTaXplOyArK2kpIHsKICAgICAg ICAgICAgIFJlbmRlckxheWVyKiBjdXJMYXllciA9IG5lZ1pPcmRlckxpc3QtPmF0KGkpOwogICAg ICAgICAgICAgaWYgKCFjdXJMYXllci0+aXNDb21wb3NpdGVkKCkpIHsKLSAgICAgICAgICAgICAg ICBMYXlvdXRSZWN0IGNoaWxkVW5pb25Cb3VuZHMgPSBjYWxjdWxhdGVMYXllckJvdW5kcyhjdXJM YXllciwgbGF5ZXIpOworICAgICAgICAgICAgICAgIEludFJlY3QgY2hpbGRVbmlvbkJvdW5kcyA9 IGNhbGN1bGF0ZUxheWVyQm91bmRzKGN1ckxheWVyLCBsYXllcik7CiAgICAgICAgICAgICAgICAg dW5pb25Cb3VuZHMudW5pdGUoY2hpbGRVbmlvbkJvdW5kcyk7CiAgICAgICAgICAgICB9CiAgICAg ICAgIH0KQEAgLTQxMzUsNyArNDEzNSw3IEBAIEludFJlY3QgUmVuZGVyTGF5ZXI6OmNhbGN1bGF0 ZUxheWVyQm91bmQKICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBsaXN0U2l6ZTsgKytp KSB7CiAgICAgICAgICAgICBSZW5kZXJMYXllciogY3VyTGF5ZXIgPSBwb3NaT3JkZXJMaXN0LT5h dChpKTsKICAgICAgICAgICAgIGlmICghY3VyTGF5ZXItPmlzQ29tcG9zaXRlZCgpKSB7Ci0gICAg ICAgICAgICAgICAgTGF5b3V0UmVjdCBjaGlsZFVuaW9uQm91bmRzID0gY2FsY3VsYXRlTGF5ZXJC b3VuZHMoY3VyTGF5ZXIsIGxheWVyKTsKKyAgICAgICAgICAgICAgICBJbnRSZWN0IGNoaWxkVW5p b25Cb3VuZHMgPSBjYWxjdWxhdGVMYXllckJvdW5kcyhjdXJMYXllciwgbGF5ZXIpOwogICAgICAg ICAgICAgICAgIHVuaW9uQm91bmRzLnVuaXRlKGNoaWxkVW5pb25Cb3VuZHMpOwogICAgICAgICAg ICAgfQogICAgICAgICB9CkBAIC00MTQ2LDcgKzQxNDYsNyBAQCBJbnRSZWN0IFJlbmRlckxheWVy OjpjYWxjdWxhdGVMYXllckJvdW5kCiAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbGlz dFNpemU7ICsraSkgewogICAgICAgICAgICAgUmVuZGVyTGF5ZXIqIGN1ckxheWVyID0gbm9ybWFs Rmxvd0xpc3QtPmF0KGkpOwogICAgICAgICAgICAgaWYgKCFjdXJMYXllci0+aXNDb21wb3NpdGVk KCkpIHsKLSAgICAgICAgICAgICAgICBMYXlvdXRSZWN0IGN1ckFic0JvdW5kcyA9IGNhbGN1bGF0 ZUxheWVyQm91bmRzKGN1ckxheWVyLCBsYXllcik7CisgICAgICAgICAgICAgICAgSW50UmVjdCBj dXJBYnNCb3VuZHMgPSBjYWxjdWxhdGVMYXllckJvdW5kcyhjdXJMYXllciwgbGF5ZXIpOwogICAg ICAgICAgICAgICAgIHVuaW9uQm91bmRzLnVuaXRlKGN1ckFic0JvdW5kcyk7CiAgICAgICAgICAg ICB9CiAgICAgICAgIH0KQEAgLTQxNTcsMTAgKzQxNTcsMTAgQEAgSW50UmVjdCBSZW5kZXJMYXll cjo6Y2FsY3VsYXRlTGF5ZXJCb3VuZAogICAgIC8vIGZpbHRlcmVkIGFyZWFzIHdpdGggdGhlIG91 dHNldHMgaWYgd2Uga25vdyB0aGF0IHRoZSBmaWx0ZXIgaXMgZ29pbmcgdG8gcmVuZGVyIGluIGhh cmR3YXJlLgogICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 MTIzOQogICAgIGlmIChpbmNsdWRlTGF5ZXJGaWx0ZXJPdXRzZXRzICYmIGxheWVyLT5yZW5kZXJl cigpLT5zdHlsZSgpLT5oYXNGaWx0ZXJPdXRzZXRzKCkpIHsKLSAgICAgICAgTGF5b3V0VW5pdCB0 b3BPdXRzZXQ7Ci0gICAgICAgIExheW91dFVuaXQgcmlnaHRPdXRzZXQ7Ci0gICAgICAgIExheW91 dFVuaXQgYm90dG9tT3V0c2V0OwotICAgICAgICBMYXlvdXRVbml0IGxlZnRPdXRzZXQ7CisgICAg ICAgIGludCB0b3BPdXRzZXQ7CisgICAgICAgIGludCByaWdodE91dHNldDsKKyAgICAgICAgaW50 IGJvdHRvbU91dHNldDsKKyAgICAgICAgaW50IGxlZnRPdXRzZXQ7CiAgICAgICAgIGxheWVyLT5y ZW5kZXJlcigpLT5zdHlsZSgpLT5nZXRGaWx0ZXJPdXRzZXRzKHRvcE91dHNldCwgcmlnaHRPdXRz ZXQsIGJvdHRvbU91dHNldCwgbGVmdE91dHNldCk7CiAgICAgICAgIHVuaW9uQm91bmRzLm1vdmUo LWxlZnRPdXRzZXQsIC10b3BPdXRzZXQpOwogICAgICAgICB1bmlvbkJvdW5kcy5leHBhbmQobGVm dE91dHNldCArIHJpZ2h0T3V0c2V0LCB0b3BPdXRzZXQgKyBib3R0b21PdXRzZXQpOwo=