82899 2012-04-02 07:40:19 -0700 Correct remaining LayoutUnit misuse in RenderReplaced and RenderFlexibleBox 2012-04-02 14:00:30 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric jchaffraix webkit.review.bot oldest_to_newest 593458 0 leviw 2012-04-02 07:40:19 -0700 Ongoing conversion. 593471 1 135101 leviw 2012-04-02 07:51:21 -0700 Created attachment 135101 Patch 593816 2 135101 webkit.review.bot 2012-04-02 14:00:26 -0700 Comment on attachment 135101 Patch Clearing flags on attachment: 135101 Committed r112936: <http://trac.webkit.org/changeset/112936> 593817 3 webkit.review.bot 2012-04-02 14:00:30 -0700 All reviewed patches have been landed. Closing bug. 135101 2012-04-02 07:51:21 -0700 2012-04-02 14:00:26 -0700 Patch bug-82899-20120402165117.patch text/plain 4925 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjg4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA0LTAyICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBDb3JyZWN0IHJlbWFpbmlu ZyBMYXlvdXRVbml0IG1pc3VzZSBpbiBSZW5kZXJSZXBsYWNlZCBhbmQgUmVuZGVyRmxleGlibGVC b3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyODk5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3Zp bmcgcmVtYWluaW5nIExheW91dFVuaXQgbWlzdXNlIGFuZCBjb21waWxlciBlcnJvcnMgdGhhdCBl eGlzdCBpbiBSZW5kZXJSZXBsYWNlZAorICAgICAgICBhbmQgUmVuZGVyRmxleGlibGVCb3ggb25j ZSBMYXlvdXRVbml0IGJlY29tZXMgc3ViLXBpeGVsLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g Tm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZsZXhp YmxlQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94OjpyZXBvc2l0 aW9uTG9naWNhbEhlaWdodERlcGVuZGVudEZsZXhJdGVtcyk6IFN3aXRjaGluZworICAgICAgICBh IHJhdyB6ZXJvIGluIGEgdGVybmFyeSBvcGVyYXRpb24gdG8gemVyb0xheW91dFVuaXQuCisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJGbGV4aWJsZUJveDo6YXBwbHlTdHJldGNoQWxpZ25tZW50VG9D aGlsZCk6IERpdHRvIGZvciBzdGQ6Om1heC4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyUmVw bGFjZWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUmVwbGFjZWQ6OnBhaW50KTogQWRk aW5nIG1pc3NpbmcgcGl4ZWwgc25hcHBpbmcgYmVmb3JlIHBhaW50aW5nLgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyUmVwbGFjZWQ6OmNvbXB1dGVSZXBsYWNlZExvZ2ljYWxXaWR0aCk6IExpa2Ug YWJvdmUsIHN3aXRjaGluZworICAgICAgICBhIHJhdyB6ZXJvIHRvIHplcm9MYXlvdXRVbml0Lgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUmVwbGFjZWQ6OmNvbXB1dGVQcmVmZXJyZWRMb2dpY2Fs V2lkdGhzKTogRGl0dG8uCisKIDIwMTItMDQtMDIgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVu YXJkQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmVuYW1lIENTU1Byb3BlcnR5TG9uZ2hhbmQg Y2xhc3MgdG8gU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAkocmV2aXNpb24gMTEyODQ4KQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjk2LDcgKzI5Niw3IEBAIHZvaWQgUmVuZGVyRmxleGlibGVCb3g6OmxheW91dEJs b2NrKGJvb2wKIAogdm9pZCBSZW5kZXJGbGV4aWJsZUJveDo6cmVwb3NpdGlvbkxvZ2ljYWxIZWln aHREZXBlbmRlbnRGbGV4SXRlbXMoRmxleE9yZGVySXRlcmF0b3ImIGl0ZXJhdG9yLCBXVEY6OlZl Y3RvcjxMaW5lQ29udGV4dD4mIGxpbmVDb250ZXh0cywgTGF5b3V0VW5pdCYgb2xkQ2xpZW50QWZ0 ZXJFZGdlKQogewotICAgIExheW91dFVuaXQgY3Jvc3NBeGlzU3RhcnRFZGdlID0gbGluZUNvbnRl eHRzLmlzRW1wdHkoKSA/IDAgOiBsaW5lQ29udGV4dHNbMF0uY3Jvc3NBeGlzT2Zmc2V0OworICAg IExheW91dFVuaXQgY3Jvc3NBeGlzU3RhcnRFZGdlID0gbGluZUNvbnRleHRzLmlzRW1wdHkoKSA/ IHplcm9MYXlvdXRVbml0IDogbGluZUNvbnRleHRzWzBdLmNyb3NzQXhpc09mZnNldDsKICAgICBw YWNrRmxleExpbmVzKGl0ZXJhdG9yLCBsaW5lQ29udGV4dHMpOwogCiAgICAgLy8gSWYgd2UgaGF2 ZSBhIHNpbmdsZSBsaW5lIGZsZXhib3gsIHRoZSBsaW5lIGhlaWdodCBpcyBhbGwgdGhlIGF2YWls YWJsZSBzcGFjZS4KQEAgLTExMjAsNyArMTEyMCw3IEBAIHZvaWQgUmVuZGVyRmxleGlibGVCb3g6 OmFwcGx5U3RyZXRjaEFsaWcKICAgICB9IGVsc2UgaWYgKGlzQ29sdW1uRmxvdygpICYmIGNoaWxk LT5zdHlsZSgpLT5sb2dpY2FsV2lkdGgoKS5pc0F1dG8oKSAmJiBpc011bHRpbGluZSgpKSB7CiAg ICAgICAgIC8vIEZJWE1FOiBIYW5kbGUgbWluLXdpZHRoIGFuZCBtYXgtd2lkdGguCiAgICAgICAg IExheW91dFVuaXQgY2hpbGRXaWR0aCA9IGxpbmVDcm9zc0F4aXNFeHRlbnQgLSBjcm9zc0F4aXNN YXJnaW5FeHRlbnRGb3JDaGlsZChjaGlsZCk7Ci0gICAgICAgIGNoaWxkLT5zZXRPdmVycmlkZVdp ZHRoKHN0ZDo6bWF4KDAsIGNoaWxkV2lkdGgpKTsKKyAgICAgICAgY2hpbGQtPnNldE92ZXJyaWRl V2lkdGgoc3RkOjptYXgoemVyb0xheW91dFVuaXQsIGNoaWxkV2lkdGgpKTsKICAgICAgICAgY2hp bGQtPnNldENoaWxkTmVlZHNMYXlvdXQodHJ1ZSk7CiAgICAgICAgIGNoaWxkLT5sYXlvdXRJZk5l ZWRlZCgpOwogICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZXBs YWNlZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJl cGxhY2VkLmNwcAkocmV2aXNpb24gMTEyODQ4KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclJlcGxhY2VkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYxLDcgKzE2MSw3IEBAIHZv aWQgUmVuZGVyUmVwbGFjZWQ6OnBhaW50KFBhaW50SW5mbyYgcGEKICAgICBpZiAoZHJhd1NlbGVj dGlvblRpbnQpIHsKICAgICAgICAgTGF5b3V0UmVjdCBzZWxlY3Rpb25QYWludGluZ1JlY3QgPSBs b2NhbFNlbGVjdGlvblJlY3QoKTsKICAgICAgICAgc2VsZWN0aW9uUGFpbnRpbmdSZWN0Lm1vdmVC eShhZGp1c3RlZFBhaW50T2Zmc2V0KTsKLSAgICAgICAgcGFpbnRJbmZvLmNvbnRleHQtPmZpbGxS ZWN0KHNlbGVjdGlvblBhaW50aW5nUmVjdCwgc2VsZWN0aW9uQmFja2dyb3VuZENvbG9yKCksIHN0 eWxlKCktPmNvbG9yU3BhY2UoKSk7CisgICAgICAgIHBhaW50SW5mby5jb250ZXh0LT5maWxsUmVj dChwaXhlbFNuYXBwZWRJbnRSZWN0KHNlbGVjdGlvblBhaW50aW5nUmVjdCksIHNlbGVjdGlvbkJh Y2tncm91bmRDb2xvcigpLCBzdHlsZSgpLT5jb2xvclNwYWNlKCkpOwogICAgIH0KIH0KIApAQCAt MzYwLDcgKzM2MCw3IEBAIExheW91dFVuaXQgUmVuZGVyUmVwbGFjZWQ6OmNvbXB1dGVSZXBsYWMK ICAgICAgICAgICAgICAgICAvLyBUaGlzIHNvbHZlcyBhYm92ZSBlcXVhdGlvbiBmb3IgJ3dpZHRo JyAoPT0gbG9naWNhbFdpZHRoKS4KICAgICAgICAgICAgICAgICBMYXlvdXRVbml0IG1hcmdpblN0 YXJ0ID0gbWluaW11bVZhbHVlRm9yTGVuZ3RoKHN0eWxlKCktPm1hcmdpblN0YXJ0KCksIGxvZ2lj YWxXaWR0aCk7CiAgICAgICAgICAgICAgICAgTGF5b3V0VW5pdCBtYXJnaW5FbmQgPSBtaW5pbXVt VmFsdWVGb3JMZW5ndGgoc3R5bGUoKS0+bWFyZ2luRW5kKCksIGxvZ2ljYWxXaWR0aCk7Ci0gICAg ICAgICAgICAgICAgbG9naWNhbFdpZHRoID0gbWF4KDAsIGxvZ2ljYWxXaWR0aCAtIChtYXJnaW5T dGFydCArIG1hcmdpbkVuZCArICh3aWR0aCgpIC0gY2xpZW50V2lkdGgoKSkpKTsKKyAgICAgICAg ICAgICAgICBsb2dpY2FsV2lkdGggPSBtYXgoemVyb0xheW91dFVuaXQsIGxvZ2ljYWxXaWR0aCAt IChtYXJnaW5TdGFydCArIG1hcmdpbkVuZCArICh3aWR0aCgpIC0gY2xpZW50V2lkdGgoKSkpKTsK ICAgICAgICAgICAgICAgICBpZiAoaXNQZXJjZW50YWdlSW50cmluc2ljU2l6ZSkKICAgICAgICAg ICAgICAgICAgICAgbG9naWNhbFdpZHRoID0gcm91bmRUb0ludChsb2dpY2FsV2lkdGggKiBpbnRy aW5zaWNTaXplLndpZHRoKCkgLyAxMDApOwogICAgICAgICAgICAgICAgIHJldHVybiBjb21wdXRl UmVwbGFjZWRMb2dpY2FsV2lkdGhSZXNwZWN0aW5nTWluTWF4V2lkdGgobG9naWNhbFdpZHRoLCBp bmNsdWRlTWF4V2lkdGgpOwpAQCAtNDI1LDcgKzQyNSw3IEBAIHZvaWQgUmVuZGVyUmVwbGFjZWQ6 OmNvbXB1dGVQcmVmZXJyZWRMb2cKICAgICBtX21heFByZWZlcnJlZExvZ2ljYWxXaWR0aCA9IGNv bXB1dGVSZXBsYWNlZExvZ2ljYWxXaWR0aChmYWxzZSkgKyBib3JkZXJBbmRQYWRkaW5nOwogCiAg ICAgaWYgKHN0eWxlKCktPm1heFdpZHRoKCkuaXNGaXhlZCgpKQotICAgICAgICBtX21heFByZWZl cnJlZExvZ2ljYWxXaWR0aCA9IG1pbihtX21heFByZWZlcnJlZExvZ2ljYWxXaWR0aCwgc3R5bGUo KS0+bWF4V2lkdGgoKS52YWx1ZSgpICsgKHN0eWxlKCktPmJveFNpemluZygpID09IENPTlRFTlRf Qk9YID8gYm9yZGVyQW5kUGFkZGluZyA6IHplcm9MYXlvdXRVbml0KSk7CisgICAgICAgIG1fbWF4 UHJlZmVycmVkTG9naWNhbFdpZHRoID0gbWluPExheW91dFVuaXQ+KG1fbWF4UHJlZmVycmVkTG9n aWNhbFdpZHRoLCBzdHlsZSgpLT5tYXhXaWR0aCgpLnZhbHVlKCkgKyAoc3R5bGUoKS0+Ym94U2l6 aW5nKCkgPT0gQ09OVEVOVF9CT1ggPyBib3JkZXJBbmRQYWRkaW5nIDogemVyb0xheW91dFVuaXQp KTsKIAogICAgIGlmIChoYXNSZWxhdGl2ZURpbWVuc2lvbnMoKSkKICAgICAgICAgbV9taW5QcmVm ZXJyZWRMb2dpY2FsV2lkdGggPSAwOwo=