82700 2012-03-30 00:14:51 -0700 [Qt][WK2] REGRESSION, fix a failing API test in qmltests 2012-05-21 13:47:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 70236 1 ossy marcelo.lira cmarcelo hausmann menard ossy rafael.lobo webkit.review.bot zoltan oldest_to_newest 591920 0 ossy 2012-03-30 00:14:51 -0700 All API tests pass with the latest pinned Qt5 hash (7d0327830bb4768753cb0c14a23d98fed08be7d2), but the following test fails with a newer Qt5: 15f3399576bd433898f8e89bbcb3c1196e0da5b9 FAIL! : qmltests::WebViewPreferences::test_standardFontFamilyChanged() Compared values are not the same Actual (): 'Bitstream Vera Serif' Expected (): Bitstream Vera Serif Loc: [/home/oszi/WebKit/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml(204)] 629368 1 143075 marcelo.lira 2012-05-21 12:17:37 -0700 Created attachment 143075 Patch 629383 2 143075 menard 2012-05-21 12:29:52 -0700 Comment on attachment 143075 Patch Question : why the behavior changed in Qt? 629388 3 143075 cmarcelo 2012-05-21 12:33:49 -0700 Comment on attachment 143075 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143075&action=review Thanks for finally fixing this one, Marcelo :-) I have some comments following. > Source/WebKit2/ChangeLog:10 > + Font family names returned by WebKit experimental always return values I would rephrase this, at least to make clear is our: __WebView__ experimental preferences API. And we return the same values as existing WKPreferences C API for WK2. > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:199 > + return text.replace(/^('*)([^']*)('*)$/, '$2') Can we make it simpler? Like /^'?(.*)'?$/, '$1'... or even no Regexp at all. This still doesn't support fonts that had ' originally in the name, but since our set of fonts is controlled for testing, that should be OK. > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:210 > + compare(unquote(webView.title), unquote(defaultStandardFontFamily)) Just need to unquote the webView.title here since we expect defaultStandarFontFamily to be unquoted. 629392 4 143075 cmarcelo 2012-05-21 12:37:29 -0700 Comment on attachment 143075 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143075&action=review >> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:199 >> + return text.replace(/^('*)([^']*)('*)$/, '$2') > > Can we make it simpler? Like /^'?(.*)'?$/, '$1'... or even no Regexp at all. > > This still doesn't support fonts that had ' originally in the name, but since our set of fonts is controlled for testing, that should be OK. Bah. My suggestion is wrong because (.*) will eat everything. But I still think we can simplify this. 629401 5 143079 marcelo.lira 2012-05-21 12:54:54 -0700 Created attachment 143079 Patch 629403 6 cmarcelo 2012-05-21 12:56:26 -0700 Looks good to me. 629408 7 143079 rafael.lobo 2012-05-21 12:57:49 -0700 Comment on attachment 143079 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143079&action=review > Source/WebKit2/ChangeLog:9 > + quotes when white space is present in its name, and no quotes otherwise. Is it on the spec? 629410 8 menard 2012-05-21 13:01:53 -0700 (In reply to comment #7) > (From update of attachment 143079 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143079&action=review > > > Source/WebKit2/ChangeLog:9 > > + quotes when white space is present in its name, and no quotes otherwise. > > Is it on the spec? Yes 629412 9 marcelo.lira 2012-05-21 13:03:58 -0700 (In reply to comment #7) > (From update of attachment 143079 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143079&action=review > > > Source/WebKit2/ChangeLog:9 > > + quotes when white space is present in its name, and no quotes otherwise. > > Is it on the spec? "To avoid mistakes in escaping, it is recommended to quote font family names that contain white space, digits, or punctuation characters other than hyphens (...)" http://www.w3.org/TR/CSS21/fonts.html#font-family-prop 629453 10 143079 webkit.review.bot 2012-05-21 13:47:35 -0700 Comment on attachment 143079 Patch Clearing flags on attachment: 143079 Committed r117812: <http://trac.webkit.org/changeset/117812> 629454 11 webkit.review.bot 2012-05-21 13:47:40 -0700 All reviewed patches have been landed. Closing bug. 143075 2012-05-21 12:17:37 -0700 2012-05-21 12:54:45 -0700 Patch bug-82700-20120521161736.patch text/plain 2251 marcelo.lira U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3ODA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzVmZDFlYjI3NmJmMTgw YjRmNjJkNjZjNTYzZmQxNzFiNGYxNzMwMC4uNDg3NmZiYWM5YzI2NzZiMjNjM2RkN2EwZWU3MTBi MjAxYmNhNDQzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTIxICBNYXJj ZWxvIExpcmEgIDxtYXJjZWxvLmxpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBbUXRdW1dL Ml0gUkVHUkVTU0lPTiwgZml4IGEgZmFpbGluZyBBUEkgdGVzdCBpbiBxbWx0ZXN0cworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI3MDAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdmFsdWUgb2YgYSBD U1MgZm9udC1mYW1pbHkgcHJvcGVydHkgaXMgZXhwZWN0ZWQgdG8gaGF2ZSBzaW5nbGUKKyAgICAg ICAgcXVvdGVzIHdoZW4gd2hpdGUgc3BhY2UgaXMgcHJlc2VudCBpbiBpdHMgbmFtZSwgYW5kIG5v IHF1b3RlcyBvdGhlcndpc2UuCisgICAgICAgIEZvbnQgZmFtaWx5IG5hbWVzIHJldHVybmVkIGJ5 IFdlYktpdCBleHBlcmltZW50YWwgYWx3YXlzIHJldHVybiB2YWx1ZXMKKyAgICAgICAgd2l0aG91 dCBxdW90ZXMsIHNpbmNlIHdoYXQgbWF0dGVyIHRvIHRoZSB0ZXN0IGlzIG9ubHkgdGhlIGlkZW50 aXR5IG9mCisgICAgICAgIHRoZSBmb250LCBhbiBhdXhpbGlhciBtZXRob2QgdG8gcmVtb3ZlIHNp bmdsZSBxdW90ZXMgd2FzIGFkZGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0 cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9wcmVmZXJlbmNlcy5xbWw6CisKIDIwMTItMDUtMjEgIEFs bGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CiAKICAgICAgICAg R0NDIDQuNyBhbmQgQysrMTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvdGVzdHMvcW1sdGVzdHMvV2ViVmlldy90c3RfcHJlZmVyZW5jZXMucW1sIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9wcmVm ZXJlbmNlcy5xbWwKaW5kZXggMTZmZjM1YzUyOWMxNGYwYWY2NmU4ODdkYzQzOWZhODlmN2M0ODdk Zi4uODA2ZWQ4NjIwOGM3ODBkZmU4OTIyZmU3ZTI2ZjE4MzZiMDk4ZmRiOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3Rz dF9wcmVmZXJlbmNlcy5xbWwKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90 ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9wcmVmZXJlbmNlcy5xbWwKQEAgLTE5NSw2ICsxOTUs MTAgQEAgSXRlbSB7CiAgICAgICAgICAgICAgICAgY29tcGFyZSh3ZWJWaWV3Mi50aXRsZSwgIk5l dyBUaXRsZSIpCiAgICAgICAgICAgICB9CiAKKyAgICAgICAgICAgIGZ1bmN0aW9uIHVucXVvdGUo dGV4dCkgeworICAgICAgICAgICAgICAgIHJldHVybiB0ZXh0LnJlcGxhY2UoL14oJyopKFteJ10q KSgnKikkLywgJyQyJykKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgZnVuY3Rpb24gdGVz dF9zdGFuZGFyZEZvbnRGYW1pbHlDaGFuZ2VkKCkgewogICAgICAgICAgICAgICAgIHZhciB1cmwg PSBRdC5yZXNvbHZlZFVybCgiLi4vY29tbW9uL2ZvbnQtcHJlZmVyZW5jZXMuaHRtbD9zdGFuZGFy ZCNmb250LWZhbWlseSIpCiAgICAgICAgICAgICAgICAgd2ViVmlldy51cmwgPSB1cmwKQEAgLTIw Myw3ICsyMDcsNyBAQCBJdGVtIHsKICAgICAgICAgICAgICAgICB0aXRsZVNweS5jbGVhcigpCiAK ICAgICAgICAgICAgICAgICB0aXRsZVNweS53YWl0KCkKLSAgICAgICAgICAgICAgICBjb21wYXJl KHdlYlZpZXcudGl0bGUsIGRlZmF1bHRTdGFuZGFyZEZvbnRGYW1pbHkpCisgICAgICAgICAgICAg ICAgY29tcGFyZSh1bnF1b3RlKHdlYlZpZXcudGl0bGUpLCB1bnF1b3RlKGRlZmF1bHRTdGFuZGFy ZEZvbnRGYW1pbHkpKQogCiAgICAgICAgICAgICAgICAgd2ViVmlldy5leHBlcmltZW50YWwucHJl ZmVyZW5jZXMuc3RhbmRhcmRGb250RmFtaWx5ID0gImZvb2JhciIKICAgICAgICAgICAgICAgICBz dGFuZGFyZEZvbnRGYW1pbHlTcHkud2FpdCgpCg== 143079 2012-05-21 12:54:54 -0700 2012-05-21 13:47:35 -0700 Patch bug-82700-20120521165451.patch text/plain 2241 marcelo.lira U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3ODA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzVmZDFlYjI3NmJmMTgw YjRmNjJkNjZjNTYzZmQxNzFiNGYxNzMwMC4uMWMyMTc3NTA2NjkyNThhNzYxMDFkMTZmZDNkNGU0 ZjU5NmZjMjFhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA1LTIxICBNYXJj ZWxvIExpcmEgIDxtYXJjZWxvLmxpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBbUXRdW1dL Ml0gUkVHUkVTU0lPTiwgZml4IGEgZmFpbGluZyBBUEkgdGVzdCBpbiBxbWx0ZXN0cworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI3MDAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdmFsdWUgb2YgYSBD U1MgZm9udC1mYW1pbHkgcHJvcGVydHkgaXMgZXhwZWN0ZWQgdG8gaGF2ZSBzaW5nbGUKKyAgICAg ICAgcXVvdGVzIHdoZW4gd2hpdGUgc3BhY2UgaXMgcHJlc2VudCBpbiBpdHMgbmFtZSwgYW5kIG5v IHF1b3RlcyBvdGhlcndpc2UuCisgICAgICAgIEZvbnQgZmFtaWx5IG5hbWVzIHJldHVybmVkIGJ5 IFdlYlZpZXcuZXhwZXJpbWVudGFsLnByZWZlcmVuY2VzIG5ldmVyIGFkZCBxdW90ZXMuCisKKyAg ICAgICAgU2luY2Ugd2hhdCBtYXR0ZXIgdG8gdGhlIHRlc3QgaXMgb25seSB0aGUgaWRlbnRpdHkg b2YgdGhlIGZvbnQsIGFuIGF1eGlsaWFyCisgICAgICAgIG1ldGhvZCB0byByZW1vdmUgc2luZ2xl IHF1b3RlcyB3YXMgYWRkZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3Ft bHRlc3RzL1dlYlZpZXcvdHN0X3ByZWZlcmVuY2VzLnFtbDoKKwogMjAxMi0wNS0yMSAgQWxsYW4g U2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4KIAogICAgICAgICBHQ0Mg NC43IGFuZCBDKysxMQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9wcmVmZXJlbmNlcy5xbWwgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X3ByZWZlcmVu Y2VzLnFtbAppbmRleCAxNmZmMzVjNTI5YzE0ZjBhZjY2ZTg4N2RjNDM5ZmE4OWY3YzQ4N2RmLi43 MWZhM2ViOWI5Njg4MTNjZjBkMjRmOTgxZjYwNjBjM2MwNDk0ZDRkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X3By ZWZlcmVuY2VzLnFtbAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3Rz L3FtbHRlc3RzL1dlYlZpZXcvdHN0X3ByZWZlcmVuY2VzLnFtbApAQCAtMTk1LDYgKzE5NSwxMCBA QCBJdGVtIHsKICAgICAgICAgICAgICAgICBjb21wYXJlKHdlYlZpZXcyLnRpdGxlLCAiTmV3IFRp dGxlIikKICAgICAgICAgICAgIH0KIAorICAgICAgICAgICAgZnVuY3Rpb24gdW5xdW90ZSh0ZXh0 KSB7CisgICAgICAgICAgICAgICAgcmV0dXJuIHRleHRbMF0gPT09ICInIiA/IHRleHQuc2xpY2Uo MSwgLTEpIDogdGV4dAorICAgICAgICAgICAgfQorCiAgICAgICAgICAgICBmdW5jdGlvbiB0ZXN0 X3N0YW5kYXJkRm9udEZhbWlseUNoYW5nZWQoKSB7CiAgICAgICAgICAgICAgICAgdmFyIHVybCA9 IFF0LnJlc29sdmVkVXJsKCIuLi9jb21tb24vZm9udC1wcmVmZXJlbmNlcy5odG1sP3N0YW5kYXJk I2ZvbnQtZmFtaWx5IikKICAgICAgICAgICAgICAgICB3ZWJWaWV3LnVybCA9IHVybApAQCAtMjAz LDcgKzIwNyw3IEBAIEl0ZW0gewogICAgICAgICAgICAgICAgIHRpdGxlU3B5LmNsZWFyKCkKIAog ICAgICAgICAgICAgICAgIHRpdGxlU3B5LndhaXQoKQotICAgICAgICAgICAgICAgIGNvbXBhcmUo d2ViVmlldy50aXRsZSwgZGVmYXVsdFN0YW5kYXJkRm9udEZhbWlseSkKKyAgICAgICAgICAgICAg ICBjb21wYXJlKHVucXVvdGUod2ViVmlldy50aXRsZSksIGRlZmF1bHRTdGFuZGFyZEZvbnRGYW1p bHkpCiAKICAgICAgICAgICAgICAgICB3ZWJWaWV3LmV4cGVyaW1lbnRhbC5wcmVmZXJlbmNlcy5z dGFuZGFyZEZvbnRGYW1pbHkgPSAiZm9vYmFyIgogICAgICAgICAgICAgICAgIHN0YW5kYXJkRm9u dEZhbWlseVNweS53YWl0KCkK