82695 2012-03-29 23:25:33 -0700 [BlackBerry] Add local: protocol support in KURL for blackberry 2012-04-04 21:06:51 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73144 1 leo.yang leo.yang charles.wei rwlbuis staikos tonikitoo webkit.review.bot zimmermann oldest_to_newest 591895 0 leo.yang 2012-03-29 23:25:33 -0700 BlackBerry porting is using local: protocol just as file: protocol with the exception that it sandboxes the path to the application private space. 591900 1 134731 leo.yang 2012-03-29 23:29:43 -0700 Created attachment 134731 Patch 594790 2 134731 rwlbuis 2012-04-03 13:12:08 -0700 Comment on attachment 134731 Patch The code change looks ok. Please make sure we really use this code before cq+. 596261 3 leo.yang 2012-04-04 20:35:39 -0700 (In reply to comment #2) > (From update of attachment 134731 [details]) > The code change looks ok. Please make sure we really use this code before cq+. Thanks for your review. We are using KURL::parse() for local:/// urls and we can reach the patched code chunk in KURL::parse(). I don't find a case to reach portAllowed() for both file:/// and local:///. But because there is checking of file:/// protocol in portAllowed(), we should add checking of local:/// since local:/// is same as file:/// here. 596262 4 134731 leo.yang 2012-04-04 20:36:13 -0700 Comment on attachment 134731 Patch Sending to cq ... 596277 5 134731 webkit.review.bot 2012-04-04 21:06:46 -0700 Comment on attachment 134731 Patch Clearing flags on attachment: 134731 Committed r113285: <http://trac.webkit.org/changeset/113285> 596279 6 webkit.review.bot 2012-04-04 21:06:51 -0700 All reviewed patches have been landed. Closing bug. 134731 2012-03-29 23:29:43 -0700 2012-04-04 21:06:46 -0700 Patch 0001-BlackBerry-Add-local-protocol-support-in-KURL-for-bl.patch text/plain 3018 leo.yang RnJvbSAwZWQxNzZhOTgwMjg4OTljMGVjNGNhNzIzMTU4ZDU1ZmMyZmQ5MThjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBGcmksIDMwIE1hciAyMDEyIDE0OjI4OjEyICswODAwClN1YmplY3Q6IFtQQVRDSF0g W0JsYWNrQmVycnldIEFkZCBsb2NhbDogcHJvdG9jb2wgc3VwcG9ydCBpbiBLVVJMIGZvcgogYmxh Y2tiZXJyeSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI2OTUKClJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKQmxhY2tCZXJyeSBwb3J0aW5nIGlzIHVzaW5nIGxv Y2FsOiBwcm90b2NvbCBqdXN0IGFzIGZpbGU6IHByb3RvY29sCndpdGggdGhlIGV4Y2VwdGlvbiB0 aGF0IGl0IHNhbmRib3hlcyB0aGUgcGF0aCB0byB0aGUgYXBwbGljYXRpb24gcHJpdmF0ZSBzcGFj ZS4KCiogcGxhdGZvcm0vS1VSTC5jcHA6CihXZWJDb3JlOjpLVVJMOjpwYXJzZSk6CihXZWJDb3Jl Ojpwb3J0QWxsb3dlZCk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgfCAg IDE0ICsrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmNwcCB8ICAg MTcgKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwg MCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2JmOTNjYi4uZTJjZmJhOSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTI5ICBMZW8gWWFuZyAgPGxlby55YW5nQHRvcmNo bW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQWRkIGxvY2FsOiBwcm90b2Nv bCBzdXBwb3J0IGluIEtVUkwgZm9yIGJsYWNrYmVycnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNjk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQmxhY2tCZXJyeSBwb3J0aW5nIGlzIHVzaW5nIGxvY2Fs OiBwcm90b2NvbCBqdXN0IGFzIGZpbGU6IHByb3RvY29sCisgICAgICAgIHdpdGggdGhlIGV4Y2Vw dGlvbiB0aGF0IGl0IHNhbmRib3hlcyB0aGUgcGF0aCB0byB0aGUgYXBwbGljYXRpb24gcHJpdmF0 ZSBzcGFjZS4KKworICAgICAgICAqIHBsYXRmb3JtL0tVUkwuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6S1VSTDo6cGFyc2UpOgorICAgICAgICAoV2ViQ29yZTo6cG9ydEFsbG93ZWQpOgorCiAyMDEy LTAzLTI5ICBBbGV4YW5kcnUgQ2hpY3VsaXRhICA8YWNoaWN1QGFkb2JlLmNvbT4KIAogICAgICAg ICBbQ1NTIEZpbHRlcnNdIFRyaWdnZXIgYSByZXBhaW50IG9uIGVsZW1lbnRzIHdpdGggY2hhbmdl ZCBmaWx0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKaW5kZXggOTMwNjQ0Ny4uZDk3YTVmMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKQEAgLTEsNSArMSw2IEBACiAvKgogICogQ29weXJp Z2h0IChDKSAyMDA0LCAyMDA3LCAyMDA4LCAyMDExLCAyMDEyIEFwcGxlIEluYy4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMiBSZXNlYXJjaCBJbiBNb3Rpb24gTGlt aXRlZC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cwpAQCAtMTEwNyw2ICsxMTA4LDE3IEBAIHZvaWQgS1VSTDo6cGFyc2UoY29uc3QgY2hhciogdXJs LCBjb25zdCBTdHJpbmcqIG9yaWdpbmFsU3RyaW5nKQogICAgICAgICAmJiBpc0xldHRlck1hdGNo SWdub3JpbmdDYXNlKHVybFsyXSwgJ2wnKQogICAgICAgICAmJiBpc0xldHRlck1hdGNoSWdub3Jp bmdDYXNlKHVybFszXSwgJ2UnKTsKIAorI2lmIFBMQVRGT1JNKEJMQUNLQkVSUlkpCisgICAgLy8g UGFyc2UgbG9jYWw6IHVybHMgdGhlIHNhbWUgYXMgZmlsZTogdXJscy4KKyAgICBpZiAoIWlzRmls ZSkKKyAgICAgICAgaXNGaWxlID0gc2NoZW1lRW5kID09IDUKKyAgICAgICAgICAgICYmIGlzTGV0 dGVyTWF0Y2hJZ25vcmluZ0Nhc2UodXJsWzBdLCAnbCcpCisgICAgICAgICAgICAmJiBpc0xldHRl ck1hdGNoSWdub3JpbmdDYXNlKHVybFsxXSwgJ28nKQorICAgICAgICAgICAgJiYgaXNMZXR0ZXJN YXRjaElnbm9yaW5nQ2FzZSh1cmxbMl0sICdjJykKKyAgICAgICAgICAgICYmIGlzTGV0dGVyTWF0 Y2hJZ25vcmluZ0Nhc2UodXJsWzNdLCAnYScpCisgICAgICAgICAgICAmJiBpc0xldHRlck1hdGNo SWdub3JpbmdDYXNlKHVybFs0XSwgJ2wnKTsKKyNlbmRpZgorCiAgICAgbV9wcm90b2NvbElzSW5I VFRQRmFtaWx5ID0gaXNMZXR0ZXJNYXRjaElnbm9yaW5nQ2FzZSh1cmxbMF0sICdoJykKICAgICAg ICAgJiYgaXNMZXR0ZXJNYXRjaElnbm9yaW5nQ2FzZSh1cmxbMV0sICd0JykKICAgICAgICAgJiYg aXNMZXR0ZXJNYXRjaElnbm9yaW5nQ2FzZSh1cmxbMl0sICd0JykKQEAgLTE4NzEsNiArMTg4Mywx MSBAQCBib29sIHBvcnRBbGxvd2VkKGNvbnN0IEtVUkwmIHVybCkKICAgICBpZiAodXJsLnByb3Rv Y29sSXMoImZpbGUiKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKKyNpZiBQTEFURk9STShCTEFD S0JFUlJZKQorICAgIGlmICh1cmwucHJvdG9jb2xJcygibG9jYWwiKSkKKyAgICAgICAgcmV0dXJu IHRydWU7CisjZW5kaWYKKwogICAgIHJldHVybiBmYWxzZTsKIH0KIAotLSAKMS43LjUuNAoK