82573 2012-03-28 22:34:38 -0700 [BlackBerry] Turn on STORE_FONT_CUSTOM_PLATFORM_DATA in CachedFont.cpp 2012-03-29 20:04:46 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73144 1 leo.yang leo.yang charles.wei japhet rwlbuis staikos tonikitoo webkit.review.bot zimmermann oldest_to_newest 590849 0 leo.yang 2012-03-28 22:34:38 -0700 Turn on STORE_FONT_CUSTOM_PLATFORM_DATA in CachedFont.cpp for blackberry porting. 590855 1 134501 leo.yang 2012-03-28 22:38:42 -0700 Created attachment 134501 Patch 591139 2 134501 rwlbuis 2012-03-29 06:53:17 -0700 Comment on attachment 134501 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=134501&action=review Looks good. > Source/WebCore/ChangeLog:7 > + You should mention here that it is covered by existing tests. 591799 3 134709 leo.yang 2012-03-29 18:43:05 -0700 Created attachment 134709 Patch for landing 591801 4 leo.yang 2012-03-29 18:44:41 -0700 (In reply to comment #2) > (From update of attachment 134501 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=134501&action=review > > Looks good. > > > Source/WebCore/ChangeLog:7 > > + > > You should mention here that it is covered by existing tests. I added this in the revised patch. Thanks for your review. 591839 5 134709 webkit.review.bot 2012-03-29 20:04:41 -0700 Comment on attachment 134709 Patch for landing Clearing flags on attachment: 134709 Committed r112640: <http://trac.webkit.org/changeset/112640> 591840 6 webkit.review.bot 2012-03-29 20:04:46 -0700 All reviewed patches have been landed. Closing bug. 134501 2012-03-28 22:38:42 -0700 2012-03-29 18:43:05 -0700 Patch 0001-BlackBerry-Turn-on-STORE_FONT_CUSTOM_PLATFORM_DATA-i.patch text/plain 1810 leo.yang RnJvbSBkNjM3M2ZkMzFhZDMyM2U5NzVhNmZlYWY3M2JjNmRlNzBhNzQ2NmY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBUaHUsIDI5IE1hciAyMDEyIDEzOjM4OjEyICswODAwClN1YmplY3Q6IFtQQVRDSF0g W0JsYWNrQmVycnldIFR1cm4gb24gU1RPUkVfRk9OVF9DVVNUT01fUExBVEZPUk1fREFUQSBpbgog Q2FjaGVkRm9udC5jcHAKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 MjU3MwoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIGxvYWRlci9jYWNoZS9DYWNoZWRG b250LmNwcDoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg fCAgICA5ICsrKysrKysrKwogU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZEZvbnQu Y3BwIHwgICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwMmE0NDkzLi4xZDYzNGMyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTItMDMtMjggIExlbyBZYW5nICA8bGVvLnlhbmdAdG9yY2htb2JpbGUu Y29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBUdXJuIG9uIFNUT1JFX0ZPTlRfQ1VTVE9N X1BMQVRGT1JNX0RBVEEgaW4gQ2FjaGVkRm9udC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNTczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkRm9udC5jcHA6CisK IDIwMTItMDMtMjggIEphc29uIExpdSAgPGphc29uLmxpdUB0b3JjaG1vYmlsZS5jb20uY24+CiAK ICAgICAgICAgW0JsYWNrQmVycnldTWlzc2luZyBjb29raWVzIGZyb20gSFRUUCByZXNwb25zZSBo ZWFkZXIgaW4gTmV0d29yayB0YWIgb2YgV2ViIEluc3BlY3Rvci4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRGb250LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9jYWNoZS9DYWNoZWRGb250LmNwcAppbmRleCBkYzg1NjdmLi41NmY4N2QyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkRm9udC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZEZvbnQuY3BwCkBAIC0yOCw3ICsyOCw3IEBA CiAjaW5jbHVkZSAiQ2FjaGVkRm9udC5oIgogCiAvLyBGSVhNRTogVGhpcyBzaG91bGQgcmVhbGx5 IGJlIGEgYmxhY2tsaXN0IGluc3RlYWQgb2YgYSB3aGl0ZWxpc3QKLSNpZiBVU0UoQ0cpIHx8IFBM QVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEspIHx8IChQTEFURk9STShDSFJPTUlVTSkgJiYgKCFP UyhEQVJXSU4pIHx8IFVTRShTS0lBX09OX01BQ19DSFJPTUlVTSkpKSB8fCBPUyhXSU5DRSkKKyNp ZiBVU0UoQ0cpIHx8IFBMQVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEspIHx8IChQTEFURk9STShD SFJPTUlVTSkgJiYgKCFPUyhEQVJXSU4pIHx8IFVTRShTS0lBX09OX01BQ19DSFJPTUlVTSkpKSB8 fCBPUyhXSU5DRSkgfHwgUExBVEZPUk0oQkxBQ0tCRVJSWSkKICNkZWZpbmUgU1RPUkVfRk9OVF9D VVNUT01fUExBVEZPUk1fREFUQQogI2VuZGlmCiAKLS0gCjEuNy41LjQKCg== 134709 2012-03-29 18:43:05 -0700 2012-03-29 20:04:41 -0700 Patch for landing 0001-BlackBerry-Turn-on-STORE_FONT_CUSTOM_PLATFORM_DATA-i.patch text/plain 1844 leo.yang RnJvbSA2YWQ0MzYxY2NlN2UzY2NhOGJhOGFjMTUzZjgyOTI1YzQ2MjA0YTZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBGcmksIDMwIE1hciAyMDEyIDA5OjQyOjAxICswODAwClN1YmplY3Q6IFtQQVRDSF0g W0JsYWNrQmVycnldIFR1cm4gb24gU1RPUkVfRk9OVF9DVVNUT01fUExBVEZPUk1fREFUQSBpbgog Q2FjaGVkRm9udC5jcHAKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 MjU3MwoKUmV2aWV3ZWQgYnkgUm9iIEJ1aXMuCgpUZXN0czogY292ZXJlZCBieSBleGlzdGluZyB0 ZXN0cy4KCiogbG9hZGVyL2NhY2hlL0NhY2hlZEZvbnQuY3BwOgotLS0KIFNvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysKIFNvdXJjZS9X ZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRGb250LmNwcCB8ICAgIDIgKy0KIDIgZmlsZXMgY2hh bmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWJh YTQzZC4uYTdmOWY0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTI5ICBM ZW8gWWFuZyAgPGxlby55YW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tC ZXJyeV0gVHVybiBvbiBTVE9SRV9GT05UX0NVU1RPTV9QTEFURk9STV9EQVRBIGluIENhY2hlZEZv bnQuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 MjU3MworCisgICAgICAgIFJldmlld2VkIGJ5IFJvYiBCdWlzLgorCisgICAgICAgIFRlc3RzOiBj b3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hl ZEZvbnQuY3BwOgorCiAyMDEyLTAzLTI5ICBCZWFyIFRyYXZpcyAgPGJldHJhdmlzQGFkb2JlLmNv bT4KIAogICAgICAgICBVcGRhdGUgc2hhcGUtaW5zaWRlL3NoYXBlLW91dHNpZGUgQ1NTIEV4Y2x1 c2lvbiBwcm9wZXJ0aWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUv Q2FjaGVkRm9udC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkRm9udC5j cHAKaW5kZXggZGM4NTY3Zi4uNTZmODdkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL0NhY2hlZEZvbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNo ZS9DYWNoZWRGb250LmNwcApAQCAtMjgsNyArMjgsNyBAQAogI2luY2x1ZGUgIkNhY2hlZEZvbnQu aCIKIAogLy8gRklYTUU6IFRoaXMgc2hvdWxkIHJlYWxseSBiZSBhIGJsYWNrbGlzdCBpbnN0ZWFk IG9mIGEgd2hpdGVsaXN0Ci0jaWYgVVNFKENHKSB8fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0o R1RLKSB8fCAoUExBVEZPUk0oQ0hST01JVU0pICYmICghT1MoREFSV0lOKSB8fCBVU0UoU0tJQV9P Tl9NQUNfQ0hST01JVU0pKSkgfHwgT1MoV0lOQ0UpCisjaWYgVVNFKENHKSB8fCBQTEFURk9STShR VCkgfHwgUExBVEZPUk0oR1RLKSB8fCAoUExBVEZPUk0oQ0hST01JVU0pICYmICghT1MoREFSV0lO KSB8fCBVU0UoU0tJQV9PTl9NQUNfQ0hST01JVU0pKSkgfHwgT1MoV0lOQ0UpIHx8IFBMQVRGT1JN KEJMQUNLQkVSUlkpCiAjZGVmaW5lIFNUT1JFX0ZPTlRfQ1VTVE9NX1BMQVRGT1JNX0RBVEEKICNl bmRpZgogCi0tIAoxLjcuNS40Cgo=