82529 2012-03-28 14:16:17 -0700 Remove unnecessary rounding in RenderLayerBacking 2012-03-28 15:09:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 eae eae eric leviw webkit.review.bot oldest_to_newest 590418 0 eae 2012-03-28 14:16:17 -0700 We have a couple of calls to pixelSnappedIntRect in RenderLayerBacking that are no longer required. 590427 1 134398 eae 2012-03-28 14:20:37 -0700 Created attachment 134398 Patch 590446 2 134398 eric 2012-03-28 14:36:15 -0700 Comment on attachment 134398 Patch The amount of massaging to get this all right has been astounding. 590452 3 eae 2012-03-28 14:39:32 -0700 (In reply to comment #2) > (From update of attachment 134398 [details]) > The amount of massaging to get this all right has been astounding. No kidding! 590496 4 134398 webkit.review.bot 2012-03-28 15:09:46 -0700 Comment on attachment 134398 Patch Clearing flags on attachment: 134398 Committed r112450: <http://trac.webkit.org/changeset/112450> 590497 5 webkit.review.bot 2012-03-28 15:09:51 -0700 All reviewed patches have been landed. Closing bug. 134398 2012-03-28 14:20:37 -0700 2012-03-28 15:09:46 -0700 Patch bug-82529-20120328142036.patch text/plain 3233 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjQzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAzLTI4ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3Nhcnkg cm91bmRpbmcgaW4gUmVuZGVyTGF5ZXJCYWNraW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MjUyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSByb3VuZGluZyB0aGF0IGlzIG5vIGxvbmdlciBy ZXF1aXJlZCBub3cgdGhhdCBib3JkZXJCb3hSZWN0IHJldHVybnMKKyAgICAgICAgYW4gSW50UmVj dC4KKyAgICAgICAgCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJMYXllckJhY2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJC YWNraW5nOjp1cGRhdGVHcmFwaGljc0xheWVyR2VvbWV0cnkpOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyTGF5ZXJCYWNraW5nOjpzdGFydEFuaW1hdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJMYXllckJhY2tpbmc6OnN0YXJ0VHJhbnNpdGlvbik6CisKIDIwMTItMDMtMjggIEZsb3Jp biBNYWxpdGEgIDxmbWFsaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgSW5jb3JyZWN0IGZvcmVp Z25PYmplY3QgaGl0IHRlc3QgcmVzdWx0cyB3aGVuIG92ZXJsYXBwaW5nIG90aGVyIFNWRyBlbGVt ZW50cwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFj a2luZy5jcHAJKHJldmlzaW9uIDExMjMyOSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllckJhY2tpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MDIsNyArNTAyLDcgQEAg dm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0ZUdyYXBoaWNzTAogICAgIH0KICAgICAKICAg ICBpZiAobV9vd25pbmdMYXllci0+aGFzVHJhbnNmb3JtKCkpIHsKLSAgICAgICAgY29uc3QgSW50 UmVjdCBib3JkZXJCb3ggPSBwaXhlbFNuYXBwZWRJbnRSZWN0KHRvUmVuZGVyQm94KHJlbmRlcmVy KCkpLT5ib3JkZXJCb3hSZWN0KCkpOworICAgICAgICBjb25zdCBJbnRSZWN0IGJvcmRlckJveCA9 IHRvUmVuZGVyQm94KHJlbmRlcmVyKCkpLT5ib3JkZXJCb3hSZWN0KCk7CiAKICAgICAgICAgLy8g R2V0IGxheW91dCBib3VuZHMgaW4gdGhlIGNvb3JkcyBvZiBjb21wQW5jZXN0b3IgdG8gbWF0Y2gg cmVsYXRpdmVDb21wb3NpdGluZ0JvdW5kcy4KICAgICAgICAgSW50UmVjdCBsYXllckJvdW5kcyA9 IEludFJlY3QoZGVsdGEsIGJvcmRlckJveC5zaXplKCkpOwpAQCAtMTI3Nyw3ICsxMjc3LDcgQEAg Ym9vbCBSZW5kZXJMYXllckJhY2tpbmc6OnN0YXJ0QW5pbWF0aW9uKAogICAgIGJvb2wgZGlkQW5p bWF0ZUZpbHRlciA9IGZhbHNlOwogI2VuZGlmCiAgICAgCi0gICAgaWYgKGhhc1RyYW5zZm9ybSAm JiBtX2dyYXBoaWNzTGF5ZXItPmFkZEFuaW1hdGlvbih0cmFuc2Zvcm1WZWN0b3IsIHBpeGVsU25h cHBlZEludFJlY3QodG9SZW5kZXJCb3gocmVuZGVyZXIoKSktPmJvcmRlckJveFJlY3QoKSkuc2l6 ZSgpLCBhbmltLCBrZXlmcmFtZXMuYW5pbWF0aW9uTmFtZSgpLCB0aW1lT2Zmc2V0KSkgeworICAg IGlmIChoYXNUcmFuc2Zvcm0gJiYgbV9ncmFwaGljc0xheWVyLT5hZGRBbmltYXRpb24odHJhbnNm b3JtVmVjdG9yLCB0b1JlbmRlckJveChyZW5kZXJlcigpKS0+Ym9yZGVyQm94UmVjdCgpLnNpemUo KSwgYW5pbSwga2V5ZnJhbWVzLmFuaW1hdGlvbk5hbWUoKSwgdGltZU9mZnNldCkpIHsKICAgICAg ICAgZGlkQW5pbWF0ZVRyYW5zZm9ybSA9IHRydWU7CiAgICAgICAgIGNvbXBvc2l0b3IoKS0+ZGlk U3RhcnRBY2NlbGVyYXRlZEFuaW1hdGlvbihDU1NQcm9wZXJ0eVdlYmtpdFRyYW5zZm9ybSk7CiAg ICAgfQpAQCAtMTM0Miw3ICsxMzQyLDcgQEAgYm9vbCBSZW5kZXJMYXllckJhY2tpbmc6OnN0YXJ0 VHJhbnNpdGlvbgogICAgICAgICAgICAgS2V5ZnJhbWVWYWx1ZUxpc3QgdHJhbnNmb3JtVmVjdG9y KEFuaW1hdGVkUHJvcGVydHlXZWJraXRUcmFuc2Zvcm0pOwogICAgICAgICAgICAgdHJhbnNmb3Jt VmVjdG9yLmluc2VydChuZXcgVHJhbnNmb3JtQW5pbWF0aW9uVmFsdWUoMCwgJmZyb21TdHlsZS0+ dHJhbnNmb3JtKCkpKTsKICAgICAgICAgICAgIHRyYW5zZm9ybVZlY3Rvci5pbnNlcnQobmV3IFRy YW5zZm9ybUFuaW1hdGlvblZhbHVlKDEsICZ0b1N0eWxlLT50cmFuc2Zvcm0oKSkpOwotICAgICAg ICAgICAgaWYgKG1fZ3JhcGhpY3NMYXllci0+YWRkQW5pbWF0aW9uKHRyYW5zZm9ybVZlY3Rvciwg cGl4ZWxTbmFwcGVkSW50UmVjdCh0b1JlbmRlckJveChyZW5kZXJlcigpKS0+Ym9yZGVyQm94UmVj dCgpKS5zaXplKCksIHRyYW5zZm9ybUFuaW0sIEdyYXBoaWNzTGF5ZXI6OmFuaW1hdGlvbk5hbWVG b3JUcmFuc2l0aW9uKEFuaW1hdGVkUHJvcGVydHlXZWJraXRUcmFuc2Zvcm0pLCB0aW1lT2Zmc2V0 KSkgeworICAgICAgICAgICAgaWYgKG1fZ3JhcGhpY3NMYXllci0+YWRkQW5pbWF0aW9uKHRyYW5z Zm9ybVZlY3RvciwgdG9SZW5kZXJCb3gocmVuZGVyZXIoKSktPmJvcmRlckJveFJlY3QoKS5zaXpl KCksIHRyYW5zZm9ybUFuaW0sIEdyYXBoaWNzTGF5ZXI6OmFuaW1hdGlvbk5hbWVGb3JUcmFuc2l0 aW9uKEFuaW1hdGVkUHJvcGVydHlXZWJraXRUcmFuc2Zvcm0pLCB0aW1lT2Zmc2V0KSkgewogICAg ICAgICAgICAgICAgIC8vIFRvIGVuc3VyZSB0aGF0IHRoZSBjb3JyZWN0IHRyYW5zZm9ybSBpcyB2 aXNpYmxlIHdoZW4gdGhlIGFuaW1hdGlvbiBlbmRzLCBhbHNvIHNldCB0aGUgZmluYWwgdHJhbnNm b3JtLgogICAgICAgICAgICAgICAgIHVwZGF0ZUxheWVyVHJhbnNmb3JtKHRvU3R5bGUpOwogICAg ICAgICAgICAgICAgIGRpZEFuaW1hdGVUcmFuc2Zvcm0gPSB0cnVlOwo=