82364 2012-03-27 12:02:45 -0700 cssText should not generate literal 'initial' in shorthand properties 2012-03-27 15:01:10 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 81737 1 max.hong.shen rniwa enrica kling koivisto macpherson menard rniwa simon.fraser webkit.review.bot oldest_to_newest 589114 0 max.hong.shen 2012-03-27 12:02:45 -0700 After the code change for bug 81737, the new markup is using shorthand notations as desired, however, it may generate a string like "border: initial solid red", which is an invalid declaration because the "initial" keyword is now combined with other component values in the same declaration. "border: initial solid red" should be "border: solid red" 589239 1 134129 rniwa 2012-03-27 13:57:20 -0700 Created attachment 134129 Fixes the bug 589241 2 rniwa 2012-03-27 13:57:50 -0700 This is causing a regression in editing because copy & pasted markup now has literal "initial" in some cases, and CSS parser can't handle that. 589254 3 134129 menard 2012-03-27 14:06:48 -0700 Comment on attachment 134129 Fixes the bug Looks ok to me as a workaround. We really need to nail this problem better in the future. Happy to see that my proposed solution worked. 589273 4 max.hong.shen 2012-03-27 14:17:00 -0700 Just curious, how about StylePropertySet::get4Values(), can it generate a string contains "initial" 589276 5 menard 2012-03-27 14:19:44 -0700 (In reply to comment #4) > Just curious, how about StylePropertySet::get4Values(), can it generate a string contains "initial" Possibly according to the code. Maybe we should fix it there as in theory getPropertyValue could return something buggy. Needs to be tested though. 589283 6 menard 2012-03-27 14:21:22 -0700 (In reply to comment #5) > (In reply to comment #4) > > Just curious, how about StylePropertySet::get4Values(), can it generate a string contains "initial" > > Possibly according to the code. Maybe we should fix it there as in theory getPropertyValue could return something buggy. Needs to be tested though. But it will return only initial once. 589287 7 134129 koivisto 2012-03-27 14:26:27 -0700 Comment on attachment 134129 Fixes the bug This probably should differentiate between implicit and explicit initial. r=me in any case as this fixes a regression. 589323 8 rniwa 2012-03-27 15:01:10 -0700 Committed r112321: <http://trac.webkit.org/changeset/112321> 134129 2012-03-27 13:57:20 -0700 2012-03-27 14:26:27 -0700 Fixes the bug bug-82364-20120327135719.patch text/plain 7069 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjMxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTAzLTI3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGNzc1RleHQgc2hvdWxkIG5vdCBn ZW5lcmF0ZSBsaXRlcmFsICdpbml0aWFsJyBpbiBzaG9ydGhhbmQgcHJvcGVydGllcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIzNjQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCB0aGUgYnVnIGJ5 IHRyZWF0aW5nIGluaXRpYWwgdmFsdWUgYXMgaWYgdGhlIHZhbHVlIGlzIG5vdCBzZXQuCisgICAg ICAgIFdoaWxlIHRoaXMgaXMgaW5jb3JyZWN0IGZvciBwcm9wZXJ0aWVzIHRoYXQgaW5oZXJpdHMg YnkgZGVmYXVsdCwKKyAgICAgICAgaXQncyBzdHJpY3RseSBiZXR0ZXIgdGhhbiBnZW5lcmF0aW5n IHVucGFyc2FibGUgdmFsdWUgYXMgd2UgZG8gdG9kYXkuCisKKyAgICAgICAgVGhlIHByb3BlciBm aXggaXMgZm9yIENTU0luaXRpYWxWYWx1ZTo6Y3NzVGV4dCB0byBmZXRjaCB0aGUgcmVzcGVjdGl2 ZQorICAgICAgICBkZWZhdWx0IHZhbHVlIGZyb20gd2hhdCdzIGN1cnJlbnRseSBpbiBDU1NTdHls ZVNlbGVjdG9yIGNvZGUgYnV0IHRoYXQgcmVxdWlyZXMKKyAgICAgICAgYSBjb25zaWRlcmFibGUg YW1vdW50IG9mIHJlZmFjdG9yaW5nIGFuZCB3b3JrLgorCisgICAgICAgICogY3NzL1N0eWxlUHJv cGVydHlTZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVQcm9wZXJ0eVNldDo6Z2V0U2hv cnRoYW5kVmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVQcm9wZXJ0eVNldDo6Z2V0Q29t bW9uVmFsdWUpOgorCiAyMDEyLTAzLTI3ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxl LmNvbT4KIAogICAgICAgICBNYWtlIFdlYktpdCBwcm9wZXJseSBsb2FkIGEgc3RhZ2VkIGZyYW1l d29yayB3aGVuIHNvZnQgbGlua2luZy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVBy b3BlcnR5U2V0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9w ZXJ0eVNldC5jcHAJKHJldmlzaW9uIDExMjI3OSkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHls ZVByb3BlcnR5U2V0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzgyLDggKzM4Miw4IEBAIFN0cmlu ZyBTdHlsZVByb3BlcnR5U2V0OjpnZXRTaG9ydGhhbmRWYWwKICAgICBmb3IgKHVuc2lnbmVkIGkg PSAwOyBpIDwgbG9uZ2hhbmQubGVuZ3RoKCk7ICsraSkgewogICAgICAgICBpZiAoIWlzUHJvcGVy dHlJbXBsaWNpdChsb25naGFuZC5wcm9wZXJ0aWVzKClbaV0pKSB7CiAgICAgICAgICAgICBSZWZQ dHI8Q1NTVmFsdWU+IHZhbHVlID0gZ2V0UHJvcGVydHlDU1NWYWx1ZShsb25naGFuZC5wcm9wZXJ0 aWVzKClbaV0pOwotICAgICAgICAgICAgLy8gRklYTUU6IHByb3ZpZGUgZGVmYXVsdCB2YWx1ZSBp ZiAhdmFsdWUKLSAgICAgICAgICAgIGlmICh2YWx1ZSkgeworICAgICAgICAgICAgLy8gRklYTUU6 IHByb3ZpZGUgZGVmYXVsdCB2YWx1ZSBpZiAhdmFsdWUgb3IgdmFsdWUgaXMgaW5pdGlhbCB2YWx1 ZQorICAgICAgICAgICAgaWYgKHZhbHVlICYmICF2YWx1ZS0+aXNJbml0aWFsVmFsdWUoKSkgewog ICAgICAgICAgICAgICAgIGlmICghcmVzLmlzTnVsbCgpKQogICAgICAgICAgICAgICAgICAgICBy ZXMgKz0gIiAiOwogICAgICAgICAgICAgICAgIHJlcyArPSB2YWx1ZS0+Y3NzVGV4dCgpOwpAQCAt Mzk5LDcgKzM5OSw4IEBAIFN0cmluZyBTdHlsZVByb3BlcnR5U2V0OjpnZXRDb21tb25WYWx1ZSgK ICAgICBTdHJpbmcgcmVzOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBsb25naGFuZC5s ZW5ndGgoKTsgKytpKSB7CiAgICAgICAgIFJlZlB0cjxDU1NWYWx1ZT4gdmFsdWUgPSBnZXRQcm9w ZXJ0eUNTU1ZhbHVlKGxvbmdoYW5kLnByb3BlcnRpZXMoKVtpXSk7Ci0gICAgICAgIGlmICghdmFs dWUpCisgICAgICAgIC8vIEZJWE1FOiBDU1NJbml0aWFsVmFsdWU6OmNzc1RleHQgc2hvdWxkIGdl bmVyYXRlIHRoZSByaWdodCB2YWx1ZS4KKyAgICAgICAgaWYgKCF2YWx1ZSB8fCB2YWx1ZS0+aXNJ bml0aWFsVmFsdWUoKSkKICAgICAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKICAgICAgICAgU3Ry aW5nIHRleHQgPSB2YWx1ZS0+Y3NzVGV4dCgpOwogICAgICAgICBpZiAodGV4dC5pc051bGwoKSkK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDExMjMxMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTI3ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGNzc1RleHQgc2hvdWxkIG5vdCBnZW5lcmF0ZSBs aXRlcmFsICdpbml0aWFsJyBpbiBzaG9ydGhhbmQgcHJvcGVydGllcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIzNjQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY3NzL2Nzc1RleHQtc2hvcnRo YW5kLWV4cGVjdGVkLnR4dDogUmViYXNlbGluZWQuCisgICAgICAgICogZmFzdC9jc3MvY3NzVGV4 dC1zaG9ydGhhbmQuaHRtbDoKKwogMjAxMi0wMy0yNyAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBNYXJrIG1lZGlhL3RyYWNrL3RyYWNrLWRlbGV0ZS1kdXJp bmctc3RhcnR1cCBhcyBjcmFzaGluZyBpbiBkZWJ1Zy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv Y3NzL2Nzc1RleHQtc2hvcnRoYW5kLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2Nzcy9jc3NUZXh0LXNob3J0aGFuZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDEx MjI3OSkKKysrIExheW91dFRlc3RzL2Zhc3QvY3NzL2Nzc1RleHQtc2hvcnRoYW5kLWV4cGVjdGVk LnR4dAkod29ya2luZyBjb3B5KQpAQCAtMywxNiArMywxNiBAQCBUaGlzIHRlc3QgZW5zdXJlcyBX ZWJLaXQgdXNlcyBzaG9ydGhhbmQgCiBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMg b2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCiAKIAotUEFT UyBub3JtYWxpemVDc3NUZXh0KGVsZW1lbnQuc3R5bGUuY3NzVGV4dCkgaXMgImJvcmRlcjogMXB4 IGluaXRpYWwgaW5pdGlhbCIKK1BBU1Mgbm9ybWFsaXplQ3NzVGV4dChlbGVtZW50LnN0eWxlLmNz c1RleHQpIGlzICJib3JkZXI6IDFweCIKIFBBU1Mgbm9ybWFsaXplQ3NzVGV4dChlbGVtZW50LnN0 eWxlLmNzc1RleHQpIGlzICJib3JkZXI6IDFweCBzb2xpZCByZWQiCi1QQVNTIG5vcm1hbGl6ZUNz c1RleHQoZWxlbWVudC5zdHlsZS5jc3NUZXh0KSBpcyAiYm9yZGVyOiAxcHggaW5pdGlhbCByZWQi Ci1QQVNTIG5vcm1hbGl6ZUNzc1RleHQoZWxlbWVudC5zdHlsZS5jc3NUZXh0KSBpcyAiYm9yZGVy OiBpbml0aWFsIGluaXRpYWwgcmVkIgotUEFTUyBub3JtYWxpemVDc3NUZXh0KGVsZW1lbnQuc3R5 bGUuY3NzVGV4dCkgaXMgImJvcmRlcjogMXB4IGluaXRpYWwgaW5pdGlhbCIKK1BBU1Mgbm9ybWFs aXplQ3NzVGV4dChlbGVtZW50LnN0eWxlLmNzc1RleHQpIGlzICJib3JkZXI6IDFweCByZWQiCitQ QVNTIG5vcm1hbGl6ZUNzc1RleHQoZWxlbWVudC5zdHlsZS5jc3NUZXh0KSBpcyAiYm9yZGVyOiBy ZWQiCitQQVNTIG5vcm1hbGl6ZUNzc1RleHQoZWxlbWVudC5zdHlsZS5jc3NUZXh0KSBpcyAiYm9y ZGVyOiAxcHgiCiBQQVNTIG5vcm1hbGl6ZUNzc1RleHQoZWxlbWVudC5zdHlsZS5jc3NUZXh0KSBp cyAiYm9yZGVyLWJvdHRvbS13aWR0aDogM3B4OyBib3JkZXItbGVmdC13aWR0aDogNHB4OyBib3Jk ZXItcmlnaHQtd2lkdGg6IDJweDsgYm9yZGVyLXRvcC13aWR0aDogMXB4IgogUEFTUyBub3JtYWxp emVDc3NUZXh0KGVsZW1lbnQuc3R5bGUuY3NzVGV4dCkgaXMgImJvcmRlci1ib3R0b20td2lkdGg6 IDFweDsgYm9yZGVyLWxlZnQtd2lkdGg6IDFweDsgYm9yZGVyLXJpZ2h0LXdpZHRoOiAxcHg7IGJv cmRlci10b3Atd2lkdGg6IDJweCIKIFBBU1Mgbm9ybWFsaXplQ3NzVGV4dChlbGVtZW50LnN0eWxl LmNzc1RleHQpIGlzICJib3JkZXItYm90dG9tLXdpZHRoOiAxcHg7IGJvcmRlci1sZWZ0LXdpZHRo OiAxcHg7IGJvcmRlci1yaWdodC13aWR0aDogMXB4OyBib3JkZXItdG9wLXdpZHRoOiAxcHggIWlt cG9ydGFudCIKIFBBU1Mgbm9ybWFsaXplQ3NzVGV4dChlbGVtZW50LnN0eWxlLmNzc1RleHQpIGlz ICJib3JkZXItYm90dG9tLXdpZHRoOiAxcHg7IGJvcmRlci1sZWZ0LXdpZHRoOiAxcHg7IGJvcmRl ci1yaWdodC13aWR0aDogMXB4OyBib3JkZXItdG9wLWNvbG9yOiByZWQ7IGJvcmRlci10b3Atd2lk dGg6IDFweCIKLVBBU1Mgbm9ybWFsaXplQ3NzVGV4dChlbGVtZW50LnN0eWxlLmNzc1RleHQpIGlz ICJib3JkZXI6IGluaXRpYWwgZG90dGVkIGluaXRpYWwiCitQQVNTIG5vcm1hbGl6ZUNzc1RleHQo ZWxlbWVudC5zdHlsZS5jc3NUZXh0KSBpcyAiYm9yZGVyOiBkb3R0ZWQiCiBQQVNTIG5vcm1hbGl6 ZUNzc1RleHQoZWxlbWVudC5zdHlsZS5jc3NUZXh0KSBpcyAiYm9yZGVyLXNwYWNpbmc6IDFweCAy cHgiCiBQQVNTIG5vcm1hbGl6ZUNzc1RleHQoZWxlbWVudC5zdHlsZS5jc3NUZXh0KSBpcyAiZm9u dC1mYW1pbHk6IHNhbnMtc2VyaWY7IGZvbnQtc2l6ZTogM2VtOyBmb250LXN0eWxlOiBpdGFsaWM7 IGZvbnQtd2VpZ2h0OiBib2xkOyBsaW5lLWhlaWdodDogMmVtIgogUEFTUyBub3JtYWxpemVDc3NU ZXh0KGVsZW1lbnQuc3R5bGUuY3NzVGV4dCkgaXMgImxpc3Qtc3R5bGU6IGNpcmNsZSBpbnNpZGUi CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9jc3NUZXh0LXNob3J0aGFuZC5odG1sCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY3NzL2Nzc1RleHQtc2hvcnRoYW5kLmh0bWwJKHJl dmlzaW9uIDExMjI3OSkKKysrIExheW91dFRlc3RzL2Zhc3QvY3NzL2Nzc1RleHQtc2hvcnRoYW5k Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTgsMTEgKzgsMTEgQEAgZGVzY3JpcHRpb24oIlRoaXMg dGVzdCBlbnN1cmVzIFdlYktpdCB1cwogCiB2YXIgdGVzdHMgPSBbCiAgICAgLy8gRklYTUU6IFRo aXMgZXhoaWJpdHMgYSBidWcuIFdlIHNob3VsZG4ndCBiZSBvdXRwdXRpbmcgYm9yZGVyLWltYWdl IGhlcmUuCi0gICAgWydib3JkZXI6IDFweDsgYm9yZGVyLXRvcDogMXB4OycsICdib3JkZXI6IDFw eCBpbml0aWFsIGluaXRpYWw7J10sCisgICAgWydib3JkZXI6IDFweDsgYm9yZGVyLXRvcDogMXB4 OycsICdib3JkZXI6IDFweDsnXSwKICAgICBbJ2JvcmRlcjogMXB4IHNvbGlkIHJlZDsnLCAnYm9y ZGVyOiAxcHggc29saWQgcmVkOyddLAotICAgIFsnYm9yZGVyOiAxcHggcmVkOycsICdib3JkZXI6 IDFweCBpbml0aWFsIHJlZDsnXSwKLSAgICBbJ2JvcmRlcjogcmVkOycsICdib3JkZXI6IGluaXRp YWwgaW5pdGlhbCByZWQ7J10sCi0gICAgWydib3JkZXItdG9wOiAxcHg7IGJvcmRlci1yaWdodDog MXB4OyBib3JkZXItYm90dG9tOiAxcHg7IGJvcmRlci1sZWZ0OiAxcHg7JywgJ2JvcmRlcjogMXB4 IGluaXRpYWwgaW5pdGlhbDsnXSwKKyAgICBbJ2JvcmRlcjogMXB4IHJlZDsnLCAnYm9yZGVyOiAx cHggcmVkOyddLAorICAgIFsnYm9yZGVyOiByZWQ7JywgJ2JvcmRlcjogcmVkOyddLAorICAgIFsn Ym9yZGVyLXRvcDogMXB4OyBib3JkZXItcmlnaHQ6IDFweDsgYm9yZGVyLWJvdHRvbTogMXB4OyBi b3JkZXItbGVmdDogMXB4OycsICdib3JkZXI6IDFweDsnXSwKICAgICBbJ2JvcmRlci10b3A6IDFw eDsgYm9yZGVyLXJpZ2h0OiAycHg7IGJvcmRlci1ib3R0b206IDNweDsgYm9yZGVyLWxlZnQ6IDRw eDsnLAogICAgICdib3JkZXItdG9wLXdpZHRoOiAxcHg7IGJvcmRlci1yaWdodC13aWR0aDogMnB4 OyBib3JkZXItYm90dG9tLXdpZHRoOiAzcHg7IGJvcmRlci1sZWZ0LXdpZHRoOiA0cHg7J10sCiAg ICAgWydib3JkZXI6IDFweDsgYm9yZGVyLXRvcDogMnB4OycsCkBAIC0yMSw3ICsyMSw3IEBAIHZh ciB0ZXN0cyA9IFsKICAgICAnYm9yZGVyLXJpZ2h0LXdpZHRoOiAxcHg7IGJvcmRlci1ib3R0b20t d2lkdGg6IDFweDsgYm9yZGVyLWxlZnQtd2lkdGg6IDFweDsgYm9yZGVyLXRvcC13aWR0aDogMXB4 ICFpbXBvcnRhbnQ7J10sCiAgICAgWydib3JkZXI6IDFweDsgYm9yZGVyLXRvcC1jb2xvcjogcmVk OycsCiAgICAgJ2JvcmRlci1yaWdodC13aWR0aDogMXB4OyBib3JkZXItYm90dG9tLXdpZHRoOiAx cHg7IGJvcmRlci1sZWZ0LXdpZHRoOiAxcHg7IGJvcmRlci10b3Atd2lkdGg6IDFweDsgYm9yZGVy LXRvcC1jb2xvcjogcmVkOyddLAotICAgIFsnYm9yZGVyOiBzb2xpZDsgYm9yZGVyLXN0eWxlOiBk b3R0ZWQnLCAnYm9yZGVyOiBpbml0aWFsIGRvdHRlZCBpbml0aWFsOyddLAorICAgIFsnYm9yZGVy OiBzb2xpZDsgYm9yZGVyLXN0eWxlOiBkb3R0ZWQnLCAnYm9yZGVyOiBkb3R0ZWQ7J10sCiAKICAg ICBbJy13ZWJraXQtYm9yZGVyLWhvcml6b250YWwtc3BhY2luZzogMXB4OyAtd2Via2l0LWJvcmRl ci12ZXJ0aWNhbC1zcGFjaW5nOiAycHg7JywgJ2JvcmRlci1zcGFjaW5nOiAxcHggMnB4OyddLAog Cg==