82344 2012-03-27 08:40:50 -0700 Correct LayoutUnit usage in virtual function layoutBlock in RenderFlexibleBox 2012-03-27 14:34:43 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw eae eric jchaffraix webkit.review.bot oldest_to_newest 588939 0 leviw 2012-03-27 08:40:50 -0700 The signature incorrectly uses ints, and it incorrectly assigns a LayoutSize to an IntSize. 588947 1 134077 leviw 2012-03-27 08:47:37 -0700 Created attachment 134077 Patch 589140 2 134077 eric 2012-03-27 12:29:39 -0700 Comment on attachment 134077 Patch OK. 589263 3 134077 leviw 2012-03-27 14:12:45 -0700 Comment on attachment 134077 Patch Thanks! 589294 4 134077 webkit.review.bot 2012-03-27 14:34:39 -0700 Comment on attachment 134077 Patch Clearing flags on attachment: 134077 Committed r112316: <http://trac.webkit.org/changeset/112316> 589295 5 webkit.review.bot 2012-03-27 14:34:43 -0700 All reviewed patches have been landed. Closing bug. 134077 2012-03-27 08:47:37 -0700 2012-03-27 14:34:39 -0700 Patch bug-82344-20120327164736.patch text/plain 2462 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMjI3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAzLTI3ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBDb3JyZWN0IExheW91dFVu aXQgdXNhZ2UgaW4gdmlydHVhbCBmdW5jdGlvbiBsYXlvdXRCbG9jayBpbiBSZW5kZXJGbGV4aWJs ZUJveAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODIz NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3Jy ZWN0aW5nIHRoZSBzaWduYXR1cmUgb2YgUmVuZGVyRmxleGlibGVCb3g6OmxheW91dEJsb2NrIHRv IHVzZSBhIExheW91dFVuaXQKKyAgICAgICAgZm9yIHRoZSBwYWdlIGhlaWdodCwgYW5kIGF2b2lk aW5nIGFzc2lnbmluZyB0aGUgcmVuZGVyZXIncyBzaXplIHRvIGFuIEludFNpemUuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxl eGlibGVCb3g6OmxheW91dEJsb2NrKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmxleGli bGVCb3guaDoKKyAgICAgICAgKFJlbmRlckZsZXhpYmxlQm94KToKKwogMjAxMi0wMy0yNyAgSGFv IFpoZW5nICA8emhlbmdoYW9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENoYW5nZSBkZWZhdWx0 IHBvc2l0aW9uIGF0dHJpYnV0ZSBvZiBtZWRpYSBjb250cm9sIHBhbmVsIHRvIHJlbGF0aXZlIGZv ciBBbmRyb2lkLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxl Qm94LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxl eGlibGVCb3guY3BwCShyZXZpc2lvbiAxMTIyNTApCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRmxleGlibGVCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzAsNyArMjMwLDcg QEAgdm9pZCBSZW5kZXJGbGV4aWJsZUJveDo6Y29tcHV0ZVByZWZlcnJlZAogICAgIHNldFByZWZl cnJlZExvZ2ljYWxXaWR0aHNEaXJ0eShmYWxzZSk7CiB9CiAKLXZvaWQgUmVuZGVyRmxleGlibGVC b3g6OmxheW91dEJsb2NrKGJvb2wgcmVsYXlvdXRDaGlsZHJlbiwgaW50LCBCbG9ja0xheW91dFBh c3MpCit2b2lkIFJlbmRlckZsZXhpYmxlQm94OjpsYXlvdXRCbG9jayhib29sIHJlbGF5b3V0Q2hp bGRyZW4sIExheW91dFVuaXQsIEJsb2NrTGF5b3V0UGFzcykKIHsKICAgICBBU1NFUlQobmVlZHNM YXlvdXQoKSk7CiAKQEAgLTI0Nyw3ICsyNDcsNyBAQCB2b2lkIFJlbmRlckZsZXhpYmxlQm94Ojps YXlvdXRCbG9jayhib29sCiAgICAgfQogICAgIGNvbXB1dGVJbml0aWFsUmVnaW9uUmFuZ2VGb3JC bG9jaygpOwogCi0gICAgSW50U2l6ZSBwcmV2aW91c1NpemUgPSBzaXplKCk7CisgICAgTGF5b3V0 U2l6ZSBwcmV2aW91c1NpemUgPSBzaXplKCk7CiAKICAgICBzZXRMb2dpY2FsSGVpZ2h0KDApOwog ICAgIGNvbXB1dGVMb2dpY2FsV2lkdGgoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJGbGV4aWJsZUJveC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJGbGV4aWJsZUJveC5oCShyZXZpc2lvbiAxMTIyNTApCisrKyBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guaAkod29ya2luZyBjb3B5KQpAQCAtNDQs NyArNDQsNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIGJvb2wgaXNGbGV4aWJsZUJveCgpIGNv bnN0IHsgcmV0dXJuIHRydWU7IH0KICAgICB2aXJ0dWFsIHZvaWQgY29tcHV0ZVByZWZlcnJlZExv Z2ljYWxXaWR0aHMoKTsKLSAgICB2aXJ0dWFsIHZvaWQgbGF5b3V0QmxvY2soYm9vbCByZWxheW91 dENoaWxkcmVuLCBpbnQgcGFnZUxvZ2ljYWxIZWlnaHQgPSAwLCBCbG9ja0xheW91dFBhc3MgPSBO b3JtYWxMYXlvdXRQYXNzKTsKKyAgICB2aXJ0dWFsIHZvaWQgbGF5b3V0QmxvY2soYm9vbCByZWxh eW91dENoaWxkcmVuLCBMYXlvdXRVbml0IHBhZ2VMb2dpY2FsSGVpZ2h0ID0gMCwgQmxvY2tMYXlv dXRQYXNzID0gTm9ybWFsTGF5b3V0UGFzcyk7CiAKICAgICBib29sIGlzSG9yaXpvbnRhbEZsb3co KSBjb25zdDsKIAo=